)]}'
{"cinder/volume/drivers/dell/dell_storagecenter_api.py":[{"author":{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},"change_message_id":"6b0a30a6357187bfd3d182feeb9c12976a118c5b","unresolved":false,"context_lines":[{"line_number":3141,"context_line":"        \"\"\"Get\u0027s the live ScLiveVolume object for the vol with primaryid."},{"line_number":3142,"context_line":""},{"line_number":3143,"context_line":"        :param primaryid: InstanceId of the primary volume."},{"line_number":3144,"context_line":"        :parma name: Volume name associated with this live volume."},{"line_number":3145,"context_line":"        :return: ScLiveVolume object or None"},{"line_number":3146,"context_line":"        \"\"\""},{"line_number":3147,"context_line":"        sclivevol \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5da102_3f7b482b","line":3144,"range":{"start_line":3144,"start_character":8,"end_line":3144,"end_character":20},"updated":"2016-11-04 10:17:17.000000000","message":"you can also fix this misprint just in case :)","commit_id":"96c5935faa3f24f6477b0e090dbe50d7bab77a48"},{"author":{"_account_id":12112,"name":"Tom Swanson","email":"tom_swanson@dell.com","username":"tomswanson"},"change_message_id":"2ddbe8ff9494c7cb718f5b1afd6eb5df35d9332b","unresolved":false,"context_lines":[{"line_number":3141,"context_line":"        \"\"\"Get\u0027s the live ScLiveVolume object for the vol with primaryid."},{"line_number":3142,"context_line":""},{"line_number":3143,"context_line":"        :param primaryid: InstanceId of the primary volume."},{"line_number":3144,"context_line":"        :parma name: Volume name associated with this live volume."},{"line_number":3145,"context_line":"        :return: ScLiveVolume object or None"},{"line_number":3146,"context_line":"        \"\"\""},{"line_number":3147,"context_line":"        sclivevol \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_d24953d2","line":3144,"range":{"start_line":3144,"start_character":8,"end_line":3144,"end_character":20},"in_reply_to":"ba5da102_3f7b482b","updated":"2016-11-07 16:50:53.000000000","message":"Done","commit_id":"96c5935faa3f24f6477b0e090dbe50d7bab77a48"}],"cinder/volume/drivers/dell/dell_storagecenter_common.py":[{"author":{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},"change_message_id":"6b0a30a6357187bfd3d182feeb9c12976a118c5b","unresolved":false,"context_lines":[{"line_number":366,"context_line":"            if ssnstrings:"},{"line_number":367,"context_line":"                ssn \u003d int(ssnstrings[0])"},{"line_number":368,"context_line":"                sclivevolume \u003d api.get_live_volume(volume.get(\u0027provider_id\u0027),"},{"line_number":369,"context_line":"                                                   volume.get(\u0027id\u0027))"},{"line_number":370,"context_line":"                # Have we found the live volume?"},{"line_number":371,"context_line":"                if (sclivevolume and"},{"line_number":372,"context_line":"                   sclivevolume.get(\u0027secondaryScSerialNumber\u0027) \u003d\u003d ssn and"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5da102_3f942843","line":369,"range":{"start_line":369,"start_character":51,"end_line":369,"end_character":67},"updated":"2016-11-04 10:17:17.000000000","message":"Sorry if i misunderstood something\nif get_live_volume has definition list this \n    get_live_volume(self, primaryid, name\u003dNone):\nwhy are you passing id parameter to it?\nand in docstring of this function\n\":parma name: Volume name associated with this live volume.\"","commit_id":"96c5935faa3f24f6477b0e090dbe50d7bab77a48"},{"author":{"_account_id":12112,"name":"Tom Swanson","email":"tom_swanson@dell.com","username":"tomswanson"},"change_message_id":"2ddbe8ff9494c7cb718f5b1afd6eb5df35d9332b","unresolved":false,"context_lines":[{"line_number":366,"context_line":"            if ssnstrings:"},{"line_number":367,"context_line":"                ssn \u003d int(ssnstrings[0])"},{"line_number":368,"context_line":"                sclivevolume \u003d api.get_live_volume(volume.get(\u0027provider_id\u0027),"},{"line_number":369,"context_line":"                                                   volume.get(\u0027id\u0027))"},{"line_number":370,"context_line":"                # Have we found the live volume?"},{"line_number":371,"context_line":"                if (sclivevolume and"},{"line_number":372,"context_line":"                   sclivevolume.get(\u0027secondaryScSerialNumber\u0027) \u003d\u003d ssn and"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_f255771d","line":369,"range":{"start_line":369,"start_character":51,"end_line":369,"end_character":67},"in_reply_to":"ba5da102_3f942843","updated":"2016-11-07 16:50:53.000000000","message":"The id is the volume name. Sometimes we can\u0027t find the Live Volume by the instanceId (stuffed into provider_id) so we have to look for a live volume referencing the volume name.","commit_id":"96c5935faa3f24f6477b0e090dbe50d7bab77a48"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a2cd2b9b684eac6dff700ce13f730f898b23fb2c","unresolved":false,"context_lines":[{"line_number":366,"context_line":"            if ssnstrings:"},{"line_number":367,"context_line":"                ssn \u003d int(ssnstrings[0])"},{"line_number":368,"context_line":"                sclivevolume \u003d api.get_live_volume(volume.get(\u0027provider_id\u0027),"},{"line_number":369,"context_line":"                                                   volume.get(\u0027id\u0027))"},{"line_number":370,"context_line":"                # Have we found the live volume?"},{"line_number":371,"context_line":"                if (sclivevolume and"},{"line_number":372,"context_line":"                   sclivevolume.get(\u0027secondaryScSerialNumber\u0027) \u003d\u003d ssn and"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a629dbe_82ca20a0","line":369,"updated":"2016-11-07 22:16:05.000000000","message":"Why don\u0027t you have a unit test for this? What if someone changes the get_live_volume method signature, which is internal to cinder, and it would break this at runtime. You wouldn\u0027t have any unit test coverage to find that out.","commit_id":"8ffd78cbe43b76781ae22ac58ea2d1286ae47d94"}]}