)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},"change_message_id":"287fab28d68a6584420abe9117949ac3cf5f7635","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use method is_valid_boolstr from oslo_utils"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Oslo.utils provides same method is_valid_boolstr,"},{"line_number":10,"context_line":"and now we are in oslo.utils\u003e\u003d3.17,so we should"},{"line_number":11,"context_line":"use it directly."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"But there has one more details,oslo_utils\u0027s is_valid_boolstr"},{"line_number":14,"context_line":"accepts \"t\" and \"f\" , \"on\" and \"off\",but Cinder didn\u0027t."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"ba5da102_916015d1","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":15},"updated":"2016-11-02 17:25:50.000000000","message":"Maybe we should write in which version Oslo.utils this method was added. You can guess, that from 3.17, but i think it\u0027s better to clarify this part","commit_id":"2e55a1f0f7f9978d41aea13698e872102cd482d7"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"b7ce3bb9e2e828db1c2e35ba8392ebe03423cedc","unresolved":false,"context_lines":[{"line_number":10,"context_line":"in oslo.utils 3.17,and now we are in oslo.utils\u003e\u003d3.17"},{"line_number":11,"context_line":",so we should use it directly."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"APIImpact: oslo_utils\u0027s is_valid_boolstr accepts \"t\" and \"f\""},{"line_number":14,"context_line":", \"on\" and \"off\",but Cinder didn\u0027t."},{"line_number":15,"context_line":"Change-Id: I0326e586fe6c402e3425fa65656821054e560e40"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"ba5da102_2c598435","line":13,"updated":"2016-11-03 16:14:27.000000000","message":"I don\u0027t think this needs to be flagged as an APIImpact either. The existing API doesn\u0027t really change, it is just possible that a few more values _could_ be used, though I don\u0027t know why anyone would care.","commit_id":"f553f085d94b47643a30705d1c67cefbbbd4109f"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"59f23440726e8b8db2cf42d14f39958e9cac9b69","unresolved":false,"context_lines":[{"line_number":19,"context_line":"           cinder snapshot-create          force"},{"line_number":20,"context_line":"           get_bool_param()                param_string"},{"line_number":21,"context_line":"           cinder backup-list              all-tenants"},{"line_number":22,"context_line":"and unrealized v3 api:group_types update function,and"},{"line_number":23,"context_line":"corresponding parameter is is_public."},{"line_number":24,"context_line":"Change-Id: I0326e586fe6c402e3425fa65656821054e560e40"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":21,"id":"1a6eadb0_6d1ae27e","line":22,"range":{"start_line":22,"start_character":4,"end_line":22,"end_character":14},"updated":"2016-12-15 10:04:26.000000000","message":"?: what does unrealized mean?","commit_id":"c204eb2c9f4f77243d41e4201dc882295c5d8b10"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"59f23440726e8b8db2cf42d14f39958e9cac9b69","unresolved":false,"context_lines":[{"line_number":19,"context_line":"           cinder snapshot-create          force"},{"line_number":20,"context_line":"           get_bool_param()                param_string"},{"line_number":21,"context_line":"           cinder backup-list              all-tenants"},{"line_number":22,"context_line":"and unrealized v3 api:group_types update function,and"},{"line_number":23,"context_line":"corresponding parameter is is_public."},{"line_number":24,"context_line":"Change-Id: I0326e586fe6c402e3425fa65656821054e560e40"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":21,"id":"1a6eadb0_0d5ece43","line":22,"range":{"start_line":22,"start_character":41,"end_line":22,"end_character":53},"updated":"2016-12-15 10:04:26.000000000","message":"nit: missing space","commit_id":"c204eb2c9f4f77243d41e4201dc882295c5d8b10"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"59f23440726e8b8db2cf42d14f39958e9cac9b69","unresolved":false,"context_lines":[{"line_number":21,"context_line":"           cinder backup-list              all-tenants"},{"line_number":22,"context_line":"and unrealized v3 api:group_types update function,and"},{"line_number":23,"context_line":"corresponding parameter is is_public."},{"line_number":24,"context_line":"Change-Id: I0326e586fe6c402e3425fa65656821054e560e40"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":21,"id":"1a6eadb0_edb27293","line":24,"updated":"2016-12-15 10:04:26.000000000","message":"nit: empty line before the footer","commit_id":"c204eb2c9f4f77243d41e4201dc882295c5d8b10"}],"cinder/api/contrib/quotas.py":[{"author":{"_account_id":23276,"name":"Nicholas Jones","email":"nj762h@att.com","username":"nj762h"},"change_message_id":"ac4c0fcee34014c4817c0f4cfb333d83536fa1c8","unresolved":false,"context_lines":[{"line_number":216,"context_line":"            msg \u003d _(\"Invalid value \u0027%s\u0027 for skip_validation.\") % skip_flag"},{"line_number":217,"context_line":"            raise exception.InvalidParameterValue(err\u003dmsg)"},{"line_number":218,"context_line":"        skip_flag \u003d strutils.bool_from_string(skip_flag)"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"        target_project_id \u003d id"},{"line_number":221,"context_line":"        bad_keys \u003d []"},{"line_number":222,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da6895a0_f2580559","side":"PARENT","line":219,"updated":"2016-10-21 19:35:40.000000000","message":"I think we should avoid making changes to unrelated code.","commit_id":"14899a9a8e828c1765e3aa95a3f4286ef8094709"},{"author":{"_account_id":23276,"name":"Nicholas Jones","email":"nj762h@att.com","username":"nj762h"},"change_message_id":"ac4c0fcee34014c4817c0f4cfb333d83536fa1c8","unresolved":false,"context_lines":[{"line_number":219,"context_line":""},{"line_number":220,"context_line":"        target_project_id \u003d id"},{"line_number":221,"context_line":"        bad_keys \u003d []"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"        # NOTE(ankit): Pass #1 - In this loop for body[\u0027quota_set\u0027].items(),"},{"line_number":224,"context_line":"        # we figure out if we have any bad keys."},{"line_number":225,"context_line":"        for key, value in body[\u0027quota_set\u0027].items():"}],"source_content_type":"text/x-python","patch_set":4,"id":"da6895a0_723b15ec","side":"PARENT","line":222,"updated":"2016-10-21 19:35:40.000000000","message":"Same with this line.","commit_id":"14899a9a8e828c1765e3aa95a3f4286ef8094709"}],"cinder/backup/api.py":[{"author":{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},"change_message_id":"28be86e25c244296ffcd162e87834aa47821f9e2","unresolved":false,"context_lines":[{"line_number":39,"context_line":"import cinder.policy"},{"line_number":40,"context_line":"from cinder import quota"},{"line_number":41,"context_line":"from cinder import quota_utils"},{"line_number":42,"context_line":"from cinder import utils"},{"line_number":43,"context_line":"import cinder.volume"},{"line_number":44,"context_line":"from cinder.volume import utils as volume_utils"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"3a71b18c_365126d9","line":42,"range":{"start_line":42,"start_character":0,"end_line":42,"end_character":24},"updated":"2016-12-05 10:22:18.000000000","message":"We don\u0027t need this import.","commit_id":"f2965fe8395eb1238a1cca9e295364e184661085"}],"releasenotes/notes/import-osloutils-is_valid_boolstr-ac3bcd477fb4c59f.yaml":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"7f32cca06eb7e603d58aa189dca254fb69c2d9b4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"issues:"},{"line_number":3,"context_line":"  - Oslo.utils provides same method is_valid_boolstr in oslo.utils 3.17,"},{"line_number":4,"context_line":"    and now we are in oslo.utils\u003e\u003d3.17,so we should use it directly."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"ba5da102_093af2e6","line":1,"updated":"2016-11-03 16:12:52.000000000","message":"Neither of these will make any sense to someone reading the resulting release notes.\n\nI could see an \"Other\" section note stating the new possible options, but I actually don\u0027t think we need to document that users could use new and strange values for true and false. I\u0027d rather there just wasn\u0027t even a release note for this.","commit_id":"f553f085d94b47643a30705d1c67cefbbbd4109f"}]}