)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"f0a7b47c1805ec6fdcb57f23fb97e7c253fb4d8e","unresolved":false,"context_lines":[{"line_number":12,"context_line":"According to the api guidelines [1] it should return 400"},{"line_number":13,"context_line":"HTTPBadRequest."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[1] https://github.com/openstack/api-wg/blob/master/guidelines/http.rst#failure-code-clarifications"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"APIImpact: For volume manage API, it will return 400 error instead"},{"line_number":18,"context_line":"of 404 if user passes non-existing volume-type or service in the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa6399be_f8f6edf7","line":15,"range":{"start_line":15,"start_character":71,"end_line":15,"end_character":99},"updated":"2016-10-19 14:08:31.000000000","message":"this line exceeds the max length","commit_id":"e435194463da1b08f18de90cc4be3091114390c3"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"67d41243bfc7d5c65d3cd535904ee2fa18b875bb","unresolved":false,"context_lines":[{"line_number":12,"context_line":"According to the api guidelines [1] it should return 400"},{"line_number":13,"context_line":"HTTPBadRequest."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[1] https://github.com/openstack/api-wg/blob/master/guidelines/http.rst#failure-code-clarifications"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"APIImpact: For volume manage API, it will return 400 error instead"},{"line_number":18,"context_line":"of 404 if user passes non-existing volume-type or service in the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da6895a0_3087eb62","line":15,"range":{"start_line":15,"start_character":71,"end_line":15,"end_character":99},"in_reply_to":"fa6399be_f8f6edf7","updated":"2016-10-21 09:44:19.000000000","message":"For links it\u0027s acceptable","commit_id":"e435194463da1b08f18de90cc4be3091114390c3"}],"cinder/api/contrib/volume_manage.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"9bd9af68dcd3798a35aa981473af09f38dba2483","unresolved":false,"context_lines":[{"line_number":123,"context_line":"                kwargs[\u0027volume_type\u0027] \u003d volume_types.get_by_name_or_id("},{"line_number":124,"context_line":"                    context, req_volume_type)"},{"line_number":125,"context_line":"            except exception.VolumeTypeNotFound as e:"},{"line_number":126,"context_line":"                raise exc.HTTPBadRequest(explanation\u003de.msg)"},{"line_number":127,"context_line":"        else:"},{"line_number":128,"context_line":"            kwargs[\u0027volume_type\u0027] \u003d {}"},{"line_number":129,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_d496ffee","line":126,"updated":"2016-10-14 10:55:16.000000000","message":"-1: Please raise a Cinder exception instead of a webob exception:\n\n raise exception InvalidVolumeType(reason\u003de)","commit_id":"90344a20ac35df57e92db1eba6b66af3592252ac"},{"author":{"_account_id":20191,"name":"Dinesh Bhor","email":"bhordinesh07@gmail.com","username":"dineshbhor"},"change_message_id":"ec5c11fcfefcba326964317589efd036f56313cc","unresolved":false,"context_lines":[{"line_number":123,"context_line":"                kwargs[\u0027volume_type\u0027] \u003d volume_types.get_by_name_or_id("},{"line_number":124,"context_line":"                    context, req_volume_type)"},{"line_number":125,"context_line":"            except exception.VolumeTypeNotFound as e:"},{"line_number":126,"context_line":"                raise exc.HTTPBadRequest(explanation\u003de.msg)"},{"line_number":127,"context_line":"        else:"},{"line_number":128,"context_line":"            kwargs[\u0027volume_type\u0027] \u003d {}"},{"line_number":129,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_d25828fd","line":126,"in_reply_to":"fa6399be_d496ffee","updated":"2016-10-19 13:38:57.000000000","message":"Done","commit_id":"90344a20ac35df57e92db1eba6b66af3592252ac"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"9bd9af68dcd3798a35aa981473af09f38dba2483","unresolved":false,"context_lines":[{"line_number":141,"context_line":"                                                         volume[\u0027ref\u0027],"},{"line_number":142,"context_line":"                                                         **kwargs)"},{"line_number":143,"context_line":"        except exception.ServiceNotFound as e:"},{"line_number":144,"context_line":"            raise exc.HTTPBadRequest(explanation\u003de.msg)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        utils.add_visible_admin_metadata(new_volume)"},{"line_number":147,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_b4a50b48","line":144,"updated":"2016-10-14 10:55:16.000000000","message":"-1: Likewise but with ServiceUnavailable.","commit_id":"90344a20ac35df57e92db1eba6b66af3592252ac"},{"author":{"_account_id":20191,"name":"Dinesh Bhor","email":"bhordinesh07@gmail.com","username":"dineshbhor"},"change_message_id":"ec5c11fcfefcba326964317589efd036f56313cc","unresolved":false,"context_lines":[{"line_number":141,"context_line":"                                                         volume[\u0027ref\u0027],"},{"line_number":142,"context_line":"                                                         **kwargs)"},{"line_number":143,"context_line":"        except exception.ServiceNotFound as e:"},{"line_number":144,"context_line":"            raise exc.HTTPBadRequest(explanation\u003de.msg)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        utils.add_visible_admin_metadata(new_volume)"},{"line_number":147,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_f25b6cf4","line":144,"in_reply_to":"fa6399be_b4a50b48","updated":"2016-10-19 13:38:57.000000000","message":"Done","commit_id":"90344a20ac35df57e92db1eba6b66af3592252ac"}]}