)]}'
{"cinder/db/sqlalchemy/api.py":[{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"47cffd16aae18bafa6e0c045b31ec5314f694562","unresolved":false,"context_lines":[{"line_number":1544,"context_line":""},{"line_number":1545,"context_line":""},{"line_number":1546,"context_line":"@require_admin_context"},{"line_number":1547,"context_line":"def migration_create(context, values):"},{"line_number":1548,"context_line":"    migration \u003d models.Migration()"},{"line_number":1549,"context_line":"    migration.update(values)"},{"line_number":1550,"context_line":"    migration.save()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2Ff5A%3D","line":1547,"updated":"2013-07-30 07:16:06.000000000","message":"This was missed?","commit_id":"57dc8a23787c16e67e0ca16a0b1506c0653499bf"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"24f15c5ba77ec28a2193e07676b62cf0bfdb2b4c","unresolved":false,"context_lines":[{"line_number":1544,"context_line":""},{"line_number":1545,"context_line":""},{"line_number":1546,"context_line":"@require_admin_context"},{"line_number":1547,"context_line":"def migration_create(context, values):"},{"line_number":1548,"context_line":"    migration \u003d models.Migration()"},{"line_number":1549,"context_line":"    migration.update(values)"},{"line_number":1550,"context_line":"    migration.save()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2FecM%3D","line":1547,"in_reply_to":"AAAAQn%2F%2Ff3g%3D","updated":"2013-07-30 15:48:40.000000000","message":"Ah I thought that was the case. I mistook the change below for volume_type_create being a migrate function since gerrit was hiding common lines, so I wasn\u0027t sure if you were updating those for the heck of it. Anyways, yeah lgtm.","commit_id":"57dc8a23787c16e67e0ca16a0b1506c0653499bf"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"089f3a813a81b9365dd8bec2b4806a8fe8e02a41","unresolved":false,"context_lines":[{"line_number":1544,"context_line":""},{"line_number":1545,"context_line":""},{"line_number":1546,"context_line":"@require_admin_context"},{"line_number":1547,"context_line":"def migration_create(context, values):"},{"line_number":1548,"context_line":"    migration \u003d models.Migration()"},{"line_number":1549,"context_line":"    migration.update(values)"},{"line_number":1550,"context_line":"    migration.save()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2Ff3g%3D","line":1547,"in_reply_to":"AAAAQn%2F%2Ff5A%3D","updated":"2013-07-30 07:24:46.000000000","message":"Mike, no, it wasn\u0027t.\n\nActually, Migration model and corresponding DB API methods are not used in Cinder at all - they are a part of Nova, and came to Cinder by mistake, when Cinder was worked out from Nova code base. So I decided not to touch this.\n\nThere is a patch on review removing this unused code: https://review.openstack.org/#/c/36648/\n\nCould you take a look at that patch, please? It\u0027s been on review for a while. I believe, John asked to hold it a bit, so that we didn\u0027t have two patches adding a migration with the same number on review, but the \u0027concurrent\u0027 migration has already been merged. Thanks!","commit_id":"57dc8a23787c16e67e0ca16a0b1506c0653499bf"}]}