)]}'
{"cinder/tests/test_migrations.py":[{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"7e988683ef72e85e27e210b2faf83b9e7b7448b2","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    except (ImportError, sqlalchemy.exc.OperationalError):"},{"line_number":80,"context_line":"        # backend is considered to be unavailable, if either a DB API module"},{"line_number":81,"context_line":"        # can not be imported or a DB connection can not be established"},{"line_number":82,"context_line":"        return False"},{"line_number":83,"context_line":"    else:"},{"line_number":84,"context_line":"        connection.close()"},{"line_number":85,"context_line":"        engine.dispose()"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2Fino%3D","line":82,"updated":"2013-07-29 15:22:59.000000000","message":"Not sure we should only target these specific exceptions here, I think we should probably leave this as a generic except block.","commit_id":"fed0c51ad6fd07a02ebe625c5c4b68671708b4f7"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"cc388670a0a012547c44508a32081f5cca47cfc6","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    except (ImportError, sqlalchemy.exc.OperationalError):"},{"line_number":80,"context_line":"        # backend is considered to be unavailable, if either a DB API module"},{"line_number":81,"context_line":"        # can not be imported or a DB connection can not be established"},{"line_number":82,"context_line":"        return False"},{"line_number":83,"context_line":"    else:"},{"line_number":84,"context_line":"        connection.close()"},{"line_number":85,"context_line":"        engine.dispose()"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2Fhvk%3D","line":82,"in_reply_to":"AAAAQn%2F%2FiTw%3D","updated":"2013-07-29 19:21:53.000000000","message":"Cool, I\u0027d be fine with going back and logging like you did or even having a default except block.  Either way this works for me, thanks for clarifying and fixing it up.","commit_id":"fed0c51ad6fd07a02ebe625c5c4b68671708b4f7"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"7232020f8ceb029cdf007ee6382d3dda7462de11","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    except (ImportError, sqlalchemy.exc.OperationalError):"},{"line_number":80,"context_line":"        # backend is considered to be unavailable, if either a DB API module"},{"line_number":81,"context_line":"        # can not be imported or a DB connection can not be established"},{"line_number":82,"context_line":"        return False"},{"line_number":83,"context_line":"    else:"},{"line_number":84,"context_line":"        connection.close()"},{"line_number":85,"context_line":"        engine.dispose()"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2FiTw%3D","line":82,"in_reply_to":"AAAAQn%2F%2Fino%3D","updated":"2013-07-29 16:16:12.000000000","message":"John, the point was to ensure we don\u0027t hide any unexpected errors here. We could log it, on the other hand.","commit_id":"fed0c51ad6fd07a02ebe625c5c4b68671708b4f7"}]}