)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"eed5023472b4c07cde81f19fcbaf2b8c233e3c17","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Huawei: Mask unnecessary log print"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There are a lot of unnecessary log print in the"},{"line_number":10,"context_line":"cinder-volume log by Driver, Consume a large amount"},{"line_number":11,"context_line":"of physical space."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This commit fixes that by masking unnecessary log"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da6895a0_8c1d0a69","line":10,"range":{"start_line":10,"start_character":29,"end_line":10,"end_character":36},"updated":"2016-10-21 02:58:27.000000000","message":"consume","commit_id":"219e9e385cb5695eb3ca03b8e2baa2a3c90d4a6d"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"eed5023472b4c07cde81f19fcbaf2b8c233e3c17","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Huawei: Mask unnecessary log print"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There are a lot of unnecessary log print in the"},{"line_number":10,"context_line":"cinder-volume log by Driver, Consume a large amount"},{"line_number":11,"context_line":"of physical space."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This commit fixes that by masking unnecessary log"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da6895a0_6c10b64f","line":10,"range":{"start_line":10,"start_character":21,"end_line":10,"end_character":27},"updated":"2016-10-21 02:58:27.000000000","message":"huawei driver","commit_id":"219e9e385cb5695eb3ca03b8e2baa2a3c90d4a6d"},{"author":{"_account_id":18026,"name":"huanan","email":"huanan@huawei.com","username":"huanan"},"change_message_id":"84caa67e1279c9eac80bd239154ada8041889d71","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Huawei: Mask unnecessary log print"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There are a lot of unnecessary log print in the"},{"line_number":10,"context_line":"cinder-volume log by Driver, Consume a large amount"},{"line_number":11,"context_line":"of physical space."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This commit fixes that by masking unnecessary log"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da6895a0_f08f0621","line":10,"range":{"start_line":10,"start_character":21,"end_line":10,"end_character":27},"in_reply_to":"da6895a0_6c10b64f","updated":"2016-10-24 06:37:27.000000000","message":"Done","commit_id":"219e9e385cb5695eb3ca03b8e2baa2a3c90d4a6d"},{"author":{"_account_id":18026,"name":"huanan","email":"huanan@huawei.com","username":"huanan"},"change_message_id":"84caa67e1279c9eac80bd239154ada8041889d71","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Huawei: Mask unnecessary log print"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There are a lot of unnecessary log print in the"},{"line_number":10,"context_line":"cinder-volume log by Driver, Consume a large amount"},{"line_number":11,"context_line":"of physical space."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This commit fixes that by masking unnecessary log"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da6895a0_10939a50","line":10,"range":{"start_line":10,"start_character":29,"end_line":10,"end_character":36},"in_reply_to":"da6895a0_8c1d0a69","updated":"2016-10-24 06:37:27.000000000","message":"Done","commit_id":"219e9e385cb5695eb3ca03b8e2baa2a3c90d4a6d"}],"cinder/tests/unit/volume/drivers/huawei/test_huawei_drivers.py":[{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"eed5023472b4c07cde81f19fcbaf2b8c233e3c17","unresolved":false,"context_lines":[{"line_number":1226,"context_line":"    FAKE_COMMON_SUCCESS_RESPONSE)"},{"line_number":1227,"context_line":""},{"line_number":1228,"context_line":"# mock storage info map"},{"line_number":1229,"context_line":"MAP_COMMAND_TO_FAKE_RESPONSE[\u0027/storagepool/GET\u0027] \u003d ("},{"line_number":1230,"context_line":"    FAKE_STORAGE_POOL_RESPONSE)"},{"line_number":1231,"context_line":""},{"line_number":1232,"context_line":"# mock lun info map"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6895a0_cc81c24f","line":1229,"range":{"start_line":1229,"start_character":42,"end_line":1229,"end_character":46},"updated":"2016-10-21 02:58:27.000000000","message":"is this related to this patch?","commit_id":"219e9e385cb5695eb3ca03b8e2baa2a3c90d4a6d"},{"author":{"_account_id":18026,"name":"huanan","email":"huanan@huawei.com","username":"huanan"},"change_message_id":"84caa67e1279c9eac80bd239154ada8041889d71","unresolved":false,"context_lines":[{"line_number":1226,"context_line":"    FAKE_COMMON_SUCCESS_RESPONSE)"},{"line_number":1227,"context_line":""},{"line_number":1228,"context_line":"# mock storage info map"},{"line_number":1229,"context_line":"MAP_COMMAND_TO_FAKE_RESPONSE[\u0027/storagepool/GET\u0027] \u003d ("},{"line_number":1230,"context_line":"    FAKE_STORAGE_POOL_RESPONSE)"},{"line_number":1231,"context_line":""},{"line_number":1232,"context_line":"# mock lun info map"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6895a0_70e856e3","line":1229,"range":{"start_line":1229,"start_character":42,"end_line":1229,"end_character":46},"in_reply_to":"da6895a0_cc81c24f","updated":"2016-10-24 06:37:27.000000000","message":"Yes, there should be add \u0027GET\u0027 methed for get_all_pools.\n\"\"\"def get_all_pools(self):\n       url \u003d \"/storagepool\"\n       result \u003d self.call(url, None, \"GET\", filter_flag\u003dTrue)\"\"\"","commit_id":"219e9e385cb5695eb3ca03b8e2baa2a3c90d4a6d"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"914d0af57a0bc503bc11f3788d24b3ddf8fbeaf3","unresolved":false,"context_lines":[{"line_number":1226,"context_line":"    FAKE_COMMON_SUCCESS_RESPONSE)"},{"line_number":1227,"context_line":""},{"line_number":1228,"context_line":"# mock storage info map"},{"line_number":1229,"context_line":"MAP_COMMAND_TO_FAKE_RESPONSE[\u0027/storagepool/GET\u0027] \u003d ("},{"line_number":1230,"context_line":"    FAKE_STORAGE_POOL_RESPONSE)"},{"line_number":1231,"context_line":""},{"line_number":1232,"context_line":"# mock lun info map"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_a63700af","line":1229,"updated":"2016-11-16 10:37:51.000000000","message":"-1: This change is unrelated to this patch.","commit_id":"b6974a74c5e60cbbff96792fd33a331f1c244d9d"},{"author":{"_account_id":18026,"name":"huanan","email":"huanan@huawei.com","username":"huanan"},"change_message_id":"b31a11544bc7250902981de4885d622c4ba80b52","unresolved":false,"context_lines":[{"line_number":1226,"context_line":"    FAKE_COMMON_SUCCESS_RESPONSE)"},{"line_number":1227,"context_line":""},{"line_number":1228,"context_line":"# mock storage info map"},{"line_number":1229,"context_line":"MAP_COMMAND_TO_FAKE_RESPONSE[\u0027/storagepool/GET\u0027] \u003d ("},{"line_number":1230,"context_line":"    FAKE_STORAGE_POOL_RESPONSE)"},{"line_number":1231,"context_line":""},{"line_number":1232,"context_line":"# mock lun info map"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_341e5a5f","line":1229,"in_reply_to":"7a77a97e_a63700af","updated":"2016-12-06 01:54:22.000000000","message":"I will remove this part.","commit_id":"b6974a74c5e60cbbff96792fd33a331f1c244d9d"}],"cinder/volume/drivers/huawei/rest_client.py":[{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"beed344a463010b66b7fb6122f78e04621de0510","unresolved":false,"context_lines":[{"line_number":100,"context_line":"            res_json \u003d json.loads(json_msg)"},{"line_number":101,"context_line":"            return res_json"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        try:"},{"line_number":104,"context_line":"            res_json \u003d json.loads(res)"},{"line_number":105,"context_line":"        except Exception as err:"},{"line_number":106,"context_line":"            LOG.error(_LE(\u0027JSON transfer error: %s.\u0027), err)"},{"line_number":107,"context_line":"            raise"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        return res_json"},{"line_number":110,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_6032fba8","side":"PARENT","line":107,"range":{"start_line":103,"start_character":8,"end_line":107,"end_character":17},"updated":"2016-10-20 12:24:29.000000000","message":"It seems you should not remove this try/except block. It won\u0027t affect in the amount of logging and you give the user a proper error message in case of error.","commit_id":"14899a9a8e828c1765e3aa95a3f4286ef8094709"},{"author":{"_account_id":18026,"name":"huanan","email":"huanan@huawei.com","username":"huanan"},"change_message_id":"7de92df38145308e12cab2cbeda2217ddf761628","unresolved":false,"context_lines":[{"line_number":100,"context_line":"            res_json \u003d json.loads(json_msg)"},{"line_number":101,"context_line":"            return res_json"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        try:"},{"line_number":104,"context_line":"            res_json \u003d json.loads(res)"},{"line_number":105,"context_line":"        except Exception as err:"},{"line_number":106,"context_line":"            LOG.error(_LE(\u0027JSON transfer error: %s.\u0027), err)"},{"line_number":107,"context_line":"            raise"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        return res_json"},{"line_number":110,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da6895a0_56a3859e","side":"PARENT","line":107,"range":{"start_line":103,"start_character":8,"end_line":107,"end_character":17},"in_reply_to":"fa6399be_6032fba8","updated":"2016-10-21 02:00:53.000000000","message":"Done","commit_id":"14899a9a8e828c1765e3aa95a3f4286ef8094709"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"beed344a463010b66b7fb6122f78e04621de0510","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            if method:"},{"line_number":83,"context_line":"                req.get_method \u003d lambda: method"},{"line_number":84,"context_line":"            res \u003d urllib.request.urlopen(req).read().decode(\"utf-8\")"},{"line_number":85,"context_line":"            res_json \u003d json.loads(res)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"            if not filter_flag:"},{"line_number":88,"context_line":"                LOG.info(_LI(\u0027\\n\\n\\n\\nRequest URL: %(url)s\\n\\n\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_00185f1d","line":85,"range":{"start_line":85,"start_character":12,"end_line":85,"end_character":38},"updated":"2016-10-20 12:24:29.000000000","message":"try/except block","commit_id":"2eb5e581397d0b30dddb1113a8f26b1468dae2b4"},{"author":{"_account_id":18026,"name":"huanan","email":"huanan@huawei.com","username":"huanan"},"change_message_id":"7de92df38145308e12cab2cbeda2217ddf761628","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            if method:"},{"line_number":83,"context_line":"                req.get_method \u003d lambda: method"},{"line_number":84,"context_line":"            res \u003d urllib.request.urlopen(req).read().decode(\"utf-8\")"},{"line_number":85,"context_line":"            res_json \u003d json.loads(res)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"            if not filter_flag:"},{"line_number":88,"context_line":"                LOG.info(_LI(\u0027\\n\\n\\n\\nRequest URL: %(url)s\\n\\n\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6895a0_369e1157","line":85,"range":{"start_line":85,"start_character":12,"end_line":85,"end_character":38},"in_reply_to":"fa6399be_00185f1d","updated":"2016-10-21 02:00:53.000000000","message":"Done","commit_id":"2eb5e581397d0b30dddb1113a8f26b1468dae2b4"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"beed344a463010b66b7fb6122f78e04621de0510","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            res_json \u003d json.loads(res)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"            if not filter_flag:"},{"line_number":88,"context_line":"                LOG.info(_LI(\u0027\\n\\n\\n\\nRequest URL: %(url)s\\n\\n\u0027"},{"line_number":89,"context_line":"                             \u0027Call Method: %(method)s\\n\\n\u0027"},{"line_number":90,"context_line":"                             \u0027Request Data: %(data)s\\n\\n\u0027"},{"line_number":91,"context_line":"                             \u0027Response Data:%(res)s\\n\\n\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_80daaf49","line":88,"range":{"start_line":88,"start_character":16,"end_line":88,"end_character":24},"updated":"2016-10-20 12:24:29.000000000","message":"Just use LOG.debug() here.","commit_id":"2eb5e581397d0b30dddb1113a8f26b1468dae2b4"},{"author":{"_account_id":18026,"name":"huanan","email":"huanan@huawei.com","username":"huanan"},"change_message_id":"7de92df38145308e12cab2cbeda2217ddf761628","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            res_json \u003d json.loads(res)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"            if not filter_flag:"},{"line_number":88,"context_line":"                LOG.info(_LI(\u0027\\n\\n\\n\\nRequest URL: %(url)s\\n\\n\u0027"},{"line_number":89,"context_line":"                             \u0027Call Method: %(method)s\\n\\n\u0027"},{"line_number":90,"context_line":"                             \u0027Request Data: %(data)s\\n\\n\u0027"},{"line_number":91,"context_line":"                             \u0027Response Data:%(res)s\\n\\n\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6895a0_96819d92","line":88,"range":{"start_line":88,"start_character":16,"end_line":88,"end_character":24},"in_reply_to":"fa6399be_80daaf49","updated":"2016-10-21 02:00:53.000000000","message":"We use LOG.info to convenient problem location, Debug switch is off in most of scenes. We use a  filter switch control logs print or not, instead of use LOG.debug mask all logs.","commit_id":"2eb5e581397d0b30dddb1113a8f26b1468dae2b4"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"eed5023472b4c07cde81f19fcbaf2b8c233e3c17","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        }"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def do_call(self, url\u003dNone, data\u003dNone, method\u003dNone,"},{"line_number":64,"context_line":"                calltimeout\u003dconstants.SOCKET_TIMEOUT, filter_flag\u003dFalse):"},{"line_number":65,"context_line":"        \"\"\"Send requests to Huawei storage server."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        Send HTTPS call, get response in JSON."}],"source_content_type":"text/x-python","patch_set":2,"id":"da6895a0_0c6e5ac9","line":64,"range":{"start_line":64,"start_character":54,"end_line":64,"end_character":65},"updated":"2016-10-21 02:58:27.000000000","message":"it\u0027d better change to a more explicit name, like log_filter_flag","commit_id":"219e9e385cb5695eb3ca03b8e2baa2a3c90d4a6d"},{"author":{"_account_id":18026,"name":"huanan","email":"huanan@huawei.com","username":"huanan"},"change_message_id":"84caa67e1279c9eac80bd239154ada8041889d71","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        }"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def do_call(self, url\u003dNone, data\u003dNone, method\u003dNone,"},{"line_number":64,"context_line":"                calltimeout\u003dconstants.SOCKET_TIMEOUT, filter_flag\u003dFalse):"},{"line_number":65,"context_line":"        \"\"\"Send requests to Huawei storage server."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        Send HTTPS call, get response in JSON."}],"source_content_type":"text/x-python","patch_set":2,"id":"da6895a0_b0774e39","line":64,"range":{"start_line":64,"start_character":54,"end_line":64,"end_character":65},"in_reply_to":"da6895a0_0c6e5ac9","updated":"2016-10-24 06:37:27.000000000","message":"Done","commit_id":"219e9e385cb5695eb3ca03b8e2baa2a3c90d4a6d"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"eed5023472b4c07cde81f19fcbaf2b8c233e3c17","unresolved":false,"context_lines":[{"line_number":83,"context_line":"                req.get_method \u003d lambda: method"},{"line_number":84,"context_line":"            res \u003d urllib.request.urlopen(req).read().decode(\"utf-8\")"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"            if not filter_flag:"},{"line_number":87,"context_line":"                LOG.info(_LI(\u0027\\n\\n\\n\\nRequest URL: %(url)s\\n\\n\u0027"},{"line_number":88,"context_line":"                             \u0027Call Method: %(method)s\\n\\n\u0027"},{"line_number":89,"context_line":"                             \u0027Request Data: %(data)s\\n\\n\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6895a0_4caf72e3","line":86,"updated":"2016-10-21 02:58:27.000000000","message":"A UT should be added to cover this branch.","commit_id":"219e9e385cb5695eb3ca03b8e2baa2a3c90d4a6d"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"2660cbad8a90becb320200fa976a8e3516c58166","unresolved":false,"context_lines":[{"line_number":83,"context_line":"                req.get_method \u003d lambda: method"},{"line_number":84,"context_line":"            res \u003d urllib.request.urlopen(req).read().decode(\"utf-8\")"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"            if not log_filter_flag:"},{"line_number":87,"context_line":"                LOG.info(_LI(\u0027\\n\\n\\n\\nRequest URL: %(url)s\\n\\n\u0027"},{"line_number":88,"context_line":"                             \u0027Call Method: %(method)s\\n\\n\u0027"},{"line_number":89,"context_line":"                             \u0027Request Data: %(data)s\\n\\n\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5da102_1c22b9b9","line":86,"updated":"2016-10-31 12:16:19.000000000","message":"IMO, it  should be:\nif log_filter_flag","commit_id":"b6974a74c5e60cbbff96792fd33a331f1c244d9d"},{"author":{"_account_id":18026,"name":"huanan","email":"huanan@huawei.com","username":"huanan"},"change_message_id":"b31a11544bc7250902981de4885d622c4ba80b52","unresolved":false,"context_lines":[{"line_number":83,"context_line":"                req.get_method \u003d lambda: method"},{"line_number":84,"context_line":"            res \u003d urllib.request.urlopen(req).read().decode(\"utf-8\")"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"            if not log_filter_flag:"},{"line_number":87,"context_line":"                LOG.info(_LI(\u0027\\n\\n\\n\\nRequest URL: %(url)s\\n\\n\u0027"},{"line_number":88,"context_line":"                             \u0027Call Method: %(method)s\\n\\n\u0027"},{"line_number":89,"context_line":"                             \u0027Request Data: %(data)s\\n\\n\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_34073a19","line":86,"in_reply_to":"7a77a97e_c6779c9d","updated":"2016-12-06 01:54:22.000000000","message":"I don\u0027t think that\u0027s a serious problem and does not affect the function, temporarily not modify.","commit_id":"b6974a74c5e60cbbff96792fd33a331f1c244d9d"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"914d0af57a0bc503bc11f3788d24b3ddf8fbeaf3","unresolved":false,"context_lines":[{"line_number":83,"context_line":"                req.get_method \u003d lambda: method"},{"line_number":84,"context_line":"            res \u003d urllib.request.urlopen(req).read().decode(\"utf-8\")"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"            if not log_filter_flag:"},{"line_number":87,"context_line":"                LOG.info(_LI(\u0027\\n\\n\\n\\nRequest URL: %(url)s\\n\\n\u0027"},{"line_number":88,"context_line":"                             \u0027Call Method: %(method)s\\n\\n\u0027"},{"line_number":89,"context_line":"                             \u0027Request Data: %(data)s\\n\\n\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_c6779c9d","line":86,"in_reply_to":"ba5da102_1c22b9b9","updated":"2016-11-16 10:37:51.000000000","message":"I disagree, to me the naming of the flag seem to indicate that we want to filter the logs, hence setting it to True should not log things.","commit_id":"b6974a74c5e60cbbff96792fd33a331f1c244d9d"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"914d0af57a0bc503bc11f3788d24b3ddf8fbeaf3","unresolved":false,"context_lines":[{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def get_all_pools(self):"},{"line_number":242,"context_line":"        url \u003d \"/storagepool\""},{"line_number":243,"context_line":"        result \u003d self.call(url, None, \"GET\", log_filter_flag\u003dTrue)"},{"line_number":244,"context_line":"        msg \u003d _(\u0027Query resource pool error.\u0027)"},{"line_number":245,"context_line":"        self._assert_rest_result(result, msg)"},{"line_number":246,"context_line":"        self._assert_data_in_result(result, msg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_46e38c05","line":243,"updated":"2016-11-16 10:37:51.000000000","message":"-1: The \"GET\" part of this change seems unrelated and should go in another patch.","commit_id":"b6974a74c5e60cbbff96792fd33a331f1c244d9d"},{"author":{"_account_id":18026,"name":"huanan","email":"huanan@huawei.com","username":"huanan"},"change_message_id":"b31a11544bc7250902981de4885d622c4ba80b52","unresolved":false,"context_lines":[{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def get_all_pools(self):"},{"line_number":242,"context_line":"        url \u003d \"/storagepool\""},{"line_number":243,"context_line":"        result \u003d self.call(url, None, \"GET\", log_filter_flag\u003dTrue)"},{"line_number":244,"context_line":"        msg \u003d _(\u0027Query resource pool error.\u0027)"},{"line_number":245,"context_line":"        self._assert_rest_result(result, msg)"},{"line_number":246,"context_line":"        self._assert_data_in_result(result, msg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_49b98378","line":243,"in_reply_to":"7a77a97e_46e38c05","updated":"2016-12-06 01:54:22.000000000","message":"Ok, I will remove this part, thanks for your review!","commit_id":"b6974a74c5e60cbbff96792fd33a331f1c244d9d"}]}