)]}'
{"cinder/volume/drivers/ibm/storwize_svc/storwize_svc_common.py":[{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"e9f3849cd00c9c378af43df7233729b50b76803e","unresolved":false,"context_lines":[{"line_number":765,"context_line":"            # begining of the list"},{"line_number":766,"context_line":"            for host in host_list:"},{"line_number":767,"context_line":"                if re.search(connector[\u0027host\u0027], host):"},{"line_number":768,"context_line":"                    idx \u003d host_list.index(host)"},{"line_number":769,"context_line":"                    del host_list[idx]"},{"line_number":770,"context_line":"                    host_list.insert(0, host)"},{"line_number":771,"context_line":"        # If we have a volume name we have a potential fast path"},{"line_number":772,"context_line":"        # for finding the matching host for that volume."},{"line_number":773,"context_line":"        # Add the host_names that have mappings for our volume to the"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6895a0_9bc5465d","line":770,"range":{"start_line":768,"start_character":17,"end_line":770,"end_character":45},"updated":"2016-10-21 01:02:25.000000000","message":"small tips: these lines can be moved into an util method","commit_id":"170c2d995bed0c2e40dc61fb05129a4695513c4e"},{"author":{"_account_id":14532,"name":"Gerald McBrearty","email":"gfm@us.ibm.com","username":"gfm"},"change_message_id":"cc18b475e449bf60aaff5d4839017c42765a7996","unresolved":false,"context_lines":[{"line_number":765,"context_line":"            # begining of the list"},{"line_number":766,"context_line":"            for host in host_list:"},{"line_number":767,"context_line":"                if re.search(connector[\u0027host\u0027], host):"},{"line_number":768,"context_line":"                    idx \u003d host_list.index(host)"},{"line_number":769,"context_line":"                    del host_list[idx]"},{"line_number":770,"context_line":"                    host_list.insert(0, host)"},{"line_number":771,"context_line":"        # If we have a volume name we have a potential fast path"},{"line_number":772,"context_line":"        # for finding the matching host for that volume."},{"line_number":773,"context_line":"        # Add the host_names that have mappings for our volume to the"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6895a0_110cb793","line":770,"range":{"start_line":768,"start_character":17,"end_line":770,"end_character":45},"in_reply_to":"da6895a0_9bc5465d","updated":"2016-10-21 02:48:08.000000000","message":"yes those are common.","commit_id":"170c2d995bed0c2e40dc61fb05129a4695513c4e"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"c1ed497fc1c47aa5c84a838541031d4239375e7d","unresolved":false,"context_lines":[{"line_number":761,"context_line":"        hosts_info \u003d self.ssh.lshost()"},{"line_number":762,"context_line":"        host_list \u003d list(hosts_info.select(\u0027name\u0027))"},{"line_number":763,"context_line":"        # If we have a \"real\" connector, we might be able to find the"},{"line_number":764,"context_line":"        # the host entry with fewer queries if we move the host entries"},{"line_number":765,"context_line":"        # that contain the connector\u0027s host property value to the front"},{"line_number":766,"context_line":"        # of the list"},{"line_number":767,"context_line":"        if \u0027host\u0027 in connector:"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5da102_bbff2100","line":764,"updated":"2016-10-29 23:37:28.000000000","message":"Duplicate the","commit_id":"26e38af0a9cb55eaa1cc673495e5273679f43ccc"},{"author":{"_account_id":14532,"name":"Gerald McBrearty","email":"gfm@us.ibm.com","username":"gfm"},"change_message_id":"d0cd04c6fd57bd7d734e231a16590c331fc55c25","unresolved":false,"context_lines":[{"line_number":761,"context_line":"        hosts_info \u003d self.ssh.lshost()"},{"line_number":762,"context_line":"        host_list \u003d list(hosts_info.select(\u0027name\u0027))"},{"line_number":763,"context_line":"        # If we have a \"real\" connector, we might be able to find the"},{"line_number":764,"context_line":"        # the host entry with fewer queries if we move the host entries"},{"line_number":765,"context_line":"        # that contain the connector\u0027s host property value to the front"},{"line_number":766,"context_line":"        # of the list"},{"line_number":767,"context_line":"        if \u0027host\u0027 in connector:"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5da102_3dee69b4","line":764,"in_reply_to":"ba5da102_bbff2100","updated":"2016-11-01 18:35:05.000000000","message":"I thought about duplicating, but I think contains is a better description. The host entry on the SVC is normally \"HOST+8digit-random\" but it could be \"_HOST+8digit-random\" if the first char of the HOST is not an allowed char by the controller.","commit_id":"26e38af0a9cb55eaa1cc673495e5273679f43ccc"}]}