)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"cc599515a9872675444336f6d77da9016701f733","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Missing parameter for storage pools in Pure Storage driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Storage pools requires a manadatory parameter called"},{"line_number":10,"context_line":"QoS_support. This is missing in the Pure Storage driver"},{"line_number":11,"context_line":"so we will add it with the value of False"},{"line_number":12,"context_line":"Also add parameter to unit test."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a77a97e_c029448b","line":9,"range":{"start_line":9,"start_character":25,"end_line":9,"end_character":35},"updated":"2016-11-16 09:58:33.000000000","message":"nit: mandatory","commit_id":"8d5a563aba6f6d66d8b240812ba4155fb3f03ff0"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"cc599515a9872675444336f6d77da9016701f733","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Missing parameter for storage pools in Pure Storage driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Storage pools requires a manadatory parameter called"},{"line_number":10,"context_line":"QoS_support. This is missing in the Pure Storage driver"},{"line_number":11,"context_line":"so we will add it with the value of False"},{"line_number":12,"context_line":"Also add parameter to unit test."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a77a97e_80190c7c","line":10,"updated":"2016-11-16 09:58:33.000000000","message":"afaik QoS_support field is not mandatory [1] and as such is defaulting to False in the Scheduler.\n\nHaving said that, I\u0027m in favor of drivers saying this explicitly.\n\n\n[1]: http://docs.openstack.org/developer/cinder/devref/drivers.html#volume-stats","commit_id":"8d5a563aba6f6d66d8b240812ba4155fb3f03ff0"},{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"cc7bb843a1e6412bc48ffae2080d17f5563350ad","unresolved":false,"context_lines":[{"line_number":11,"context_line":"so we will add it with the value of False"},{"line_number":12,"context_line":"Also add parameter to unit test."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Fixes bug 1635342"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I9f81f72fddf85ed7dee920ae48bea7f9707d4744"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da6895a0_dbe78c10","line":14,"updated":"2016-10-23 08:29:55.000000000","message":"I think the \"official\" format is more like:\n\n Closes-Bug: #1635342\n\nBut looks like gerrit figured out the link to launchpad anyway... not sure how much (if any) it matters.","commit_id":"8d5a563aba6f6d66d8b240812ba4155fb3f03ff0"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"80f4481a18b4dd297aa4ea40595a47001c4d3f9c","unresolved":false,"context_lines":[{"line_number":11,"context_line":"so we will add it with the value of False"},{"line_number":12,"context_line":"Also add parameter to unit test."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Fixes bug 1635342"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I9f81f72fddf85ed7dee920ae48bea7f9707d4744"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da6895a0_5bdd3c13","line":14,"in_reply_to":"da6895a0_dbe78c10","updated":"2016-10-23 08:42:33.000000000","message":"Yeah, looks like it should be OK. If you do need to do an update for some reason it would be good to normalize it, but otherwise I don\u0027t think it\u0027s a big deal.","commit_id":"8d5a563aba6f6d66d8b240812ba4155fb3f03ff0"}]}