)]}'
{"cinder/volume/manager.py":[{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"8d2492d01862fa2507bf33ecb284efd603c82276","unresolved":false,"context_lines":[{"line_number":2354,"context_line":""},{"line_number":2355,"context_line":"        return vol_ref"},{"line_number":2356,"context_line":""},{"line_number":2357,"context_line":"    def get_manageable_volumes(self, ctxt, marker, limit, offset, sort_keys,"},{"line_number":2358,"context_line":"                               sort_dirs, want_objects\u003dFalse):"},{"line_number":2359,"context_line":"        try:"},{"line_number":2360,"context_line":"            utils.require_driver_initialized(self.driver)"},{"line_number":2361,"context_line":"        except exception.DriverNotInitialized:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_5b581757","line":2358,"range":{"start_line":2357,"start_character":3,"end_line":2358,"end_character":62},"updated":"2016-10-26 07:39:13.000000000","message":"does this method need a UT likewise?","commit_id":"7d4c37bfc0bce617ac51af576c8492599b23440b"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"8d2492d01862fa2507bf33ecb284efd603c82276","unresolved":false,"context_lines":[{"line_number":2367,"context_line":"        try:"},{"line_number":2368,"context_line":"            driver_entries \u003d self.driver.get_manageable_volumes("},{"line_number":2369,"context_line":"                cinder_volumes, marker, limit, offset, sort_keys, sort_dirs)"},{"line_number":2370,"context_line":"            if want_objects is True:"},{"line_number":2371,"context_line":"                driver_entries \u003d objects.ManageableVolumeList.\\"},{"line_number":2372,"context_line":"                    get_manage_volume_list_object(ctxt, driver_entries)"},{"line_number":2373,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_bb085393","line":2370,"range":{"start_line":2370,"start_character":12,"end_line":2370,"end_character":36},"updated":"2016-10-26 07:39:13.000000000","message":"why not directly use \u0027if want_objects\u0027?","commit_id":"7d4c37bfc0bce617ac51af576c8492599b23440b"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"8d2492d01862fa2507bf33ecb284efd603c82276","unresolved":false,"context_lines":[{"line_number":4157,"context_line":"            flow_engine.run()"},{"line_number":4158,"context_line":"        return snapshot.id"},{"line_number":4159,"context_line":""},{"line_number":4160,"context_line":"    def get_manageable_snapshots(self, ctxt, marker, limit, offset,"},{"line_number":4161,"context_line":"                                 sort_keys, sort_dirs, want_objects\u003dFalse):"},{"line_number":4162,"context_line":"        try:"},{"line_number":4163,"context_line":"            utils.require_driver_initialized(self.driver)"},{"line_number":4164,"context_line":"        except exception.DriverNotInitialized:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_7b55db1b","line":4161,"range":{"start_line":4160,"start_character":5,"end_line":4161,"end_character":75},"updated":"2016-10-26 07:39:13.000000000","message":"ditto","commit_id":"7d4c37bfc0bce617ac51af576c8492599b23440b"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"8d2492d01862fa2507bf33ecb284efd603c82276","unresolved":false,"context_lines":[{"line_number":4170,"context_line":"        try:"},{"line_number":4171,"context_line":"            driver_entries \u003d self.driver.get_manageable_snapshots("},{"line_number":4172,"context_line":"                cinder_snapshots, marker, limit, offset, sort_keys, sort_dirs)"},{"line_number":4173,"context_line":"            if want_objects is True:"},{"line_number":4174,"context_line":"                driver_entries \u003d objects.ManageableVolumeList.\\"},{"line_number":4175,"context_line":"                    get_manage_volume_list_object(ctxt, driver_entries)"},{"line_number":4176,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_1bf85f7c","line":4173,"range":{"start_line":4173,"start_character":12,"end_line":4173,"end_character":36},"updated":"2016-10-26 07:39:13.000000000","message":"ditto","commit_id":"7d4c37bfc0bce617ac51af576c8492599b23440b"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"ff9a2b55a45cd0812f50e04e3ca233d3465ccd94","unresolved":false,"context_lines":[{"line_number":2379,"context_line":"            driver_entries \u003d self.driver.get_manageable_volumes("},{"line_number":2380,"context_line":"                cinder_volumes, marker, limit, offset, sort_keys, sort_dirs)"},{"line_number":2381,"context_line":"            if want_objects:"},{"line_number":2382,"context_line":"                driver_entries \u003d objects.ManageableVolumeList.\\"},{"line_number":2383,"context_line":"                    get_manage_volume_list_object(ctxt, driver_entries)"},{"line_number":2384,"context_line":"        except Exception:"},{"line_number":2385,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":2386,"context_line":"                LOG.exception(_LE(\"Listing manageable volumes failed, due \""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_0fb612dc","line":2383,"range":{"start_line":2382,"start_character":0,"end_line":2383,"end_character":71},"updated":"2016-11-22 14:45:01.000000000","message":"Can we use parentheses to wrap lines ([1]).\n\n[1] http://docs.openstack.org/developer/hacking/#general","commit_id":"d1f1aac503d830dc3e4eed1f596ad8d61f72b42a"},{"author":{"_account_id":20140,"name":"Karthik Prabhu Vinod","email":"karthik.prabhu.vinod@intel.com","username":"kprabhuv"},"change_message_id":"951eeb3f00ab4802451f5f7a17261ac8e0e5b75e","unresolved":false,"context_lines":[{"line_number":2379,"context_line":"            driver_entries \u003d self.driver.get_manageable_volumes("},{"line_number":2380,"context_line":"                cinder_volumes, marker, limit, offset, sort_keys, sort_dirs)"},{"line_number":2381,"context_line":"            if want_objects:"},{"line_number":2382,"context_line":"                driver_entries \u003d objects.ManageableVolumeList.\\"},{"line_number":2383,"context_line":"                    get_manage_volume_list_object(ctxt, driver_entries)"},{"line_number":2384,"context_line":"        except Exception:"},{"line_number":2385,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":2386,"context_line":"                LOG.exception(_LE(\"Listing manageable volumes failed, due \""}],"source_content_type":"text/x-python","patch_set":6,"id":"5a74a57a_2c8f7a24","line":2383,"range":{"start_line":2382,"start_character":0,"end_line":2383,"end_character":71},"in_reply_to":"7a77a97e_0fb612dc","updated":"2016-11-23 18:38:51.000000000","message":"Done","commit_id":"d1f1aac503d830dc3e4eed1f596ad8d61f72b42a"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"ff9a2b55a45cd0812f50e04e3ca233d3465ccd94","unresolved":false,"context_lines":[{"line_number":4182,"context_line":"            driver_entries \u003d self.driver.get_manageable_snapshots("},{"line_number":4183,"context_line":"                cinder_snapshots, marker, limit, offset, sort_keys, sort_dirs)"},{"line_number":4184,"context_line":"            if want_objects:"},{"line_number":4185,"context_line":"                driver_entries \u003d objects.ManageableSnapshotList.\\"},{"line_number":4186,"context_line":"                    get_manage_snapshot_list_object(ctxt, driver_entries)"},{"line_number":4187,"context_line":"        except Exception:"},{"line_number":4188,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":4189,"context_line":"                LOG.exception(_LE(\"Listing manageable snapshots failed, due \""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_2fb90ecc","line":4186,"range":{"start_line":4185,"start_character":0,"end_line":4186,"end_character":73},"updated":"2016-11-22 14:45:01.000000000","message":"ditto","commit_id":"d1f1aac503d830dc3e4eed1f596ad8d61f72b42a"},{"author":{"_account_id":20140,"name":"Karthik Prabhu Vinod","email":"karthik.prabhu.vinod@intel.com","username":"kprabhuv"},"change_message_id":"951eeb3f00ab4802451f5f7a17261ac8e0e5b75e","unresolved":false,"context_lines":[{"line_number":4182,"context_line":"            driver_entries \u003d self.driver.get_manageable_snapshots("},{"line_number":4183,"context_line":"                cinder_snapshots, marker, limit, offset, sort_keys, sort_dirs)"},{"line_number":4184,"context_line":"            if want_objects:"},{"line_number":4185,"context_line":"                driver_entries \u003d objects.ManageableSnapshotList.\\"},{"line_number":4186,"context_line":"                    get_manage_snapshot_list_object(ctxt, driver_entries)"},{"line_number":4187,"context_line":"        except Exception:"},{"line_number":4188,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":4189,"context_line":"                LOG.exception(_LE(\"Listing manageable snapshots failed, due \""}],"source_content_type":"text/x-python","patch_set":6,"id":"5a74a57a_6c99726e","line":4186,"range":{"start_line":4185,"start_character":0,"end_line":4186,"end_character":73},"in_reply_to":"7a77a97e_2fb90ecc","updated":"2016-11-23 18:38:51.000000000","message":"Done","commit_id":"d1f1aac503d830dc3e4eed1f596ad8d61f72b42a"}],"cinder/volume/rpcapi.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"ff9a2b55a45cd0812f50e04e3ca233d3465ccd94","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        3.1  - Remove promote_replica and reenable_replication. This is"},{"line_number":111,"context_line":"               non-backward compatible, but the user-facing API was removed"},{"line_number":112,"context_line":"               back in Mitaka when introducing cheesecake replication."},{"line_number":113,"context_line":"        3.2 -  Converting List Manageable Volumes list"},{"line_number":114,"context_line":"               \u0026 Manageable Snapshots list returned from drivers to ovo"},{"line_number":115,"context_line":"    \"\"\""},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    RPC_API_VERSION \u003d \u00273.2\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_8fd142fe","line":114,"range":{"start_line":113,"start_character":15,"end_line":114,"end_character":71},"updated":"2016-11-22 14:45:01.000000000","message":"I would reword it into:\n\n Returning objects instead of raw dictionaries in get_manageable_volumes and get_manageable_snapshots.","commit_id":"d1f1aac503d830dc3e4eed1f596ad8d61f72b42a"},{"author":{"_account_id":20140,"name":"Karthik Prabhu Vinod","email":"karthik.prabhu.vinod@intel.com","username":"kprabhuv"},"change_message_id":"951eeb3f00ab4802451f5f7a17261ac8e0e5b75e","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        3.1  - Remove promote_replica and reenable_replication. This is"},{"line_number":111,"context_line":"               non-backward compatible, but the user-facing API was removed"},{"line_number":112,"context_line":"               back in Mitaka when introducing cheesecake replication."},{"line_number":113,"context_line":"        3.2 -  Converting List Manageable Volumes list"},{"line_number":114,"context_line":"               \u0026 Manageable Snapshots list returned from drivers to ovo"},{"line_number":115,"context_line":"    \"\"\""},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    RPC_API_VERSION \u003d \u00273.2\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a74a57a_8c9ece54","line":114,"range":{"start_line":113,"start_character":15,"end_line":114,"end_character":71},"in_reply_to":"7a77a97e_8fd142fe","updated":"2016-11-23 18:38:51.000000000","message":"Done","commit_id":"d1f1aac503d830dc3e4eed1f596ad8d61f72b42a"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"ff9a2b55a45cd0812f50e04e3ca233d3465ccd94","unresolved":false,"context_lines":[{"line_number":310,"context_line":"        cctxt \u003d self._get_cctxt(host, version\u003dversion)"},{"line_number":311,"context_line":"        return cctxt.call(ctxt, \u0027get_manageable_volumes\u0027, marker\u003dmarker,"},{"line_number":312,"context_line":"                          limit\u003dlimit, offset\u003doffset, sort_keys\u003dsort_keys,"},{"line_number":313,"context_line":"                          sort_dirs\u003dsort_dirs, want_objects\u003dwant_objects)"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"    def get_manageable_snapshots(self, ctxt, host, marker, limit, offset,"},{"line_number":316,"context_line":"                                 sort_keys, sort_dirs, want_objects\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_2f4d8e99","line":313,"range":{"start_line":313,"start_character":47,"end_line":313,"end_character":72},"updated":"2016-11-22 14:45:01.000000000","message":"You should send want_objects only for 3.2 (actually it will be 3.3 once you rebase). Older c-vols won\u0027t accept this parameter.","commit_id":"d1f1aac503d830dc3e4eed1f596ad8d61f72b42a"},{"author":{"_account_id":20140,"name":"Karthik Prabhu Vinod","email":"karthik.prabhu.vinod@intel.com","username":"kprabhuv"},"change_message_id":"951eeb3f00ab4802451f5f7a17261ac8e0e5b75e","unresolved":false,"context_lines":[{"line_number":310,"context_line":"        cctxt \u003d self._get_cctxt(host, version\u003dversion)"},{"line_number":311,"context_line":"        return cctxt.call(ctxt, \u0027get_manageable_volumes\u0027, marker\u003dmarker,"},{"line_number":312,"context_line":"                          limit\u003dlimit, offset\u003doffset, sort_keys\u003dsort_keys,"},{"line_number":313,"context_line":"                          sort_dirs\u003dsort_dirs, want_objects\u003dwant_objects)"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"    def get_manageable_snapshots(self, ctxt, host, marker, limit, offset,"},{"line_number":316,"context_line":"                                 sort_keys, sort_dirs, want_objects\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a74a57a_cca0c693","line":313,"range":{"start_line":313,"start_character":47,"end_line":313,"end_character":72},"in_reply_to":"7a77a97e_2f4d8e99","updated":"2016-11-23 18:38:51.000000000","message":"Done","commit_id":"d1f1aac503d830dc3e4eed1f596ad8d61f72b42a"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"ff9a2b55a45cd0812f50e04e3ca233d3465ccd94","unresolved":false,"context_lines":[{"line_number":318,"context_line":"        cctxt \u003d self._get_cctxt(host, version\u003dversion)"},{"line_number":319,"context_line":"        return cctxt.call(ctxt, \u0027get_manageable_snapshots\u0027, marker\u003dmarker,"},{"line_number":320,"context_line":"                          limit\u003dlimit, offset\u003doffset, sort_keys\u003dsort_keys,"},{"line_number":321,"context_line":"                          sort_dirs\u003dsort_dirs, want_objects\u003dwant_objects)"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"    def create_group(self, ctxt, group, host):"},{"line_number":324,"context_line":"        cctxt \u003d self._get_cctxt(host)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_af599e5d","line":321,"range":{"start_line":321,"start_character":47,"end_line":321,"end_character":72},"updated":"2016-11-22 14:45:01.000000000","message":"Ditto.","commit_id":"d1f1aac503d830dc3e4eed1f596ad8d61f72b42a"},{"author":{"_account_id":20140,"name":"Karthik Prabhu Vinod","email":"karthik.prabhu.vinod@intel.com","username":"kprabhuv"},"change_message_id":"951eeb3f00ab4802451f5f7a17261ac8e0e5b75e","unresolved":false,"context_lines":[{"line_number":318,"context_line":"        cctxt \u003d self._get_cctxt(host, version\u003dversion)"},{"line_number":319,"context_line":"        return cctxt.call(ctxt, \u0027get_manageable_snapshots\u0027, marker\u003dmarker,"},{"line_number":320,"context_line":"                          limit\u003dlimit, offset\u003doffset, sort_keys\u003dsort_keys,"},{"line_number":321,"context_line":"                          sort_dirs\u003dsort_dirs, want_objects\u003dwant_objects)"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"    def create_group(self, ctxt, group, host):"},{"line_number":324,"context_line":"        cctxt \u003d self._get_cctxt(host)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a74a57a_ecad8289","line":321,"range":{"start_line":321,"start_character":47,"end_line":321,"end_character":72},"in_reply_to":"7a77a97e_af599e5d","updated":"2016-11-23 18:38:51.000000000","message":"Done","commit_id":"d1f1aac503d830dc3e4eed1f596ad8d61f72b42a"}]}