)]}'
{"cinder/tests/unit/test_falconstor_fss.py":[{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"22370ccfdd37ee33feedadf19c2374dc4cf188e9","unresolved":false,"context_lines":[{"line_number":308,"context_line":"        SNAPSHOT_METADATA[\"fss-tm-comment\"] \u003d snap_name"},{"line_number":309,"context_line":"        result \u003d self.driver.create_snapshot(SNAPSHOT_LONG_NAME)"},{"line_number":310,"context_line":"        mock_create_snapshot.assert_called_once_with(SNAPSHOT_LONG_NAME)"},{"line_number":311,"context_line":"        self.assertEqual(result, {\u0027metadata\u0027: SNAPSHOT_METADATA})"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"    @mock.patch.object(proxy.RESTProxy, \u0027delete_snapshot\u0027,"},{"line_number":314,"context_line":"                                        return_value\u003dAPI_RESPONSE)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5da102_754a1485","line":311,"range":{"start_line":311,"start_character":7,"end_line":311,"end_character":65},"updated":"2016-10-28 06:43:03.000000000","message":"As you described in your testcase title, the result should be:\n```\n{\"metadata\":  encoded_snapshot_id}\n```\nAm I right?","commit_id":"da619b8616f6c95e08490888b0d266d22a8f2052"}],"cinder/volume/drivers/falconstor/rest_proxy.py":[{"author":{"_account_id":23685,"name":"Mohammad Sayyed","email":"sayyedsbox@gmail.com","username":"sayyedm"},"change_message_id":"e7963459fd1542d82c8ce3b6a0c4506380146c29","unresolved":false,"context_lines":[{"line_number":348,"context_line":"        if not snap_name:"},{"line_number":349,"context_line":"            snap_name \u003d \"snap-%s\" % time.strftime(\u0027%Y%m%d%H%M%S\u0027)"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"        if snap_name is not None and len(snap_name) \u003e 32:"},{"line_number":352,"context_line":"            snap_name \u003d self._encode_name(snapshot[\"id\"])"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"        self.FSS.create_timemark(vid, snap_name)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5da102_3fbaf2c0","line":351,"range":{"start_line":351,"start_character":20,"end_line":351,"end_character":21},"updated":"2016-11-01 11:00:32.000000000","message":"The not None check is not required here, as we are checking \u0027if not snap_name\u0027 on above line 348.","commit_id":"68683080cddab5c313a88690e45f2be2402a0d37"},{"author":{"_account_id":23685,"name":"Mohammad Sayyed","email":"sayyedsbox@gmail.com","username":"sayyedm"},"change_message_id":"e7963459fd1542d82c8ce3b6a0c4506380146c29","unresolved":false,"context_lines":[{"line_number":358,"context_line":"    def delete_snapshot(self, snapshot):"},{"line_number":359,"context_line":"        volume_name \u003d self._get_vol_name_from_snap(snapshot)"},{"line_number":360,"context_line":"        snap_name \u003d snapshot[\"display_name\"]"},{"line_number":361,"context_line":"        if snap_name is not None and len(snap_name) \u003e 32:"},{"line_number":362,"context_line":"            snap_name \u003d self._encode_name(snapshot[\"id\"])"},{"line_number":363,"context_line":"        vid \u003d self._get_fss_vid_from_name(volume_name, FSS_SINGLE_TYPE)"},{"line_number":364,"context_line":"        if not vid:"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5da102_9fcbfe52","line":361,"range":{"start_line":361,"start_character":37,"end_line":361,"end_character":40},"updated":"2016-11-01 11:00:32.000000000","message":"I think if create snapshot was successful, it implies that snap_name would not be None. But still if we want to check it for some failure cases, we can use \u0027if not snap_name\u0027.","commit_id":"68683080cddab5c313a88690e45f2be2402a0d37"}]}