)]}'
{"cinder/volume/drivers/dell/dell_storagecenter_api.py":[{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"f9662cd3964c066db1d940aeae0a20142afd83d8","unresolved":false,"context_lines":[{"line_number":674,"context_line":"                if provider_id.split(\u0027.\u0027)[0] \u003d\u003d six.text_type(self.ssn):"},{"line_number":675,"context_line":"                    ret \u003d True"},{"line_number":676,"context_line":"                else:"},{"line_number":677,"context_line":"                    LOG.info(_LI(\u0027_use_provider_id: provider_id \u0027"},{"line_number":678,"context_line":"                                 \u0027%(pid)r not valid on %(ssn)r\u0027),"},{"line_number":679,"context_line":"                             {\u0027pid\u0027: provider_id, \u0027ssn\u0027: self.ssn})"},{"line_number":680,"context_line":"            except Exception:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5da102_385f9742","line":677,"updated":"2016-10-29 23:37:08.000000000","message":"This doesn\u0027t seem to be helpful for operators. Can we improve that please?","commit_id":"d37ddaf1c0f23f7ed988d743a77e50c29054dc77"},{"author":{"_account_id":12112,"name":"Tom Swanson","email":"tom_swanson@dell.com","username":"tomswanson"},"change_message_id":"ede2ea8bd6be7ce44b90d5b9632b3c9323405ed5","unresolved":false,"context_lines":[{"line_number":674,"context_line":"                if provider_id.split(\u0027.\u0027)[0] \u003d\u003d six.text_type(self.ssn):"},{"line_number":675,"context_line":"                    ret \u003d True"},{"line_number":676,"context_line":"                else:"},{"line_number":677,"context_line":"                    LOG.info(_LI(\u0027_use_provider_id: provider_id \u0027"},{"line_number":678,"context_line":"                                 \u0027%(pid)r not valid on %(ssn)r\u0027),"},{"line_number":679,"context_line":"                             {\u0027pid\u0027: provider_id, \u0027ssn\u0027: self.ssn})"},{"line_number":680,"context_line":"            except Exception:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5da102_f171a6e1","line":677,"in_reply_to":"ba5da102_385f9742","updated":"2016-10-31 15:37:34.000000000","message":"Changed to debug.","commit_id":"d37ddaf1c0f23f7ed988d743a77e50c29054dc77"},{"author":{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},"change_message_id":"e6079bb0f41d8a78cecfdc3c679d6dfb48acb9ac","unresolved":false,"context_lines":[{"line_number":677,"context_line":"                    LOG.info(_LI(\u0027_use_provider_id: provider_id \u0027"},{"line_number":678,"context_line":"                                 \u0027%(pid)r not valid on %(ssn)r\u0027),"},{"line_number":679,"context_line":"                             {\u0027pid\u0027: provider_id, \u0027ssn\u0027: self.ssn})"},{"line_number":680,"context_line":"            except Exception:"},{"line_number":681,"context_line":"                LOG.error(_LE(\u0027_use_provider_id: provider_id %s is invalid!\u0027),"},{"line_number":682,"context_line":"                          provider_id)"},{"line_number":683,"context_line":"        return ret"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5da102_080d1a90","line":680,"range":{"start_line":680,"start_character":12,"end_line":680,"end_character":29},"updated":"2016-10-31 10:13:49.000000000","message":"It\u0027s not connected to your patch, but what kind of exception do we expect here?","commit_id":"d37ddaf1c0f23f7ed988d743a77e50c29054dc77"},{"author":{"_account_id":12112,"name":"Tom Swanson","email":"tom_swanson@dell.com","username":"tomswanson"},"change_message_id":"ede2ea8bd6be7ce44b90d5b9632b3c9323405ed5","unresolved":false,"context_lines":[{"line_number":677,"context_line":"                    LOG.info(_LI(\u0027_use_provider_id: provider_id \u0027"},{"line_number":678,"context_line":"                                 \u0027%(pid)r not valid on %(ssn)r\u0027),"},{"line_number":679,"context_line":"                             {\u0027pid\u0027: provider_id, \u0027ssn\u0027: self.ssn})"},{"line_number":680,"context_line":"            except Exception:"},{"line_number":681,"context_line":"                LOG.error(_LE(\u0027_use_provider_id: provider_id %s is invalid!\u0027),"},{"line_number":682,"context_line":"                          provider_id)"},{"line_number":683,"context_line":"        return ret"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5da102_b1672e24","line":680,"range":{"start_line":680,"start_character":12,"end_line":680,"end_character":29},"in_reply_to":"ba5da102_080d1a90","updated":"2016-10-31 15:37:34.000000000","message":"Index, type error, I think another one can show up. Handful of errors on the if not worth breaking up.","commit_id":"d37ddaf1c0f23f7ed988d743a77e50c29054dc77"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"f9662cd3964c066db1d940aeae0a20142afd83d8","unresolved":false,"context_lines":[{"line_number":850,"context_line":"                    # We have changed the volume so grab a new copy of it."},{"line_number":851,"context_line":"                    scvolume \u003d self.get_volume(self._get_id(scvolume))"},{"line_number":852,"context_line":"                    if not scvolume.get(\u0027active\u0027, False):"},{"line_number":853,"context_line":"                        LOG.error(_LE(\u0027init_volume failure: %r\u0027), scvolume)"},{"line_number":854,"context_line":"                    self.unmap_volume(scvolume, scserver)"},{"line_number":855,"context_line":"                    return"},{"line_number":856,"context_line":"        # We didn\u0027t map/unmap the volume.  So no initialization done."}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5da102_585a8b51","line":853,"updated":"2016-10-29 23:37:08.000000000","message":"Ditto","commit_id":"d37ddaf1c0f23f7ed988d743a77e50c29054dc77"},{"author":{"_account_id":12112,"name":"Tom Swanson","email":"tom_swanson@dell.com","username":"tomswanson"},"change_message_id":"ede2ea8bd6be7ce44b90d5b9632b3c9323405ed5","unresolved":false,"context_lines":[{"line_number":850,"context_line":"                    # We have changed the volume so grab a new copy of it."},{"line_number":851,"context_line":"                    scvolume \u003d self.get_volume(self._get_id(scvolume))"},{"line_number":852,"context_line":"                    if not scvolume.get(\u0027active\u0027, False):"},{"line_number":853,"context_line":"                        LOG.error(_LE(\u0027init_volume failure: %r\u0027), scvolume)"},{"line_number":854,"context_line":"                    self.unmap_volume(scvolume, scserver)"},{"line_number":855,"context_line":"                    return"},{"line_number":856,"context_line":"        # We didn\u0027t map/unmap the volume.  So no initialization done."}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5da102_c30db938","line":853,"in_reply_to":"ba5da102_1cce395a","updated":"2016-10-31 15:37:34.000000000","message":"I think an error is required here. This will precede an error in whatever call is using this init_volume function and will indicate a specific error.","commit_id":"d37ddaf1c0f23f7ed988d743a77e50c29054dc77"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"338b75514b2c79c4fd86b2c344913405cfda0645","unresolved":false,"context_lines":[{"line_number":850,"context_line":"                    # We have changed the volume so grab a new copy of it."},{"line_number":851,"context_line":"                    scvolume \u003d self.get_volume(self._get_id(scvolume))"},{"line_number":852,"context_line":"                    if not scvolume.get(\u0027active\u0027, False):"},{"line_number":853,"context_line":"                        LOG.error(_LE(\u0027init_volume failure: %r\u0027), scvolume)"},{"line_number":854,"context_line":"                    self.unmap_volume(scvolume, scserver)"},{"line_number":855,"context_line":"                    return"},{"line_number":856,"context_line":"        # We didn\u0027t map/unmap the volume.  So no initialization done."}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5da102_1cce395a","line":853,"in_reply_to":"ba5da102_585a8b51","updated":"2016-10-31 12:05:15.000000000","message":"Do we really need \u0027error\u0027  level here?","commit_id":"d37ddaf1c0f23f7ed988d743a77e50c29054dc77"},{"author":{"_account_id":12112,"name":"Tom Swanson","email":"tom_swanson@dell.com","username":"tomswanson"},"change_message_id":"ede2ea8bd6be7ce44b90d5b9632b3c9323405ed5","unresolved":false,"context_lines":[{"line_number":850,"context_line":"                    # We have changed the volume so grab a new copy of it."},{"line_number":851,"context_line":"                    scvolume \u003d self.get_volume(self._get_id(scvolume))"},{"line_number":852,"context_line":"                    if not scvolume.get(\u0027active\u0027, False):"},{"line_number":853,"context_line":"                        LOG.error(_LE(\u0027init_volume failure: %r\u0027), scvolume)"},{"line_number":854,"context_line":"                    self.unmap_volume(scvolume, scserver)"},{"line_number":855,"context_line":"                    return"},{"line_number":856,"context_line":"        # We didn\u0027t map/unmap the volume.  So no initialization done."}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5da102_231f5560","line":853,"in_reply_to":"ba5da102_585a8b51","updated":"2016-10-31 15:37:34.000000000","message":"Made this more verbose and the volume id is made obvious.","commit_id":"d37ddaf1c0f23f7ed988d743a77e50c29054dc77"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"b4a9d0bb2e966fc7048d816ef0eeaa7262899b90","unresolved":false,"context_lines":[{"line_number":850,"context_line":"                    # We have changed the volume so grab a new copy of it."},{"line_number":851,"context_line":"                    scvolume \u003d self.get_volume(self._get_id(scvolume))"},{"line_number":852,"context_line":"                    if not scvolume.get(\u0027active\u0027, False):"},{"line_number":853,"context_line":"                        LOG.error(_LE(\u0027init_volume failed to initialize\u0027"},{"line_number":854,"context_line":"                                      \u0027volume: %(name)s %(obj)r\u0027),"},{"line_number":855,"context_line":"                                  {\u0027name\u0027: scvolume[\u0027name\u0027],"},{"line_number":856,"context_line":"                                   \u0027obj\u0027: scvolume})"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5da102_9c0a3e20","line":853,"updated":"2016-10-31 17:01:04.000000000","message":"Can we please get a better message to give operators here? I wouldn\u0027t know what to do about \"init_volume\".","commit_id":"57ac9043ece23e4f0537bb3cdaae1a5f7fe2291e"},{"author":{"_account_id":12112,"name":"Tom Swanson","email":"tom_swanson@dell.com","username":"tomswanson"},"change_message_id":"63a9cad84fa69ea9c2d44f1da024377c9b5eac52","unresolved":false,"context_lines":[{"line_number":850,"context_line":"                    # We have changed the volume so grab a new copy of it."},{"line_number":851,"context_line":"                    scvolume \u003d self.get_volume(self._get_id(scvolume))"},{"line_number":852,"context_line":"                    if not scvolume.get(\u0027active\u0027, False):"},{"line_number":853,"context_line":"                        LOG.error(_LE(\u0027init_volume failed to initialize\u0027"},{"line_number":854,"context_line":"                                      \u0027volume: %(name)s %(obj)r\u0027),"},{"line_number":855,"context_line":"                                  {\u0027name\u0027: scvolume[\u0027name\u0027],"},{"line_number":856,"context_line":"                                   \u0027obj\u0027: scvolume})"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5da102_7c164aa8","line":853,"in_reply_to":"ba5da102_9c0a3e20","updated":"2016-10-31 17:30:58.000000000","message":"What is the traditional wording for \"call the vendor\"?","commit_id":"57ac9043ece23e4f0537bb3cdaae1a5f7fe2291e"}]}