)]}'
{"cinder/brick/exceptions.py":[{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"6654951575b4b36662770dda1d2afd276f6e7230","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# (c) Copyright 2013 Hewlett-Packard Development Company, L.P."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":6,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":7,"context_line":"#    a copy of the License at"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAQn%2F%2FKkQ%3D","line":4,"updated":"2013-08-06 04:51:08.000000000","message":"Do we need to include OpenStack here too?","commit_id":"23b3a2391a2f55fdd7781df2f696bbf86dda08db"},{"author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"change_message_id":"f86be84ebb26811895da1d37fba7cdeb984003c7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# (c) Copyright 2013 Hewlett-Packard Development Company, L.P."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":6,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":7,"context_line":"#    a copy of the License at"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAQn%2F%2FKgQ%3D","line":4,"in_reply_to":"AAAAQn%2F%2FKkQ%3D","updated":"2013-08-06 05:40:03.000000000","message":"HP only should be correct","commit_id":"23b3a2391a2f55fdd7781df2f696bbf86dda08db"}],"cinder/brick/initiator/connector.py":[{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"4cf868b33979522c8170dbf4e98f2eec0cfc7183","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        tries \u003d 0"},{"line_number":174,"context_line":"        while not os.path.exists(host_device):"},{"line_number":175,"context_line":"            if tries \u003e\u003d CONF.num_iscsi_scan_tries:"},{"line_number":176,"context_line":"                raise Exception("},{"line_number":177,"context_line":"                    _(\"iSCSI device not found at %s\") % (host_device))"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"            LOG.warn(_(\"ISCSI volume not yet found at: %(host_device)s. \""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2FdCk%3D","line":176,"updated":"2013-07-30 23:32:42.000000000","message":"ideally I think we should write an exception class in brick and raise that, whether it be internal to the connector code or imported by the connector module pointing to another brick exception class (similar to what\u0027s in the LVM code)","commit_id":"417e7117d7d1865d76a4c1b5b7620c87db1e6506"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"a8bc8c081da966ced09607417534db1e871e89fa","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        tries \u003d 0"},{"line_number":174,"context_line":"        while not os.path.exists(host_device):"},{"line_number":175,"context_line":"            if tries \u003e\u003d CONF.num_iscsi_scan_tries:"},{"line_number":176,"context_line":"                raise Exception("},{"line_number":177,"context_line":"                    _(\"iSCSI device not found at %s\") % (host_device))"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"            LOG.warn(_(\"ISCSI volume not yet found at: %(host_device)s. \""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2Fc78%3D","line":176,"in_reply_to":"AAAAQn%2F%2FdCk%3D","updated":"2013-08-03 03:27:40.000000000","message":"Done","commit_id":"417e7117d7d1865d76a4c1b5b7620c87db1e6506"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"4cf868b33979522c8170dbf4e98f2eec0cfc7183","unresolved":false,"context_lines":[{"line_number":255,"context_line":"            for l in lines.split(\u0027\\n\u0027):"},{"line_number":256,"context_line":"                if l.startswith(\u0027InitiatorName\u003d\u0027):"},{"line_number":257,"context_line":"                    return l[l.index(\u0027\u003d\u0027) + 1:].strip()"},{"line_number":258,"context_line":"        except putils.ProcessExecutionError:"},{"line_number":259,"context_line":"            return None"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"    def _run_iscsiadm(self, connection_properties, iscsi_command, **kwargs):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2FdCM%3D","line":258,"updated":"2013-07-30 23:32:42.000000000","message":"So this might be ok, but we should at least do a log.error like you did above.  Can also consider translate to brick exception and raise.","commit_id":"417e7117d7d1865d76a4c1b5b7620c87db1e6506"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"a8bc8c081da966ced09607417534db1e871e89fa","unresolved":false,"context_lines":[{"line_number":255,"context_line":"            for l in lines.split(\u0027\\n\u0027):"},{"line_number":256,"context_line":"                if l.startswith(\u0027InitiatorName\u003d\u0027):"},{"line_number":257,"context_line":"                    return l[l.index(\u0027\u003d\u0027) + 1:].strip()"},{"line_number":258,"context_line":"        except putils.ProcessExecutionError:"},{"line_number":259,"context_line":"            return None"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"    def _run_iscsiadm(self, connection_properties, iscsi_command, **kwargs):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2Fc74%3D","line":258,"in_reply_to":"AAAAQn%2F%2FdCM%3D","updated":"2013-08-03 03:27:40.000000000","message":"Done","commit_id":"417e7117d7d1865d76a4c1b5b7620c87db1e6506"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"4cf868b33979522c8170dbf4e98f2eec0cfc7183","unresolved":false,"context_lines":[{"line_number":507,"context_line":"        if len(host_devices) \u003d\u003d 0:"},{"line_number":508,"context_line":"            # this is empty because we don\u0027t have any FC HBAs"},{"line_number":509,"context_line":"            msg \u003d _(\"We are unable to locate any Fibre Channel devices\")"},{"line_number":510,"context_line":"            raise Exception(msg)"},{"line_number":511,"context_line":""},{"line_number":512,"context_line":"        # The /dev/disk/by-path/... node is not always present immediately"},{"line_number":513,"context_line":"        # We only need to find the first device.  Once we see the first device"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2FdCE%3D","line":510,"updated":"2013-07-30 23:32:42.000000000","message":"Same note as above, should probably create a custom exception class","commit_id":"417e7117d7d1865d76a4c1b5b7620c87db1e6506"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"a8bc8c081da966ced09607417534db1e871e89fa","unresolved":false,"context_lines":[{"line_number":507,"context_line":"        if len(host_devices) \u003d\u003d 0:"},{"line_number":508,"context_line":"            # this is empty because we don\u0027t have any FC HBAs"},{"line_number":509,"context_line":"            msg \u003d _(\"We are unable to locate any Fibre Channel devices\")"},{"line_number":510,"context_line":"            raise Exception(msg)"},{"line_number":511,"context_line":""},{"line_number":512,"context_line":"        # The /dev/disk/by-path/... node is not always present immediately"},{"line_number":513,"context_line":"        # We only need to find the first device.  Once we see the first device"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2FQpY%3D","line":510,"in_reply_to":"AAAAQn%2F%2FdCE%3D","updated":"2013-08-03 03:27:40.000000000","message":"Done","commit_id":"417e7117d7d1865d76a4c1b5b7620c87db1e6506"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"4cf868b33979522c8170dbf4e98f2eec0cfc7183","unresolved":false,"context_lines":[{"line_number":526,"context_line":""},{"line_number":527,"context_line":"            if self.tries \u003e\u003d CONF.num_iscsi_scan_tries:"},{"line_number":528,"context_line":"                msg \u003d _(\"Fibre Channel device not found.\")"},{"line_number":529,"context_line":"                raise Exception(msg)"},{"line_number":530,"context_line":""},{"line_number":531,"context_line":"            LOG.warn(_(\"Fibre volume not yet found. \""},{"line_number":532,"context_line":"                       \"Will rescan \u0026 retry.  Try number: %(tries)s\"),"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2FdCA%3D","line":529,"updated":"2013-07-30 23:32:42.000000000","message":"ditto","commit_id":"417e7117d7d1865d76a4c1b5b7620c87db1e6506"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"a8bc8c081da966ced09607417534db1e871e89fa","unresolved":false,"context_lines":[{"line_number":526,"context_line":""},{"line_number":527,"context_line":"            if self.tries \u003e\u003d CONF.num_iscsi_scan_tries:"},{"line_number":528,"context_line":"                msg \u003d _(\"Fibre Channel device not found.\")"},{"line_number":529,"context_line":"                raise Exception(msg)"},{"line_number":530,"context_line":""},{"line_number":531,"context_line":"            LOG.warn(_(\"Fibre volume not yet found. \""},{"line_number":532,"context_line":"                       \"Will rescan \u0026 retry.  Try number: %(tries)s\"),"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2FQpU%3D","line":529,"in_reply_to":"AAAAQn%2F%2FdCA%3D","updated":"2013-08-03 03:27:40.000000000","message":"Done","commit_id":"417e7117d7d1865d76a4c1b5b7620c87db1e6506"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"dd10803b29da71810d2cfa4ccb0db926ae643135","unresolved":false,"context_lines":[{"line_number":36,"context_line":"synchronized \u003d lockutils.synchronized_with_prefix(\u0027brick-\u0027)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"class VolumeDeviceNotFound(Exception):"},{"line_number":40,"context_line":"    def __init__(self, device):"},{"line_number":41,"context_line":"        message \u003d _(\"Volume device not found at %s\") % device"},{"line_number":42,"context_line":"        super(VolumeDeviceNotFound, self).__init__(message)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAQn%2F%2FP7k%3D","line":39,"updated":"2013-08-04 01:01:04.000000000","message":"Do we want to break these out into another file?","commit_id":"44517e2d980ea860f4226ff1d630e1773faa1346"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"e34aba4794a92bfec97cc5642a53789a9531904c","unresolved":false,"context_lines":[{"line_number":36,"context_line":"synchronized \u003d lockutils.synchronized_with_prefix(\u0027brick-\u0027)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"class VolumeDeviceNotFound(Exception):"},{"line_number":40,"context_line":"    def __init__(self, device):"},{"line_number":41,"context_line":"        message \u003d _(\"Volume device not found at %s\") % device"},{"line_number":42,"context_line":"        super(VolumeDeviceNotFound, self).__init__(message)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAQn%2F%2FL0E%3D","line":39,"in_reply_to":"AAAAQn%2F%2FP7k%3D","updated":"2013-08-05 20:33:11.000000000","message":"I was following the lead in lvm.py.   I can move them into a brick/exceptions.py and then move the lvm.py exceptions in there in a later patch?","commit_id":"44517e2d980ea860f4226ff1d630e1773faa1346"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"dd10803b29da71810d2cfa4ccb0db926ae643135","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"class NoFibreChannelHostsFound(Exception):"},{"line_number":46,"context_line":"    def __init__(self, device):"},{"line_number":47,"context_line":"        message \u003d _(\"We are unable to locate any Fibre Channel devices\")"},{"line_number":48,"context_line":"        super(NoFibreChannelHostsFound, self).__init__(message)"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAQn%2F%2FP7U%3D","line":46,"updated":"2013-08-04 01:01:04.000000000","message":"This doesn\u0027t need a device passed in.","commit_id":"44517e2d980ea860f4226ff1d630e1773faa1346"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"e34aba4794a92bfec97cc5642a53789a9531904c","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"class NoFibreChannelHostsFound(Exception):"},{"line_number":46,"context_line":"    def __init__(self, device):"},{"line_number":47,"context_line":"        message \u003d _(\"We are unable to locate any Fibre Channel devices\")"},{"line_number":48,"context_line":"        super(NoFibreChannelHostsFound, self).__init__(message)"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAQn%2F%2FLz8%3D","line":46,"in_reply_to":"AAAAQn%2F%2FP7U%3D","updated":"2013-08-05 20:33:11.000000000","message":"Done","commit_id":"44517e2d980ea860f4226ff1d630e1773faa1346"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"dd10803b29da71810d2cfa4ccb0db926ae643135","unresolved":false,"context_lines":[{"line_number":524,"context_line":"        if len(host_devices) \u003d\u003d 0:"},{"line_number":525,"context_line":"            # this is empty because we don\u0027t have any FC HBAs"},{"line_number":526,"context_line":"            msg \u003d _(\"We are unable to locate any Fibre Channel devices\")"},{"line_number":527,"context_line":"            raise NoFibreChannelHostsFound(msg)"},{"line_number":528,"context_line":""},{"line_number":529,"context_line":"        # The /dev/disk/by-path/... node is not always present immediately"},{"line_number":530,"context_line":"        # We only need to find the first device.  Once we see the first device"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAQn%2F%2FP7Y%3D","line":527,"updated":"2013-08-04 01:01:04.000000000","message":"NoFibreChannelHostsFound doesn\u0027t take in a message.","commit_id":"44517e2d980ea860f4226ff1d630e1773faa1346"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"e34aba4794a92bfec97cc5642a53789a9531904c","unresolved":false,"context_lines":[{"line_number":524,"context_line":"        if len(host_devices) \u003d\u003d 0:"},{"line_number":525,"context_line":"            # this is empty because we don\u0027t have any FC HBAs"},{"line_number":526,"context_line":"            msg \u003d _(\"We are unable to locate any Fibre Channel devices\")"},{"line_number":527,"context_line":"            raise NoFibreChannelHostsFound(msg)"},{"line_number":528,"context_line":""},{"line_number":529,"context_line":"        # The /dev/disk/by-path/... node is not always present immediately"},{"line_number":530,"context_line":"        # We only need to find the first device.  Once we see the first device"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAQn%2F%2FLuA%3D","line":527,"in_reply_to":"AAAAQn%2F%2FP7Y%3D","updated":"2013-08-05 20:33:11.000000000","message":"Done","commit_id":"44517e2d980ea860f4226ff1d630e1773faa1346"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"dd10803b29da71810d2cfa4ccb0db926ae643135","unresolved":false,"context_lines":[{"line_number":544,"context_line":"            if self.tries \u003e\u003d CONF.num_iscsi_scan_tries:"},{"line_number":545,"context_line":"                msg \u003d _(\"Fibre Channel device not found.\")"},{"line_number":546,"context_line":"                LOG.error(msg)"},{"line_number":547,"context_line":"                raise VolumeDeviceNotFound(msg)"},{"line_number":548,"context_line":""},{"line_number":549,"context_line":"            LOG.warn(_(\"Fibre volume not yet found. \""},{"line_number":550,"context_line":"                       \"Will rescan \u0026 retry.  Try number: %(tries)s\"),"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAQn%2F%2FP7c%3D","line":547,"updated":"2013-08-04 01:01:04.000000000","message":"Pass the device in.","commit_id":"44517e2d980ea860f4226ff1d630e1773faa1346"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"e34aba4794a92bfec97cc5642a53789a9531904c","unresolved":false,"context_lines":[{"line_number":544,"context_line":"            if self.tries \u003e\u003d CONF.num_iscsi_scan_tries:"},{"line_number":545,"context_line":"                msg \u003d _(\"Fibre Channel device not found.\")"},{"line_number":546,"context_line":"                LOG.error(msg)"},{"line_number":547,"context_line":"                raise VolumeDeviceNotFound(msg)"},{"line_number":548,"context_line":""},{"line_number":549,"context_line":"            LOG.warn(_(\"Fibre volume not yet found. \""},{"line_number":550,"context_line":"                       \"Will rescan \u0026 retry.  Try number: %(tries)s\"),"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAQn%2F%2FLt8%3D","line":547,"in_reply_to":"AAAAQn%2F%2FP7c%3D","updated":"2013-08-05 20:33:11.000000000","message":"Done","commit_id":"44517e2d980ea860f4226ff1d630e1773faa1346"}],"cinder/tests/brick/test_brick_connector.py":[{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"b0804a091301960185b8e0db6bf3fd3935b5d2b0","unresolved":false,"context_lines":[{"line_number":226,"context_line":"                       lambda: [])"},{"line_number":227,"context_line":"        self.stubs.Set(self.connector._linuxfc, \u0027get_fc_hbas_info\u0027,"},{"line_number":228,"context_line":"                       lambda: [])"},{"line_number":229,"context_line":"        self.assertRaises(Exception,"},{"line_number":230,"context_line":"                          self.connector.connect_volume,"},{"line_number":231,"context_line":"                          connection_info[\u0027data\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2FgQ0%3D","line":229,"updated":"2013-07-30 04:43:43.000000000","message":"We don\u0027t need the cinder.exception import anymore.","commit_id":"19a4bb9488e2637bab82253e1ab2d1560fdd3db5"}]}