)]}'
{"cinder/tests/unit/volume/drivers/test_rbd.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"4ada71826efef3fe0234bfeac69d82fb2eea3953","unresolved":false,"context_lines":[{"line_number":821,"context_line":"            storage_protocol\u003d\u0027ceph\u0027,"},{"line_number":822,"context_line":"            total_capacity_gb\u003d28.44,"},{"line_number":823,"context_line":"            free_capacity_gb\u003d27.0,"},{"line_number":824,"context_line":"            reserved_percentage\u003d0,"},{"line_number":825,"context_line":"            thin_provisioning_support\u003dTrue,"},{"line_number":826,"context_line":"            provisioned_capacity_gb\u003d0.0,"},{"line_number":827,"context_line":"            max_over_subscription_ratio\u003d0.0,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_fcfeda36","line":824,"updated":"2016-10-31 17:34:21.000000000","message":"AFAIR, unit tests will fail. We have to change these values in mocks to get it working","commit_id":"1b2f177d9a5aade09d72e8c34fddcc2d23b834a6"},{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"02a836347720b207003b0486bc6cc10174cf9398","unresolved":false,"context_lines":[{"line_number":821,"context_line":"            storage_protocol\u003d\u0027ceph\u0027,"},{"line_number":822,"context_line":"            total_capacity_gb\u003d28.44,"},{"line_number":823,"context_line":"            free_capacity_gb\u003d27.0,"},{"line_number":824,"context_line":"            reserved_percentage\u003d0,"},{"line_number":825,"context_line":"            thin_provisioning_support\u003dTrue,"},{"line_number":826,"context_line":"            provisioned_capacity_gb\u003d0.0,"},{"line_number":827,"context_line":"            max_over_subscription_ratio\u003d0.0,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_d7800f49","line":824,"in_reply_to":"ba5da102_fcfeda36","updated":"2016-10-31 17:49:01.000000000","message":"Ahh, thanks for the pointer, I\u0027ll get it fixed up.","commit_id":"1b2f177d9a5aade09d72e8c34fddcc2d23b834a6"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"d51308471d701ee9b99e0681149eb24b99b43404","unresolved":false,"context_lines":[{"line_number":834,"context_line":"            reserved_percentage\u003d0,"},{"line_number":835,"context_line":"            thin_provisioning_support\u003dTrue,"},{"line_number":836,"context_line":"            provisioned_capacity_gb\u003d0.0,"},{"line_number":837,"context_line":"            max_over_subscription_ratio\u003d0.0,"},{"line_number":838,"context_line":"            multiattach\u003dFalse)"},{"line_number":839,"context_line":""},{"line_number":840,"context_line":"        actual \u003d self.driver.get_volume_stats(True)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_b5cbd771","line":837,"updated":"2016-11-08 03:35:38.000000000","message":"0.0 is not a valid max_over_subscription_ratio.  Can you change this to 1.0.","commit_id":"4a6006506267de1ab164a4a966564ff4f167d5df"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"d51308471d701ee9b99e0681149eb24b99b43404","unresolved":false,"context_lines":[{"line_number":864,"context_line":"                        reserved_percentage\u003d0,"},{"line_number":865,"context_line":"                        multiattach\u003dFalse,"},{"line_number":866,"context_line":"                        provisioned_capacity_gb\u003d0.0,"},{"line_number":867,"context_line":"                        max_over_subscription_ratio\u003d0.0,"},{"line_number":868,"context_line":"                        thin_provisioning_support\u003dTrue)"},{"line_number":869,"context_line":""},{"line_number":870,"context_line":"        actual \u003d self.driver.get_volume_stats(True)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_b592f755","line":867,"updated":"2016-11-08 03:35:38.000000000","message":"Same","commit_id":"4a6006506267de1ab164a4a966564ff4f167d5df"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"7a9026f45abcf5612d1ef0349f36e8c7dd07af59","unresolved":false,"context_lines":[{"line_number":820,"context_line":"            \u0027{\"name\":\"volumes\",\"id\":3,\"stats\":{\"kb_used\":0,\"bytes_used\":0,\u0027"},{"line_number":821,"context_line":"            \u0027\"max_avail\":28987613184,\"objects\":0}}]}\\n\u0027, \u0027\u0027)"},{"line_number":822,"context_line":""},{"line_number":823,"context_line":"        self.driver.configuration.safe_get \u003d mock.Mock()"},{"line_number":824,"context_line":"        self.driver.configuration.safe_get.side_effect \u003d \\"},{"line_number":825,"context_line":"            mock_driver_configuration"},{"line_number":826,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_3596bc4c","line":823,"updated":"2016-11-16 09:50:38.000000000","message":"This is somewhat nasty... We should be mocking the method and not assigning a mock as this is no different than doing:\n\n self.driver.configuration.safe_get \u003d mock_driver_configuration\n\nThis would be better as:\n\n self.mock_object(self.driver.configuration, \u0027safe_get\u0027, \n                  mock_driver_configuration)","commit_id":"34f2aaf362511ef5514f91672b325b5def2274c6"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"7a9026f45abcf5612d1ef0349f36e8c7dd07af59","unresolved":false,"context_lines":[{"line_number":851,"context_line":"        client.cluster.mon_command \u003d mock.Mock()"},{"line_number":852,"context_line":"        client.cluster.mon_command.return_value \u003d (22, \u0027\u0027, \u0027\u0027)"},{"line_number":853,"context_line":""},{"line_number":854,"context_line":"        self.driver.configuration.safe_get \u003d mock.Mock()"},{"line_number":855,"context_line":"        self.driver.configuration.safe_get.side_effect \u003d \\"},{"line_number":856,"context_line":"            mock_driver_configuration"},{"line_number":857,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_75ae7486","line":854,"updated":"2016-11-16 09:50:38.000000000","message":"ditto","commit_id":"34f2aaf362511ef5514f91672b325b5def2274c6"}]}