)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"026d9997efdcd2d042d3f647d8817db62aa76ef7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     zhangyi \u003cyi.zhang@easystack.cn\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-11-02 20:27:03 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Delete the \u0027backup snapshot\u0027 for target volume"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"A snapshot will be generated when restoring backup to a volume if"},{"line_number":10,"context_line":"cinder-volume and cinder-backup are ceph and diff restoring is"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba5da102_50b76539","line":7,"updated":"2016-11-02 13:32:39.000000000","message":"This is a Ceph specific change.  Please indicate that in the title.\n\nCeph backup driver: delete \u0027backup snapshot\u0027","commit_id":"460604c1a7dabfe4c8f48522e003175f6d8480d4"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"026d9997efdcd2d042d3f647d8817db62aa76ef7","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"A snapshot will be generated when restoring backup to a volume if"},{"line_number":10,"context_line":"cinder-volume and cinder-backup are ceph and diff restoring is"},{"line_number":11,"context_line":"used. The snapshot is unnecessary. Delete the \u0027backup snapshot\u0027"},{"line_number":12,"context_line":"after diff restoring in _diff_restore_rbd."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ic120acd8767744a4ba5c07a31eb9915a6550b5c8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba5da102_10dfad69","line":11,"updated":"2016-11-02 13:32:39.000000000","message":"\"The snapshot is unnecessary\" does not sound right.  You mean the snapshot is no longer needed after the restore is complete?","commit_id":"460604c1a7dabfe4c8f48522e003175f6d8480d4"}],"cinder/backup/drivers/ceph.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"026d9997efdcd2d042d3f647d8817db62aa76ef7","unresolved":false,"context_lines":[{"line_number":977,"context_line":"                              \"restore\"))"},{"line_number":978,"context_line":"            raise"},{"line_number":979,"context_line":""},{"line_number":980,"context_line":"        # Delete the dest volume\u0027s \u0027backup snapshot\u0027, which is unnecessary."},{"line_number":981,"context_line":"        restore_file.rbd_image.remove_snap(restore_point)"},{"line_number":982,"context_line":""},{"line_number":983,"context_line":"        # If the volume we are restoring to is larger than the backup volume,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_f0595936","line":980,"updated":"2016-11-02 13:32:39.000000000","message":"Is this snapshot really unnecessary in the restore process?  My understanding is that it is needed for the restore but not needed any more after the restore is complete.","commit_id":"460604c1a7dabfe4c8f48522e003175f6d8480d4"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"20bc81471dac693c5172daf8a3a513358c28b21c","unresolved":false,"context_lines":[{"line_number":979,"context_line":""},{"line_number":980,"context_line":"        # Delete the dest volume\u0027s \u0027backup snapshot\u0027, which is unnecessary"},{"line_number":981,"context_line":"        # when restore is complete."},{"line_number":982,"context_line":"        restore_file.rbd_image.remove_snap(restore_point)"},{"line_number":983,"context_line":""},{"line_number":984,"context_line":"        # If the volume we are restoring to is larger than the backup volume,"},{"line_number":985,"context_line":"        # we will need to resize it after the diff import since import-diff"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a461143_277c1a72","line":982,"updated":"2017-01-25 19:04:28.000000000","message":"Doesn\u0027t this also need to be removed if an error occurred during _rbd_diff_transfer() above?\n\nI think this needs to be in a finally: block.","commit_id":"669355c7977d916e7fd1c8c6f1aed135c2fdb926"},{"author":{"_account_id":25169,"name":"Xiaojun Liao","email":"xiaojunliao85@gmail.com","username":"wwba"},"change_message_id":"031504ff0b8dcf59722861851454008e39182c60","unresolved":false,"context_lines":[{"line_number":979,"context_line":""},{"line_number":980,"context_line":"        # Delete the dest volume\u0027s \u0027backup snapshot\u0027, which is unnecessary"},{"line_number":981,"context_line":"        # when restore is complete."},{"line_number":982,"context_line":"        restore_file.rbd_image.remove_snap(restore_point)"},{"line_number":983,"context_line":""},{"line_number":984,"context_line":"        # If the volume we are restoring to is larger than the backup volume,"},{"line_number":985,"context_line":"        # we will need to resize it after the diff import since import-diff"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4b6375_19bd8901","line":982,"in_reply_to":"3a461143_277c1a72","updated":"2017-10-25 09:50:09.000000000","message":"The rbd snapshot indeedly reduce rbd performance a lot for a time after snapshot created while ceph backend need do object clones. As Gorka say, snapshots are kept to be able to quickly restore to different backups of the volume, but it only work when restored dest volume is the backup original volume. I think the snapshot should be removed when backup restored to a new created volume.","commit_id":"669355c7977d916e7fd1c8c6f1aed135c2fdb926"}],"cinder/tests/unit/backup/drivers/test_backup_ceph.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"8853fb2edb35e76ac4c0097ea522fdfbbf0ea2ef","unresolved":false,"context_lines":[{"line_number":1003,"context_line":"        base_name \u003d \u0027volume-%s.backup.base\u0027 % (uuid.uuid4())"},{"line_number":1004,"context_line":"        restore_name \u003d \u0027foo_target\u0027"},{"line_number":1005,"context_line":"        restore_point \u003d \u0027backup.%s.snap.3824923.1425\u0027 % (uuid.uuid4())"},{"line_number":1006,"context_line":"        global snaps"},{"line_number":1007,"context_line":"        snaps \u003d {\u0027name\u0027: \u0027initial\u0027}"},{"line_number":1008,"context_line":""},{"line_number":1009,"context_line":"        def snap_create(snap):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_ed72fbaf","line":1006,"updated":"2016-11-21 14:03:07.000000000","message":"Could you please do not use globals here? It\u0027s unnecessary for the current case and make code more complecated","commit_id":"b7fe70ca6c4ca5c0c6f596e43a6802224245a54e"}]}