)]}'
{"cinder/volume/drivers/lvm.py":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"23d1832a1e9377761f6eacfbb63af66d3dfa388c","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    cfg.BoolOpt(\u0027lvm_suppress_fd_warnings\u0027,"},{"line_number":74,"context_line":"                default\u003dFalse,"},{"line_number":75,"context_line":"                help\u003d\u0027Suppress leaked file descriptor warnings in LVM \u0027"},{"line_number":76,"context_line":"                     \u0027commands.\u0027),"},{"line_number":77,"context_line":"]"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_f6f42e88","line":76,"updated":"2016-11-16 18:42:11.000000000","message":"I\u0027d remove this from this patch as it doesn\u0027t add any value to this specific patch.","commit_id":"136a35f9209648a90044c3206d83a338716f6063"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"6abca68bb609869c222f838f47f1018ce51a6dbe","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    cfg.BoolOpt(\u0027lvm_suppress_fd_warnings\u0027,"},{"line_number":74,"context_line":"                default\u003dFalse,"},{"line_number":75,"context_line":"                help\u003d\u0027Suppress leaked file descriptor warnings in LVM \u0027"},{"line_number":76,"context_line":"                     \u0027commands.\u0027),"},{"line_number":77,"context_line":"]"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_5a84075d","line":76,"in_reply_to":"7a77a97e_f6f42e88","updated":"2016-11-17 10:12:53.000000000","message":"Ooooops, absolutely!!  That\u0027s a leftover from when the patch was a PoC that also had an example of setting the attribute in a driver\u0027s __init__ method.","commit_id":"136a35f9209648a90044c3206d83a338716f6063"}],"cinder/volume/manager.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"09a0b5822a50f98fe52c333bf63bdbb2365ef879","unresolved":false,"context_lines":[{"line_number":226,"context_line":"            active_backend_id\u003dcurr_active_backend_id)"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        if self.cluster and not self.driver.SUPPORTS_ACTIVE_ACTIVE:"},{"line_number":229,"context_line":"            msg \u003d _LE(\u0027Active-Active configuration is not currently supported \u0027"},{"line_number":230,"context_line":"                      \u0027by driver %s.\u0027) % volume_driver"},{"line_number":231,"context_line":"            LOG.error(msg)"},{"line_number":232,"context_line":"            raise exception.VolumeDriverException(message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_d85cc6ef","line":229,"range":{"start_line":229,"start_character":19,"end_line":229,"end_character":21},"updated":"2016-11-16 16:53:10.000000000","message":"This should be _() since it\u0027s used in the exception.","commit_id":"136a35f9209648a90044c3206d83a338716f6063"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"98780e230f0b5006334f281373d8c3346dee6516","unresolved":false,"context_lines":[{"line_number":226,"context_line":"            active_backend_id\u003dcurr_active_backend_id)"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        if self.cluster and not self.driver.SUPPORTS_ACTIVE_ACTIVE:"},{"line_number":229,"context_line":"            msg \u003d _LE(\u0027Active-Active configuration is not currently supported \u0027"},{"line_number":230,"context_line":"                      \u0027by driver %s.\u0027) % volume_driver"},{"line_number":231,"context_line":"            LOG.error(msg)"},{"line_number":232,"context_line":"            raise exception.VolumeDriverException(message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_7091d4f0","line":229,"range":{"start_line":229,"start_character":19,"end_line":229,"end_character":21},"in_reply_to":"7a77a97e_5a2ec743","updated":"2016-11-17 15:38:24.000000000","message":"Then why bother even setting this message in the exception? I think we need to stick to the policy of using _() whenever a message is passed in to an exception. Otherwise we are making a lot more work for ourselves of checking everywhere that may or may not actually be raised up to the user. And knowing to keep that in mind when making changes that could switch from doing one or the other.","commit_id":"136a35f9209648a90044c3206d83a338716f6063"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"6abca68bb609869c222f838f47f1018ce51a6dbe","unresolved":false,"context_lines":[{"line_number":226,"context_line":"            active_backend_id\u003dcurr_active_backend_id)"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        if self.cluster and not self.driver.SUPPORTS_ACTIVE_ACTIVE:"},{"line_number":229,"context_line":"            msg \u003d _LE(\u0027Active-Active configuration is not currently supported \u0027"},{"line_number":230,"context_line":"                      \u0027by driver %s.\u0027) % volume_driver"},{"line_number":231,"context_line":"            LOG.error(msg)"},{"line_number":232,"context_line":"            raise exception.VolumeDriverException(message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_5a2ec743","line":229,"range":{"start_line":229,"start_character":19,"end_line":229,"end_character":21},"in_reply_to":"7a77a97e_d85cc6ef","updated":"2016-11-17 10:12:53.000000000","message":"I disagree, in this case the correct log translation method is _LE, because the user will not be seeing it.\n\nAs the guidelines mention:\n\n API calls should be marked for translation. However, some\n exceptions are used internally to signal error conditions\n between modules and are not intended to be presented to the\n user. Those do not need to be translated.","commit_id":"136a35f9209648a90044c3206d83a338716f6063"}]}