)]}'
{"cinder/tests/unit/volume/drivers/hpe/test_hpelefthand.py":[{"author":{"_account_id":1773,"name":"oliver-leahy-l","email":"oliver.leahy@hpe.com","username":"oliver-leahy-l"},"change_message_id":"4bbfb9a7ae2c3f9d04f974d089a9c5ec2298125d","unresolved":false,"context_lines":[{"line_number":180,"context_line":"            return subprocess.check_output(arg)"},{"line_number":181,"context_line":"        except subprocess.CalledProcessError:"},{"line_number":182,"context_line":"            pass"},{"line_number":183,"context_line":"    return False"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"@unittest.skipUnless(check_client_install(),"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_eb739413","line":183,"updated":"2016-11-08 15:17:10.000000000","message":"Would it be more efficient to try to import hpelefthandclient here and return false in the except clause? That would be a closer reflection of what the driver actually needs.","commit_id":"8b4467802ca6cac6afc4f453ec8935d1530735ed"}],"cinder/volume/drivers/hpe/hpe_lefthand_iscsi.py":[{"author":{"_account_id":1773,"name":"oliver-leahy-l","email":"oliver.leahy@hpe.com","username":"oliver-leahy-l"},"change_message_id":"da72d3d8f1b27a07af8b05bc4da697fa05a0827d","unresolved":false,"context_lines":[{"line_number":200,"context_line":"            raise exception.NotFound(_(\"HPELeftHand client is not installed.\""},{"line_number":201,"context_line":"                                       \"\\nPlease install using sudo pip\""},{"line_number":202,"context_line":"                                       \" install --upgrade python-lefthand\""},{"line_number":203,"context_line":"                                       \"client.\"))"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        # blank is the only invalid character for cluster names"},{"line_number":206,"context_line":"        # so we need to use it as a separator"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_2bf6838f","line":203,"updated":"2016-11-08 08:25:44.000000000","message":"The nested function is not called, so it should be removed? Also, why was the check for hpelefthand_api_url removed.\n\nWould it not be easier just to test whether hpelefthandclient was None? The import was attempted above at line 62","commit_id":"8037bb4bfe0ddb811a8135eab40b85732da92b66"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"e6c529ce546ea5265537f78c422950f236b7d3d8","unresolved":false,"context_lines":[{"line_number":185,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":186,"context_line":"        super(HPELeftHandISCSIDriver, self).__init__(*args, **kwargs)"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        if not hpelefthandclient:"},{"line_number":189,"context_line":"            # Checks if client was successfully imported"},{"line_number":190,"context_line":"            raise exception.NotFound(_(\"HPELeftHand client is not installed.\""},{"line_number":191,"context_line":"                                       \"\\nPlease install using sudo pip\""}],"source_content_type":"text/x-python","patch_set":4,"id":"3a71b18c_efa4baba","line":188,"updated":"2016-12-07 15:48:09.000000000","message":"IMO, it should be done in \u0027check_for_setup_error\u0027 method","commit_id":"e94690d6089d386420ed04a0ccc43e7246e8ff71"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"85ae49b5405a871f9be3cf4fa7fff983d25410cb","unresolved":false,"context_lines":[{"line_number":185,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":186,"context_line":"        super(HPELeftHandISCSIDriver, self).__init__(*args, **kwargs)"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        if not hpelefthandclient:"},{"line_number":189,"context_line":"            # Checks if client was successfully imported"},{"line_number":190,"context_line":"            raise exception.NotFound(_(\"HPELeftHand client is not installed.\""},{"line_number":191,"context_line":"                                       \"\\nPlease install using sudo pip\""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5201f7_17a328b3","line":188,"in_reply_to":"3a71b18c_85bde504","updated":"2017-01-05 20:04:23.000000000","message":"For now, it would have to be in do_setup(), because the other code in do_setup() will fail without it, since do_setup runs before check_for_setup_error.\n\nIt should not be in __init__, though.","commit_id":"e94690d6089d386420ed04a0ccc43e7246e8ff71"},{"author":{"_account_id":23185,"name":"Samantha Blanco","email":"samantha.blanco@att.com","username":"sblanco"},"change_message_id":"bcfcc123de5e84ad1afa44cdc72ca44809a47ac2","unresolved":false,"context_lines":[{"line_number":185,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":186,"context_line":"        super(HPELeftHandISCSIDriver, self).__init__(*args, **kwargs)"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        if not hpelefthandclient:"},{"line_number":189,"context_line":"            # Checks if client was successfully imported"},{"line_number":190,"context_line":"            raise exception.NotFound(_(\"HPELeftHand client is not installed.\""},{"line_number":191,"context_line":"                                       \"\\nPlease install using sudo pip\""}],"source_content_type":"text/x-python","patch_set":4,"id":"3a71b18c_85bde504","line":188,"in_reply_to":"3a71b18c_efa4baba","updated":"2016-12-07 16:12:54.000000000","message":"Looking at the code again, I agree this should be moved, but I\u0027m wondering why check_for_setup_error over do_setup","commit_id":"e94690d6089d386420ed04a0ccc43e7246e8ff71"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"aae21afce23b7a23e902f0824dc1ab65e4055db3","unresolved":false,"context_lines":[{"line_number":335,"context_line":"                        \" install using sudo pip install --upgrade \""},{"line_number":336,"context_line":"                        \"python-lefthandclient.\"))"},{"line_number":337,"context_line":"            LOG.error(ex_msg)"},{"line_number":338,"context_line":"            raise exception.NotFound(ex_msg)"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"        if hpelefthandclient.version \u003c MIN_CLIENT_VERSION:"},{"line_number":341,"context_line":"            ex_msg \u003d (_(\"Invalid hpelefthandclient version found (\""}],"source_content_type":"text/x-python","patch_set":5,"id":"ba5201f7_7bd98cf2","line":338,"updated":"2017-01-07 12:02:52.000000000","message":"Please, raise VolumeDriverException or it\u0027s child","commit_id":"7865234b1a7104557618f26e7bbad6a285615f53"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"e88a1545bb58884b89a7e5cc9f4152c98af95bac","unresolved":false,"context_lines":[{"line_number":333,"context_line":"            # Checks if client was successfully imported"},{"line_number":334,"context_line":"            ex_msg \u003d (_(\"HPELeftHand client is not installed. Please\""},{"line_number":335,"context_line":"                        \" install using sudo pip install --upgrade \""},{"line_number":336,"context_line":"                        \"python-lefthandclient.\"))"},{"line_number":337,"context_line":"            LOG.error(ex_msg)"},{"line_number":338,"context_line":"            raise exception.VolumeDriverException(ex_msg)"},{"line_number":339,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5201f7_5f2ac22d","line":336,"updated":"2017-01-09 18:29:57.000000000","message":"Odd that this message indicates to run this with sudo and the message below does not.  (The message below also put quotes around the command to run.)","commit_id":"e797d9a33b4505662f5bcbd1190c11b9d47a5501"}]}