)]}'
{"id":"openstack%2Fcinder~39485","triplet_id":"openstack%2Fcinder~master~I57b3fe60e64d9d0dc1ea9a18442c877be2ceece3","project":"openstack/cinder","branch":"master","topic":"bug/1192971","hashtags":[],"change_id":"I57b3fe60e64d9d0dc1ea9a18442c877be2ceece3","subject":"Tidy up the SSH call to avoid injection attacks in storwize_svc","status":"MERGED","created":"2013-07-31 13:53:58.000000000","updated":"2013-08-02 12:25:32.000000000","submitted":"2013-08-02 12:25:32.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"911796c4e524a491266779783c0c29a796d52eef","_number":39485,"virtual_id_number":39485,"owner":{"_account_id":7593,"name":"Haomai Wang","email":"haomaiwang@gmail.com","username":"HaomaiWang"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},{"value":0,"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":2,"date":"2013-08-02 12:25:32.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2013-07-31 14:18:32.000000000","_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"all":[{"value":2,"date":"2013-07-31 15:10:45.000000000","_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},{"value":2,"date":"2013-08-02 04:11:19.000000000","_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":2,"date":"2013-08-02 11:26:05.000000000","_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"all":[{"value":0,"date":"2013-07-31 13:54:20.000000000","_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},{"value":0,"date":"2013-08-02 04:11:19.000000000","_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":1,"date":"2013-08-02 11:26:05.000000000","_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},{"value":0,"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-07-31 13:54:20.000000000","updated_by":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"reviewer":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"state":"REVIEWER"},{"updated":"2013-07-31 14:18:32.000000000","updated_by":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"reviewer":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2013-08-02 04:11:19.000000000","updated_by":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"reviewer":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"state":"REVIEWER"},{"updated":"2013-08-02 11:26:05.000000000","updated_by":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"reviewer":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"state":"REVIEWER"},{"updated":"2013-08-02 12:25:32.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"9f18f9ec9db1105c8d252ef4caccf2a312fc2801","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2013-07-31 14:18:32.000000000","message":"Patch Set 1: Works for me\n\nSmokeStack Results (patch set 1):\n\tLibvirt (Fedora 18) Success: http://smokestack.openstack.org/?go\u003d/jobs/106713\n\tLibvirt (Centos 6.4) Success: http://smokestack.openstack.org/?go\u003d/jobs/106714\n","accounts_in_message":[],"_revision_number":1},{"id":"bf182a7e0aefcf15ec7a1708f3a95129e8ec09aa","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-31 14:51:11.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/85/39485/1/check/gate-cinder-pep8/5494 : SUCCESS in 2m 55s\n- http://docs-draft.openstack.org/85/39485/1/check/gate-cinder-docs/5388/doc/build/html/ : SUCCESS in 5m 48s\n- http://logs.openstack.org/85/39485/1/check/gate-cinder-python26/5397 : SUCCESS in 6m 55s\n- http://logs.openstack.org/85/39485/1/check/gate-cinder-python27/5418 : SUCCESS in 3m 46s\n- http://logs.openstack.org/85/39485/1/check/gate-cinder-pylint/1397 : SUCCESS in 5m 33s (non-voting)\n- http://logs.openstack.org/85/39485/1/check/gate-tempest-devstack-vm-full/37818 : SUCCESS in 57m 01s\n- http://logs.openstack.org/85/39485/1/check/gate-tempest-devstack-vm-cells-full/4338 : FAILURE in 27m 36s (non-voting)\n- http://logs.openstack.org/85/39485/1/check/gate-tempest-devstack-vm-testr-full/3152 : SUCCESS in 28m 15s (non-voting)\n- http://logs.openstack.org/85/39485/1/check/gate-tempest-devstack-vm-postgres-full/37493 : SUCCESS in 45m 42s\n- http://logs.openstack.org/85/39485/1/check/gate-tempest-devstack-vm-neutron/9970 : SUCCESS in 24m 52s (non-voting)\n- http://logs.openstack.org/85/39485/1/check/gate-grenade-devstack-vm/23143 : SUCCESS in 28m 37s\n","accounts_in_message":[],"_revision_number":1},{"id":"22e353ab448d8d98fa8dcc956700cd3bf0f0499e","author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"date":"2013-07-31 15:10:45.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\nTested on the Storwize V7000 - looks good!  Thanks for this!","accounts_in_message":[],"_revision_number":1},{"id":"34cace520a3b45cdb560691fea57cf0ba6201c9b","author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"date":"2013-08-02 04:11:19.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"44eebdce343449e27df50525d1f895d51cce7b7e","author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"date":"2013-08-02 11:26:05.000000000","message":"Patch Set 1: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":1},{"id":"d9e93e494b5f478f07cbb7df236759a7d7d50464","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-08-02 11:26:07.000000000","message":"Patch Set 1: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"91ff1f0feb86b15d7070cd9c19703c25c2b5d50c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-08-02 12:25:32.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1},{"id":"f248c8527f5f82c1fc63c593c5fc0942c9ddee22","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-08-02 12:25:32.000000000","message":"Patch Set 1: Verified\n\nBuild succeeded.\n\n- http://docs-draft.openstack.org/85/39485/1/gate/gate-cinder-docs/968f388/doc/build/html/ : SUCCESS in 4m 38s\n- http://logs.openstack.org/85/39485/1/gate/gate-cinder-pep8/bed00be : SUCCESS in 3m 45s\n- http://logs.openstack.org/85/39485/1/gate/gate-cinder-python26/895d742 : SUCCESS in 5m 49s\n- http://logs.openstack.org/85/39485/1/gate/gate-cinder-python27/a014830 : SUCCESS in 3m 36s\n- http://logs.openstack.org/85/39485/1/gate/gate-tempest-devstack-vm-full/8526094 : SUCCESS in 58m 22s\n- http://logs.openstack.org/85/39485/1/gate/gate-tempest-devstack-vm-postgres-full/ef377a2 : SUCCESS in 49m 46s\n- http://logs.openstack.org/85/39485/1/gate/gate-tempest-devstack-vm-neutron/2b4663a : SUCCESS in 22m 53s (non-voting)\n- http://logs.openstack.org/85/39485/1/gate/gate-grenade-devstack-vm/5b3fb57 : SUCCESS in 23m 46s\n","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"f752302d181583a95cf44354aea607ce9d9283f4","revisions":{"f752302d181583a95cf44354aea607ce9d9283f4":{"kind":"REWORK","_number":1,"created":"2013-07-31 13:53:58.000000000","uploader":{"_account_id":7593,"name":"Haomai Wang","email":"haomaiwang@gmail.com","username":"HaomaiWang"},"ref":"refs/changes/85/39485/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cinder","ref":"refs/changes/85/39485/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cinder refs/changes/85/39485/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cinder refs/changes/85/39485/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cinder refs/changes/85/39485/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cinder refs/changes/85/39485/1"}}},"commit":{"parents":[{"commit":"3437a37d1ae86fa256663dc89f9d325514d09bd9","subject":"Merge \"Pop out \u0027offset\u0027 and \u0027limit\u0027 before use for filter\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder/commit/3437a37d1ae86fa256663dc89f9d325514d09bd9"}]}],"author":{"name":"Haomai Wang","email":"haomai@unitedstack.com","date":"2013-07-17 13:36:55.000000000","tz":480},"committer":{"name":"Haomai Wang","email":"haomai@unitedstack.com","date":"2013-07-31 13:50:41.000000000","tz":480},"subject":"Tidy up the SSH call to avoid injection attacks in storwize_svc","message":"Tidy up the SSH call to avoid injection attacks in storwize_svc\n\nLet the command and arguments form up a list and avoid the extra arguments\nattackers inserted to the command string\n\nfix bug 1192971\n\nChange-Id: I57b3fe60e64d9d0dc1ea9a18442c877be2ceece3\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder/commit/f752302d181583a95cf44354aea607ce9d9283f4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder/commit/f752302d181583a95cf44354aea607ce9d9283f4"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"3437a37d1ae86fa256663dc89f9d325514d09bd9","is_merged_in_target_branch":true}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}