)]}'
{"cinder/tests/unit/test_volume_utils.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"ed8c54a4baa549a64c7eb823eb5170e11fde4a34","unresolved":false,"context_lines":[{"line_number":421,"context_line":"    @mock.patch(\u0027cinder.volume.utils.copy_volume\u0027, return_value\u003dNone)"},{"line_number":422,"context_line":"    @mock.patch(\u0027cinder.volume.utils.CONF\u0027)"},{"line_number":423,"context_line":"    def test_clear_volume_args(self, mock_conf, mock_copy):"},{"line_number":424,"context_line":"        mock_conf.volume_clear \u003d \u0027should_override_with_arg\u0027"},{"line_number":425,"context_line":"        mock_conf.volume_clear_size \u003d 0"},{"line_number":426,"context_line":"        mock_conf.volume_dd_blocksize \u003d \u00271M\u0027"},{"line_number":427,"context_line":"        mock_conf.volume_clear_ionice \u003d \u0027-c3\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_0c29bd37","line":424,"range":{"start_line":424,"start_character":33,"end_line":424,"end_character":59},"updated":"2016-11-22 15:06:40.000000000","message":"-1: There\u0027s something wrong, because with this configuration clear_volume should be raising an InvalidConfigurationValue exception, right?","commit_id":"a302ebdb22d38ad86799c702725de5675eb87151"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"348c8e9e5d1469ff3d9e652308959c7186eb4851","unresolved":false,"context_lines":[{"line_number":421,"context_line":"    @mock.patch(\u0027cinder.volume.utils.copy_volume\u0027, return_value\u003dNone)"},{"line_number":422,"context_line":"    @mock.patch(\u0027cinder.volume.utils.CONF\u0027)"},{"line_number":423,"context_line":"    def test_clear_volume_args(self, mock_conf, mock_copy):"},{"line_number":424,"context_line":"        mock_conf.volume_clear \u003d \u0027should_override_with_arg\u0027"},{"line_number":425,"context_line":"        mock_conf.volume_clear_size \u003d 0"},{"line_number":426,"context_line":"        mock_conf.volume_dd_blocksize \u003d \u00271M\u0027"},{"line_number":427,"context_line":"        mock_conf.volume_clear_ionice \u003d \u0027-c3\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_0b4e1196","line":424,"range":{"start_line":424,"start_character":33,"end_line":424,"end_character":59},"in_reply_to":"5a74a57a_884107ac","updated":"2016-12-02 09:10:26.000000000","message":"My bad, I should have read more carefully the name you gave `volume_clear`, it explains the purpose of the test and the assignment.","commit_id":"a302ebdb22d38ad86799c702725de5675eb87151"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"cb04a2bb0129a8ecd5faa1c8c9f833c7a2a12e75","unresolved":false,"context_lines":[{"line_number":421,"context_line":"    @mock.patch(\u0027cinder.volume.utils.copy_volume\u0027, return_value\u003dNone)"},{"line_number":422,"context_line":"    @mock.patch(\u0027cinder.volume.utils.CONF\u0027)"},{"line_number":423,"context_line":"    def test_clear_volume_args(self, mock_conf, mock_copy):"},{"line_number":424,"context_line":"        mock_conf.volume_clear \u003d \u0027should_override_with_arg\u0027"},{"line_number":425,"context_line":"        mock_conf.volume_clear_size \u003d 0"},{"line_number":426,"context_line":"        mock_conf.volume_dd_blocksize \u003d \u00271M\u0027"},{"line_number":427,"context_line":"        mock_conf.volume_clear_ionice \u003d \u0027-c3\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a74a57a_0eab9b1e","line":424,"range":{"start_line":424,"start_character":33,"end_line":424,"end_character":59},"in_reply_to":"7a77a97e_0c29bd37","updated":"2016-11-23 16:18:42.000000000","message":"Good catch!","commit_id":"a302ebdb22d38ad86799c702725de5675eb87151"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"059dac8529e949520423013c597639587bc910bc","unresolved":false,"context_lines":[{"line_number":421,"context_line":"    @mock.patch(\u0027cinder.volume.utils.copy_volume\u0027, return_value\u003dNone)"},{"line_number":422,"context_line":"    @mock.patch(\u0027cinder.volume.utils.CONF\u0027)"},{"line_number":423,"context_line":"    def test_clear_volume_args(self, mock_conf, mock_copy):"},{"line_number":424,"context_line":"        mock_conf.volume_clear \u003d \u0027should_override_with_arg\u0027"},{"line_number":425,"context_line":"        mock_conf.volume_clear_size \u003d 0"},{"line_number":426,"context_line":"        mock_conf.volume_dd_blocksize \u003d \u00271M\u0027"},{"line_number":427,"context_line":"        mock_conf.volume_clear_ionice \u003d \u0027-c3\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a74a57a_884107ac","line":424,"range":{"start_line":424,"start_character":33,"end_line":424,"end_character":59},"in_reply_to":"7a77a97e_0c29bd37","updated":"2016-11-25 14:11:07.000000000","message":"No, because this test does not validate the config setting is used. It is validating that it does not matter what the config setting is when an explicit argument is givem in the clear_volume call, as done on line 428.\n\nSee below for test_clear_volume_invalid_opt that covers the case you were thinking of.","commit_id":"a302ebdb22d38ad86799c702725de5675eb87151"}]}