)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"change_message_id":"db5b8ee5b54c1878112e9b881da96a8a726ee60a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Ignore stmf target must be offline exception"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Patch to ignore \"NexentaJSONException: : Unable to add member to targetgroup: stmfadm: STMF target must be offline\""},{"line_number":10,"context_line":"This error happen when targetgroup already configured and it busy."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I275dcf465934c99d30f85932fe72e8b1818ef870"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAQn%2F%2FPbA%3D","line":9,"updated":"2013-08-04 16:24:17.000000000","message":"Please wrap commit message at 72 characters.","commit_id":"c759b008d08c9e9ba77b0f402c5dc7465fc54a9f"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"089ee1c4b6dda2e339d83b0f38ba1bffe52d3d98","unresolved":false,"context_lines":[{"line_number":11,"context_line":"\"NexentaJSONException: : Unable to add member to targetgroup:"},{"line_number":12,"context_line":"    stmfadm: STMF target must be offline\""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This error happen when targetgroup already configured and it busy."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I275dcf465934c99d30f85932fe72e8b1818ef870"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"AAAAQn%2F%2FKjg%3D","line":14,"updated":"2013-08-06 04:57:37.000000000","message":"This error happens when targetgroup is already configured and busy.*","commit_id":"d1d5c1503745edecdabc75fbbe531bea13a38b98"}],"cinder/volume/drivers/nexenta/volume.py":[{"author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"change_message_id":"db5b8ee5b54c1878112e9b881da96a8a726ee60a","unresolved":false,"context_lines":[{"line_number":200,"context_line":"        except nexenta.NexentaException as exc:"},{"line_number":201,"context_line":"            if not ensure or \u0027already configured\u0027 not in exc.args[1]:"},{"line_number":202,"context_line":"                raise"},{"line_number":203,"context_line":"            target_already_configured \u003d True"},{"line_number":204,"context_line":"            LOG.info(_(\u0027Ignored target creation error \"%s\"\u0027"},{"line_number":205,"context_line":"                       \u0027 while ensuring export\u0027), exc)"},{"line_number":206,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAQn%2F%2FPak%3D","line":203,"updated":"2013-08-04 16:24:17.000000000","message":"You can get he if \u0027ensure\u0027 is True and \u0027already configured\u0027 not in exc.args[1].","commit_id":"c759b008d08c9e9ba77b0f402c5dc7465fc54a9f"},{"author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"change_message_id":"db5b8ee5b54c1878112e9b881da96a8a726ee60a","unresolved":false,"context_lines":[{"line_number":210,"context_line":"                raise"},{"line_number":211,"context_line":"            if \u0027already exists\u0027 not in exc.args[1] and \\"},{"line_number":212,"context_line":"                    (target_already_configured and"},{"line_number":213,"context_line":"                        \u0027target must be offline\u0027 not in exc.args[1]):"},{"line_number":214,"context_line":"                raise"},{"line_number":215,"context_line":"            LOG.info(_(\u0027Ignored target group creation error \"%s\"\u0027"},{"line_number":216,"context_line":"                       \u0027 while ensuring export\u0027), exc)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAQn%2F%2FPaU%3D","line":213,"updated":"2013-08-04 16:24:17.000000000","message":"The parentheses around the last two are unnecessary.  I would put around all 3 statements and remove the backslash.","commit_id":"c759b008d08c9e9ba77b0f402c5dc7465fc54a9f"},{"author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"change_message_id":"fe04827e5c3ae67d2d2307e3f1307659950e415e","unresolved":false,"context_lines":[{"line_number":208,"context_line":"            if not ensure:"},{"line_number":209,"context_line":"                raise"},{"line_number":210,"context_line":"            if \u0027already configured\u0027 not in exc.args[1]:"},{"line_number":211,"context_line":"                raise"},{"line_number":212,"context_line":"            else:"},{"line_number":213,"context_line":"                target_already_configured \u003d True"},{"line_number":214,"context_line":"            LOG.info(_(\u0027Ignored target creation error \"%s\"\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAQn%2F%2FMx0%3D","line":211,"updated":"2013-08-05 16:02:26.000000000","message":"I guess it should be:\n\nif \u0027already configured\u0027 not in exc.args[1] and not ensure:\n\n?","commit_id":"01251d14aaae142162c5439d80303c60a19cf142"},{"author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"change_message_id":"dd719fa7700bc5d55b14421eb55d76b62133c9c9","unresolved":false,"context_lines":[{"line_number":205,"context_line":"        try:"},{"line_number":206,"context_line":"            self.nms.iscsitarget.create_target({\u0027target_name\u0027: target_name})"},{"line_number":207,"context_line":"        except nexenta.NexentaException as exc:"},{"line_number":208,"context_line":"            if not ensure or \u0027already configured\u0027 not in exc.args[1]:"},{"line_number":209,"context_line":"                raise"},{"line_number":210,"context_line":"            if \u0027already configured\u0027 in exc.args[1]:"},{"line_number":211,"context_line":"                target_already_configured \u003d True"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAQn%2F%2FMkI%3D","line":208,"updated":"2013-08-05 16:42:04.000000000","message":"This is wrong because you are ignoring all errors, not only \u0027already configured\u0027 (according to the comment at the start of the function, that\u0027s the only error you want to ignore).\n\nif \u0027already configured\u0027 not in exc.args[1]:\n    if not ensure:\n        raise\n    else:\n        target_already_configured \u003d True\n        LOG.info(_(\u0027Ignored target creation error \"%s\"\u0027\n                         \u0027 while ensuring export\u0027), exc)\nelse:\n    raise","commit_id":"40940ffff85a018f40557f3f7646b471e920aa21"},{"author":{"_account_id":2401,"name":"Victor Rodionov","email":"vito.ordaz@gmail.com","username":"vito-ordaz"},"change_message_id":"71b6655ef229684772f9cd1053f08fb7f00523e7","unresolved":false,"context_lines":[{"line_number":205,"context_line":"        try:"},{"line_number":206,"context_line":"            self.nms.iscsitarget.create_target({\u0027target_name\u0027: target_name})"},{"line_number":207,"context_line":"        except nexenta.NexentaException as exc:"},{"line_number":208,"context_line":"            if not ensure or \u0027already configured\u0027 not in exc.args[1]:"},{"line_number":209,"context_line":"                raise"},{"line_number":210,"context_line":"            if \u0027already configured\u0027 in exc.args[1]:"},{"line_number":211,"context_line":"                target_already_configured \u003d True"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAQn%2F%2FMcI%3D","line":208,"in_reply_to":"AAAAQn%2F%2FMkI%3D","updated":"2013-08-05 17:21:53.000000000","message":"Done","commit_id":"40940ffff85a018f40557f3f7646b471e920aa21"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"089ee1c4b6dda2e339d83b0f38ba1bffe52d3d98","unresolved":false,"context_lines":[{"line_number":214,"context_line":"        try:"},{"line_number":215,"context_line":"            self.nms.stmf.create_targetgroup(target_group_name)"},{"line_number":216,"context_line":"        except nexenta.NexentaException as exc:"},{"line_number":217,"context_line":"            if (ensure and \u0027already exists\u0027 in exc.args[1]) or \\"},{"line_number":218,"context_line":"                    (target_already_configured and"},{"line_number":219,"context_line":"                     \u0027target must be offline\u0027 in exc.args[1]):"},{"line_number":220,"context_line":"                LOG.info(_(\u0027Ignored target group creation error \"%s\"\u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAQn%2F%2FKjc%3D","line":217,"updated":"2013-08-06 04:57:37.000000000","message":"backslash shouldn\u0027t be needed when in parentheses.","commit_id":"d1d5c1503745edecdabc75fbbe531bea13a38b98"}]}