)]}'
{"cinder/tests/unit/volume/drivers/hitachi/test_hitachi_vsp_horcm_iscsi.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"93ea79a3d15976217b9cbcafa5bd85bb1256fe84","unresolved":false,"context_lines":[{"line_number":613,"context_line":"    \u0027multipath\u0027: False,"},{"line_number":614,"context_line":"}"},{"line_number":615,"context_line":""},{"line_number":616,"context_line":"TEST_VOLUME0 \u003d {"},{"line_number":617,"context_line":"    \u0027id\u0027: \u002700000000-0000-0000-0000-000000000000\u0027,"},{"line_number":618,"context_line":"    \u0027name\u0027: \u0027test-volume0\u0027,"},{"line_number":619,"context_line":"    \u0027provider_location\u0027: \u00270\u0027,"},{"line_number":620,"context_line":"    \u0027size\u0027: 128,"},{"line_number":621,"context_line":"    \u0027status\u0027: \u0027available\u0027,"},{"line_number":622,"context_line":"}"},{"line_number":623,"context_line":""},{"line_number":624,"context_line":"TEST_VOLUME1 \u003d {"},{"line_number":625,"context_line":"    \u0027id\u0027: \u002700000000-0000-0000-0000-000000000001\u0027,"},{"line_number":626,"context_line":"    \u0027name\u0027: \u0027test-volume1\u0027,"},{"line_number":627,"context_line":"    \u0027provider_location\u0027: \u00271\u0027,"},{"line_number":628,"context_line":"    \u0027size\u0027: 256,"},{"line_number":629,"context_line":"    \u0027status\u0027: \u0027available\u0027,"},{"line_number":630,"context_line":"}"},{"line_number":631,"context_line":""},{"line_number":632,"context_line":"TEST_VOLUME2 \u003d {"},{"line_number":633,"context_line":"    \u0027id\u0027: \u002700000000-0000-0000-0000-000000000002\u0027,"},{"line_number":634,"context_line":"    \u0027name\u0027: \u0027test-volume2\u0027,"},{"line_number":635,"context_line":"    \u0027provider_location\u0027: None,"},{"line_number":636,"context_line":"    \u0027size\u0027: 128,"},{"line_number":637,"context_line":"    \u0027status\u0027: \u0027creating\u0027,"},{"line_number":638,"context_line":"}"},{"line_number":639,"context_line":""},{"line_number":640,"context_line":"TEST_VOLUME3 \u003d {"},{"line_number":641,"context_line":"    \u0027id\u0027: \u002700000000-0000-0000-0000-000000000003\u0027,"},{"line_number":642,"context_line":"    \u0027name\u0027: \u0027test-volume3\u0027,"},{"line_number":643,"context_line":"    \u0027provider_location\u0027: \u00273\u0027,"},{"line_number":644,"context_line":"    \u0027size\u0027: 128,"},{"line_number":645,"context_line":"    \u0027status\u0027: \u0027available\u0027,"},{"line_number":646,"context_line":"}"},{"line_number":647,"context_line":""},{"line_number":648,"context_line":"TEST_VOLUME4 \u003d {"},{"line_number":649,"context_line":"    \u0027id\u0027: \u002700000000-0000-0000-0000-000000000004\u0027,"},{"line_number":650,"context_line":"    \u0027name\u0027: \u0027test-volume4\u0027,"},{"line_number":651,"context_line":"    \u0027provider_location\u0027: \u00274\u0027,"},{"line_number":652,"context_line":"    \u0027size\u0027: 128,"},{"line_number":653,"context_line":"    \u0027status\u0027: \u0027available\u0027,"},{"line_number":654,"context_line":"}"},{"line_number":655,"context_line":""},{"line_number":656,"context_line":"TEST_VOLUME5 \u003d {"},{"line_number":657,"context_line":"    \u0027id\u0027: \u002700000000-0000-0000-0000-000000000005\u0027,"},{"line_number":658,"context_line":"    \u0027name\u0027: \u0027test-volume5\u0027,"},{"line_number":659,"context_line":"    \u0027provider_location\u0027: \u00275\u0027,"},{"line_number":660,"context_line":"    \u0027size\u0027: 128,"},{"line_number":661,"context_line":"    \u0027status\u0027: \u0027in-use\u0027,"},{"line_number":662,"context_line":"}"},{"line_number":663,"context_line":""},{"line_number":664,"context_line":"TEST_VOLUME6 \u003d {"},{"line_number":665,"context_line":"    \u0027id\u0027: \u002700000000-0000-0000-0000-000000000006\u0027,"},{"line_number":666,"context_line":"    \u0027name\u0027: \u0027test-volume6\u0027,"},{"line_number":667,"context_line":"    \u0027provider_location\u0027: \u00276\u0027,"},{"line_number":668,"context_line":"    \u0027size\u0027: 128,"},{"line_number":669,"context_line":"    \u0027status\u0027: \u0027available\u0027,"},{"line_number":670,"context_line":"}"},{"line_number":671,"context_line":""},{"line_number":672,"context_line":"TEST_VOLUME7 \u003d {"},{"line_number":673,"context_line":"    \u0027id\u0027: \u002700000000-0000-0000-0000-000000000007\u0027,"},{"line_number":674,"context_line":"    \u0027name\u0027: \u0027test-volume7\u0027,"},{"line_number":675,"context_line":"    \u0027provider_location\u0027: \u00277\u0027,"},{"line_number":676,"context_line":"    \u0027size\u0027: 128,"},{"line_number":677,"context_line":"    \u0027status\u0027: \u0027available\u0027,"},{"line_number":678,"context_line":"}"},{"line_number":679,"context_line":""},{"line_number":680,"context_line":"TEST_VOLUME13 \u003d {"},{"line_number":681,"context_line":"    \u0027id\u0027: \u002700000000-0000-0000-0000-000000000013\u0027,"},{"line_number":682,"context_line":"    \u0027name\u0027: \u0027test-volume13\u0027,"},{"line_number":683,"context_line":"    \u0027provider_location\u0027: \u002713\u0027,"},{"line_number":684,"context_line":"    \u0027size\u0027: 128,"},{"line_number":685,"context_line":"    \u0027status\u0027: \u0027available\u0027,"},{"line_number":686,"context_line":"}"},{"line_number":687,"context_line":""},{"line_number":688,"context_line":"CTXT \u003d cinder_context.get_admin_context()"},{"line_number":689,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5a74a57a_abd07df7","line":686,"range":{"start_line":616,"start_character":0,"end_line":686,"end_character":1},"updated":"2016-11-25 14:43:18.000000000","message":"This should be created in a loop.","commit_id":"5a5e63c40e3c97b5e5e9823f13828799ba554341"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"93ea79a3d15976217b9cbcafa5bd85bb1256fe84","unresolved":false,"context_lines":[{"line_number":874,"context_line":"class VSPHORCMISCSIDriverTest(test.TestCase):"},{"line_number":875,"context_line":"    \"\"\"Unit test class for VSP HORCM interface iSCSI module.\"\"\""},{"line_number":876,"context_line":""},{"line_number":877,"context_line":"    test_snapshot0 \u003d {"},{"line_number":878,"context_line":"        \u0027id\u0027: \u002710000000-0000-0000-0000-000000000000\u0027,"},{"line_number":879,"context_line":"        \u0027name\u0027: \u0027test-snapshot0\u0027,"},{"line_number":880,"context_line":"        \u0027provider_location\u0027: \u00270\u0027,"},{"line_number":881,"context_line":"        \u0027size\u0027: 128,"},{"line_number":882,"context_line":"        \u0027status\u0027: \u0027available\u0027,"},{"line_number":883,"context_line":"        \u0027volume\u0027: TEST_VOLUME_TABLE.get("},{"line_number":884,"context_line":"            \"00000000-0000-0000-0000-000000000000\"),"},{"line_number":885,"context_line":"        \u0027volume_id\u0027: \u002700000000-0000-0000-0000-000000000000\u0027,"},{"line_number":886,"context_line":"        \u0027volume_name\u0027: \u0027test-volume0\u0027,"},{"line_number":887,"context_line":"        \u0027volume_size\u0027: 128,"},{"line_number":888,"context_line":"    }"},{"line_number":889,"context_line":""},{"line_number":890,"context_line":"    test_snapshot1 \u003d {"},{"line_number":891,"context_line":"        \u0027id\u0027: \u002710000000-0000-0000-0000-000000000001\u0027,"},{"line_number":892,"context_line":"        \u0027name\u0027: \u0027test-snapshot1\u0027,"},{"line_number":893,"context_line":"        \u0027provider_location\u0027: \u00271\u0027,"},{"line_number":894,"context_line":"        \u0027size\u0027: 256,"},{"line_number":895,"context_line":"        \u0027status\u0027: \u0027available\u0027,"},{"line_number":896,"context_line":"        \u0027volume\u0027: TEST_VOLUME_TABLE.get("},{"line_number":897,"context_line":"            \"00000000-0000-0000-0000-000000000001\"),"},{"line_number":898,"context_line":"        \u0027volume_id\u0027: \u002700000000-0000-0000-0000-000000000001\u0027,"},{"line_number":899,"context_line":"        \u0027volume_name\u0027: \u0027test-volume1\u0027,"},{"line_number":900,"context_line":"        \u0027volume_size\u0027: 256,"},{"line_number":901,"context_line":"    }"},{"line_number":902,"context_line":""},{"line_number":903,"context_line":"    test_snapshot2 \u003d {"},{"line_number":904,"context_line":"        \u0027id\u0027: \u002710000000-0000-0000-0000-000000000002\u0027,"},{"line_number":905,"context_line":"        \u0027name\u0027: \u0027test-snapshot2\u0027,"},{"line_number":906,"context_line":"        \u0027provider_location\u0027: None,"},{"line_number":907,"context_line":"        \u0027size\u0027: 128,"},{"line_number":908,"context_line":"        \u0027status\u0027: \u0027creating\u0027,"},{"line_number":909,"context_line":"        \u0027volume\u0027: TEST_VOLUME_TABLE.get("},{"line_number":910,"context_line":"            \"00000000-0000-0000-0000-000000000002\"),"},{"line_number":911,"context_line":"        \u0027volume_id\u0027: \u002700000000-0000-0000-0000-000000000002\u0027,"},{"line_number":912,"context_line":"        \u0027volume_name\u0027: \u0027test-volume2\u0027,"},{"line_number":913,"context_line":"        \u0027volume_size\u0027: 128,"},{"line_number":914,"context_line":"    }"},{"line_number":915,"context_line":""},{"line_number":916,"context_line":"    test_snapshot3 \u003d {"},{"line_number":917,"context_line":"        \u0027id\u0027: \u002710000000-0000-0000-0000-000000000003\u0027,"},{"line_number":918,"context_line":"        \u0027name\u0027: \u0027test-snapshot3\u0027,"},{"line_number":919,"context_line":"        \u0027provider_location\u0027: \u00273\u0027,"},{"line_number":920,"context_line":"        \u0027size\u0027: 128,"},{"line_number":921,"context_line":"        \u0027status\u0027: \u0027available\u0027,"},{"line_number":922,"context_line":"        \u0027volume\u0027: TEST_VOLUME_TABLE.get("},{"line_number":923,"context_line":"            \"00000000-0000-0000-0000-000000000003\"),"},{"line_number":924,"context_line":"        \u0027volume_id\u0027: \u002700000000-0000-0000-0000-000000000003\u0027,"},{"line_number":925,"context_line":"        \u0027volume_name\u0027: \u0027test-volume3\u0027,"},{"line_number":926,"context_line":"        \u0027volume_size\u0027: 128,"},{"line_number":927,"context_line":"    }"},{"line_number":928,"context_line":""},{"line_number":929,"context_line":"    test_snapshot4 \u003d {"},{"line_number":930,"context_line":"        \u0027id\u0027: \u002710000000-0000-0000-0000-000000000004\u0027,"},{"line_number":931,"context_line":"        \u0027name\u0027: \u0027test-snapshot4\u0027,"},{"line_number":932,"context_line":"        \u0027provider_location\u0027: \u00274\u0027,"},{"line_number":933,"context_line":"        \u0027size\u0027: 128,"},{"line_number":934,"context_line":"        \u0027status\u0027: \u0027available\u0027,"},{"line_number":935,"context_line":"        \u0027volume\u0027: TEST_VOLUME_TABLE.get("},{"line_number":936,"context_line":"            \"00000000-0000-0000-0000-000000000004\"),"},{"line_number":937,"context_line":"        \u0027volume_id\u0027: \u002700000000-0000-0000-0000-000000000004\u0027,"},{"line_number":938,"context_line":"        \u0027volume_name\u0027: \u0027test-volume4\u0027,"},{"line_number":939,"context_line":"        \u0027volume_size\u0027: 128,"},{"line_number":940,"context_line":"    }"},{"line_number":941,"context_line":""},{"line_number":942,"context_line":"    test_snapshot5 \u003d {"},{"line_number":943,"context_line":"        \u0027id\u0027: \u002710000000-0000-0000-0000-000000000005\u0027,"},{"line_number":944,"context_line":"        \u0027name\u0027: \u0027test-snapshot5\u0027,"},{"line_number":945,"context_line":"        \u0027provider_location\u0027: \u002710\u0027,"},{"line_number":946,"context_line":"        \u0027size\u0027: 128,"},{"line_number":947,"context_line":"        \u0027status\u0027: \u0027available\u0027,"},{"line_number":948,"context_line":"        \u0027volume\u0027: TEST_VOLUME_TABLE.get("},{"line_number":949,"context_line":"            \"00000000-0000-0000-0000-000000000007\"),"},{"line_number":950,"context_line":"        \u0027volume_id\u0027: \u002700000000-0000-0000-0000-000000000007\u0027,"},{"line_number":951,"context_line":"        \u0027volume_name\u0027: \u0027test-volume7\u0027,"},{"line_number":952,"context_line":"        \u0027volume_size\u0027: 128,"},{"line_number":953,"context_line":"    }"},{"line_number":954,"context_line":""},{"line_number":955,"context_line":"    test_snapshot6 \u003d {"},{"line_number":956,"context_line":"        \u0027id\u0027: \u002710000000-0000-0000-0000-000000000006\u0027,"},{"line_number":957,"context_line":"        \u0027name\u0027: \u0027test-snapshot6\u0027,"},{"line_number":958,"context_line":"        \u0027provider_location\u0027: \u002711\u0027,"},{"line_number":959,"context_line":"        \u0027size\u0027: 128,"},{"line_number":960,"context_line":"        \u0027status\u0027: \u0027available\u0027,"},{"line_number":961,"context_line":"        \u0027volume\u0027: TEST_VOLUME_TABLE.get("},{"line_number":962,"context_line":"            \"00000000-0000-0000-0000-000000000007\"),"},{"line_number":963,"context_line":"        \u0027volume_id\u0027: \u002700000000-0000-0000-0000-000000000007\u0027,"},{"line_number":964,"context_line":"        \u0027volume_name\u0027: \u0027test-volume7\u0027,"},{"line_number":965,"context_line":"        \u0027volume_size\u0027: 128,"},{"line_number":966,"context_line":"    }"},{"line_number":967,"context_line":""},{"line_number":968,"context_line":"    test_snapshot7 \u003d {"},{"line_number":969,"context_line":"        \u0027id\u0027: \u002710000000-0000-0000-0000-000000000007\u0027,"},{"line_number":970,"context_line":"        \u0027name\u0027: \u0027test-snapshot7\u0027,"},{"line_number":971,"context_line":"        \u0027provider_location\u0027: \u002712\u0027,"},{"line_number":972,"context_line":"        \u0027size\u0027: 128,"},{"line_number":973,"context_line":"        \u0027status\u0027: \u0027available\u0027,"},{"line_number":974,"context_line":"        \u0027volume\u0027: TEST_VOLUME_TABLE.get("},{"line_number":975,"context_line":"            \"00000000-0000-0000-0000-000000000007\"),"},{"line_number":976,"context_line":"        \u0027volume_id\u0027: \u002700000000-0000-0000-0000-000000000007\u0027,"},{"line_number":977,"context_line":"        \u0027volume_name\u0027: \u0027test-volume7\u0027,"},{"line_number":978,"context_line":"        \u0027volume_size\u0027: 128,"},{"line_number":979,"context_line":"    }"},{"line_number":980,"context_line":""},{"line_number":981,"context_line":"    TEST_SNAPSHOT_TABLE \u003d {"},{"line_number":982,"context_line":"        \u0027test-snapshot0\u0027: fake_snapshot.fake_db_snapshot(**test_snapshot0),"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a74a57a_4bfc4972","line":979,"range":{"start_line":877,"start_character":0,"end_line":979,"end_character":5},"updated":"2016-11-25 14:43:18.000000000","message":"Same here.","commit_id":"5a5e63c40e3c97b5e5e9823f13828799ba554341"}],"cinder/volume/drivers/hitachi/vsp_common.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"4ebd8cd7b8b73788f09ec4c48b52fd47a6452461","unresolved":false,"context_lines":[{"line_number":632,"context_line":"        if self.conf.vsp_use_chap_auth:"},{"line_number":633,"context_line":"            if not self.conf.vsp_auth_user:"},{"line_number":634,"context_line":"                msg \u003d utils.output_log(601, param\u003d\u0027vsp_auth_user\u0027)"},{"line_number":635,"context_line":"                raise exception.HBSDError(data\u003dmsg)"},{"line_number":636,"context_line":"            if not self.conf.vsp_auth_password:"},{"line_number":637,"context_line":"                msg \u003d utils.output_log(601, param\u003d\u0027vsp_auth_password\u0027)"},{"line_number":638,"context_line":"                raise exception.HBSDError(data\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a71b18c_e0262bcd","line":635,"updated":"2016-12-02 22:54:14.000000000","message":"Are you supposed to use the new exception VSPError?","commit_id":"074b1cd23d474ceb2c020aa26c09c50aec05477b"},{"author":{"_account_id":16373,"name":"Kazumasa Nomura","email":"kazumasa.nomura.rx@hitachi.com","username":"knomura"},"change_message_id":"21b00c9608475c57ae83178a3e443fd106fbd392","unresolved":false,"context_lines":[{"line_number":632,"context_line":"        if self.conf.vsp_use_chap_auth:"},{"line_number":633,"context_line":"            if not self.conf.vsp_auth_user:"},{"line_number":634,"context_line":"                msg \u003d utils.output_log(601, param\u003d\u0027vsp_auth_user\u0027)"},{"line_number":635,"context_line":"                raise exception.HBSDError(data\u003dmsg)"},{"line_number":636,"context_line":"            if not self.conf.vsp_auth_password:"},{"line_number":637,"context_line":"                msg \u003d utils.output_log(601, param\u003d\u0027vsp_auth_password\u0027)"},{"line_number":638,"context_line":"                raise exception.HBSDError(data\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a71b18c_36bd9b02","line":635,"in_reply_to":"3a71b18c_e0262bcd","updated":"2016-12-05 14:39:32.000000000","message":"Done","commit_id":"074b1cd23d474ceb2c020aa26c09c50aec05477b"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"4ebd8cd7b8b73788f09ec4c48b52fd47a6452461","unresolved":false,"context_lines":[{"line_number":634,"context_line":"                msg \u003d utils.output_log(601, param\u003d\u0027vsp_auth_user\u0027)"},{"line_number":635,"context_line":"                raise exception.HBSDError(data\u003dmsg)"},{"line_number":636,"context_line":"            if not self.conf.vsp_auth_password:"},{"line_number":637,"context_line":"                msg \u003d utils.output_log(601, param\u003d\u0027vsp_auth_password\u0027)"},{"line_number":638,"context_line":"                raise exception.HBSDError(data\u003dmsg)"},{"line_number":639,"context_line":""},{"line_number":640,"context_line":"    def _range2list(self, param):"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a71b18c_40551f1b","line":637,"updated":"2016-12-02 22:54:14.000000000","message":"Does this print the password in the log?","commit_id":"074b1cd23d474ceb2c020aa26c09c50aec05477b"},{"author":{"_account_id":16373,"name":"Kazumasa Nomura","email":"kazumasa.nomura.rx@hitachi.com","username":"knomura"},"change_message_id":"21b00c9608475c57ae83178a3e443fd106fbd392","unresolved":false,"context_lines":[{"line_number":634,"context_line":"                msg \u003d utils.output_log(601, param\u003d\u0027vsp_auth_user\u0027)"},{"line_number":635,"context_line":"                raise exception.HBSDError(data\u003dmsg)"},{"line_number":636,"context_line":"            if not self.conf.vsp_auth_password:"},{"line_number":637,"context_line":"                msg \u003d utils.output_log(601, param\u003d\u0027vsp_auth_password\u0027)"},{"line_number":638,"context_line":"                raise exception.HBSDError(data\u003dmsg)"},{"line_number":639,"context_line":""},{"line_number":640,"context_line":"    def _range2list(self, param):"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a71b18c_b60d2bea","line":637,"in_reply_to":"3a71b18c_40551f1b","updated":"2016-12-05 14:39:32.000000000","message":"The message is \"MSGID0601-E: A parameter is invalid. (vsp_auth_password)\". The password value specified by the user is not output to the log file.","commit_id":"074b1cd23d474ceb2c020aa26c09c50aec05477b"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"4ebd8cd7b8b73788f09ec4c48b52fd47a6452461","unresolved":false,"context_lines":[{"line_number":635,"context_line":"                raise exception.HBSDError(data\u003dmsg)"},{"line_number":636,"context_line":"            if not self.conf.vsp_auth_password:"},{"line_number":637,"context_line":"                msg \u003d utils.output_log(601, param\u003d\u0027vsp_auth_password\u0027)"},{"line_number":638,"context_line":"                raise exception.HBSDError(data\u003dmsg)"},{"line_number":639,"context_line":""},{"line_number":640,"context_line":"    def _range2list(self, param):"},{"line_number":641,"context_line":"        \"\"\"Analyze a \u0027xxx-xxx\u0027 string and return a list of two integers.\"\"\""}],"source_content_type":"text/x-python","patch_set":9,"id":"3a71b18c_002247b9","line":638,"updated":"2016-12-02 22:54:14.000000000","message":"Same here.","commit_id":"074b1cd23d474ceb2c020aa26c09c50aec05477b"},{"author":{"_account_id":16373,"name":"Kazumasa Nomura","email":"kazumasa.nomura.rx@hitachi.com","username":"knomura"},"change_message_id":"21b00c9608475c57ae83178a3e443fd106fbd392","unresolved":false,"context_lines":[{"line_number":635,"context_line":"                raise exception.HBSDError(data\u003dmsg)"},{"line_number":636,"context_line":"            if not self.conf.vsp_auth_password:"},{"line_number":637,"context_line":"                msg \u003d utils.output_log(601, param\u003d\u0027vsp_auth_password\u0027)"},{"line_number":638,"context_line":"                raise exception.HBSDError(data\u003dmsg)"},{"line_number":639,"context_line":""},{"line_number":640,"context_line":"    def _range2list(self, param):"},{"line_number":641,"context_line":"        \"\"\"Analyze a \u0027xxx-xxx\u0027 string and return a list of two integers.\"\"\""}],"source_content_type":"text/x-python","patch_set":9,"id":"3a71b18c_16f97fc7","line":638,"in_reply_to":"3a71b18c_002247b9","updated":"2016-12-05 14:39:32.000000000","message":"Done","commit_id":"074b1cd23d474ceb2c020aa26c09c50aec05477b"}],"cinder/volume/drivers/hitachi/vsp_horcm_fc.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"4ebd8cd7b8b73788f09ec4c48b52fd47a6452461","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        utils.output_log(5, object\u003d\u0027port-wwn list\u0027,"},{"line_number":66,"context_line":"                         value\u003dself.storage_info[\u0027wwns\u0027])"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def create_target_to_storage(self, port, connector, hba_ids):"},{"line_number":69,"context_line":"        \"\"\"Create a host group on the specified port.\"\"\""},{"line_number":70,"context_line":"        wwpns \u003d self.get_hba_ids_from_connector(connector)"},{"line_number":71,"context_line":"        target_name \u003d utils.TARGET_PREFIX + min(wwpns)"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a71b18c_604bfb87","line":68,"updated":"2016-12-02 22:54:14.000000000","message":"hba_ids is not used in this function.","commit_id":"074b1cd23d474ceb2c020aa26c09c50aec05477b"},{"author":{"_account_id":16373,"name":"Kazumasa Nomura","email":"kazumasa.nomura.rx@hitachi.com","username":"knomura"},"change_message_id":"21b00c9608475c57ae83178a3e443fd106fbd392","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        utils.output_log(5, object\u003d\u0027port-wwn list\u0027,"},{"line_number":66,"context_line":"                         value\u003dself.storage_info[\u0027wwns\u0027])"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def create_target_to_storage(self, port, connector, hba_ids):"},{"line_number":69,"context_line":"        \"\"\"Create a host group on the specified port.\"\"\""},{"line_number":70,"context_line":"        wwpns \u003d self.get_hba_ids_from_connector(connector)"},{"line_number":71,"context_line":"        target_name \u003d utils.TARGET_PREFIX + min(wwpns)"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a71b18c_36f03bc9","line":68,"in_reply_to":"3a71b18c_604bfb87","updated":"2016-12-05 14:39:32.000000000","message":"This function does not use hba_ids parameter, but vsp_horcm_iscsi::create_target_to_storage() uses hba_ids parameter. Since both methods are called from the same method(vsp_common::_create_target()), the signature of the two methods must be the same. Therefore, this method needs hba_ids parameter for maintenance even if it is not used.","commit_id":"074b1cd23d474ceb2c020aa26c09c50aec05477b"}],"cinder/volume/drivers/hitachi/vsp_horcm_iscsi.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"6b19c43f4f7d49faeec07dbaec36b0d2d525780c","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    .. code-block:: none"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    1.0.0 - Initial driver."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    \"\"\""},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"3a71b18c_b0ad888a","line":49,"updated":"2016-12-08 16:22:27.000000000","message":"I believe this needs to be indented to format properly.","commit_id":"3f6a9739b351980f938b4f4346586ba1012f2ce0"}]}