)]}'
{"cinder/tests/unit/volume/flows/test_create_volume_flow.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"8fcf42a120ead50fe6e379dbe4067718fd32f677","unresolved":false,"context_lines":[{"line_number":910,"context_line":""},{"line_number":911,"context_line":"    @ddt.data("},{"line_number":912,"context_line":"        NotImplementedError(),        # Driver does not support clone"},{"line_number":913,"context_line":"        exception.CinderException())  # Error during cloning"},{"line_number":914,"context_line":"    def test_create_from_image_clone_not_supported("},{"line_number":915,"context_line":"            self, effect, mock_get_internal_context,"},{"line_number":916,"context_line":"            mock_create_from_img_dl, mock_create_from_src,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_7e98b7c0","line":913,"updated":"2016-11-17 21:04:07.000000000","message":"You can pass these comments into the exceptions themselves, which may print nicer messages when this unit test fails for someone eventually.","commit_id":"b5b7c3c0de1d1727d69e14941dc723bf82bd02a6"}],"cinder/volume/flows/manager/create_volume.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"d86690e42dd563633ce9dd2889849102c14108c0","unresolved":false,"context_lines":[{"line_number":685,"context_line":"                    cache_entry[\u0027volume_id\u0027]"},{"line_number":686,"context_line":"                )"},{"line_number":687,"context_line":"                return model_update, True"},{"line_number":688,"context_line":"        except NotImplementedError as e:"},{"line_number":689,"context_line":"            LOG.warning(_LW(\u0027Backend does not support creating image-volume \u0027"},{"line_number":690,"context_line":"                            \u0027clone. Will fail back to default behavior.\u0027))"},{"line_number":691,"context_line":"        except exception.CinderException as e:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_0515b547","line":688,"updated":"2016-11-17 18:52:04.000000000","message":"We don\u0027t need unused \u0027e\u0027 variable here","commit_id":"69e030eba8ff3b5578ebe0f5baa7e817d14e92e7"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"801414abf7f4ec150999b2238962c433ddd1b4a5","unresolved":false,"context_lines":[{"line_number":685,"context_line":"                    cache_entry[\u0027volume_id\u0027]"},{"line_number":686,"context_line":"                )"},{"line_number":687,"context_line":"                return model_update, True"},{"line_number":688,"context_line":"        except NotImplementedError as e:"},{"line_number":689,"context_line":"            LOG.warning(_LW(\u0027Backend does not support creating image-volume \u0027"},{"line_number":690,"context_line":"                            \u0027clone. Will fail back to default behavior.\u0027))"},{"line_number":691,"context_line":"        except exception.CinderException as e:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_38b2d706","line":688,"in_reply_to":"7a77a97e_0515b547","updated":"2016-11-17 20:25:13.000000000","message":"Done","commit_id":"69e030eba8ff3b5578ebe0f5baa7e817d14e92e7"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"556b734682176b75d21b95f3474be4a49884e897","unresolved":false,"context_lines":[{"line_number":686,"context_line":"                )"},{"line_number":687,"context_line":"                return model_update, True"},{"line_number":688,"context_line":"        except NotImplementedError as e:"},{"line_number":689,"context_line":"            LOG.warning(_LW(\u0027Backend does not support creating image-volume \u0027"},{"line_number":690,"context_line":"                            \u0027clone. Will fail back to default behavior.\u0027))"},{"line_number":691,"context_line":"        except exception.CinderException as e:"},{"line_number":692,"context_line":"            LOG.warning(_LW(\u0027Failed to create volume from image-volume cache, \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_da3d90bc","line":689,"updated":"2016-11-16 21:22:41.000000000","message":"log the volume id in here for context? and/or the backend?","commit_id":"69e030eba8ff3b5578ebe0f5baa7e817d14e92e7"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"801414abf7f4ec150999b2238962c433ddd1b4a5","unresolved":false,"context_lines":[{"line_number":686,"context_line":"                )"},{"line_number":687,"context_line":"                return model_update, True"},{"line_number":688,"context_line":"        except NotImplementedError as e:"},{"line_number":689,"context_line":"            LOG.warning(_LW(\u0027Backend does not support creating image-volume \u0027"},{"line_number":690,"context_line":"                            \u0027clone. Will fail back to default behavior.\u0027))"},{"line_number":691,"context_line":"        except exception.CinderException as e:"},{"line_number":692,"context_line":"            LOG.warning(_LW(\u0027Failed to create volume from image-volume cache, \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_38a9f790","line":689,"in_reply_to":"7a77a97e_da3d90bc","updated":"2016-11-17 20:25:13.000000000","message":"This is an internal process, so I think the initial debug message for the call saying what is being attempted gives enough context for this.","commit_id":"69e030eba8ff3b5578ebe0f5baa7e817d14e92e7"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"556b734682176b75d21b95f3474be4a49884e897","unresolved":false,"context_lines":[{"line_number":687,"context_line":"                return model_update, True"},{"line_number":688,"context_line":"        except NotImplementedError as e:"},{"line_number":689,"context_line":"            LOG.warning(_LW(\u0027Backend does not support creating image-volume \u0027"},{"line_number":690,"context_line":"                            \u0027clone. Will fail back to default behavior.\u0027))"},{"line_number":691,"context_line":"        except exception.CinderException as e:"},{"line_number":692,"context_line":"            LOG.warning(_LW(\u0027Failed to create volume from image-volume cache, \u0027"},{"line_number":693,"context_line":"                            \u0027will fall back to default behavior. Error: \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_7a58fc32","line":690,"range":{"start_line":690,"start_character":41,"end_line":690,"end_character":45},"updated":"2016-11-16 21:22:41.000000000","message":"fall?","commit_id":"69e030eba8ff3b5578ebe0f5baa7e817d14e92e7"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"801414abf7f4ec150999b2238962c433ddd1b4a5","unresolved":false,"context_lines":[{"line_number":687,"context_line":"                return model_update, True"},{"line_number":688,"context_line":"        except NotImplementedError as e:"},{"line_number":689,"context_line":"            LOG.warning(_LW(\u0027Backend does not support creating image-volume \u0027"},{"line_number":690,"context_line":"                            \u0027clone. Will fail back to default behavior.\u0027))"},{"line_number":691,"context_line":"        except exception.CinderException as e:"},{"line_number":692,"context_line":"            LOG.warning(_LW(\u0027Failed to create volume from image-volume cache, \u0027"},{"line_number":693,"context_line":"                            \u0027will fall back to default behavior. Error: \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_58aeb398","line":690,"range":{"start_line":690,"start_character":41,"end_line":690,"end_character":45},"in_reply_to":"7a77a97e_7a58fc32","updated":"2016-11-17 20:25:13.000000000","message":"Done","commit_id":"69e030eba8ff3b5578ebe0f5baa7e817d14e92e7"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"f71701997c03a6f44ef2a77f232b3edfe8bf0a6b","unresolved":false,"context_lines":[{"line_number":687,"context_line":"                return model_update, True"},{"line_number":688,"context_line":"        except NotImplementedError:"},{"line_number":689,"context_line":"            LOG.warning(_LW(\u0027Backend does not support creating image-volume \u0027"},{"line_number":690,"context_line":"                            \u0027clone. Will fall back to default behavior.\u0027))"},{"line_number":691,"context_line":"        except exception.CinderException as e:"},{"line_number":692,"context_line":"            LOG.warning(_LW(\u0027Failed to create volume from image-volume cache, \u0027"},{"line_number":693,"context_line":"                            \u0027will fall back to default behavior. Error: \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_99282635","line":690,"updated":"2016-11-18 16:40:19.000000000","message":"Can we say something more useful and specific like \"image will be downloaded from Glance\" rather than \"fall back to default behavior\"?","commit_id":"528ec0cadbf7260234269d7764e97afda537ece8"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"913ee8dd86f90e3771c8c63b825a97cb3ca45a1f","unresolved":false,"context_lines":[{"line_number":687,"context_line":"                return model_update, True"},{"line_number":688,"context_line":"        except NotImplementedError:"},{"line_number":689,"context_line":"            LOG.warning(_LW(\u0027Backend does not support creating image-volume \u0027"},{"line_number":690,"context_line":"                            \u0027clone. Will fall back to default behavior.\u0027))"},{"line_number":691,"context_line":"        except exception.CinderException as e:"},{"line_number":692,"context_line":"            LOG.warning(_LW(\u0027Failed to create volume from image-volume cache, \u0027"},{"line_number":693,"context_line":"                            \u0027will fall back to default behavior. Error: \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_790b4a7d","line":690,"in_reply_to":"7a77a97e_99282635","updated":"2016-11-18 16:45:47.000000000","message":"Done","commit_id":"528ec0cadbf7260234269d7764e97afda537ece8"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"481894b982d8e2bd76326fef2bc064c5dd384d81","unresolved":false,"context_lines":[{"line_number":687,"context_line":"                return model_update, True"},{"line_number":688,"context_line":"        except NotImplementedError:"},{"line_number":689,"context_line":"            LOG.warning(_LW(\u0027Backend does not support creating image-volume \u0027"},{"line_number":690,"context_line":"                            \u0027clone. Image will be downloaded from Glance.\u0027))"},{"line_number":691,"context_line":"        except exception.CinderException as e:"},{"line_number":692,"context_line":"            LOG.warning(_LW(\u0027Failed to create volume from image-volume cache, \u0027"},{"line_number":693,"context_line":"                            \u0027image will be downloaded from Glance. Error: \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_36252d0a","line":690,"updated":"2016-11-21 11:30:29.000000000","message":"?: Should we log which backend doesn\u0027t support it for multibackend deployments?","commit_id":"80b93f24b2e71a25594808fb2c41e7e7ce24b697"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"d7d68854f7a97d6ec7029def171d60b3edd2a892","unresolved":false,"context_lines":[{"line_number":687,"context_line":"                return model_update, True"},{"line_number":688,"context_line":"        except NotImplementedError:"},{"line_number":689,"context_line":"            LOG.warning(_LW(\u0027Backend does not support creating image-volume \u0027"},{"line_number":690,"context_line":"                            \u0027clone. Image will be downloaded from Glance.\u0027))"},{"line_number":691,"context_line":"        except exception.CinderException as e:"},{"line_number":692,"context_line":"            LOG.warning(_LW(\u0027Failed to create volume from image-volume cache, \u0027"},{"line_number":693,"context_line":"                            \u0027image will be downloaded from Glance. Error: \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_f34c599f","line":690,"in_reply_to":"7a77a97e_36252d0a","updated":"2016-11-22 17:42:24.000000000","message":"+1 I think that NFS is the only one that doesn\u0027t.\nAlso would be god a TODO once NFS Snapshots land (if im right about it being the only one that does not support clone).","commit_id":"80b93f24b2e71a25594808fb2c41e7e7ce24b697"}]}