)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10213,"name":"Alon Marx","email":"alonma@il.ibm.com","username":"alonmarx"},"change_message_id":"fbf0aa6526faf0795b04b41d2f3649ada97eddad","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Storwize: Add volume qos parameter Bandwidth_limit"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"From Storwize Release 7.7 , there is a new qos parameter Bandwidth_limit for"},{"line_number":10,"context_line":" volume. This patch is to add the Bandwidth_limit to the qos parameter support"},{"line_number":11,"context_line":" list."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"DocImpact"},{"line_number":14,"context_line":"Adds qos config \u0027Bandwidth_limit\u0027"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5a74a57a_d2304aeb","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":6},"updated":"2016-11-24 07:38:57.000000000","message":"limit to 80 characters\nalso remove spaces at the beginning of line","commit_id":"b3a0d9762bca3f59d7b8824e222c56806235f74e"},{"author":{"_account_id":11186,"name":"yixuan zhang","email":"yixuan_z@hotmail.com","username":"yixuanzhang"},"change_message_id":"5b57ae79d2838b5149a792acd28fe30406ce671a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Storwize: Add volume qos parameter Bandwidth_limit"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"From Storwize Release 7.7 , there is a new qos parameter Bandwidth_limit for"},{"line_number":10,"context_line":" volume. This patch is to add the Bandwidth_limit to the qos parameter support"},{"line_number":11,"context_line":" list."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"DocImpact"},{"line_number":14,"context_line":"Adds qos config \u0027Bandwidth_limit\u0027"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5a74a57a_35cd8785","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":6},"in_reply_to":"5a74a57a_d2304aeb","updated":"2016-11-28 06:40:07.000000000","message":"Thank you, Alon, I have fixed it","commit_id":"b3a0d9762bca3f59d7b8824e222c56806235f74e"}],"cinder/tests/unit/volume/drivers/ibm/test_storwize_svc.py":[{"author":{"_account_id":17045,"name":"xiaoqin","email":"xiaoqin.li@hotmail.com","username":"xiaoqin"},"change_message_id":"947966731d5747c5851107f2409daa9849597b4d","unresolved":false,"context_lines":[{"line_number":3490,"context_line":"            # If qos is specified for both source and target volumes,"},{"line_number":3491,"context_line":"            # update_vdisk_qos will be called for retype, and disable_vdisk_qos"},{"line_number":3492,"context_line":"            # will not be called."},{"line_number":3493,"context_line":"            get_vdisk_params.side_effect \u003d [fake_opts_old, fake_opts_qos]"},{"line_number":3494,"context_line":"            self.driver.retype(ctxt, volume, new_type, diff, host)"},{"line_number":3495,"context_line":"            self.driver.delete_volume(volume)"},{"line_number":3496,"context_line":""},{"line_number":3497,"context_line":"        self.driver.create_volume(volume)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a74a57a_5d4b9d2b","line":3494,"range":{"start_line":3493,"start_character":0,"end_line":3494,"end_character":66},"updated":"2016-11-23 10:48:55.000000000","message":"Verify the new Qos take effect.","commit_id":"3c7dfe27383338eedcba79df99731b0d32d2507f"},{"author":{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},"change_message_id":"cfd2ab8e3647ee31cc860b15a3660e6939df35be","unresolved":false,"context_lines":[{"line_number":1666,"context_line":""},{"line_number":1667,"context_line":"        params \u003d [\u0027name\u0027, \u0027warning\u0027, \u0027udid\u0027, \u0027rate\u0027, \u0027unitmb\u0027,"},{"line_number":1668,"context_line":"                  \u0027autoexpand\u0027, \u0027easytier\u0027, \u0027primary\u0027]"},{"line_number":1669,"context_line":"        for key, value in kwargs.items():"},{"line_number":1670,"context_line":"            if key \u003d\u003d \u0027easytier\u0027:"},{"line_number":1671,"context_line":"                vol[\u0027easy_tier\u0027] \u003d value"},{"line_number":1672,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a71b18c_3647664c","line":1669,"range":{"start_line":1669,"start_character":0,"end_line":1669,"end_character":41},"updated":"2016-12-05 10:16:36.000000000","message":"-1\nI think, at this part of code key variable has only one value at a time. It\u0027s better to rewrite it to elif.\nException is the last \u0027if key in params\u0027 and we can move this check up.","commit_id":"8b97f7147601cc020adb284bab7be68c09393fa0"},{"author":{"_account_id":11186,"name":"yixuan zhang","email":"yixuan_z@hotmail.com","username":"yixuanzhang"},"change_message_id":"4375827162081da9464473c7fe8808c7516dfd2a","unresolved":false,"context_lines":[{"line_number":1666,"context_line":""},{"line_number":1667,"context_line":"        params \u003d [\u0027name\u0027, \u0027warning\u0027, \u0027udid\u0027, \u0027rate\u0027, \u0027unitmb\u0027,"},{"line_number":1668,"context_line":"                  \u0027autoexpand\u0027, \u0027easytier\u0027, \u0027primary\u0027]"},{"line_number":1669,"context_line":"        for key, value in kwargs.items():"},{"line_number":1670,"context_line":"            if key \u003d\u003d \u0027easytier\u0027:"},{"line_number":1671,"context_line":"                vol[\u0027easy_tier\u0027] \u003d value"},{"line_number":1672,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6eadb0_beaa3083","line":1669,"range":{"start_line":1669,"start_character":0,"end_line":1669,"end_character":41},"in_reply_to":"3a71b18c_3647664c","updated":"2016-12-16 07:18:51.000000000","message":"Thank you, Michael, I have fixed it","commit_id":"8b97f7147601cc020adb284bab7be68c09393fa0"}],"cinder/volume/drivers/ibm/storwize_svc/storwize_svc_common.py":[{"author":{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},"change_message_id":"cc5168acefbbcf079d83a7e047e2e2e8c07793c9","unresolved":false,"context_lines":[{"line_number":1701,"context_line":"                    else:"},{"line_number":1702,"context_line":"                        self.ssh.chvdisk(vdisk, [\u0027-unitmb\u0027, \u0027-\u0027 + param,"},{"line_number":1703,"context_line":"                                         str(value)])"},{"line_number":1704,"context_line":"                if key \u003d\u003d \u0027IOThrottling\u0027:"},{"line_number":1705,"context_line":"                    self.ssh.chvdisk(vdisk, [\u0027-\u0027 + param, str(value)])"},{"line_number":1706,"context_line":""},{"line_number":1707,"context_line":"    def update_vdisk_qos(self, code_level, vdisk, qos):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_711c0f14","line":1704,"range":{"start_line":1704,"start_character":16,"end_line":1704,"end_character":41},"updated":"2016-11-21 11:51:58.000000000","message":"I think, we should use \u0027elif\u0027 construction here","commit_id":"ae65d3067802c0f44e65d540f063e92c28755a5b"},{"author":{"_account_id":11186,"name":"yixuan zhang","email":"yixuan_z@hotmail.com","username":"yixuanzhang"},"change_message_id":"c25ed351ea8eba53bc69b512d664ec0dde51d755","unresolved":false,"context_lines":[{"line_number":1701,"context_line":"                    else:"},{"line_number":1702,"context_line":"                        self.ssh.chvdisk(vdisk, [\u0027-unitmb\u0027, \u0027-\u0027 + param,"},{"line_number":1703,"context_line":"                                         str(value)])"},{"line_number":1704,"context_line":"                if key \u003d\u003d \u0027IOThrottling\u0027:"},{"line_number":1705,"context_line":"                    self.ssh.chvdisk(vdisk, [\u0027-\u0027 + param, str(value)])"},{"line_number":1706,"context_line":""},{"line_number":1707,"context_line":"    def update_vdisk_qos(self, code_level, vdisk, qos):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_ab7d2fe9","line":1704,"range":{"start_line":1704,"start_character":16,"end_line":1704,"end_character":41},"in_reply_to":"7a77a97e_711c0f14","updated":"2016-11-22 04:35:27.000000000","message":"Thank you,Michael I have fixed it.","commit_id":"ae65d3067802c0f44e65d540f063e92c28755a5b"},{"author":{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},"change_message_id":"cc5168acefbbcf079d83a7e047e2e2e8c07793c9","unresolved":false,"context_lines":[{"line_number":1731,"context_line":"                              {\u0027code_level\u0027: code_level})"},{"line_number":1732,"context_line":"                else:"},{"line_number":1733,"context_line":"                    self.ssh.chvdisk(vdisk, [\u0027-unitmb\u0027, \u0027-\u0027 + param, str(v)])"},{"line_number":1734,"context_line":"            if key \u003d\u003d \u0027IOThrottling\u0027:"},{"line_number":1735,"context_line":"                self.ssh.chvdisk(vdisk, [\u0027-\u0027 + param, str(v)])"},{"line_number":1736,"context_line":""},{"line_number":1737,"context_line":"    def disable_vdisk_qos(self, vdisk, qos):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_9119ab25","line":1734,"range":{"start_line":1734,"start_character":12,"end_line":1734,"end_character":37},"updated":"2016-11-21 11:51:58.000000000","message":"Same","commit_id":"ae65d3067802c0f44e65d540f063e92c28755a5b"},{"author":{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},"change_message_id":"cc5168acefbbcf079d83a7e047e2e2e8c07793c9","unresolved":false,"context_lines":[{"line_number":1747,"context_line":"                if key \u003d\u003d \u0027Bandwidth_limit\u0027:"},{"line_number":1748,"context_line":"                    self.ssh.chvdisk(vdisk, [\u0027-unitmb\u0027, \u0027-\u0027 + param,"},{"line_number":1749,"context_line":"                                             value])"},{"line_number":1750,"context_line":"                if key \u003d\u003d \u0027IOThrottling\u0027:"},{"line_number":1751,"context_line":"                    self.ssh.chvdisk(vdisk, [\u0027-\u0027 + param, value])"},{"line_number":1752,"context_line":""},{"line_number":1753,"context_line":"    def change_vdisk_options(self, vdisk, changes, opts, state):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_d1b883eb","line":1750,"range":{"start_line":1750,"start_character":16,"end_line":1750,"end_character":41},"updated":"2016-11-21 11:51:58.000000000","message":"Same","commit_id":"ae65d3067802c0f44e65d540f063e92c28755a5b"},{"author":{"_account_id":17045,"name":"xiaoqin","email":"xiaoqin.li@hotmail.com","username":"xiaoqin"},"change_message_id":"947966731d5747c5851107f2409daa9849597b4d","unresolved":false,"context_lines":[{"line_number":1684,"context_line":"            return None"},{"line_number":1685,"context_line":"        return dest_pool"},{"line_number":1686,"context_line":""},{"line_number":1687,"context_line":"    def add_vdisk_qos(self, code_level, vdisk, qos):"},{"line_number":1688,"context_line":"        \"\"\"Add the QoS configuration to the volume.\"\"\""},{"line_number":1689,"context_line":"        for key, value in qos.items():"},{"line_number":1690,"context_line":"            if key in self.svc_qos_keys.keys():"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a74a57a_8c86e9b7","line":1687,"range":{"start_line":1687,"start_character":28,"end_line":1687,"end_character":38},"updated":"2016-11-23 10:48:55.000000000","message":"This parameter should be added to the end of this function and a default None value should be given if needed.","commit_id":"3c7dfe27383338eedcba79df99731b0d32d2507f"},{"author":{"_account_id":11186,"name":"yixuan zhang","email":"yixuan_z@hotmail.com","username":"yixuanzhang"},"change_message_id":"7fa6055accd3c98cb923428655ec9c0f46c1b3dd","unresolved":false,"context_lines":[{"line_number":1684,"context_line":"            return None"},{"line_number":1685,"context_line":"        return dest_pool"},{"line_number":1686,"context_line":""},{"line_number":1687,"context_line":"    def add_vdisk_qos(self, code_level, vdisk, qos):"},{"line_number":1688,"context_line":"        \"\"\"Add the QoS configuration to the volume.\"\"\""},{"line_number":1689,"context_line":"        for key, value in qos.items():"},{"line_number":1690,"context_line":"            if key in self.svc_qos_keys.keys():"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a74a57a_17cb941f","line":1687,"range":{"start_line":1687,"start_character":28,"end_line":1687,"end_character":38},"in_reply_to":"5a74a57a_8c86e9b7","updated":"2016-11-24 07:16:37.000000000","message":"Thank you, Xiaoqi, I have fixed it.","commit_id":"3c7dfe27383338eedcba79df99731b0d32d2507f"},{"author":{"_account_id":17045,"name":"xiaoqin","email":"xiaoqin.li@hotmail.com","username":"xiaoqin"},"change_message_id":"947966731d5747c5851107f2409daa9849597b4d","unresolved":false,"context_lines":[{"line_number":1694,"context_line":"                # chvdisk -unitmb -rate Bandwidth_limit_rate vdisk"},{"line_number":1695,"context_line":"                if key \u003d\u003d \u0027Bandwidth_limit\u0027:"},{"line_number":1696,"context_line":"                    if code_level \u003c (7, 7, 0, 0):"},{"line_number":1697,"context_line":"                        LOG.debug(\u0027Ignore Bandwidth_limit as storage code \u0027"},{"line_number":1698,"context_line":"                                  \u0027level is %(code_level)s, below the \u0027"},{"line_number":1699,"context_line":"                                  \u0027required 7.7.0.0.\u0027,"},{"line_number":1700,"context_line":"                                  {\u0027code_level\u0027: code_level})"},{"line_number":1701,"context_line":"                    else:"},{"line_number":1702,"context_line":"                        self.ssh.chvdisk(vdisk, [\u0027-unitmb\u0027, \u0027-\u0027 + param,"},{"line_number":1703,"context_line":"                                         str(value)])"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a74a57a_ec175d52","line":1700,"range":{"start_line":1697,"start_character":0,"end_line":1700,"end_character":61},"updated":"2016-11-23 10:48:55.000000000","message":"Exception should be raised here since Bandwidth_limit is only supported after version 7.7?","commit_id":"3c7dfe27383338eedcba79df99731b0d32d2507f"},{"author":{"_account_id":11186,"name":"yixuan zhang","email":"yixuan_z@hotmail.com","username":"yixuanzhang"},"change_message_id":"7fa6055accd3c98cb923428655ec9c0f46c1b3dd","unresolved":false,"context_lines":[{"line_number":1694,"context_line":"                # chvdisk -unitmb -rate Bandwidth_limit_rate vdisk"},{"line_number":1695,"context_line":"                if key \u003d\u003d \u0027Bandwidth_limit\u0027:"},{"line_number":1696,"context_line":"                    if code_level \u003c (7, 7, 0, 0):"},{"line_number":1697,"context_line":"                        LOG.debug(\u0027Ignore Bandwidth_limit as storage code \u0027"},{"line_number":1698,"context_line":"                                  \u0027level is %(code_level)s, below the \u0027"},{"line_number":1699,"context_line":"                                  \u0027required 7.7.0.0.\u0027,"},{"line_number":1700,"context_line":"                                  {\u0027code_level\u0027: code_level})"},{"line_number":1701,"context_line":"                    else:"},{"line_number":1702,"context_line":"                        self.ssh.chvdisk(vdisk, [\u0027-unitmb\u0027, \u0027-\u0027 + param,"},{"line_number":1703,"context_line":"                                         str(value)])"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a74a57a_77dcc8e4","line":1700,"range":{"start_line":1697,"start_character":0,"end_line":1700,"end_character":61},"in_reply_to":"5a74a57a_ec175d52","updated":"2016-11-24 07:16:37.000000000","message":"I have changed the debug to warning here, the bandwidth_limit will be ignore but not exception on the release before 7.7.0.0","commit_id":"3c7dfe27383338eedcba79df99731b0d32d2507f"},{"author":{"_account_id":17045,"name":"xiaoqin","email":"xiaoqin.li@hotmail.com","username":"xiaoqin"},"change_message_id":"947966731d5747c5851107f2409daa9849597b4d","unresolved":false,"context_lines":[{"line_number":1701,"context_line":"                    else:"},{"line_number":1702,"context_line":"                        self.ssh.chvdisk(vdisk, [\u0027-unitmb\u0027, \u0027-\u0027 + param,"},{"line_number":1703,"context_line":"                                         str(value)])"},{"line_number":1704,"context_line":"                elif key \u003d\u003d \u0027IOThrottling\u0027:"},{"line_number":1705,"context_line":"                    self.ssh.chvdisk(vdisk, [\u0027-\u0027 + param, str(value)])"},{"line_number":1706,"context_line":"                else:"},{"line_number":1707,"context_line":"                    LOG.warning(_LW(\u0027Invalid qos parameters\u0027))"},{"line_number":1708,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a74a57a_177ca671","line":1705,"range":{"start_line":1704,"start_character":0,"end_line":1705,"end_character":70},"updated":"2016-11-23 10:48:55.000000000","message":"Bandwidth_limit and IOThrottling can not be set at the same time?","commit_id":"3c7dfe27383338eedcba79df99731b0d32d2507f"},{"author":{"_account_id":11186,"name":"yixuan zhang","email":"yixuan_z@hotmail.com","username":"yixuanzhang"},"change_message_id":"7fa6055accd3c98cb923428655ec9c0f46c1b3dd","unresolved":false,"context_lines":[{"line_number":1701,"context_line":"                    else:"},{"line_number":1702,"context_line":"                        self.ssh.chvdisk(vdisk, [\u0027-unitmb\u0027, \u0027-\u0027 + param,"},{"line_number":1703,"context_line":"                                         str(value)])"},{"line_number":1704,"context_line":"                elif key \u003d\u003d \u0027IOThrottling\u0027:"},{"line_number":1705,"context_line":"                    self.ssh.chvdisk(vdisk, [\u0027-\u0027 + param, str(value)])"},{"line_number":1706,"context_line":"                else:"},{"line_number":1707,"context_line":"                    LOG.warning(_LW(\u0027Invalid qos parameters\u0027))"},{"line_number":1708,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a74a57a_1799d41f","line":1705,"range":{"start_line":1704,"start_character":0,"end_line":1705,"end_character":70},"in_reply_to":"5a74a57a_177ca671","updated":"2016-11-24 07:16:37.000000000","message":"There is a \u0027for\u0027 loop for every qos key check.  It will cover the case of Bandwidth_limit and IOThrottling set at the same time.","commit_id":"3c7dfe27383338eedcba79df99731b0d32d2507f"},{"author":{"_account_id":17045,"name":"xiaoqin","email":"xiaoqin.li@hotmail.com","username":"xiaoqin"},"change_message_id":"947966731d5747c5851107f2409daa9849597b4d","unresolved":false,"context_lines":[{"line_number":1727,"context_line":"            # the command is: chvdisk -unitmb -rate Bandwidth_limit_rate vdisk"},{"line_number":1728,"context_line":"            if key \u003d\u003d \u0027Bandwidth_limit\u0027:"},{"line_number":1729,"context_line":"                if code_level \u003c (7, 7, 0, 0):"},{"line_number":1730,"context_line":"                    LOG.debug(\u0027Ignore Bandwidth_limit as storage code \u0027"},{"line_number":1731,"context_line":"                              \u0027level is %(code_level)s, below the \u0027"},{"line_number":1732,"context_line":"                              \u0027required 7.7.0.0.\u0027,"},{"line_number":1733,"context_line":"                              {\u0027code_level\u0027: code_level})"},{"line_number":1734,"context_line":"                else:"},{"line_number":1735,"context_line":"                    self.ssh.chvdisk(vdisk, [\u0027-unitmb\u0027, \u0027-\u0027 + param, str(v)])"},{"line_number":1736,"context_line":"            elif key \u003d\u003d \u0027IOThrottling\u0027:"},{"line_number":1737,"context_line":"                self.ssh.chvdisk(vdisk, [\u0027-\u0027 + param, str(v)])"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a74a57a_77c15a80","line":1734,"range":{"start_line":1730,"start_character":0,"end_line":1734,"end_character":21},"updated":"2016-11-23 10:48:55.000000000","message":"Exception should be raised here since Bandwidth_limit is only supported after version 7.7?","commit_id":"3c7dfe27383338eedcba79df99731b0d32d2507f"},{"author":{"_account_id":17045,"name":"xiaoqin","email":"xiaoqin.li@hotmail.com","username":"xiaoqin"},"change_message_id":"947966731d5747c5851107f2409daa9849597b4d","unresolved":false,"context_lines":[{"line_number":1733,"context_line":"                              {\u0027code_level\u0027: code_level})"},{"line_number":1734,"context_line":"                else:"},{"line_number":1735,"context_line":"                    self.ssh.chvdisk(vdisk, [\u0027-unitmb\u0027, \u0027-\u0027 + param, str(v)])"},{"line_number":1736,"context_line":"            elif key \u003d\u003d \u0027IOThrottling\u0027:"},{"line_number":1737,"context_line":"                self.ssh.chvdisk(vdisk, [\u0027-\u0027 + param, str(v)])"},{"line_number":1738,"context_line":"            else:"},{"line_number":1739,"context_line":"                LOG.warning(_LW(\u0027Invalid qos parameters\u0027))"},{"line_number":1740,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a74a57a_b7bbf20d","line":1737,"range":{"start_line":1736,"start_character":0,"end_line":1737,"end_character":61},"updated":"2016-11-23 10:48:55.000000000","message":"The same as the above.","commit_id":"3c7dfe27383338eedcba79df99731b0d32d2507f"},{"author":{"_account_id":17045,"name":"xiaoqin","email":"xiaoqin.li@hotmail.com","username":"xiaoqin"},"change_message_id":"947966731d5747c5851107f2409daa9849597b4d","unresolved":false,"context_lines":[{"line_number":1745,"context_line":"                param \u003d self.svc_qos_keys[key][\u0027param\u0027]"},{"line_number":1746,"context_line":"                # Take the default value."},{"line_number":1747,"context_line":"                value \u003d self.svc_qos_keys[key][\u0027default\u0027]"},{"line_number":1748,"context_line":"                # If the Bandwidth_limit was disabled,"},{"line_number":1749,"context_line":"                # the cli command is:"},{"line_number":1750,"context_line":"                # chvdisk -unitmb -rate Bandwidth_limit_rate vdisk"},{"line_number":1751,"context_line":"                if key \u003d\u003d \u0027Bandwidth_limit\u0027:"},{"line_number":1752,"context_line":"                    self.ssh.chvdisk(vdisk, [\u0027-unitmb\u0027, \u0027-\u0027 + param,"},{"line_number":1753,"context_line":"                                             value])"},{"line_number":1754,"context_line":"                elif key \u003d\u003d \u0027IOThrottling\u0027:"},{"line_number":1755,"context_line":"                    self.ssh.chvdisk(vdisk, [\u0027-\u0027 + param, value])"},{"line_number":1756,"context_line":"                else:"},{"line_number":1757,"context_line":"                    LOG.warning(_LW(\u0027Invalid qos parameters\u0027))"},{"line_number":1758,"context_line":""},{"line_number":1759,"context_line":"    def change_vdisk_options(self, vdisk, changes, opts, state):"},{"line_number":1760,"context_line":"        if \u0027warning\u0027 in opts:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a74a57a_57f9bec7","line":1757,"range":{"start_line":1748,"start_character":0,"end_line":1757,"end_character":62},"updated":"2016-11-23 10:48:55.000000000","message":"The same as the above. Bandwidth_limit and IOThrottling can not be removed at the same time?","commit_id":"3c7dfe27383338eedcba79df99731b0d32d2507f"},{"author":{"_account_id":10213,"name":"Alon Marx","email":"alonma@il.ibm.com","username":"alonmarx"},"change_message_id":"fbf0aa6526faf0795b04b41d2f3649ada97eddad","unresolved":false,"context_lines":[{"line_number":561,"context_line":"    # \u0027default\u0027: to indicate the value, when the parameter is disabled."},{"line_number":562,"context_line":"    # \u0027param\u0027: to indicate the corresponding parameter in the command."},{"line_number":563,"context_line":"    # \u0027type\u0027: to indicate the type of this value."},{"line_number":564,"context_line":"    # Add new Qos parameter Bandwidth_limit from storwize release 7.7"},{"line_number":565,"context_line":"    # The unit for Bandwidth_limit is MB."},{"line_number":566,"context_line":"    WAIT_TIME \u003d 5"},{"line_number":567,"context_line":"    svc_qos_keys \u003d {\u0027IOThrottling\u0027: {\u0027default\u0027: \u00270\u0027,"},{"line_number":568,"context_line":"                                     \u0027param\u0027: \u0027rate\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a74a57a_12be42d4","line":565,"range":{"start_line":564,"start_character":0,"end_line":565,"end_character":41},"updated":"2016-11-24 07:38:57.000000000","message":"The additional lines make a good comment, but it is not directly related to the previous lines. It needs some separation to be clear.","commit_id":"b3a0d9762bca3f59d7b8824e222c56806235f74e"},{"author":{"_account_id":11186,"name":"yixuan zhang","email":"yixuan_z@hotmail.com","username":"yixuanzhang"},"change_message_id":"5b57ae79d2838b5149a792acd28fe30406ce671a","unresolved":false,"context_lines":[{"line_number":561,"context_line":"    # \u0027default\u0027: to indicate the value, when the parameter is disabled."},{"line_number":562,"context_line":"    # \u0027param\u0027: to indicate the corresponding parameter in the command."},{"line_number":563,"context_line":"    # \u0027type\u0027: to indicate the type of this value."},{"line_number":564,"context_line":"    # Add new Qos parameter Bandwidth_limit from storwize release 7.7"},{"line_number":565,"context_line":"    # The unit for Bandwidth_limit is MB."},{"line_number":566,"context_line":"    WAIT_TIME \u003d 5"},{"line_number":567,"context_line":"    svc_qos_keys \u003d {\u0027IOThrottling\u0027: {\u0027default\u0027: \u00270\u0027,"},{"line_number":568,"context_line":"                                     \u0027param\u0027: \u0027rate\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a74a57a_d5a8d38e","line":565,"range":{"start_line":564,"start_character":0,"end_line":565,"end_character":41},"in_reply_to":"5a74a57a_12be42d4","updated":"2016-11-28 06:40:07.000000000","message":"Thank you, Alon, I have fixed it.","commit_id":"b3a0d9762bca3f59d7b8824e222c56806235f74e"},{"author":{"_account_id":10213,"name":"Alon Marx","email":"alonma@il.ibm.com","username":"alonmarx"},"change_message_id":"fbf0aa6526faf0795b04b41d2f3649ada97eddad","unresolved":false,"context_lines":[{"line_number":1694,"context_line":"                # the cli command is:"},{"line_number":1695,"context_line":"                # chvdisk -unitmb -rate Bandwidth_limit_rate vdisk"},{"line_number":1696,"context_line":"                if key \u003d\u003d \u0027Bandwidth_limit\u0027:"},{"line_number":1697,"context_line":"                    if code_level \u003c (7, 7, 0, 0):"},{"line_number":1698,"context_line":"                        LOG.warning(_LW(\u0027Ignore Bandwidth_limit as storage \u0027"},{"line_number":1699,"context_line":"                                        \u0027code_level is %(code_level)s, below \u0027"},{"line_number":1700,"context_line":"                                        \u0027the required 7.7.0.0.\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a74a57a_32425e11","line":1697,"range":{"start_line":1697,"start_character":20,"end_line":1697,"end_character":48},"updated":"2016-11-24 07:38:57.000000000","message":"Wouldn\u0027t it be better to raise an exception in this case? The warning will not be visible to the user.","commit_id":"b3a0d9762bca3f59d7b8824e222c56806235f74e"},{"author":{"_account_id":11186,"name":"yixuan zhang","email":"yixuan_z@hotmail.com","username":"yixuanzhang"},"change_message_id":"5b57ae79d2838b5149a792acd28fe30406ce671a","unresolved":false,"context_lines":[{"line_number":1694,"context_line":"                # the cli command is:"},{"line_number":1695,"context_line":"                # chvdisk -unitmb -rate Bandwidth_limit_rate vdisk"},{"line_number":1696,"context_line":"                if key \u003d\u003d \u0027Bandwidth_limit\u0027:"},{"line_number":1697,"context_line":"                    if code_level \u003c (7, 7, 0, 0):"},{"line_number":1698,"context_line":"                        LOG.warning(_LW(\u0027Ignore Bandwidth_limit as storage \u0027"},{"line_number":1699,"context_line":"                                        \u0027code_level is %(code_level)s, below \u0027"},{"line_number":1700,"context_line":"                                        \u0027the required 7.7.0.0.\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a74a57a_9589fb28","line":1697,"range":{"start_line":1697,"start_character":20,"end_line":1697,"end_character":48},"in_reply_to":"5a74a57a_32425e11","updated":"2016-11-28 06:40:07.000000000","message":"As discussed with Xiaoqin, She also think it is better to raise an exception here. I have chnaged the warning log to an exception","commit_id":"b3a0d9762bca3f59d7b8824e222c56806235f74e"},{"author":{"_account_id":10213,"name":"Alon Marx","email":"alonma@il.ibm.com","username":"alonmarx"},"change_message_id":"fbf0aa6526faf0795b04b41d2f3649ada97eddad","unresolved":false,"context_lines":[{"line_number":1727,"context_line":"            # If the Bandwidth_limit was changed,"},{"line_number":1728,"context_line":"            # the command is: chvdisk -unitmb -rate Bandwidth_limit_rate vdisk"},{"line_number":1729,"context_line":"            if key \u003d\u003d \u0027Bandwidth_limit\u0027:"},{"line_number":1730,"context_line":"                if code_level \u003c (7, 7, 0, 0):"},{"line_number":1731,"context_line":"                    LOG.warning(_LW(\u0027Ignore Bandwidth_limit as storage \u0027"},{"line_number":1732,"context_line":"                                    \u0027code_level is %(code_level)s, below the \u0027"},{"line_number":1733,"context_line":"                                    \u0027required 7.7.0.0.\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a74a57a_724cd642","line":1730,"range":{"start_line":1730,"start_character":16,"end_line":1730,"end_character":45},"updated":"2016-11-24 07:38:57.000000000","message":"Wouldn\u0027t it be better to raise an exception in this case? The warning will not be visible to the user.","commit_id":"b3a0d9762bca3f59d7b8824e222c56806235f74e"},{"author":{"_account_id":11186,"name":"yixuan zhang","email":"yixuan_z@hotmail.com","username":"yixuanzhang"},"change_message_id":"5b57ae79d2838b5149a792acd28fe30406ce671a","unresolved":false,"context_lines":[{"line_number":1727,"context_line":"            # If the Bandwidth_limit was changed,"},{"line_number":1728,"context_line":"            # the command is: chvdisk -unitmb -rate Bandwidth_limit_rate vdisk"},{"line_number":1729,"context_line":"            if key \u003d\u003d \u0027Bandwidth_limit\u0027:"},{"line_number":1730,"context_line":"                if code_level \u003c (7, 7, 0, 0):"},{"line_number":1731,"context_line":"                    LOG.warning(_LW(\u0027Ignore Bandwidth_limit as storage \u0027"},{"line_number":1732,"context_line":"                                    \u0027code_level is %(code_level)s, below the \u0027"},{"line_number":1733,"context_line":"                                    \u0027required 7.7.0.0.\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a74a57a_d57ff314","line":1730,"range":{"start_line":1730,"start_character":16,"end_line":1730,"end_character":45},"in_reply_to":"5a74a57a_724cd642","updated":"2016-11-28 06:40:07.000000000","message":"Fixed it","commit_id":"b3a0d9762bca3f59d7b8824e222c56806235f74e"},{"author":{"_account_id":10213,"name":"Alon Marx","email":"alonma@il.ibm.com","username":"alonmarx"},"change_message_id":"fbf0aa6526faf0795b04b41d2f3649ada97eddad","unresolved":false,"context_lines":[{"line_number":1749,"context_line":"                # If the Bandwidth_limit was disabled,"},{"line_number":1750,"context_line":"                # the cli command is:"},{"line_number":1751,"context_line":"                # chvdisk -unitmb -rate Bandwidth_limit_rate vdisk"},{"line_number":1752,"context_line":"                if key \u003d\u003d \u0027Bandwidth_limit\u0027:"},{"line_number":1753,"context_line":"                    self.ssh.chvdisk(vdisk, [\u0027-unitmb\u0027, \u0027-\u0027 + param,"},{"line_number":1754,"context_line":"                                             value])"},{"line_number":1755,"context_line":"                elif key \u003d\u003d \u0027IOThrottling\u0027:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a74a57a_32597eff","line":1752,"range":{"start_line":1752,"start_character":16,"end_line":1752,"end_character":44},"updated":"2016-11-24 07:38:57.000000000","message":"Don\u0027t you need here as well to check the code level?","commit_id":"b3a0d9762bca3f59d7b8824e222c56806235f74e"},{"author":{"_account_id":11186,"name":"yixuan zhang","email":"yixuan_z@hotmail.com","username":"yixuanzhang"},"change_message_id":"5b57ae79d2838b5149a792acd28fe30406ce671a","unresolved":false,"context_lines":[{"line_number":1749,"context_line":"                # If the Bandwidth_limit was disabled,"},{"line_number":1750,"context_line":"                # the cli command is:"},{"line_number":1751,"context_line":"                # chvdisk -unitmb -rate Bandwidth_limit_rate vdisk"},{"line_number":1752,"context_line":"                if key \u003d\u003d \u0027Bandwidth_limit\u0027:"},{"line_number":1753,"context_line":"                    self.ssh.chvdisk(vdisk, [\u0027-unitmb\u0027, \u0027-\u0027 + param,"},{"line_number":1754,"context_line":"                                             value])"},{"line_number":1755,"context_line":"                elif key \u003d\u003d \u0027IOThrottling\u0027:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a74a57a_5574c334","line":1752,"range":{"start_line":1752,"start_character":16,"end_line":1752,"end_character":44},"in_reply_to":"5a74a57a_32597eff","updated":"2016-11-28 06:40:07.000000000","message":"Fixed it.","commit_id":"b3a0d9762bca3f59d7b8824e222c56806235f74e"}]}