)]}'
{"cinder/volume/drivers/emc/emc_vmax_common.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"ed18b8881f725c348e0546fa6a993fc61ef0e2e3","unresolved":false,"context_lines":[{"line_number":1396,"context_line":"                                    \u0027targetWorkload\u0027: targetWorkload})"},{"line_number":1397,"context_line":"            if targetCombination in emcFastSetting:"},{"line_number":1398,"context_line":"                # Check if migration is from compression to non compression"},{"line_number":1399,"context_line":"                # of vice versa"},{"line_number":1400,"context_line":"                if not doChangeCompression:"},{"line_number":1401,"context_line":"                    LOG.error(_LE("},{"line_number":1402,"context_line":"                        \"No action required. Volume: %(volumeName)s is \""}],"source_content_type":"text/x-python","patch_set":21,"id":"ba5201f7_b485565a","line":1399,"updated":"2017-01-03 21:00:50.000000000","message":"s/of/or","commit_id":"2191397e5ce3f4f241ed333bc9ad644d13f60995"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"763bd7cf42ecf309e1659f0b01bc223954297ee3","unresolved":false,"context_lines":[{"line_number":1396,"context_line":"                                    \u0027targetWorkload\u0027: targetWorkload})"},{"line_number":1397,"context_line":"            if targetCombination in emcFastSetting:"},{"line_number":1398,"context_line":"                # Check if migration is from compression to non compression"},{"line_number":1399,"context_line":"                # of vice versa"},{"line_number":1400,"context_line":"                if not doChangeCompression:"},{"line_number":1401,"context_line":"                    LOG.error(_LE("},{"line_number":1402,"context_line":"                        \"No action required. Volume: %(volumeName)s is \""}],"source_content_type":"text/x-python","patch_set":30,"id":"7a3c09a3_38a3e9b3","line":1399,"range":{"start_line":1399,"start_character":18,"end_line":1399,"end_character":20},"updated":"2017-01-16 21:25:14.000000000","message":"nit: s/of/or","commit_id":"6ebe83ad5ec6c04749176991d81b162018fd053d"}],"cinder/volume/drivers/emc/emc_vmax_utils.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"ed18b8881f725c348e0546fa6a993fc61ef0e2e3","unresolved":false,"context_lines":[{"line_number":2840,"context_line":"        return foundinitiatorGroupInstanceName"},{"line_number":2841,"context_line":""},{"line_number":2842,"context_line":"    def is_all_flash(self, conn, array):"},{"line_number":2843,"context_line":"        \"\"\"Check if array is all flash"},{"line_number":2844,"context_line":""},{"line_number":2845,"context_line":"        :param conn: connection the ecom server"},{"line_number":2846,"context_line":"        :param array:"}],"source_content_type":"text/x-python","patch_set":21,"id":"ba5201f7_340fa62f","line":2843,"updated":"2017-01-03 21:00:50.000000000","message":"Ending period","commit_id":"2191397e5ce3f4f241ed333bc9ad644d13f60995"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"ed18b8881f725c348e0546fa6a993fc61ef0e2e3","unresolved":false,"context_lines":[{"line_number":2853,"context_line":"            return False"},{"line_number":2854,"context_line":""},{"line_number":2855,"context_line":"    def _is_all_flash(self, conn, array):"},{"line_number":2856,"context_line":"        \"\"\"Check if array is all flash"},{"line_number":2857,"context_line":""},{"line_number":2858,"context_line":"        :param conn: connection the ecom server"},{"line_number":2859,"context_line":"        :param array:"}],"source_content_type":"text/x-python","patch_set":21,"id":"ba5201f7_541eea63","line":2856,"updated":"2017-01-03 21:00:50.000000000","message":"period","commit_id":"2191397e5ce3f4f241ed333bc9ad644d13f60995"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"ed18b8881f725c348e0546fa6a993fc61ef0e2e3","unresolved":false,"context_lines":[{"line_number":2877,"context_line":"        return is_all_flash"},{"line_number":2878,"context_line":""},{"line_number":2879,"context_line":"    def is_compression_disabled(self, extraSpecs):"},{"line_number":2880,"context_line":"        \"\"\"Check is compression is to be disabled"},{"line_number":2881,"context_line":""},{"line_number":2882,"context_line":"        :param extraSpecs: extra specifications"},{"line_number":2883,"context_line":"        :returns: dict -- a dictionary with masking view information"}],"source_content_type":"text/x-python","patch_set":21,"id":"ba5201f7_74192e79","line":2880,"updated":"2017-01-03 21:00:50.000000000","message":"period","commit_id":"2191397e5ce3f4f241ed333bc9ad644d13f60995"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"ed18b8881f725c348e0546fa6a993fc61ef0e2e3","unresolved":false,"context_lines":[{"line_number":2889,"context_line":"        return doDisableCompression"},{"line_number":2890,"context_line":""},{"line_number":2891,"context_line":"    def change_compression_type(self, isSourceCompressionDisabled, newType):"},{"line_number":2892,"context_line":"        \"\"\"Check if volume type have different compression types"},{"line_number":2893,"context_line":""},{"line_number":2894,"context_line":"        :param isCompressionDisabled: from source"},{"line_number":2895,"context_line":"        :param newType: from target"}],"source_content_type":"text/x-python","patch_set":21,"id":"ba5201f7_f4235ea5","line":2892,"updated":"2017-01-03 21:00:50.000000000","message":"period","commit_id":"2191397e5ce3f4f241ed333bc9ad644d13f60995"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"ed18b8881f725c348e0546fa6a993fc61ef0e2e3","unresolved":false,"context_lines":[{"line_number":2903,"context_line":"            return True"},{"line_number":2904,"context_line":""},{"line_number":2905,"context_line":"    def str2bool(self, value):"},{"line_number":2906,"context_line":"        \"\"\"Check if value is yes or true"},{"line_number":2907,"context_line":""},{"line_number":2908,"context_line":"        :param value - string value"},{"line_number":2909,"context_line":"        :returns: boolean"}],"source_content_type":"text/x-python","patch_set":21,"id":"ba5201f7_74476e4b","line":2906,"updated":"2017-01-03 21:00:50.000000000","message":"period","commit_id":"2191397e5ce3f4f241ed333bc9ad644d13f60995"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"9cfcf25c35b7ddbff3eafd6f6ee3bc398487acbf","unresolved":false,"context_lines":[{"line_number":2840,"context_line":"        return foundinitiatorGroupInstanceName"},{"line_number":2841,"context_line":""},{"line_number":2842,"context_line":"    def is_all_flash(self, conn, array):"},{"line_number":2843,"context_line":"        \"\"\"Check if array is all flash"},{"line_number":2844,"context_line":""},{"line_number":2845,"context_line":"        :param conn: connection the ecom server"},{"line_number":2846,"context_line":"        :param array:"}],"source_content_type":"text/x-python","patch_set":27,"id":"ba5201f7_e399587a","line":2843,"updated":"2017-01-07 04:43:28.000000000","message":"nit: add missing period if you need to upload another patch set.  Same comment for other new functions in this file.","commit_id":"3aa254db11d66514ed69e079fdccb3ced75ee147"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"763bd7cf42ecf309e1659f0b01bc223954297ee3","unresolved":false,"context_lines":[{"line_number":2877,"context_line":"        return is_all_flash"},{"line_number":2878,"context_line":""},{"line_number":2879,"context_line":"    def is_compression_disabled(self, extraSpecs):"},{"line_number":2880,"context_line":"        \"\"\"Check is compression is to be disabled."},{"line_number":2881,"context_line":""},{"line_number":2882,"context_line":"        :param extraSpecs: extra specifications"},{"line_number":2883,"context_line":"        :returns: dict -- a dictionary with masking view information"}],"source_content_type":"text/x-python","patch_set":30,"id":"7a3c09a3_f8188120","line":2880,"range":{"start_line":2880,"start_character":17,"end_line":2880,"end_character":19},"updated":"2017-01-16 21:25:14.000000000","message":"nit: s/is/if","commit_id":"6ebe83ad5ec6c04749176991d81b162018fd053d"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"00152b3c15cf40a74ed58b9b896d4f5bd1db8322","unresolved":false,"context_lines":[{"line_number":2896,"context_line":"        \"\"\""},{"line_number":2897,"context_line":"        extraSpecs \u003d newType[\u0027extra_specs\u0027]"},{"line_number":2898,"context_line":"        isTargetCompressionDisabled \u003d self.is_compression_disabled(extraSpecs)"},{"line_number":2899,"context_line":"        if isTargetCompressionDisabled \u003d\u003d isSourceCompressionDisabled:"},{"line_number":2900,"context_line":"            return False"},{"line_number":2901,"context_line":"        else:"},{"line_number":2902,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":33,"id":"5a3905b3_27f1cf01","line":2899,"range":{"start_line":2899,"start_character":11,"end_line":2899,"end_character":38},"updated":"2017-01-23 15:44:20.000000000","message":"nit: could be simplified to:\nreturn isTargetCompressionDisabled \u003d\u003d isSourceCompressionDisabled","commit_id":"a9a3eddaf26d4705c06f25152ccb0a6a427eaf7b"}],"releasenotes/notes/vmax-compression-support-1dfe463328b56d7f.yaml":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"49f3f6053750b9c3a5415120139644e218db3a50","unresolved":false,"context_lines":[{"line_number":1,"context_line":"features:"},{"line_number":2,"context_line":"   VMAX driver - Support for compression on VMAX All Flash."}],"source_content_type":"text/x-yaml","patch_set":14,"id":"1a6eadb0_d6f059cc","line":2,"updated":"2016-12-19 14:51:18.000000000","message":"This release note is wrong.  Please add \"---\" on the first line and move \"-\" to the beginning of the note.\n\nhttps://review.openstack.org/#/c/412445/2/releasenotes/notes/vmax-clone-cg-09fce492931c957f.yaml","commit_id":"982c2f9fa136e2da5bb43173dcffeacae08a8434"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"b82ceffc1688387e2315743338d79799897d4549","unresolved":false,"context_lines":[{"line_number":1,"context_line":"features:"},{"line_number":2,"context_line":"   VMAX driver - Support for compression on VMAX All Flash."}],"source_content_type":"text/x-yaml","patch_set":14,"id":"1a6eadb0_49902796","line":2,"in_reply_to":"1a6eadb0_d6f059cc","updated":"2016-12-19 16:37:13.000000000","message":"Will do.  Thank you","commit_id":"982c2f9fa136e2da5bb43173dcffeacae08a8434"}]}