)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"099aefca74fd8ffc19a8e730665e6032c1e051e7","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Possible values reported for replication are:"},{"line_number":14,"context_line":" - No"},{"line_number":15,"context_line":" - Version 2.1"},{"line_number":16,"context_line":" - v2.1 with Active/Active support"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I8edd43e88d9b2d145855b5bad9f4995dda46449b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5a74a57a_5ffbba78","line":15,"range":{"start_line":15,"start_character":3,"end_line":15,"end_character":14},"updated":"2016-11-29 11:02:20.000000000","message":"This gives the impression that some drivers support only a previous version of replication (v2.0, v1.0). Is there? If no, I think we should have \u0027yes\u0027 and may be another field, \u0027replication_version\u0027 for future versions of replication.","commit_id":"2285f7355e4791d25d0a94fa0c9cb9899da452ca"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"3731344d3f48496beadd52b19ddf29da67fe12c2","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Possible values reported for replication are:"},{"line_number":14,"context_line":" - No"},{"line_number":15,"context_line":" - Version 2.1"},{"line_number":16,"context_line":" - v2.1 with Active/Active support"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I8edd43e88d9b2d145855b5bad9f4995dda46449b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5a74a57a_45984878","line":15,"range":{"start_line":15,"start_character":3,"end_line":15,"end_character":14},"in_reply_to":"5a74a57a_02080627","updated":"2016-11-29 11:56:21.000000000","message":"Finally going with:\n\n- No\n- Yes (only in Active/Passive configurations)\n- Yes","commit_id":"2285f7355e4791d25d0a94fa0c9cb9899da452ca"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"298868938337ee6ee3284fbc1dec72c6b63634be","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Possible values reported for replication are:"},{"line_number":14,"context_line":" - No"},{"line_number":15,"context_line":" - Version 2.1"},{"line_number":16,"context_line":" - v2.1 with Active/Active support"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I8edd43e88d9b2d145855b5bad9f4995dda46449b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5a74a57a_02080627","line":15,"range":{"start_line":15,"start_character":3,"end_line":15,"end_character":14},"in_reply_to":"5a74a57a_5ffbba78","updated":"2016-11-29 11:28:57.000000000","message":"Good point, I\u0027ll change it to:\n\n- No\n- Yes (Active/Active not supported)\n- Yes (Active/Active supported)","commit_id":"2285f7355e4791d25d0a94fa0c9cb9899da452ca"}],"cinder/interface/util.py":[{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"099aefca74fd8ffc19a8e730665e6032c1e051e7","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    @staticmethod"},{"line_number":64,"context_line":"    def _get_replication(cls):"},{"line_number":65,"context_line":"        if not hasattr(cls, \u0027supports_replication_feature\u0027):"},{"line_number":66,"context_line":"            return None"},{"line_number":67,"context_line":"        if cls.supports_replication_feature(\u0027a/a\u0027):"},{"line_number":68,"context_line":"            return \u0027v2.1 with Active/Active support\u0027"},{"line_number":69,"context_line":"        if cls.supports_replication_feature(\u0027v2.1\u0027):"},{"line_number":70,"context_line":"            return \u0027Version 2.1\u0027"},{"line_number":71,"context_line":"        return \u0027No\u0027"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def __init__(self, cls):"},{"line_number":74,"context_line":"        self.cls \u003d cls"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a74a57a_bf484eb4","line":71,"range":{"start_line":65,"start_character":8,"end_line":71,"end_character":19},"updated":"2016-11-29 11:02:20.000000000","message":"Do we have those strings documented in the dev ref?","commit_id":"2285f7355e4791d25d0a94fa0c9cb9899da452ca"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"298868938337ee6ee3284fbc1dec72c6b63634be","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    @staticmethod"},{"line_number":64,"context_line":"    def _get_replication(cls):"},{"line_number":65,"context_line":"        if not hasattr(cls, \u0027supports_replication_feature\u0027):"},{"line_number":66,"context_line":"            return None"},{"line_number":67,"context_line":"        if cls.supports_replication_feature(\u0027a/a\u0027):"},{"line_number":68,"context_line":"            return \u0027v2.1 with Active/Active support\u0027"},{"line_number":69,"context_line":"        if cls.supports_replication_feature(\u0027v2.1\u0027):"},{"line_number":70,"context_line":"            return \u0027Version 2.1\u0027"},{"line_number":71,"context_line":"        return \u0027No\u0027"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def __init__(self, cls):"},{"line_number":74,"context_line":"        self.cls \u003d cls"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a74a57a_02a48605","line":71,"range":{"start_line":65,"start_character":8,"end_line":71,"end_character":19},"in_reply_to":"5a74a57a_bf484eb4","updated":"2016-11-29 11:28:57.000000000","message":"I don\u0027t think that needs to be documented in the updated dev_ref [1] since those are just parameter that the `supports_replication_feature` method accepts [2].\n\n[1]: https://review.openstack.org/400807\n[2]: https://review.openstack.org/#/c/381835/21/cinder/volume/driver.py@1735","commit_id":"2285f7355e4791d25d0a94fa0c9cb9899da452ca"}]}
