)]}'
{"cinder/volume/manager.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"1bf67b93feac9a9c7e929075fd14bd81d175e6e1","unresolved":false,"context_lines":[{"line_number":3502,"context_line":"                    # NOTE(xyang): snapshots is a list of snapshot objects."},{"line_number":3503,"context_line":"                    # snapshots_model_update should be a list of dicts."},{"line_number":3504,"context_line":"                    snap_id \u003d snap_model.pop(\u0027id\u0027)"},{"line_number":3505,"context_line":"                    snap_obj \u003d objects.Snapshot.get_by_id(context, snap_id)"},{"line_number":3506,"context_line":"                    snap_obj.update(snap_model)"},{"line_number":3507,"context_line":"                    snap_obj.save()"},{"line_number":3508,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_856e60c7","line":3505,"updated":"2016-12-20 19:55:16.000000000","message":"Instead  of retrieving the snapshot object from db again, can you find the snapshot object by id from \"snapshots\" that is already retrieved on line 3475?","commit_id":"0497bf8eadc6f71147914718e5c817b25205f5f4"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"ecb019b8328785824c289ab080e997a4175c05b4","unresolved":false,"context_lines":[{"line_number":3502,"context_line":"                    # NOTE(xyang): snapshots is a list of snapshot objects."},{"line_number":3503,"context_line":"                    # snapshots_model_update should be a list of dicts."},{"line_number":3504,"context_line":"                    snap_id \u003d snap_model.pop(\u0027id\u0027)"},{"line_number":3505,"context_line":"                    snap_obj \u003d objects.Snapshot.get_by_id(context, snap_id)"},{"line_number":3506,"context_line":"                    snap_obj.update(snap_model)"},{"line_number":3507,"context_line":"                    snap_obj.save()"},{"line_number":3508,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_f1b2174b","line":3505,"in_reply_to":"1a6eadb0_856e60c7","updated":"2017-01-31 09:42:01.000000000","message":"-1: I agree with Xing, that\u0027s an easy enough optimization and it will halve our DB requests.","commit_id":"0497bf8eadc6f71147914718e5c817b25205f5f4"}]}