)]}'
{"cinder/objects/snapshot.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"bbeb585ba4e3f7727640425e9b9b85cc473140b2","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        return changes"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def obj_make_compatible(self, primitive, target_version):"},{"line_number":116,"context_line":"        \"\"\"Make an object representation compatible with a target version.\"\"\""},{"line_number":117,"context_line":"        super(Snapshot, self).obj_make_compatible(primitive, target_version)"},{"line_number":118,"context_line":"        target_version \u003d versionutils.convert_version_to_tuple(target_version)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    @classmethod"},{"line_number":121,"context_line":"    def _from_db_object(cls, context, snapshot, db_snapshot,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_bc91de9b","line":118,"range":{"start_line":115,"start_character":0,"end_line":118,"end_character":78},"updated":"2016-12-02 10:42:44.000000000","message":"You need to provide a backward compatibility routine here. Just set the status to deleting so older c-vols will not explode when receiving that object during unmanage. See [1] for example.\n\n[1] https://github.com/openstack/cinder/blob/0a32edb94c7bb0d2fddbf00c40e8d545778565af/cinder/objects/volume.py#L238-L242","commit_id":"1bf8e25aa6475e616d0acb6a1e4f4564b75ed743"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"bee115c85c401798679e06b02f1bc7f45927f425","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        return changes"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def obj_make_compatible(self, primitive, target_version):"},{"line_number":116,"context_line":"        \"\"\"Make an object representation compatible with a target version.\"\"\""},{"line_number":117,"context_line":"        super(Snapshot, self).obj_make_compatible(primitive, target_version)"},{"line_number":118,"context_line":"        target_version \u003d versionutils.convert_version_to_tuple(target_version)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    @classmethod"},{"line_number":121,"context_line":"    def _from_db_object(cls, context, snapshot, db_snapshot,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_25b090dd","line":118,"range":{"start_line":115,"start_character":0,"end_line":118,"end_character":78},"in_reply_to":"3a71b18c_bc91de9b","updated":"2016-12-12 21:11:22.000000000","message":"Done","commit_id":"1bf8e25aa6475e616d0acb6a1e4f4564b75ed743"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"fb7f53f17574c4a54b14a156419df09b16e335ce","unresolved":false,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        if target_version \u003c (1, 3):"},{"line_number":121,"context_line":"            if primitive.get(\u0027status\u0027) \u003d\u003d \u0027unmanaging\u0027:"},{"line_number":122,"context_line":"                primitive[\u0027status\u0027] \u003d \u0027deleting\u0027"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    @classmethod"},{"line_number":125,"context_line":"    def _from_db_object(cls, context, snapshot, db_snapshot,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_857404d0","line":122,"updated":"2016-12-12 21:18:04.000000000","message":"Should probably use SnapshotStatus fields here.","commit_id":"4596854f14b9e213f998139ab4a2ad3695b1ab20"}]}