)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"6da9e261ae58ee776c9e8d9a4680e1c33e7b34d5","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Current url scheme doesn\u0027t allow to skip admin_tenant_id"},{"line_number":10,"context_line":"or tenant_id params. This change marks them as required"},{"line_number":11,"context_line":"in api-ref."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Partial-Bug: #1415214"},{"line_number":14,"context_line":"DocImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1a1ced50_4def5fe8","line":11,"updated":"2017-03-17 20:47:08.000000000","message":"Can you also mention the changes you made WRT quotas? There are more changes in this patch than just making required: true. Thanks!","commit_id":"45e8b2d89e4bac1c13be5693244cc0253d08fd18"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"1fd4022c37d0f9c3e8dca6ddbb3809fb6a1f5096","unresolved":false,"context_lines":[{"line_number":12,"context_line":"was changed on correct also."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Partial-Bug: #1415214"},{"line_number":15,"context_line":"DocImpact"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I0c528d1c49346477b608a12f8f35ee6d47404bd3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"ff0f0b1f_943ef288","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":9},"updated":"2017-05-23 14:24:30.000000000","message":"nit: It\u0027s s api-ref related change. I can\u0027t see any doc impact here.","commit_id":"99b7ef8aaaf384c493e7ad07351101ff28c4361e"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"1280b628b461b470801d5179e9739c1e12f85941","unresolved":false,"context_lines":[{"line_number":12,"context_line":"was changed on correct also."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Partial-Bug: #1415214"},{"line_number":15,"context_line":"DocImpact"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I0c528d1c49346477b608a12f8f35ee6d47404bd3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"ff0f0b1f_34204648","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":9},"in_reply_to":"ff0f0b1f_943ef288","updated":"2017-05-23 14:26:58.000000000","message":"+1","commit_id":"99b7ef8aaaf384c493e7ad07351101ff28c4361e"}],"api-ref/source/v1/os-quota-sets-v1.inc":[{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"08d3a494633b686f0d394156354c5e46403cb58e","unresolved":false,"context_lines":[{"line_number":11,"context_line":"Show default quotas"},{"line_number":12,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":".. rest_method::  GET /v1/{admin_tenant_id}/os-quota-sets/defaults"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Shows default quotas for a tenant."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":1,"id":"3a71b18c_ba609bd0","line":14,"updated":"2016-12-05 22:21:13.000000000","message":"Should be:\nGET /v1/{admin_tenant_id|/os-quota-sets/{tenant_id}/defaults","commit_id":"c34373f07711c379970d8bfa823ce8bca7f2b8dc"}],"api-ref/source/v2/quota-sets.inc":[{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"08d3a494633b686f0d394156354c5e46403cb58e","unresolved":false,"context_lines":[{"line_number":159,"context_line":"Get default quotas"},{"line_number":160,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":".. rest_method::  GET /v2/{admin_tenant_id}/os-quota-sets/defaults"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"Gets default quotas for a tenant."},{"line_number":165,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":1,"id":"3a71b18c_5af6a7f9","line":162,"updated":"2016-12-05 22:21:13.000000000","message":"should be:\nGET /v2/{admin_tenant_id}/os-quota-sets/{tenant_id}/defaults","commit_id":"c34373f07711c379970d8bfa823ce8bca7f2b8dc"}],"api-ref/source/v3/parameters.yaml":[{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"1bb319e909c61978c356e344ee1d4d9fe64df23d","unresolved":false,"context_lines":[{"line_number":11,"context_line":"  description: |"},{"line_number":12,"context_line":"    The UUID of the administrative project."},{"line_number":13,"context_line":"  in: path"},{"line_number":14,"context_line":"  required: false"},{"line_number":15,"context_line":"  type: string"},{"line_number":16,"context_line":"all_tenants:"},{"line_number":17,"context_line":"  description: |"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ba2be162_eb03a60d","line":14,"updated":"2017-03-01 09:15:22.000000000","message":"I guess the change at L20 shoud be here.","commit_id":"a84d24fcd26ec0b3d7e3a054bd6c6d90ae715f0e"},{"author":{"_account_id":21813,"name":"Andrey Volkov","email":"m@amadev.ru","username":"avolkov"},"change_message_id":"e88a30daa781e935de8fc77ce5420eedea546ac5","unresolved":false,"context_lines":[{"line_number":11,"context_line":"  description: |"},{"line_number":12,"context_line":"    The UUID of the administrative project."},{"line_number":13,"context_line":"  in: path"},{"line_number":14,"context_line":"  required: false"},{"line_number":15,"context_line":"  type: string"},{"line_number":16,"context_line":"all_tenants:"},{"line_number":17,"context_line":"  description: |"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ba2be162_0024450b","line":14,"in_reply_to":"ba2be162_eb03a60d","updated":"2017-03-01 15:03:36.000000000","message":"You are right, thank you.","commit_id":"a84d24fcd26ec0b3d7e3a054bd6c6d90ae715f0e"}],"api-ref/source/v3/quota-sets.inc":[{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"08d3a494633b686f0d394156354c5e46403cb58e","unresolved":false,"context_lines":[{"line_number":159,"context_line":"Get default quotas for a tenant"},{"line_number":160,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":".. rest_method::  GET /v3/{admin_tenant_id}/os-quota-sets/defaults"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"Gets default quotas for a tenant."},{"line_number":165,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":1,"id":"3a71b18c_9a4aff24","line":162,"updated":"2016-12-05 22:21:13.000000000","message":"Should be:\nGET /v3/{admin_tenant_id}/os-quota-sets/{tenant_id}/defaults","commit_id":"c34373f07711c379970d8bfa823ce8bca7f2b8dc"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"9d96266e136124fb6e141c001794b16318e3a3e6","unresolved":false,"context_lines":[{"line_number":160,"context_line":"Get default quotas for a project"},{"line_number":161,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":".. rest_method::  GET /v3/{admin_project_id}/os-quota-sets/defaults"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"Gets default quotas for a project."},{"line_number":166,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":3,"id":"ba2be162_e76f4390","line":163,"updated":"2017-03-01 16:25:11.000000000","message":"actually I think Scott is right here. See:\nhttps://github.com/openstack/cinder/blob/master/cinder/api/contrib/quotas.py#L334\n\nand  \"cinder help quota-defaults\"","commit_id":"f2f9242422b7d25fef82cf9ab114de39c0054bba"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"632d57762326411b0d8ba31fada384d71e51651d","unresolved":false,"context_lines":[{"line_number":160,"context_line":"Get default quotas for a project"},{"line_number":161,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":".. rest_method::  GET /v3/{admin_project_id}/os-quota-sets/defaults"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"Gets default quotas for a project."},{"line_number":166,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":3,"id":"ba2be162_e841c10c","line":163,"in_reply_to":"ba2be162_10b72c87","updated":"2017-03-02 00:42:11.000000000","message":"I can see your point. It\u0027s right that project_id is useless when use DbQuotaDriver. But when use NestedDbQuotaDriver, it\u0027s useful. See:\nhttps://github.com/openstack/cinder/blob/master/cinder/quota.py#L613\n\nThe default driver is DbQuotaDriver:\nhttps://github.com/openstack/cinder/blob/master/cinder/quota.py#L71-L73","commit_id":"f2f9242422b7d25fef82cf9ab114de39c0054bba"},{"author":{"_account_id":21813,"name":"Andrey Volkov","email":"m@amadev.ru","username":"avolkov"},"change_message_id":"4738f10f1ac9706d72f571c51816821ff86155c4","unresolved":false,"context_lines":[{"line_number":160,"context_line":"Get default quotas for a project"},{"line_number":161,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":".. rest_method::  GET /v3/{admin_project_id}/os-quota-sets/defaults"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"Gets default quotas for a project."},{"line_number":166,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":3,"id":"ba2be162_10b72c87","line":163,"in_reply_to":"ba2be162_e76f4390","updated":"2017-03-01 17:10:05.000000000","message":"Formally, it\u0027s true. My point is I don\u0027t want to introduce more confusing description than it was.\nSee https://github.com/openstack/cinder/blob/bug/1415214/cinder/quota.py#L109, project_id isn\u0027t used.\n\nThe only difference in response http://ix.io/nRu.\nIt\u0027s just add project_id to response[\u0027quota_set\u0027][\u0027id\u0027] if it\u0027s passed or set as default. I\u0027d rather deprecate this logic, can\u0027t imagine how it can be useful.","commit_id":"f2f9242422b7d25fef82cf9ab114de39c0054bba"},{"author":{"_account_id":21813,"name":"Andrey Volkov","email":"m@amadev.ru","username":"avolkov"},"change_message_id":"fad69f330c363339ae203e616b7eb165a5270d0c","unresolved":false,"context_lines":[{"line_number":160,"context_line":"Get default quotas for a project"},{"line_number":161,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":".. rest_method::  GET /v3/{admin_project_id}/os-quota-sets/defaults"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"Gets default quotas for a project."},{"line_number":166,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":3,"id":"ba2be162_20791e30","line":163,"in_reply_to":"ba2be162_e841c10c","updated":"2017-03-02 09:46:09.000000000","message":"Oh, that\u0027s weird nested quotas case, you are right, again )\nFixed.\nThanks.","commit_id":"f2f9242422b7d25fef82cf9ab114de39c0054bba"}]}