)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"d4cd90f8de103fba0dd58ff88918d9b62ff906a3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     nikesh \u003cNikesh.Mahalka.ctr@kaminario.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-12-06 17:19:44 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove Kaminario deprecate option"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In Newton release, \"kaminario_nodedup_substring\" option"},{"line_number":10,"context_line":"was marked deprecated in Kaminario driver and needs to be"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3a71b18c_93bc5ddd","line":7,"range":{"start_line":7,"start_character":17,"end_line":7,"end_character":26},"updated":"2016-12-07 11:20:21.000000000","message":"deprecated","commit_id":"08b1bd874ecc1f785d7cf2922e9cf28f44704d43"},{"author":{"_account_id":16258,"name":"nikesh","email":"nike.niec@gmail.com","username":"nikem"},"change_message_id":"eb99cd69a633990c5091b14cf14f79304b80017d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     nikesh \u003cNikesh.Mahalka.ctr@kaminario.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-12-06 17:19:44 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove Kaminario deprecate option"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In Newton release, \"kaminario_nodedup_substring\" option"},{"line_number":10,"context_line":"was marked deprecated in Kaminario driver and needs to be"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3a71b18c_d4807cfa","line":7,"range":{"start_line":7,"start_character":17,"end_line":7,"end_character":26},"in_reply_to":"3a71b18c_93bc5ddd","updated":"2016-12-07 12:10:04.000000000","message":"Done","commit_id":"08b1bd874ecc1f785d7cf2922e9cf28f44704d43"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"d4cd90f8de103fba0dd58ff88918d9b62ff906a3","unresolved":false,"context_lines":[{"line_number":11,"context_line":"remove in Ocata release."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Also, use \"CONF.register_opts\" for"},{"line_number":14,"context_line":"\"auto_calc_max_oversubscription_ratio\" to add this option"},{"line_number":15,"context_line":"automatically in driver specific options table for the"},{"line_number":16,"context_line":"config-reference OpenStack manual for Kaminario driver."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3a71b18c_13420dae","line":14,"range":{"start_line":14,"start_character":1,"end_line":14,"end_character":37},"updated":"2016-12-07 11:20:21.000000000","message":"This is not the scope of this change but please consider also parsing the CONF.max_over_subscription_ratio as a second option to your driver. This is the broadly used option for drivers.","commit_id":"08b1bd874ecc1f785d7cf2922e9cf28f44704d43"},{"author":{"_account_id":16258,"name":"nikesh","email":"nike.niec@gmail.com","username":"nikem"},"change_message_id":"eb99cd69a633990c5091b14cf14f79304b80017d","unresolved":false,"context_lines":[{"line_number":11,"context_line":"remove in Ocata release."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Also, use \"CONF.register_opts\" for"},{"line_number":14,"context_line":"\"auto_calc_max_oversubscription_ratio\" to add this option"},{"line_number":15,"context_line":"automatically in driver specific options table for the"},{"line_number":16,"context_line":"config-reference OpenStack manual for Kaminario driver."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3a71b18c_f75ada29","line":14,"range":{"start_line":14,"start_character":1,"end_line":14,"end_character":37},"in_reply_to":"3a71b18c_13420dae","updated":"2016-12-07 12:10:04.000000000","message":"My intention is not to read the value of option \"auto_calc_max_oversubscription_ratio\" from [DEFAULT] section of cinder.conf but to read its value from backend sections. I want to add this option in OpenStack manual table. So I am not considering CONF.max_over_subscription_ratio and I am using CONF.register_opts for this option.\n\nSame for other options like conf.san_ip, conf.san_login, conf.san_password","commit_id":"08b1bd874ecc1f785d7cf2922e9cf28f44704d43"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"56b48bd463fd04c4d307ad45b651d56742f852c8","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In Newton release, \"kaminario_nodedup_substring\" option"},{"line_number":10,"context_line":"was marked deprecated in Kaminario driver and needs to be"},{"line_number":11,"context_line":"remove in Ocata release."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Also, use \"CONF.register_opts\" for"},{"line_number":14,"context_line":"\"auto_calc_max_oversubscription_ratio\" to add this option"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3a71b18c_d3e780aa","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":6},"updated":"2016-12-08 10:34:38.000000000","message":"removed","commit_id":"681d090e9e213286a57910c267a611c6e11838e3"}],"cinder/volume/drivers/kaminario/kaminario_common.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"56b48bd463fd04c4d307ad45b651d56742f852c8","unresolved":false,"context_lines":[{"line_number":978,"context_line":"        if vol_type:"},{"line_number":979,"context_line":"            specs_val \u003d vol_type.get(\u0027extra_specs\u0027, {}).get("},{"line_number":980,"context_line":"                \u0027kaminario:thin_prov_type\u0027)"},{"line_number":981,"context_line":"            if specs_val \u003d\u003d \u0027nodedup\u0027:"},{"line_number":982,"context_line":"                return False"},{"line_number":983,"context_line":"            else:"},{"line_number":984,"context_line":"                return True"},{"line_number":985,"context_line":"        else:"},{"line_number":986,"context_line":"            return True"},{"line_number":987,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3a71b18c_539370fa","line":984,"range":{"start_line":981,"start_character":0,"end_line":984,"end_character":27},"updated":"2016-12-08 10:34:38.000000000","message":"return specs_val !\u003d \u0027nodedup\u0027","commit_id":"681d090e9e213286a57910c267a611c6e11838e3"}]}