)]}'
{"cinder/tests/unit/fake_snapshot.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"9c6be4391160921f84e5d79ec7986e1e477bd782","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"def fake_snapshot_obj(context, **updates):"},{"line_number":52,"context_line":"    expected_attrs \u003d updates.pop(\u0027expected_attrs\u0027, [])"},{"line_number":53,"context_line":"    if updates.get(\u0027volume\u0027) and \u0027volume\u0027 not in expected_attrs:"},{"line_number":54,"context_line":"        expected_attrs.append(\u0027volume\u0027)"},{"line_number":55,"context_line":"    return snapshot.Snapshot._from_db_object(context, snapshot.Snapshot(),"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_712a3480","line":52,"range":{"start_line":52,"start_character":21,"end_line":52,"end_character":54},"updated":"2016-12-19 13:38:45.000000000","message":"nit: Since we are already changing this we should allow expected_attrs to be set to None as it\u0027s an accepted value by our OVOs.\n\n  expected_attrs \u003d updates.pop(\u0027expected_attrs\u0027) or []","commit_id":"14699b200c4c74b7a4ce9c36015a95beb7ea3fee"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"dabbfcceac54dc4c37589cb49a2e069e9d0dcdcd","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"def fake_snapshot_obj(context, **updates):"},{"line_number":52,"context_line":"    expected_attrs \u003d updates.pop(\u0027expected_attrs\u0027, [])"},{"line_number":53,"context_line":"    if updates.get(\u0027volume\u0027) and \u0027volume\u0027 not in expected_attrs:"},{"line_number":54,"context_line":"        expected_attrs.append(\u0027volume\u0027)"},{"line_number":55,"context_line":"    return snapshot.Snapshot._from_db_object(context, snapshot.Snapshot(),"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_225d5a79","line":52,"range":{"start_line":52,"start_character":21,"end_line":52,"end_character":54},"in_reply_to":"1a6eadb0_712a3480","updated":"2017-01-17 11:34:19.000000000","message":"Done","commit_id":"14699b200c4c74b7a4ce9c36015a95beb7ea3fee"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"7c57ae963267dbf7998343f7b44ae04bd51da14d","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"def fake_snapshot_obj(context, **updates):"},{"line_number":52,"context_line":"    expected_attrs \u003d updates.pop(\u0027expected_attrs\u0027, [])"},{"line_number":53,"context_line":"    if updates.get(\u0027volume\u0027) and \u0027volume\u0027 not in expected_attrs:"},{"line_number":54,"context_line":"        expected_attrs.append(\u0027volume\u0027)"},{"line_number":55,"context_line":"    return snapshot.Snapshot._from_db_object(context, snapshot.Snapshot(),"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5201f7_aa862314","line":52,"range":{"start_line":52,"start_character":21,"end_line":52,"end_character":54},"in_reply_to":"1a6eadb0_712a3480","updated":"2017-01-09 11:48:53.000000000","message":"I don\u0027t understand this comment. The current code allows expected_attrs to be set to None.","commit_id":"14699b200c4c74b7a4ce9c36015a95beb7ea3fee"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"170d4b7ccec1d23da5a06d970b5da9769050cbc3","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"def fake_snapshot_obj(context, **updates):"},{"line_number":52,"context_line":"    expected_attrs \u003d updates.pop(\u0027expected_attrs\u0027, [])"},{"line_number":53,"context_line":"    if updates.get(\u0027volume\u0027) and \u0027volume\u0027 not in expected_attrs:"},{"line_number":54,"context_line":"        expected_attrs.append(\u0027volume\u0027)"},{"line_number":55,"context_line":"    return snapshot.Snapshot._from_db_object(context, snapshot.Snapshot(),"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_0659ce5a","line":52,"range":{"start_line":52,"start_character":21,"end_line":52,"end_character":54},"in_reply_to":"ba5201f7_aa862314","updated":"2017-01-13 14:14:26.000000000","message":"I don\u0027t think it is supported, because if expected_attrs is set to None on the updates then when we\u0027ll get an exception when we do \u0027volume\u0027 not in expected_attrs in L53","commit_id":"14699b200c4c74b7a4ce9c36015a95beb7ea3fee"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"9c6be4391160921f84e5d79ec7986e1e477bd782","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"def fake_snapshot_obj(context, **updates):"},{"line_number":52,"context_line":"    expected_attrs \u003d updates.pop(\u0027expected_attrs\u0027, [])"},{"line_number":53,"context_line":"    if updates.get(\u0027volume\u0027) and \u0027volume\u0027 not in expected_attrs:"},{"line_number":54,"context_line":"        expected_attrs.append(\u0027volume\u0027)"},{"line_number":55,"context_line":"    return snapshot.Snapshot._from_db_object(context, snapshot.Snapshot(),"},{"line_number":56,"context_line":"                                             fake_db_snapshot(**updates),"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_a6a3b44e","line":53,"range":{"start_line":53,"start_character":7,"end_line":53,"end_character":28},"updated":"2016-12-19 13:38:45.000000000","message":"nit: \u0027volume\u0027 in updates","commit_id":"14699b200c4c74b7a4ce9c36015a95beb7ea3fee"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"7c57ae963267dbf7998343f7b44ae04bd51da14d","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"def fake_snapshot_obj(context, **updates):"},{"line_number":52,"context_line":"    expected_attrs \u003d updates.pop(\u0027expected_attrs\u0027, [])"},{"line_number":53,"context_line":"    if updates.get(\u0027volume\u0027) and \u0027volume\u0027 not in expected_attrs:"},{"line_number":54,"context_line":"        expected_attrs.append(\u0027volume\u0027)"},{"line_number":55,"context_line":"    return snapshot.Snapshot._from_db_object(context, snapshot.Snapshot(),"},{"line_number":56,"context_line":"                                             fake_db_snapshot(**updates),"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5201f7_8aeddff1","line":53,"range":{"start_line":53,"start_character":7,"end_line":53,"end_character":28},"in_reply_to":"1a6eadb0_a6a3b44e","updated":"2017-01-09 11:48:53.000000000","message":"Done","commit_id":"14699b200c4c74b7a4ce9c36015a95beb7ea3fee"}]}