)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10213,"name":"Alon Marx","email":"alonma@il.ibm.com","username":"alonmarx"},"change_message_id":"0804050b18f2d7c6344e7af9854985885c9f35d7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Xiaoqin Li \u003clixqin@cn.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-12-06 16:48:46 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Storwize: create vol fails when near cluster licenced limit"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The volume creation fails when the virtualized storage capacity that"},{"line_number":10,"context_line":"the cluster is using is approaching the virtualized storage capacity"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a71b18c_3df513cb","line":7,"range":{"start_line":7,"start_character":45,"end_line":7,"end_character":53},"updated":"2016-12-07 13:15:25.000000000","message":"limit to 50 characters. licenced \u003d\u003e licensed","commit_id":"878ef2ff245303490330bd00582a9abfd66f5fd4"},{"author":{"_account_id":17045,"name":"xiaoqin","email":"xiaoqin.li@hotmail.com","username":"xiaoqin"},"change_message_id":"812c8875aa61a889b8319aea6fd9f6fc82fdf36b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Xiaoqin Li \u003clixqin@cn.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-12-06 16:48:46 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Storwize: create vol fails when near cluster licenced limit"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The volume creation fails when the virtualized storage capacity that"},{"line_number":10,"context_line":"the cluster is using is approaching the virtualized storage capacity"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a71b18c_0a2541c1","line":7,"range":{"start_line":7,"start_character":45,"end_line":7,"end_character":53},"in_reply_to":"3a71b18c_3df513cb","updated":"2016-12-08 09:43:06.000000000","message":"Hi Alone, thanks a lot for your comments. Addressed in new patch.","commit_id":"878ef2ff245303490330bd00582a9abfd66f5fd4"},{"author":{"_account_id":10213,"name":"Alon Marx","email":"alonma@il.ibm.com","username":"alonmarx"},"change_message_id":"0804050b18f2d7c6344e7af9854985885c9f35d7","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The volume creation fails when the virtualized storage capacity that"},{"line_number":10,"context_line":"the cluster is using is approaching the virtualized storage capacity"},{"line_number":11,"context_line":"that is licensed. The creation is success actually in backend and a"},{"line_number":12,"context_line":"waining message is sent to standard error. This change makes the"},{"line_number":13,"context_line":"creation success and adds the warning message to log."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a71b18c_bdbda3d9","line":11,"updated":"2016-12-07 13:15:25.000000000","message":"\"is successful in the backend\"","commit_id":"878ef2ff245303490330bd00582a9abfd66f5fd4"},{"author":{"_account_id":17045,"name":"xiaoqin","email":"xiaoqin.li@hotmail.com","username":"xiaoqin"},"change_message_id":"812c8875aa61a889b8319aea6fd9f6fc82fdf36b","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The volume creation fails when the virtualized storage capacity that"},{"line_number":10,"context_line":"the cluster is using is approaching the virtualized storage capacity"},{"line_number":11,"context_line":"that is licensed. The creation is success actually in backend and a"},{"line_number":12,"context_line":"waining message is sent to standard error. This change makes the"},{"line_number":13,"context_line":"creation success and adds the warning message to log."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a71b18c_6a031510","line":11,"in_reply_to":"3a71b18c_bdbda3d9","updated":"2016-12-08 09:43:06.000000000","message":"Done","commit_id":"878ef2ff245303490330bd00582a9abfd66f5fd4"},{"author":{"_account_id":10213,"name":"Alon Marx","email":"alonma@il.ibm.com","username":"alonmarx"},"change_message_id":"0804050b18f2d7c6344e7af9854985885c9f35d7","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The volume creation fails when the virtualized storage capacity that"},{"line_number":10,"context_line":"the cluster is using is approaching the virtualized storage capacity"},{"line_number":11,"context_line":"that is licensed. The creation is success actually in backend and a"},{"line_number":12,"context_line":"waining message is sent to standard error. This change makes the"},{"line_number":13,"context_line":"creation success and adds the warning message to log."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I95a7a39744d7bb025a47ff60e1a0195d5c4887a7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a71b18c_3dca736f","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":7},"updated":"2016-12-07 13:15:25.000000000","message":"warning","commit_id":"878ef2ff245303490330bd00582a9abfd66f5fd4"},{"author":{"_account_id":17045,"name":"xiaoqin","email":"xiaoqin.li@hotmail.com","username":"xiaoqin"},"change_message_id":"812c8875aa61a889b8319aea6fd9f6fc82fdf36b","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The volume creation fails when the virtualized storage capacity that"},{"line_number":10,"context_line":"the cluster is using is approaching the virtualized storage capacity"},{"line_number":11,"context_line":"that is licensed. The creation is success actually in backend and a"},{"line_number":12,"context_line":"waining message is sent to standard error. This change makes the"},{"line_number":13,"context_line":"creation success and adds the warning message to log."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I95a7a39744d7bb025a47ff60e1a0195d5c4887a7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a71b18c_ad03870c","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":7},"in_reply_to":"3a71b18c_3dca736f","updated":"2016-12-08 09:43:06.000000000","message":"Done","commit_id":"878ef2ff245303490330bd00582a9abfd66f5fd4"}],"cinder/tests/unit/volume/drivers/ibm/test_storwize_svc.py":[{"author":{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},"change_message_id":"c83de458e2e2434fdea2fc3e859bb9839727c9d3","unresolved":false,"context_lines":[{"line_number":5380,"context_line":"    @mock.patch.object(storwize_svc_common.StorwizeSSH,"},{"line_number":5381,"context_line":"                       \u0027run_ssh_check_created\u0027)"},{"line_number":5382,"context_line":"    @mock.patch.object(storwize_svc_common.StorwizeSSH, \u0027lsvdisk\u0027)"},{"line_number":5383,"context_line":"    def test_mkvdisk_with_warning(self, lsvdisk, run_ssh_check_created):"},{"line_number":5384,"context_line":"        opt \u003d {\u0027iogrp\u0027: 0}"},{"line_number":5385,"context_line":"        vdisk \u003d {\u0027name\u0027: \u0027fakevol\u0027, \u0027id\u0027: \u00270\u0027, \u0027uid\u0027: \u00270\u0027, \u0027IO_group_id\u0027: \u00270\u0027,"},{"line_number":5386,"context_line":"                 \u0027IO_group_name\u0027: \u0027fakepool\u0027}"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_dfa941e1","line":5383,"range":{"start_line":5383,"start_character":0,"end_line":5383,"end_character":72},"updated":"2016-12-08 11:46:51.000000000","message":"-1 \nI think, you should have used ddt library for side_effects for this test not to create the same checks.","commit_id":"3a607efd3de373c500d3d032fbe0fe628c010ff7"},{"author":{"_account_id":17045,"name":"xiaoqin","email":"xiaoqin.li@hotmail.com","username":"xiaoqin"},"change_message_id":"5596d8b88af1d071208a2729bad83e6f9e6bd46b","unresolved":false,"context_lines":[{"line_number":5380,"context_line":"    @mock.patch.object(storwize_svc_common.StorwizeSSH,"},{"line_number":5381,"context_line":"                       \u0027run_ssh_check_created\u0027)"},{"line_number":5382,"context_line":"    @mock.patch.object(storwize_svc_common.StorwizeSSH, \u0027lsvdisk\u0027)"},{"line_number":5383,"context_line":"    def test_mkvdisk_with_warning(self, lsvdisk, run_ssh_check_created):"},{"line_number":5384,"context_line":"        opt \u003d {\u0027iogrp\u0027: 0}"},{"line_number":5385,"context_line":"        vdisk \u003d {\u0027name\u0027: \u0027fakevol\u0027, \u0027id\u0027: \u00270\u0027, \u0027uid\u0027: \u00270\u0027, \u0027IO_group_id\u0027: \u00270\u0027,"},{"line_number":5386,"context_line":"                 \u0027IO_group_name\u0027: \u0027fakepool\u0027}"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_f2832101","line":5383,"range":{"start_line":5383,"start_character":0,"end_line":5383,"end_character":72},"in_reply_to":"3a71b18c_dfa941e1","updated":"2016-12-12 10:22:40.000000000","message":"Hi michael, thanks a lot for your comments. ddt is normally used when running the same test function with different input parameters. However, this case is to test different expectations for mkvdisk based on the different return values of functions run_ssh_check_created and lsvdisk. I tried to use ddt, but do not find a better way.","commit_id":"3a607efd3de373c500d3d032fbe0fe628c010ff7"}],"cinder/volume/drivers/ibm/storwize_svc/storwize_svc_common.py":[{"author":{"_account_id":10213,"name":"Alon Marx","email":"alonma@il.ibm.com","username":"alonmarx"},"change_message_id":"0804050b18f2d7c6344e7af9854985885c9f35d7","unresolved":false,"context_lines":[{"line_number":383,"context_line":"            if hasattr(ex, \u0027msg\u0027) and \u0027CMMVC6372W\u0027 in ex.msg:"},{"line_number":384,"context_line":"                vdisk \u003d self.lsvdisk(name)"},{"line_number":385,"context_line":"                if vdisk:"},{"line_number":386,"context_line":"                    msg \u003d _(\u0027CMMVC6372W The virtualized storage capacity that\u0027"},{"line_number":387,"context_line":"                            \u0027 the cluster is using is approaching the \u0027"},{"line_number":388,"context_line":"                            \u0027virtualized storage capacity that is licensed.\u0027)"},{"line_number":389,"context_line":"                    LOG.warning(msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_3d699326","line":386,"range":{"start_line":386,"start_character":20,"end_line":386,"end_character":23},"updated":"2016-12-07 13:15:25.000000000","message":"This is just a warning and the volume is created, so I\u0027m thinking if it matters which volume it is. Does it?\nAnyway, if it does matter, then you should add the name to the message.","commit_id":"878ef2ff245303490330bd00582a9abfd66f5fd4"},{"author":{"_account_id":17045,"name":"xiaoqin","email":"xiaoqin.li@hotmail.com","username":"xiaoqin"},"change_message_id":"812c8875aa61a889b8319aea6fd9f6fc82fdf36b","unresolved":false,"context_lines":[{"line_number":383,"context_line":"            if hasattr(ex, \u0027msg\u0027) and \u0027CMMVC6372W\u0027 in ex.msg:"},{"line_number":384,"context_line":"                vdisk \u003d self.lsvdisk(name)"},{"line_number":385,"context_line":"                if vdisk:"},{"line_number":386,"context_line":"                    msg \u003d _(\u0027CMMVC6372W The virtualized storage capacity that\u0027"},{"line_number":387,"context_line":"                            \u0027 the cluster is using is approaching the \u0027"},{"line_number":388,"context_line":"                            \u0027virtualized storage capacity that is licensed.\u0027)"},{"line_number":389,"context_line":"                    LOG.warning(msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_c90fda2c","line":386,"range":{"start_line":386,"start_character":20,"end_line":386,"end_character":23},"in_reply_to":"3a71b18c_3d699326","updated":"2016-12-08 09:43:06.000000000","message":"Hi, Alone, thanks a lot for your comments. We will double check whether the volume is created, if it is created, just log a warning message in log. If it is not created, re-raise the exception.","commit_id":"878ef2ff245303490330bd00582a9abfd66f5fd4"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"3082d9716b040694552841b917c919b8a0c0cabd","unresolved":false,"context_lines":[{"line_number":383,"context_line":"            if hasattr(ex, \u0027msg\u0027) and \u0027CMMVC6372W\u0027 in ex.msg:"},{"line_number":384,"context_line":"                vdisk \u003d self.lsvdisk(name)"},{"line_number":385,"context_line":"                if vdisk:"},{"line_number":386,"context_line":"                    msg \u003d _(\u0027CMMVC6372W The virtualized storage capacity that\u0027"},{"line_number":387,"context_line":"                            \u0027 the cluster is using is approaching the \u0027"},{"line_number":388,"context_line":"                            \u0027virtualized storage capacity that is licensed.\u0027)"},{"line_number":389,"context_line":"                    LOG.warning(msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_cf48de8d","line":386,"range":{"start_line":386,"start_character":20,"end_line":386,"end_character":23},"in_reply_to":"3a71b18c_3d699326","updated":"2016-12-07 15:54:02.000000000","message":"_ \u003d\u003e _LW","commit_id":"878ef2ff245303490330bd00582a9abfd66f5fd4"},{"author":{"_account_id":17045,"name":"xiaoqin","email":"xiaoqin.li@hotmail.com","username":"xiaoqin"},"change_message_id":"812c8875aa61a889b8319aea6fd9f6fc82fdf36b","unresolved":false,"context_lines":[{"line_number":383,"context_line":"            if hasattr(ex, \u0027msg\u0027) and \u0027CMMVC6372W\u0027 in ex.msg:"},{"line_number":384,"context_line":"                vdisk \u003d self.lsvdisk(name)"},{"line_number":385,"context_line":"                if vdisk:"},{"line_number":386,"context_line":"                    msg \u003d _(\u0027CMMVC6372W The virtualized storage capacity that\u0027"},{"line_number":387,"context_line":"                            \u0027 the cluster is using is approaching the \u0027"},{"line_number":388,"context_line":"                            \u0027virtualized storage capacity that is licensed.\u0027)"},{"line_number":389,"context_line":"                    LOG.warning(msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_c9c6fa48","line":386,"range":{"start_line":386,"start_character":20,"end_line":386,"end_character":23},"in_reply_to":"3a71b18c_cf48de8d","updated":"2016-12-08 09:43:06.000000000","message":"Hi Ivan, thanks a lot for your comments. It\u0027s addressed in new patch.","commit_id":"878ef2ff245303490330bd00582a9abfd66f5fd4"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"3082d9716b040694552841b917c919b8a0c0cabd","unresolved":false,"context_lines":[{"line_number":389,"context_line":"                    LOG.warning(msg)"},{"line_number":390,"context_line":"                    return vdisk[\u0027id\u0027]"},{"line_number":391,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":392,"context_line":"                LOG.error(_LE(\u0027Error creating vdisk %s\u0027), name)"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"    def rmvdisk(self, vdisk, force\u003dTrue):"},{"line_number":395,"context_line":"        ssh_cmd \u003d [\u0027svctask\u0027, \u0027rmvdisk\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_4f24cec5","line":392,"updated":"2016-12-07 15:54:02.000000000","message":"LOG.error \u003d\u003e LOG.exception","commit_id":"878ef2ff245303490330bd00582a9abfd66f5fd4"},{"author":{"_account_id":20382,"name":"YuYang","email":"yuyangwang1985@gmail.com","username":"YuYangWang"},"change_message_id":"efd435cc667bffb3e09deb119cc01bd643fd5590","unresolved":false,"context_lines":[{"line_number":389,"context_line":"                    LOG.warning(msg)"},{"line_number":390,"context_line":"                    return vdisk[\u0027id\u0027]"},{"line_number":391,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":392,"context_line":"                LOG.error(_LE(\u0027Error creating vdisk %s\u0027), name)"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"    def rmvdisk(self, vdisk, force\u003dTrue):"},{"line_number":395,"context_line":"        ssh_cmd \u003d [\u0027svctask\u0027, \u0027rmvdisk\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_d3222701","line":392,"range":{"start_line":392,"start_character":16,"end_line":392,"end_character":63},"updated":"2016-12-08 08:12:26.000000000","message":"this you should add the error msg in the error log.not just the name.if you add the error msg.we can analyze the svc error log to fix the problem.","commit_id":"878ef2ff245303490330bd00582a9abfd66f5fd4"},{"author":{"_account_id":17045,"name":"xiaoqin","email":"xiaoqin.li@hotmail.com","username":"xiaoqin"},"change_message_id":"812c8875aa61a889b8319aea6fd9f6fc82fdf36b","unresolved":false,"context_lines":[{"line_number":389,"context_line":"                    LOG.warning(msg)"},{"line_number":390,"context_line":"                    return vdisk[\u0027id\u0027]"},{"line_number":391,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":392,"context_line":"                LOG.error(_LE(\u0027Error creating vdisk %s\u0027), name)"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"    def rmvdisk(self, vdisk, force\u003dTrue):"},{"line_number":395,"context_line":"        ssh_cmd \u003d [\u0027svctask\u0027, \u0027rmvdisk\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_89b402d2","line":392,"in_reply_to":"3a71b18c_4f24cec5","updated":"2016-12-08 09:43:06.000000000","message":"Hi Ivan, thanks a lot for your comments. It is addressed in new patch.","commit_id":"878ef2ff245303490330bd00582a9abfd66f5fd4"},{"author":{"_account_id":17045,"name":"xiaoqin","email":"xiaoqin.li@hotmail.com","username":"xiaoqin"},"change_message_id":"812c8875aa61a889b8319aea6fd9f6fc82fdf36b","unresolved":false,"context_lines":[{"line_number":389,"context_line":"                    LOG.warning(msg)"},{"line_number":390,"context_line":"                    return vdisk[\u0027id\u0027]"},{"line_number":391,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":392,"context_line":"                LOG.error(_LE(\u0027Error creating vdisk %s\u0027), name)"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"    def rmvdisk(self, vdisk, force\u003dTrue):"},{"line_number":395,"context_line":"        ssh_cmd \u003d [\u0027svctask\u0027, \u0027rmvdisk\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_845ce7ee","line":392,"range":{"start_line":392,"start_character":16,"end_line":392,"end_character":63},"in_reply_to":"3a71b18c_d3222701","updated":"2016-12-08 09:43:06.000000000","message":"Hi Yu, thanks a lot for comments, the error message will be recorded in reraise_exception. However, I also add it here.","commit_id":"878ef2ff245303490330bd00582a9abfd66f5fd4"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"a9bf4b41c12e766497b7bf646b829af868b9b1bc","unresolved":false,"context_lines":[{"line_number":379,"context_line":"                   \u0027-size\u0027, size, \u0027-unit\u0027, units] + params"},{"line_number":380,"context_line":"        try:"},{"line_number":381,"context_line":"            return self.run_ssh_check_created(ssh_cmd)"},{"line_number":382,"context_line":"        except Exception as ex:"},{"line_number":383,"context_line":"            if hasattr(ex, \u0027msg\u0027) and \u0027CMMVC6372W\u0027 in ex.msg:"},{"line_number":384,"context_line":"                vdisk \u003d self.lsvdisk(name)"},{"line_number":385,"context_line":"                if vdisk:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_58759861","line":382,"updated":"2016-12-16 16:31:33.000000000","message":"Could we catch more specific exception here?","commit_id":"3d63f50d9779ab1249cf86387d465a1341228cd3"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"a9bf4b41c12e766497b7bf646b829af868b9b1bc","unresolved":false,"context_lines":[{"line_number":391,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":392,"context_line":"                LOG.exception(_LE(\u0027Failed to create vdisk %(vol)s. \u0027"},{"line_number":393,"context_line":"                                  \u0027Error %(err)s\u0027),"},{"line_number":394,"context_line":"                              {\u0027vol\u0027: name, \u0027err\u0027: ex})"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"    def rmvdisk(self, vdisk, force\u003dTrue):"},{"line_number":397,"context_line":"        ssh_cmd \u003d [\u0027svctask\u0027, \u0027rmvdisk\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_d860c8a7","line":394,"updated":"2016-12-16 16:31:33.000000000","message":"LOG.exception will add full traceback to the log message. You don\u0027t need to pass \u0027ex\u0027 to the logger","commit_id":"3d63f50d9779ab1249cf86387d465a1341228cd3"}]}