)]}'
{"cinder/manager.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ddb67b4f4124e534f4668bffe86dbb382436d074","unresolved":false,"context_lines":[{"line_number":184,"context_line":"                # This means we have Newton\u0027s c-sch in the deployment, so"},{"line_number":185,"context_line":"                # rpcapi cannot send the message. We can safely ignore the"},{"line_number":186,"context_line":"                # error. Log it because it shouldn\u0027t happen after upgrade."},{"line_number":187,"context_line":"                LOG.warning(e.msg)"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    def _add_to_threadpool(self, func, *args, **kwargs):"},{"line_number":190,"context_line":"        self._tp.spawn_n(func, *args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_bbfcf6b8","line":187,"range":{"start_line":187,"start_character":28,"end_line":187,"end_character":33},"updated":"2016-12-06 17:24:28.000000000","message":"Is this marked for _LW translation? It\u0027d probably be better to add your own _LW message here and log the ServiceTooOld error in there, e.g.:\n\n_LW(\"Failed to notify cinder-volume service capabilities for host %(host)s. Error: %(e)s\") % (self.host, e)","commit_id":"fac8ccb2dfc597a1257527c205dd79d74beaf198"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"f2d6b11e2ac041abd673da5eecd1b88dc921d578","unresolved":false,"context_lines":[{"line_number":184,"context_line":"                # This means we have Newton\u0027s c-sch in the deployment, so"},{"line_number":185,"context_line":"                # rpcapi cannot send the message. We can safely ignore the"},{"line_number":186,"context_line":"                # error. Log it because it shouldn\u0027t happen after upgrade."},{"line_number":187,"context_line":"                LOG.warning(e.msg)"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    def _add_to_threadpool(self, func, *args, **kwargs):"},{"line_number":190,"context_line":"        self._tp.spawn_n(func, *args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_5ba762bc","line":187,"updated":"2016-12-06 17:26:31.000000000","message":"should this be e.message ?","commit_id":"fac8ccb2dfc597a1257527c205dd79d74beaf198"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"135f6ee89b8d97c573ab69504e72724192416975","unresolved":false,"context_lines":[{"line_number":184,"context_line":"                # This means we have Newton\u0027s c-sch in the deployment, so"},{"line_number":185,"context_line":"                # rpcapi cannot send the message. We can safely ignore the"},{"line_number":186,"context_line":"                # error. Log it because it shouldn\u0027t happen after upgrade."},{"line_number":187,"context_line":"                LOG.warning(e.msg)"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    def _add_to_threadpool(self, func, *args, **kwargs):"},{"line_number":190,"context_line":"        self._tp.spawn_n(func, *args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_beb2244a","line":187,"in_reply_to":"3a71b18c_5ba762bc","updated":"2016-12-06 17:45:35.000000000","message":"I think this should be a warning, as it shouldn\u0027t happen outside of maintenance windows.","commit_id":"fac8ccb2dfc597a1257527c205dd79d74beaf198"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a0d3e704861aed1f77f23d32dc0f54e487ecae8f","unresolved":false,"context_lines":[{"line_number":184,"context_line":"                # This means we have Newton\u0027s c-sch in the deployment, so"},{"line_number":185,"context_line":"                # rpcapi cannot send the message. We can safely ignore the"},{"line_number":186,"context_line":"                # error. Log it because it shouldn\u0027t happen after upgrade."},{"line_number":187,"context_line":"                LOG.warning(e.msg)"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    def _add_to_threadpool(self, func, *args, **kwargs):"},{"line_number":190,"context_line":"        self._tp.spawn_n(func, *args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_5bc202ea","line":187,"in_reply_to":"3a71b18c_5ba762bc","updated":"2016-12-06 17:32:23.000000000","message":"You don\u0027t need to call any attributes on the exception if you use the message I have above.","commit_id":"fac8ccb2dfc597a1257527c205dd79d74beaf198"}],"cinder/scheduler/rpcapi.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ddb67b4f4124e534f4668bffe86dbb382436d074","unresolved":false,"context_lines":[{"line_number":147,"context_line":"                                    host, capabilities):"},{"line_number":148,"context_line":"        cctxt \u003d self._get_cctxt(version\u003d\u00273.1\u0027)"},{"line_number":149,"context_line":"        if not cctxt.can_send_version(\u00273.1\u0027):"},{"line_number":150,"context_line":"            msg \u003d _(\u0027notify_service_capabilities is unsupported during an \u0027"},{"line_number":151,"context_line":"                    \u0027upgrade\u0027)"},{"line_number":152,"context_line":"            raise exception.ServiceTooOld(msg)"},{"line_number":153,"context_line":"        cctxt.cast(ctxt, \u0027notify_service_capabilities\u0027,"},{"line_number":154,"context_line":"                   service_name\u003dservice_name, host\u003dhost,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_fbf02ecb","line":151,"range":{"start_line":150,"start_character":18,"end_line":151,"end_character":30},"updated":"2016-12-06 17:24:28.000000000","message":"I feel like this message could be better, maybe instead of talking about an upgrade, mention that the cinder-scheduler RPC API needs to be \u003e\u003d v3.1.","commit_id":"fac8ccb2dfc597a1257527c205dd79d74beaf198"}]}