)]}'
{"cinder/consistencygroup/api.py":[{"author":{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},"change_message_id":"72d31879c3cc6931a9518f3b5fbe323eed801909","unresolved":false,"context_lines":[{"line_number":411,"context_line":"                try:"},{"line_number":412,"context_line":"                    if isinstance(e, exception.OverQuota):"},{"line_number":413,"context_line":"                        group.destroy()"},{"line_number":414,"context_line":"                        quota_utils.process_reserve_over_quota("},{"line_number":415,"context_line":"                            context, e, resource\u003d\u0027groups\u0027)"},{"line_number":416,"context_line":"                    group.destroy()"},{"line_number":417,"context_line":"                finally:"},{"line_number":418,"context_line":"                    LOG.error(_LE(\"Failed to update quota for \""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_03f5b1eb","line":415,"range":{"start_line":414,"start_character":0,"end_line":415,"end_character":58},"updated":"2016-12-12 13:38:35.000000000","message":"Actually, can we left only this code under the if statement? Or we need to run group.destroy() code twice?","commit_id":"201d336587f505202496d70fce3269c513b634f6"},{"author":{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},"change_message_id":"985c2fb9290cebc76b36cb2bc0a0beb0146d66c6","unresolved":false,"context_lines":[{"line_number":409,"context_line":"        except Exception as e:"},{"line_number":410,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":411,"context_line":"                try:"},{"line_number":412,"context_line":"                    if isinstance(e, exception.OverQuota):"},{"line_number":413,"context_line":"                        group.destroy()"},{"line_number":414,"context_line":"                        quota_utils.process_reserve_over_quota("},{"line_number":415,"context_line":"                            context, e, resource\u003d\u0027groups\u0027)"},{"line_number":416,"context_line":"                    else:"},{"line_number":417,"context_line":"                        group.destroy()"},{"line_number":418,"context_line":"                finally:"},{"line_number":419,"context_line":"                    LOG.error(_LE(\"Failed to update quota for \""},{"line_number":420,"context_line":"                                  \"consistency group %s.\"), group.id)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6eadb0_e0810f91","line":417,"range":{"start_line":412,"start_character":0,"end_line":417,"end_character":39},"updated":"2016-12-13 10:00:27.000000000","message":"So we need this group.destroy() only once.\nAccording to this, please, change to \n    group.destroy()\n    if isinstance(e, exception.OverQuota):\n        ...\nbecause, we don\u0027t need this else and group destroying must be at the first place. Thank you","commit_id":"e5914335782bf06ed7abec053f976314ba445d15"}],"cinder/exception.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"0d96b4eee3bf12b549a94cfdaa33cc1162f207f0","unresolved":false,"context_lines":[{"line_number":661,"context_line":""},{"line_number":662,"context_line":"class GroupLimitExceeded(QuotaError):"},{"line_number":663,"context_line":"    message \u003d _(\"Maximum number of groups allowed (%(allowed)d) exceeded for \""},{"line_number":664,"context_line":"                \"quota \u0027%(name)s\u0027.\")"},{"line_number":665,"context_line":""},{"line_number":666,"context_line":"    def __init__(self, message\u003dNone, **kwargs):"},{"line_number":667,"context_line":"        kwargs.setdefault(\u0027name\u0027, \u0027groups\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a6eadb0_4a962c95","line":664,"updated":"2016-12-20 11:59:24.000000000","message":"-1: We should remove everything after exceeded, it doesn\u0027t add any additional information, since quota name will always be groups.","commit_id":"2b9169bb14dcffd1b75acdd340a48e6627ac268c"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"0d96b4eee3bf12b549a94cfdaa33cc1162f207f0","unresolved":false,"context_lines":[{"line_number":663,"context_line":"    message \u003d _(\"Maximum number of groups allowed (%(allowed)d) exceeded for \""},{"line_number":664,"context_line":"                \"quota \u0027%(name)s\u0027.\")"},{"line_number":665,"context_line":""},{"line_number":666,"context_line":"    def __init__(self, message\u003dNone, **kwargs):"},{"line_number":667,"context_line":"        kwargs.setdefault(\u0027name\u0027, \u0027groups\u0027)"},{"line_number":668,"context_line":"        super(GroupLimitExceeded, self).__init__(message, **kwargs)"},{"line_number":669,"context_line":""},{"line_number":670,"context_line":""},{"line_number":671,"context_line":"class UnknownCmd(VolumeDriverException):"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a6eadb0_2a71f0a8","line":668,"range":{"start_line":666,"start_character":0,"end_line":668,"end_character":67},"updated":"2016-12-20 11:59:24.000000000","message":"-1: This is unnecessary, name will always be present.","commit_id":"2b9169bb14dcffd1b75acdd340a48e6627ac268c"}],"cinder/group/api.py":[{"author":{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},"change_message_id":"72d31879c3cc6931a9518f3b5fbe323eed801909","unresolved":false,"context_lines":[{"line_number":475,"context_line":"                try:"},{"line_number":476,"context_line":"                    if isinstance(e, exception.OverQuota):"},{"line_number":477,"context_line":"                        group.destroy()"},{"line_number":478,"context_line":"                        quota_utils.process_reserve_over_quota("},{"line_number":479,"context_line":"                            context, e, resource\u003d\u0027groups\u0027)"},{"line_number":480,"context_line":"                    group.destroy()"},{"line_number":481,"context_line":"                finally:"},{"line_number":482,"context_line":"                    LOG.error(_LE(\"Failed to update quota for \""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_d4fd26b2","line":479,"range":{"start_line":478,"start_character":0,"end_line":479,"end_character":58},"updated":"2016-12-12 13:38:35.000000000","message":"Same","commit_id":"201d336587f505202496d70fce3269c513b634f6"}]}