)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"9d2eba025adbb7b9b55b943a94538fa7712d372b","unresolved":false,"context_lines":[{"line_number":13,"context_line":"fail if another process created this dir between"},{"line_number":14,"context_line":"the check and the creation."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"(When we move to py3, call makedirs with the"},{"line_number":17,"context_line":"exist_ok\u003dTrue arg, which handles this race but"},{"line_number":18,"context_line":"is not available in py27.)"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a71b18c_20e3ce06","line":16,"updated":"2016-12-09 07:32:16.000000000","message":"nit: We can move this part into the code as a comment but I won\u0027t -1 on it","commit_id":"844b3a10d407576a6d3cd0523e6ba4165652c3af"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"4c054c7ffc81891b23828da54efa6692a511eebe","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Fix a race condition where os.makedirs() could"},{"line_number":13,"context_line":"fail if another process created this dir between"},{"line_number":14,"context_line":"the check and the creation."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I700c8937cffe6dfc41feea59e0e04cd75228473c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a6eadb0_43541720","line":14,"updated":"2016-12-15 10:45:16.000000000","message":"nit: These should be 2 different patches","commit_id":"99504dde36662c40885b7c228bbb23d1bc36e9a7"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"b5148d2575adc71613acb2122250cdadff70bdaf","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Fix a race condition where os.makedirs() could"},{"line_number":13,"context_line":"fail if another process created this dir between"},{"line_number":14,"context_line":"the check and the creation."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I700c8937cffe6dfc41feea59e0e04cd75228473c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a6eadb0_7f50b6d4","line":14,"in_reply_to":"1a6eadb0_43541720","updated":"2016-12-15 14:36:02.000000000","message":"Yeah, probably.","commit_id":"99504dde36662c40885b7c228bbb23d1bc36e9a7"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"4c054c7ffc81891b23828da54efa6692a511eebe","unresolved":false,"context_lines":[{"line_number":13,"context_line":"fail if another process created this dir between"},{"line_number":14,"context_line":"the check and the creation."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I700c8937cffe6dfc41feea59e0e04cd75228473c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a6eadb0_a3396bf4","line":16,"updated":"2016-12-15 10:45:16.000000000","message":"?: I agree with e0ne, no LP bug for the race condition?","commit_id":"99504dde36662c40885b7c228bbb23d1bc36e9a7"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"b5148d2575adc71613acb2122250cdadff70bdaf","unresolved":false,"context_lines":[{"line_number":13,"context_line":"fail if another process created this dir between"},{"line_number":14,"context_line":"the check and the creation."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I700c8937cffe6dfc41feea59e0e04cd75228473c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a6eadb0_ff43e610","line":16,"in_reply_to":"1a6eadb0_a3396bf4","updated":"2016-12-15 14:36:02.000000000","message":"I can write one, but I think this is unlikely enough that it shouldn\u0027t really be a requirement.  The odds of an LP on this ever being useful in a meaningful way are fairly slim.  It\u0027s more likely to just be overhead.","commit_id":"99504dde36662c40885b7c228bbb23d1bc36e9a7"}],"cinder/volume/drivers/rbd.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"4c054c7ffc81891b23828da54efa6692a511eebe","unresolved":false,"context_lines":[{"line_number":847,"context_line":"        except OSError as exc:"},{"line_number":848,"context_line":"            if exc.errno \u003d\u003d errno.EEXIST:"},{"line_number":849,"context_line":"                if os.path.isdir(tmpdir):"},{"line_number":850,"context_line":"                    pass"},{"line_number":851,"context_line":""},{"line_number":852,"context_line":"        return tmpdir"},{"line_number":853,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_03b05f89","line":850,"updated":"2016-12-15 10:45:16.000000000","message":"-1: Shouldn\u0027t you make sure the exception is raised if it\u0027s not a dir?","commit_id":"99504dde36662c40885b7c228bbb23d1bc36e9a7"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"b5148d2575adc71613acb2122250cdadff70bdaf","unresolved":false,"context_lines":[{"line_number":847,"context_line":"        except OSError as exc:"},{"line_number":848,"context_line":"            if exc.errno \u003d\u003d errno.EEXIST:"},{"line_number":849,"context_line":"                if os.path.isdir(tmpdir):"},{"line_number":850,"context_line":"                    pass"},{"line_number":851,"context_line":""},{"line_number":852,"context_line":"        return tmpdir"},{"line_number":853,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_9fbbd2e4","line":850,"in_reply_to":"1a6eadb0_03b05f89","updated":"2016-12-15 14:36:02.000000000","message":"Yes.","commit_id":"99504dde36662c40885b7c228bbb23d1bc36e9a7"}]}