)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23113,"name":"Hariprasad S Venkatasubramanian","email":"hari.venkat@hpe.com","username":"hari.venkat"},"change_message_id":"03582a260e6a938e00c9f876c4b2bd6e1250dfcd","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Kushal \u003ckushal.wathore@hpe.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-02-08 13:35:44 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"handle manage and unmanage hosts present on 3par"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"3PAR Driver fails to handle pre-existing host record with"},{"line_number":10,"context_line":"different name but the same path,this patch ensure to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa31d9ce_c333b360","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":48},"updated":"2017-02-14 11:07:18.000000000","message":"Nit: Please prefix vendor array context. \n\n\"HPE 3PAR: Handle manage and unmanage hosts present on the array\"","commit_id":"c6ab1b71ca6166ca14786cd280cbfdf5fc626843"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"cc7c3764529efbab62ad5060b515c058aaaa6806","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"3PAR Driver fails to handle pre-existing host record with"},{"line_number":10,"context_line":"different name but the same path,this patch ensure to"},{"line_number":11,"context_line":"handle this scneario"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I82ecbbe1932c5e6147703f44f2d002f7e7094a43"},{"line_number":14,"context_line":"Closes-Bug: #1648067"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa31d9ce_4fccc135","line":11,"range":{"start_line":11,"start_character":12,"end_line":11,"end_character":20},"updated":"2017-02-10 13:37:55.000000000","message":"nit: scenario","commit_id":"c6ab1b71ca6166ca14786cd280cbfdf5fc626843"},{"author":{"_account_id":21407,"name":"Kushal Wathore","email":"kushal.wathore@hpe.com","username":"kwathore"},"change_message_id":"776b7277987a124d913326b3ab5c4ff625d24e73","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"3PAR Driver fails to handle pre-existing host record with"},{"line_number":10,"context_line":"different name but the same path,this patch ensure to"},{"line_number":11,"context_line":"handle this scneario"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I82ecbbe1932c5e6147703f44f2d002f7e7094a43"},{"line_number":14,"context_line":"Closes-Bug: #1648067"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa31d9ce_3480478b","line":11,"range":{"start_line":11,"start_character":12,"end_line":11,"end_character":20},"in_reply_to":"fa31d9ce_03422bae","updated":"2017-02-14 12:18:13.000000000","message":"Done","commit_id":"c6ab1b71ca6166ca14786cd280cbfdf5fc626843"},{"author":{"_account_id":23113,"name":"Hariprasad S Venkatasubramanian","email":"hari.venkat@hpe.com","username":"hari.venkat"},"change_message_id":"03582a260e6a938e00c9f876c4b2bd6e1250dfcd","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"3PAR Driver fails to handle pre-existing host record with"},{"line_number":10,"context_line":"different name but the same path,this patch ensure to"},{"line_number":11,"context_line":"handle this scneario"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I82ecbbe1932c5e6147703f44f2d002f7e7094a43"},{"line_number":14,"context_line":"Closes-Bug: #1648067"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa31d9ce_03422bae","line":11,"range":{"start_line":11,"start_character":12,"end_line":11,"end_character":20},"in_reply_to":"fa31d9ce_4fccc135","updated":"2017-02-14 11:07:18.000000000","message":"+1","commit_id":"c6ab1b71ca6166ca14786cd280cbfdf5fc626843"}],"cinder/volume/drivers/hpe/hpe_3par_common.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"fdf21218e64cf2b309003e2f9f4682fb41863b4a","unresolved":false,"context_lines":[{"line_number":1123,"context_line":"        # Check whether host with wwn/iqn of initiator present on 3par"},{"line_number":1124,"context_line":"        if hosts and hosts[\u0027members\u0027] and \u0027name\u0027 in hosts[\u0027members\u0027][0]:"},{"line_number":1125,"context_line":"            # Retrieving \u0027host\u0027 and \u0027hosts\u0027 from 3par using hostname"},{"line_number":1126,"context_line":"            # and iqn respectively.Compare hostname of \u0027host\u0027 and \u0027hosts\u0027,"},{"line_number":1127,"context_line":"            # if they do not match it means 3par has a pre-existing host"},{"line_number":1128,"context_line":"            # with some other name."},{"line_number":1129,"context_line":"            hostname \u003d hosts[\u0027members\u0027][0][\u0027name\u0027]"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa31d9ce_27eb42b2","line":1126,"range":{"start_line":1126,"start_character":34,"end_line":1126,"end_character":36},"updated":"2017-02-16 15:53:31.000000000","message":"Space missing here.","commit_id":"0e282ee1c9658df17ce02bbcc0a811888f2b2499"},{"author":{"_account_id":21407,"name":"Kushal Wathore","email":"kushal.wathore@hpe.com","username":"kwathore"},"change_message_id":"b47b167bc0894624a571b219a80999f0ab76a02d","unresolved":false,"context_lines":[{"line_number":1123,"context_line":"        # Check whether host with wwn/iqn of initiator present on 3par"},{"line_number":1124,"context_line":"        if hosts and hosts[\u0027members\u0027] and \u0027name\u0027 in hosts[\u0027members\u0027][0]:"},{"line_number":1125,"context_line":"            # Retrieving \u0027host\u0027 and \u0027hosts\u0027 from 3par using hostname"},{"line_number":1126,"context_line":"            # and iqn respectively.Compare hostname of \u0027host\u0027 and \u0027hosts\u0027,"},{"line_number":1127,"context_line":"            # if they do not match it means 3par has a pre-existing host"},{"line_number":1128,"context_line":"            # with some other name."},{"line_number":1129,"context_line":"            hostname \u003d hosts[\u0027members\u0027][0][\u0027name\u0027]"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa31d9ce_cd0367bd","line":1126,"range":{"start_line":1126,"start_character":34,"end_line":1126,"end_character":36},"in_reply_to":"fa31d9ce_27eb42b2","updated":"2017-02-16 16:33:04.000000000","message":"Done","commit_id":"0e282ee1c9658df17ce02bbcc0a811888f2b2499"},{"author":{"_account_id":21406,"name":"Vijay Ladani","email":"vijay.ladani@hpe.com","username":"vladani"},"change_message_id":"13d2146695036d8d27d47031797cb0778a923fc7","unresolved":false,"context_lines":[{"line_number":2524,"context_line":"                LOG.error(_LE(\"Exception: %s\"), ex)"},{"line_number":2525,"context_line":"                raise exception.SnapshotIsBusy(message\u003dex.get_description())"},{"line_number":2526,"context_line":""},{"line_number":2527,"context_line":"    def _get_3par_hostname_from_wwn_iqn(self, wwns, iqns):"},{"line_number":2528,"context_line":"        if wwns is not None and not isinstance(wwns, list):"},{"line_number":2529,"context_line":"            wwns \u003d [wwns]"},{"line_number":2530,"context_line":"        if iqns is not None and not isinstance(iqns, list):"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa31d9ce_1ed05df7","line":2527,"updated":"2017-02-16 10:01:52.000000000","message":"Should use this method in fc and iscsi.","commit_id":"0e282ee1c9658df17ce02bbcc0a811888f2b2499"},{"author":{"_account_id":21407,"name":"Kushal Wathore","email":"kushal.wathore@hpe.com","username":"kwathore"},"change_message_id":"695dff4521537cd1c984f3e8ddba0fe080717b47","unresolved":false,"context_lines":[{"line_number":2524,"context_line":"                LOG.error(_LE(\"Exception: %s\"), ex)"},{"line_number":2525,"context_line":"                raise exception.SnapshotIsBusy(message\u003dex.get_description())"},{"line_number":2526,"context_line":""},{"line_number":2527,"context_line":"    def _get_3par_hostname_from_wwn_iqn(self, wwns, iqns):"},{"line_number":2528,"context_line":"        if wwns is not None and not isinstance(wwns, list):"},{"line_number":2529,"context_line":"            wwns \u003d [wwns]"},{"line_number":2530,"context_line":"        if iqns is not None and not isinstance(iqns, list):"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa31d9ce_9fce07b6","line":2527,"in_reply_to":"fa31d9ce_1ed05df7","updated":"2017-02-16 10:54:40.000000000","message":"This method will not be useful to solve our purpose here.\nThanks vijay","commit_id":"0e282ee1c9658df17ce02bbcc0a811888f2b2499"},{"author":{"_account_id":23113,"name":"Hariprasad S Venkatasubramanian","email":"hari.venkat@hpe.com","username":"hari.venkat"},"change_message_id":"36c9f2a746237cbf52db71c6ce6ff4e04addd353","unresolved":false,"context_lines":[{"line_number":1123,"context_line":"        # Check whether host with wwn/iqn of initiator present on 3par"},{"line_number":1124,"context_line":"        if hosts and hosts[\u0027members\u0027] and \u0027name\u0027 in hosts[\u0027members\u0027][0]:"},{"line_number":1125,"context_line":"            # Retrieving \u0027host\u0027 and \u0027hosts\u0027 from 3par using hostname"},{"line_number":1126,"context_line":"            # and iqn respectively. Compare hostname of \u0027host\u0027 and \u0027hosts\u0027,"},{"line_number":1127,"context_line":"            # if they do not match it means 3par has a pre-existing host"},{"line_number":1128,"context_line":"            # with some other name."},{"line_number":1129,"context_line":"            hostname \u003d hosts[\u0027members\u0027][0][\u0027name\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa31d9ce_32f28970","line":1126,"range":{"start_line":1126,"start_character":18,"end_line":1126,"end_character":21},"updated":"2017-02-17 07:13:42.000000000","message":"port name (wwn/iqn)","commit_id":"3c583fdaaefc5373cdbf85433c6691b13eaf276a"},{"author":{"_account_id":23113,"name":"Hariprasad S Venkatasubramanian","email":"hari.venkat@hpe.com","username":"hari.venkat"},"change_message_id":"36c9f2a746237cbf52db71c6ce6ff4e04addd353","unresolved":false,"context_lines":[{"line_number":1128,"context_line":"            # with some other name."},{"line_number":1129,"context_line":"            hostname \u003d hosts[\u0027members\u0027][0][\u0027name\u0027]"},{"line_number":1130,"context_line":"            if host[\u0027name\u0027] !\u003d hostname:"},{"line_number":1131,"context_line":"                LOG.debug(\"Prioritize the host retrieved from iqn. \""},{"line_number":1132,"context_line":"                          \"Hostname : %(hosts)s  is used instead \""},{"line_number":1133,"context_line":"                          \"of Hostname: %(host)s\","},{"line_number":1134,"context_line":"                          {\u0027hosts\u0027: hosts[\u0027members\u0027][0][\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa31d9ce_12bbc576","line":1131,"range":{"start_line":1131,"start_character":20,"end_line":1131,"end_character":25},"updated":"2017-02-17 07:13:42.000000000","message":"change this to LOG.info()","commit_id":"3c583fdaaefc5373cdbf85433c6691b13eaf276a"},{"author":{"_account_id":23113,"name":"Hariprasad S Venkatasubramanian","email":"hari.venkat@hpe.com","username":"hari.venkat"},"change_message_id":"36c9f2a746237cbf52db71c6ce6ff4e04addd353","unresolved":false,"context_lines":[{"line_number":1128,"context_line":"            # with some other name."},{"line_number":1129,"context_line":"            hostname \u003d hosts[\u0027members\u0027][0][\u0027name\u0027]"},{"line_number":1130,"context_line":"            if host[\u0027name\u0027] !\u003d hostname:"},{"line_number":1131,"context_line":"                LOG.debug(\"Prioritize the host retrieved from iqn. \""},{"line_number":1132,"context_line":"                          \"Hostname : %(hosts)s  is used instead \""},{"line_number":1133,"context_line":"                          \"of Hostname: %(host)s\","},{"line_number":1134,"context_line":"                          {\u0027hosts\u0027: hosts[\u0027members\u0027][0][\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa31d9ce_52e7fdab","line":1131,"range":{"start_line":1131,"start_character":62,"end_line":1131,"end_character":65},"updated":"2017-02-17 07:13:42.000000000","message":"port name (wwn/iqn)","commit_id":"3c583fdaaefc5373cdbf85433c6691b13eaf276a"},{"author":{"_account_id":21407,"name":"Kushal Wathore","email":"kushal.wathore@hpe.com","username":"kwathore"},"change_message_id":"1e7aefe33929bcdf205a6aa8a848eccc9088a5da","unresolved":false,"context_lines":[{"line_number":1128,"context_line":"            # with some other name."},{"line_number":1129,"context_line":"            hostname \u003d hosts[\u0027members\u0027][0][\u0027name\u0027]"},{"line_number":1130,"context_line":"            if host[\u0027name\u0027] !\u003d hostname:"},{"line_number":1131,"context_line":"                LOG.debug(\"Prioritize the host retrieved from iqn. \""},{"line_number":1132,"context_line":"                          \"Hostname : %(hosts)s  is used instead \""},{"line_number":1133,"context_line":"                          \"of Hostname: %(host)s\","},{"line_number":1134,"context_line":"                          {\u0027hosts\u0027: hosts[\u0027members\u0027][0][\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":7,"id":"da36d5c6_2b74e19a","line":1131,"range":{"start_line":1131,"start_character":20,"end_line":1131,"end_character":25},"in_reply_to":"fa31d9ce_12bbc576","updated":"2017-02-20 12:21:24.000000000","message":"Done","commit_id":"3c583fdaaefc5373cdbf85433c6691b13eaf276a"},{"author":{"_account_id":23113,"name":"Hariprasad S Venkatasubramanian","email":"hari.venkat@hpe.com","username":"hari.venkat"},"change_message_id":"36c9f2a746237cbf52db71c6ce6ff4e04addd353","unresolved":false,"context_lines":[{"line_number":1132,"context_line":"                          \"Hostname : %(hosts)s  is used instead \""},{"line_number":1133,"context_line":"                          \"of Hostname: %(host)s\","},{"line_number":1134,"context_line":"                          {\u0027hosts\u0027: hosts[\u0027members\u0027][0][\u0027name\u0027],"},{"line_number":1135,"context_line":"                           \u0027host\u0027: hostname})"},{"line_number":1136,"context_line":"                return True"},{"line_number":1137,"context_line":""},{"line_number":1138,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa31d9ce_727161e0","line":1135,"range":{"start_line":1135,"start_character":35,"end_line":1135,"end_character":43},"updated":"2017-02-17 07:13:42.000000000","message":"hostname is same as hosts[\u0027members\u0027][0][\u0027name\u0027], so then this should be host[\u0027name\u0027] ?","commit_id":"3c583fdaaefc5373cdbf85433c6691b13eaf276a"},{"author":{"_account_id":21407,"name":"Kushal Wathore","email":"kushal.wathore@hpe.com","username":"kwathore"},"change_message_id":"1e7aefe33929bcdf205a6aa8a848eccc9088a5da","unresolved":false,"context_lines":[{"line_number":1132,"context_line":"                          \"Hostname : %(hosts)s  is used instead \""},{"line_number":1133,"context_line":"                          \"of Hostname: %(host)s\","},{"line_number":1134,"context_line":"                          {\u0027hosts\u0027: hosts[\u0027members\u0027][0][\u0027name\u0027],"},{"line_number":1135,"context_line":"                           \u0027host\u0027: hostname})"},{"line_number":1136,"context_line":"                return True"},{"line_number":1137,"context_line":""},{"line_number":1138,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":7,"id":"da36d5c6_8b730db1","line":1135,"range":{"start_line":1135,"start_character":35,"end_line":1135,"end_character":43},"in_reply_to":"fa31d9ce_727161e0","updated":"2017-02-20 12:21:24.000000000","message":"Done","commit_id":"3c583fdaaefc5373cdbf85433c6691b13eaf276a"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"01cb4e8160f047d6c645b9a01292c24748e440cf","unresolved":false,"context_lines":[{"line_number":1134,"context_line":"            # with some other name."},{"line_number":1135,"context_line":"            if host[\u0027name\u0027] !\u003d hosts[\u0027members\u0027][0][\u0027name\u0027]:"},{"line_number":1136,"context_line":"                hostname \u003d hosts[\u0027members\u0027][0][\u0027name\u0027]"},{"line_number":1137,"context_line":"                LOG.info(_LI(\"Prioritize the host retrieved from wwn/iqn \""},{"line_number":1138,"context_line":"                             \"Hostname : %(hosts)s  is used instead \""},{"line_number":1139,"context_line":"                             \"of Hostname: %(host)s\"),"},{"line_number":1140,"context_line":"                         {\u0027hosts\u0027: hostname,"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a1ced50_44fb5547","line":1137,"range":{"start_line":1137,"start_character":25,"end_line":1137,"end_character":28},"updated":"2017-03-21 16:02:15.000000000","message":"Since this is failing CI and we have decided not to use these anymore we might as well make the change here.","commit_id":"c4baa09294e763172ca7dff4eec27b41a626f1b6"},{"author":{"_account_id":21407,"name":"Kushal Wathore","email":"kushal.wathore@hpe.com","username":"kwathore"},"change_message_id":"2bc53a9db0897bc599f5ae973f0615a152dbc96f","unresolved":false,"context_lines":[{"line_number":1134,"context_line":"            # with some other name."},{"line_number":1135,"context_line":"            if host[\u0027name\u0027] !\u003d hosts[\u0027members\u0027][0][\u0027name\u0027]:"},{"line_number":1136,"context_line":"                hostname \u003d hosts[\u0027members\u0027][0][\u0027name\u0027]"},{"line_number":1137,"context_line":"                LOG.info(_LI(\"Prioritize the host retrieved from wwn/iqn \""},{"line_number":1138,"context_line":"                             \"Hostname : %(hosts)s  is used instead \""},{"line_number":1139,"context_line":"                             \"of Hostname: %(host)s\"),"},{"line_number":1140,"context_line":"                         {\u0027hosts\u0027: hostname,"}],"source_content_type":"text/x-python","patch_set":12,"id":"ffe62b97_7d409008","line":1137,"range":{"start_line":1137,"start_character":25,"end_line":1137,"end_character":28},"in_reply_to":"1a1ced50_44fb5547","updated":"2017-03-24 02:37:46.000000000","message":"Thanks, Done the changes.","commit_id":"c4baa09294e763172ca7dff4eec27b41a626f1b6"}],"cinder/volume/drivers/hpe/hpe_3par_fc.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"db603288faae767451c75fb33d4879bfdbb9cedb","unresolved":false,"context_lines":[{"line_number":505,"context_line":"                # and wwn respectively.Compare hostname of \u0027host\u0027 and \u0027hosts\u0027,"},{"line_number":506,"context_line":"                # if they do not match it means 3par has a pre-existing host"},{"line_number":507,"context_line":"                # with some other name."},{"line_number":508,"context_line":"                if str(hostname) !\u003d str(hosts[\u0027members\u0027][0][\u0027name\u0027]):"},{"line_number":509,"context_line":"                    LOG.debug(\"Prioritize the host retrieved from wwn.\""},{"line_number":510,"context_line":"                              \"Hostname : %(hosts)s  is used instead\""},{"line_number":511,"context_line":"                              \"of Hostname: %(host)s\","}],"source_content_type":"text/x-python","patch_set":3,"id":"1a430d35_dae19d2b","line":508,"range":{"start_line":508,"start_character":19,"end_line":508,"end_character":23},"updated":"2017-02-08 22:10:43.000000000","message":"Is calling str() on these necessary?","commit_id":"662609c225beb2047e56bbdd0590ce9b05be3a06"},{"author":{"_account_id":21407,"name":"Kushal Wathore","email":"kushal.wathore@hpe.com","username":"kwathore"},"change_message_id":"6d0bfa9c555c0d51449dde4866fa5464d1951d72","unresolved":false,"context_lines":[{"line_number":505,"context_line":"                # and wwn respectively.Compare hostname of \u0027host\u0027 and \u0027hosts\u0027,"},{"line_number":506,"context_line":"                # if they do not match it means 3par has a pre-existing host"},{"line_number":507,"context_line":"                # with some other name."},{"line_number":508,"context_line":"                if str(hostname) !\u003d str(hosts[\u0027members\u0027][0][\u0027name\u0027]):"},{"line_number":509,"context_line":"                    LOG.debug(\"Prioritize the host retrieved from wwn.\""},{"line_number":510,"context_line":"                              \"Hostname : %(hosts)s  is used instead\""},{"line_number":511,"context_line":"                              \"of Hostname: %(host)s\","}],"source_content_type":"text/x-python","patch_set":3,"id":"1a430d35_4c708d0b","line":508,"range":{"start_line":508,"start_character":19,"end_line":508,"end_character":23},"in_reply_to":"1a430d35_dae19d2b","updated":"2017-02-09 08:39:31.000000000","message":"Done","commit_id":"662609c225beb2047e56bbdd0590ce9b05be3a06"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"db603288faae767451c75fb33d4879bfdbb9cedb","unresolved":false,"context_lines":[{"line_number":506,"context_line":"                # if they do not match it means 3par has a pre-existing host"},{"line_number":507,"context_line":"                # with some other name."},{"line_number":508,"context_line":"                if str(hostname) !\u003d str(hosts[\u0027members\u0027][0][\u0027name\u0027]):"},{"line_number":509,"context_line":"                    LOG.debug(\"Prioritize the host retrieved from wwn.\""},{"line_number":510,"context_line":"                              \"Hostname : %(hosts)s  is used instead\""},{"line_number":511,"context_line":"                              \"of Hostname: %(host)s\","},{"line_number":512,"context_line":"                              {\u0027hosts\u0027: hosts[\u0027members\u0027][0][\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a430d35_da8a7d63","line":509,"updated":"2017-02-08 22:10:43.000000000","message":"Need space on the end.","commit_id":"662609c225beb2047e56bbdd0590ce9b05be3a06"},{"author":{"_account_id":21407,"name":"Kushal Wathore","email":"kushal.wathore@hpe.com","username":"kwathore"},"change_message_id":"6d0bfa9c555c0d51449dde4866fa5464d1951d72","unresolved":false,"context_lines":[{"line_number":506,"context_line":"                # if they do not match it means 3par has a pre-existing host"},{"line_number":507,"context_line":"                # with some other name."},{"line_number":508,"context_line":"                if str(hostname) !\u003d str(hosts[\u0027members\u0027][0][\u0027name\u0027]):"},{"line_number":509,"context_line":"                    LOG.debug(\"Prioritize the host retrieved from wwn.\""},{"line_number":510,"context_line":"                              \"Hostname : %(hosts)s  is used instead\""},{"line_number":511,"context_line":"                              \"of Hostname: %(host)s\","},{"line_number":512,"context_line":"                              {\u0027hosts\u0027: hosts[\u0027members\u0027][0][\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a430d35_6c6b891e","line":509,"in_reply_to":"1a430d35_da8a7d63","updated":"2017-02-09 08:39:31.000000000","message":"Done","commit_id":"662609c225beb2047e56bbdd0590ce9b05be3a06"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"db603288faae767451c75fb33d4879bfdbb9cedb","unresolved":false,"context_lines":[{"line_number":507,"context_line":"                # with some other name."},{"line_number":508,"context_line":"                if str(hostname) !\u003d str(hosts[\u0027members\u0027][0][\u0027name\u0027]):"},{"line_number":509,"context_line":"                    LOG.debug(\"Prioritize the host retrieved from wwn.\""},{"line_number":510,"context_line":"                              \"Hostname : %(hosts)s  is used instead\""},{"line_number":511,"context_line":"                              \"of Hostname: %(host)s\","},{"line_number":512,"context_line":"                              {\u0027hosts\u0027: hosts[\u0027members\u0027][0][\u0027name\u0027],"},{"line_number":513,"context_line":"                               \u0027host\u0027: hostname})"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a430d35_1aefa51e","line":510,"updated":"2017-02-08 22:10:43.000000000","message":"Here too.","commit_id":"662609c225beb2047e56bbdd0590ce9b05be3a06"},{"author":{"_account_id":21407,"name":"Kushal Wathore","email":"kushal.wathore@hpe.com","username":"kwathore"},"change_message_id":"6d0bfa9c555c0d51449dde4866fa5464d1951d72","unresolved":false,"context_lines":[{"line_number":507,"context_line":"                # with some other name."},{"line_number":508,"context_line":"                if str(hostname) !\u003d str(hosts[\u0027members\u0027][0][\u0027name\u0027]):"},{"line_number":509,"context_line":"                    LOG.debug(\"Prioritize the host retrieved from wwn.\""},{"line_number":510,"context_line":"                              \"Hostname : %(hosts)s  is used instead\""},{"line_number":511,"context_line":"                              \"of Hostname: %(host)s\","},{"line_number":512,"context_line":"                              {\u0027hosts\u0027: hosts[\u0027members\u0027][0][\u0027name\u0027],"},{"line_number":513,"context_line":"                               \u0027host\u0027: hostname})"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a430d35_8c76f503","line":510,"in_reply_to":"1a430d35_1aefa51e","updated":"2017-02-09 08:39:31.000000000","message":"Done","commit_id":"662609c225beb2047e56bbdd0590ce9b05be3a06"},{"author":{"_account_id":22664,"name":"William Durairaj","email":"william.dur.sandanaraj@hpe.com","username":"william.durairaj"},"change_message_id":"30df9eca39d1a32264c0fcf3eabe009d25774751","unresolved":false,"context_lines":[{"line_number":506,"context_line":"                # if they do not match it means 3par has a pre-existing host"},{"line_number":507,"context_line":"                # with some other name."},{"line_number":508,"context_line":"                if hostname !\u003d hosts[\u0027members\u0027][0][\u0027name\u0027]:"},{"line_number":509,"context_line":"                    LOG.debug(\"Prioritize the host retrieved from wwn. \""},{"line_number":510,"context_line":"                              \"Hostname : %(hosts)s  is used instead \""},{"line_number":511,"context_line":"                              \"of Hostname: %(host)s\","},{"line_number":512,"context_line":"                              {\u0027hosts\u0027: hosts[\u0027members\u0027][0][\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa31d9ce_bf4bba58","line":509,"range":{"start_line":509,"start_character":24,"end_line":509,"end_character":29},"updated":"2017-02-10 09:05:26.000000000","message":"this could be a LOG.info() call since not every production customer with debug level logging.","commit_id":"c6ab1b71ca6166ca14786cd280cbfdf5fc626843"},{"author":{"_account_id":21407,"name":"Kushal Wathore","email":"kushal.wathore@hpe.com","username":"kwathore"},"change_message_id":"776b7277987a124d913326b3ab5c4ff625d24e73","unresolved":false,"context_lines":[{"line_number":506,"context_line":"                # if they do not match it means 3par has a pre-existing host"},{"line_number":507,"context_line":"                # with some other name."},{"line_number":508,"context_line":"                if hostname !\u003d hosts[\u0027members\u0027][0][\u0027name\u0027]:"},{"line_number":509,"context_line":"                    LOG.debug(\"Prioritize the host retrieved from wwn. \""},{"line_number":510,"context_line":"                              \"Hostname : %(hosts)s  is used instead \""},{"line_number":511,"context_line":"                              \"of Hostname: %(host)s\","},{"line_number":512,"context_line":"                              {\u0027hosts\u0027: hosts[\u0027members\u0027][0][\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa31d9ce_9451f338","line":509,"range":{"start_line":509,"start_character":24,"end_line":509,"end_character":29},"in_reply_to":"fa31d9ce_03706b0a","updated":"2017-02-14 12:18:13.000000000","message":"Done","commit_id":"c6ab1b71ca6166ca14786cd280cbfdf5fc626843"},{"author":{"_account_id":23113,"name":"Hariprasad S Venkatasubramanian","email":"hari.venkat@hpe.com","username":"hari.venkat"},"change_message_id":"03582a260e6a938e00c9f876c4b2bd6e1250dfcd","unresolved":false,"context_lines":[{"line_number":506,"context_line":"                # if they do not match it means 3par has a pre-existing host"},{"line_number":507,"context_line":"                # with some other name."},{"line_number":508,"context_line":"                if hostname !\u003d hosts[\u0027members\u0027][0][\u0027name\u0027]:"},{"line_number":509,"context_line":"                    LOG.debug(\"Prioritize the host retrieved from wwn. \""},{"line_number":510,"context_line":"                              \"Hostname : %(hosts)s  is used instead \""},{"line_number":511,"context_line":"                              \"of Hostname: %(host)s\","},{"line_number":512,"context_line":"                              {\u0027hosts\u0027: hosts[\u0027members\u0027][0][\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa31d9ce_03706b0a","line":509,"range":{"start_line":509,"start_character":24,"end_line":509,"end_character":29},"in_reply_to":"fa31d9ce_bf4bba58","updated":"2017-02-14 11:07:18.000000000","message":"+1","commit_id":"c6ab1b71ca6166ca14786cd280cbfdf5fc626843"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"fdf21218e64cf2b309003e2f9f4682fb41863b4a","unresolved":false,"context_lines":[{"line_number":500,"context_line":"            host \u003d common._get_3par_host(hostname)"},{"line_number":501,"context_line":"            # Check whether host with wwn of initiator present on 3par"},{"line_number":502,"context_line":"            hosts \u003d common.client.queryHost(wwns\u003dconnector[\u0027wwpns\u0027])"},{"line_number":503,"context_line":"            host_exist \u003d common._check_pre_existing_host_on_3par(host, hosts)"},{"line_number":504,"context_line":"            if host_exist:"},{"line_number":505,"context_line":"                hostname \u003d hosts[\u0027members\u0027][0][\u0027name\u0027]"},{"line_number":506,"context_line":"                host \u003d common._get_3par_host(hostname)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa31d9ce_a74572b4","line":503,"range":{"start_line":503,"start_character":12,"end_line":503,"end_character":21},"updated":"2017-02-16 15:53:31.000000000","message":"This would be clearer if it were \u0027host_exists\u0027","commit_id":"0e282ee1c9658df17ce02bbcc0a811888f2b2499"},{"author":{"_account_id":21407,"name":"Kushal Wathore","email":"kushal.wathore@hpe.com","username":"kwathore"},"change_message_id":"b47b167bc0894624a571b219a80999f0ab76a02d","unresolved":false,"context_lines":[{"line_number":500,"context_line":"            host \u003d common._get_3par_host(hostname)"},{"line_number":501,"context_line":"            # Check whether host with wwn of initiator present on 3par"},{"line_number":502,"context_line":"            hosts \u003d common.client.queryHost(wwns\u003dconnector[\u0027wwpns\u0027])"},{"line_number":503,"context_line":"            host_exist \u003d common._check_pre_existing_host_on_3par(host, hosts)"},{"line_number":504,"context_line":"            if host_exist:"},{"line_number":505,"context_line":"                hostname \u003d hosts[\u0027members\u0027][0][\u0027name\u0027]"},{"line_number":506,"context_line":"                host \u003d common._get_3par_host(hostname)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa31d9ce_cd2a872f","line":503,"range":{"start_line":503,"start_character":12,"end_line":503,"end_character":21},"in_reply_to":"fa31d9ce_a74572b4","updated":"2017-02-16 16:33:04.000000000","message":"Done","commit_id":"0e282ee1c9658df17ce02bbcc0a811888f2b2499"},{"author":{"_account_id":21406,"name":"Vijay Ladani","email":"vijay.ladani@hpe.com","username":"vladani"},"change_message_id":"13d2146695036d8d27d47031797cb0778a923fc7","unresolved":false,"context_lines":[{"line_number":498,"context_line":"        domain \u003d common.get_domain(cpg)"},{"line_number":499,"context_line":"        try:"},{"line_number":500,"context_line":"            host \u003d common._get_3par_host(hostname)"},{"line_number":501,"context_line":"            # Check whether host with wwn of initiator present on 3par"},{"line_number":502,"context_line":"            hosts \u003d common.client.queryHost(wwns\u003dconnector[\u0027wwpns\u0027])"},{"line_number":503,"context_line":"            host_exist \u003d common._check_pre_existing_host_on_3par(host, hosts)"},{"line_number":504,"context_line":"            if host_exist:"},{"line_number":505,"context_line":"                hostname \u003d hosts[\u0027members\u0027][0][\u0027name\u0027]"},{"line_number":506,"context_line":"                host \u003d common._get_3par_host(hostname)"},{"line_number":507,"context_line":"        except hpeexceptions.HTTPNotFound:"},{"line_number":508,"context_line":"            # get persona from the volume type extra specs"},{"line_number":509,"context_line":"            persona_id \u003d common.get_persona_type(volume)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa31d9ce_3ee36107","line":506,"range":{"start_line":501,"start_character":0,"end_line":506,"end_character":54},"updated":"2017-02-16 10:01:52.000000000","message":"Can not we use already existing method \"_get_3par_hostname_from_wwn_iqn(self, wwns, iqns)\" available in common file?","commit_id":"0e282ee1c9658df17ce02bbcc0a811888f2b2499"},{"author":{"_account_id":21407,"name":"Kushal Wathore","email":"kushal.wathore@hpe.com","username":"kwathore"},"change_message_id":"695dff4521537cd1c984f3e8ddba0fe080717b47","unresolved":false,"context_lines":[{"line_number":498,"context_line":"        domain \u003d common.get_domain(cpg)"},{"line_number":499,"context_line":"        try:"},{"line_number":500,"context_line":"            host \u003d common._get_3par_host(hostname)"},{"line_number":501,"context_line":"            # Check whether host with wwn of initiator present on 3par"},{"line_number":502,"context_line":"            hosts \u003d common.client.queryHost(wwns\u003dconnector[\u0027wwpns\u0027])"},{"line_number":503,"context_line":"            host_exist \u003d common._check_pre_existing_host_on_3par(host, hosts)"},{"line_number":504,"context_line":"            if host_exist:"},{"line_number":505,"context_line":"                hostname \u003d hosts[\u0027members\u0027][0][\u0027name\u0027]"},{"line_number":506,"context_line":"                host \u003d common._get_3par_host(hostname)"},{"line_number":507,"context_line":"        except hpeexceptions.HTTPNotFound:"},{"line_number":508,"context_line":"            # get persona from the volume type extra specs"},{"line_number":509,"context_line":"            persona_id \u003d common.get_persona_type(volume)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa31d9ce_7f5153d8","line":506,"range":{"start_line":501,"start_character":0,"end_line":506,"end_character":54},"in_reply_to":"fa31d9ce_3ee36107","updated":"2017-02-16 10:54:40.000000000","message":"This method is not useful to solve our purpose here.\nThanks Vijay.","commit_id":"0e282ee1c9658df17ce02bbcc0a811888f2b2499"},{"author":{"_account_id":23113,"name":"Hariprasad S Venkatasubramanian","email":"hari.venkat@hpe.com","username":"hari.venkat"},"change_message_id":"36c9f2a746237cbf52db71c6ce6ff4e04addd353","unresolved":false,"context_lines":[{"line_number":500,"context_line":"            host \u003d common._get_3par_host(hostname)"},{"line_number":501,"context_line":"            # Check whether host with wwn of initiator present on 3par"},{"line_number":502,"context_line":"            hosts \u003d common.client.queryHost(wwns\u003dconnector[\u0027wwpns\u0027])"},{"line_number":503,"context_line":"            host_exists \u003d common._check_pre_existing_host_on_3par(host, hosts)"},{"line_number":504,"context_line":"            if host_exists:"},{"line_number":505,"context_line":"                hostname \u003d hosts[\u0027members\u0027][0][\u0027name\u0027]"},{"line_number":506,"context_line":"                host \u003d common._get_3par_host(hostname)"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa31d9ce_f202b10a","line":503,"range":{"start_line":503,"start_character":33,"end_line":503,"end_character":65},"updated":"2017-02-17 07:13:42.000000000","message":"Please consider retrieving the prioritized host record in one shot. You may push the logic to retrieve the host record into this common method and simply use the same in the driver. This would make the code read better. Rename this method to something like \"_get_prioritized_host_on_3par\"","commit_id":"3c583fdaaefc5373cdbf85433c6691b13eaf276a"},{"author":{"_account_id":21407,"name":"Kushal Wathore","email":"kushal.wathore@hpe.com","username":"kwathore"},"change_message_id":"1e7aefe33929bcdf205a6aa8a848eccc9088a5da","unresolved":false,"context_lines":[{"line_number":500,"context_line":"            host \u003d common._get_3par_host(hostname)"},{"line_number":501,"context_line":"            # Check whether host with wwn of initiator present on 3par"},{"line_number":502,"context_line":"            hosts \u003d common.client.queryHost(wwns\u003dconnector[\u0027wwpns\u0027])"},{"line_number":503,"context_line":"            host_exists \u003d common._check_pre_existing_host_on_3par(host, hosts)"},{"line_number":504,"context_line":"            if host_exists:"},{"line_number":505,"context_line":"                hostname \u003d hosts[\u0027members\u0027][0][\u0027name\u0027]"},{"line_number":506,"context_line":"                host \u003d common._get_3par_host(hostname)"}],"source_content_type":"text/x-python","patch_set":7,"id":"da36d5c6_0bb71d3a","line":503,"range":{"start_line":503,"start_character":33,"end_line":503,"end_character":65},"in_reply_to":"fa31d9ce_f202b10a","updated":"2017-02-20 12:21:24.000000000","message":"Done","commit_id":"3c583fdaaefc5373cdbf85433c6691b13eaf276a"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"b77238bf43258bf9118fb81fb9cc466d1d2c5f07","unresolved":false,"context_lines":[{"line_number":499,"context_line":"            hosts \u003d common.client.queryHost(wwns\u003dconnector[\u0027wwpns\u0027])"},{"line_number":500,"context_line":"            host, hostname \u003d common._get_prioritized_host_on_3par(host,"},{"line_number":501,"context_line":"                                                                  hosts,"},{"line_number":502,"context_line":"                                                                  hostname)"},{"line_number":503,"context_line":"        except hpeexceptions.HTTPNotFound:"},{"line_number":504,"context_line":"            # get persona from the volume type extra specs"},{"line_number":505,"context_line":"            persona_id \u003d common.get_persona_type(volume)"}],"source_content_type":"text/x-python","patch_set":16,"id":"dfeb2761_d943a512","line":502,"updated":"2017-04-04 21:30:02.000000000","message":"this seems to be a duplication of effort in the common class here:\n\nhttps://github.com/openstack/cinder/blob/master/cinder/volume/drivers/hpe/hpe_3par_common.py#L2533","commit_id":"2dd6484458d5ee1f1311665abcc8d66a21af6594"},{"author":{"_account_id":21407,"name":"Kushal Wathore","email":"kushal.wathore@hpe.com","username":"kwathore"},"change_message_id":"2fac1faadacee23da9307c7d0b508ae73346099b","unresolved":false,"context_lines":[{"line_number":499,"context_line":"            hosts \u003d common.client.queryHost(wwns\u003dconnector[\u0027wwpns\u0027])"},{"line_number":500,"context_line":"            host, hostname \u003d common._get_prioritized_host_on_3par(host,"},{"line_number":501,"context_line":"                                                                  hosts,"},{"line_number":502,"context_line":"                                                                  hostname)"},{"line_number":503,"context_line":"        except hpeexceptions.HTTPNotFound:"},{"line_number":504,"context_line":"            # get persona from the volume type extra specs"},{"line_number":505,"context_line":"            persona_id \u003d common.get_persona_type(volume)"}],"source_content_type":"text/x-python","patch_set":16,"id":"dfeb2761_4a32fe5f","line":502,"in_reply_to":"dfeb2761_d943a512","updated":"2017-04-05 11:14:14.000000000","message":"Thanks Walter for review.\nYes i do agree that you mentioned function can be used but here the difference is we also need to compare both the hosts and return the prioritized list. Hence we created a new function _get_prioritized_host_on_3par.","commit_id":"2dd6484458d5ee1f1311665abcc8d66a21af6594"}],"cinder/volume/drivers/hpe/hpe_3par_iscsi.py":[{"author":{"_account_id":21406,"name":"Vijay Ladani","email":"vijay.ladani@hpe.com","username":"vladani"},"change_message_id":"f756e8173d19d9362821e46d4af49249356115aa","unresolved":false,"context_lines":[{"line_number":610,"context_line":"                              {\u0027hosts\u0027: hosts[\u0027members\u0027][0][\u0027name\u0027],"},{"line_number":611,"context_line":"                               \u0027host\u0027: hostname})"},{"line_number":612,"context_line":"                    hostname \u003d hosts[\u0027members\u0027][0][\u0027name\u0027]"},{"line_number":613,"context_line":"                    host \u003d common._get_3par_host(hosts[\u0027members\u0027][0][\u0027name\u0027])"},{"line_number":614,"context_line":"        except hpeexceptions.HTTPNotFound:"},{"line_number":615,"context_line":"            # get persona from the volume type extra specs"},{"line_number":616,"context_line":"            persona_id \u003d common.get_persona_type(volume)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_94d6d9c3","line":613,"range":{"start_line":613,"start_character":49,"end_line":613,"end_character":76},"updated":"2016-12-13 11:11:38.000000000","message":"should use \u0027hostname\u0027 as available in previous statement.","commit_id":"86ea2d0ccef916950dd3352662de2b5e6ef187c4"},{"author":{"_account_id":23113,"name":"Hariprasad S Venkatasubramanian","email":"hari.venkat@hpe.com","username":"hari.venkat"},"change_message_id":"869263096cf24ce8242a2eb4926d1e76755632f3","unresolved":false,"context_lines":[{"line_number":610,"context_line":"                              {\u0027hosts\u0027: hosts[\u0027members\u0027][0][\u0027name\u0027],"},{"line_number":611,"context_line":"                               \u0027host\u0027: hostname})"},{"line_number":612,"context_line":"                    hostname \u003d hosts[\u0027members\u0027][0][\u0027name\u0027]"},{"line_number":613,"context_line":"                    host \u003d common._get_3par_host(hosts[\u0027members\u0027][0][\u0027name\u0027])"},{"line_number":614,"context_line":"        except hpeexceptions.HTTPNotFound:"},{"line_number":615,"context_line":"            # get persona from the volume type extra specs"},{"line_number":616,"context_line":"            persona_id \u003d common.get_persona_type(volume)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a430d35_b1e80b12","line":613,"range":{"start_line":613,"start_character":49,"end_line":613,"end_character":76},"in_reply_to":"1a430d35_40d2b7d3","updated":"2017-02-06 08:18:46.000000000","message":"@Kushal, the way I interpreted Vijay\u0027s comment here is to revise this line of code as follows: \n\nhost \u003d common._get_3par_host(hostname)\n\nIt is about variable re-use and not calling the method _get_3par_host(), which you have already taken care.\n\nPlease do the needful.","commit_id":"86ea2d0ccef916950dd3352662de2b5e6ef187c4"},{"author":{"_account_id":21407,"name":"Kushal Wathore","email":"kushal.wathore@hpe.com","username":"kwathore"},"change_message_id":"737d2f01c805a545bc4a89c5a3f738e2ef1bbbcd","unresolved":false,"context_lines":[{"line_number":610,"context_line":"                              {\u0027hosts\u0027: hosts[\u0027members\u0027][0][\u0027name\u0027],"},{"line_number":611,"context_line":"                               \u0027host\u0027: hostname})"},{"line_number":612,"context_line":"                    hostname \u003d hosts[\u0027members\u0027][0][\u0027name\u0027]"},{"line_number":613,"context_line":"                    host \u003d common._get_3par_host(hosts[\u0027members\u0027][0][\u0027name\u0027])"},{"line_number":614,"context_line":"        except hpeexceptions.HTTPNotFound:"},{"line_number":615,"context_line":"            # get persona from the volume type extra specs"},{"line_number":616,"context_line":"            persona_id \u003d common.get_persona_type(volume)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a430d35_368411d3","line":613,"range":{"start_line":613,"start_character":49,"end_line":613,"end_character":76},"in_reply_to":"1a430d35_40d2b7d3","updated":"2017-02-06 07:59:31.000000000","message":"have called _get_3par_host of common file using \"hosts[\u0027members\u0027][0][\u0027name\u0027]\" to keep similar calling in both \"hpe_3par_iscsi\" and \"hpe_3par_fc\" files.","commit_id":"86ea2d0ccef916950dd3352662de2b5e6ef187c4"},{"author":{"_account_id":23113,"name":"Hariprasad S Venkatasubramanian","email":"hari.venkat@hpe.com","username":"hari.venkat"},"change_message_id":"c8a9446d6f72f371bcbf1de93ab70f739ac8855f","unresolved":false,"context_lines":[{"line_number":610,"context_line":"                              {\u0027hosts\u0027: hosts[\u0027members\u0027][0][\u0027name\u0027],"},{"line_number":611,"context_line":"                               \u0027host\u0027: hostname})"},{"line_number":612,"context_line":"                    hostname \u003d hosts[\u0027members\u0027][0][\u0027name\u0027]"},{"line_number":613,"context_line":"                    host \u003d common._get_3par_host(hosts[\u0027members\u0027][0][\u0027name\u0027])"},{"line_number":614,"context_line":"        except hpeexceptions.HTTPNotFound:"},{"line_number":615,"context_line":"            # get persona from the volume type extra specs"},{"line_number":616,"context_line":"            persona_id \u003d common.get_persona_type(volume)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a430d35_40d2b7d3","line":613,"range":{"start_line":613,"start_character":49,"end_line":613,"end_character":76},"in_reply_to":"1a6eadb0_94d6d9c3","updated":"2017-02-06 06:55:39.000000000","message":"+1","commit_id":"86ea2d0ccef916950dd3352662de2b5e6ef187c4"},{"author":{"_account_id":23113,"name":"Hariprasad S Venkatasubramanian","email":"hari.venkat@hpe.com","username":"hari.venkat"},"change_message_id":"e6d47874b72f2f51c5d1ffab9b4f9576ac3871ee","unresolved":false,"context_lines":[{"line_number":595,"context_line":"                vol_name, CHAP_PASS_KEY)[\u0027value\u0027]"},{"line_number":596,"context_line":""},{"line_number":597,"context_line":"        try:"},{"line_number":598,"context_line":"            host \u003d common._get_3par_host(hostname)"},{"line_number":599,"context_line":"            # Check whether host with iqn of initiator present on 3par"},{"line_number":600,"context_line":"            hosts \u003d common.client.queryHost(iqns\u003d[connector[\u0027initiator\u0027]])"},{"line_number":601,"context_line":"            if hosts and hosts[\u0027members\u0027] and \u0027name\u0027 in hosts[\u0027members\u0027][0]:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a430d35_5e6b41f1","line":598,"range":{"start_line":598,"start_character":12,"end_line":598,"end_character":16},"updated":"2017-02-07 05:30:27.000000000","message":"moving this host record retrieval based on hostname to the \"else\" part of the if loop below should save a WSAPI call to 3PAR.\n\nif hosts and hosts[\u0027members\u0027] and \u0027name\u0027 in hosts[\u0027members\u0027][0]:\n    hostname \u003d hosts[\u0027members\u0027][0][\u0027name\u0027]\n    ...\n    host \u003d common._get_3par_host(hostname)\nelse:\n    host \u003d common._get_3par_host(hostname)","commit_id":"47e7301f31508c7e49f6589883f172573ddbdfbf"},{"author":{"_account_id":21407,"name":"Kushal Wathore","email":"kushal.wathore@hpe.com","username":"kwathore"},"change_message_id":"1f3ae39cb7f8574de900e726c6250d30800f1dfb","unresolved":false,"context_lines":[{"line_number":595,"context_line":"                vol_name, CHAP_PASS_KEY)[\u0027value\u0027]"},{"line_number":596,"context_line":""},{"line_number":597,"context_line":"        try:"},{"line_number":598,"context_line":"            host \u003d common._get_3par_host(hostname)"},{"line_number":599,"context_line":"            # Check whether host with iqn of initiator present on 3par"},{"line_number":600,"context_line":"            hosts \u003d common.client.queryHost(iqns\u003d[connector[\u0027initiator\u0027]])"},{"line_number":601,"context_line":"            if hosts and hosts[\u0027members\u0027] and \u0027name\u0027 in hosts[\u0027members\u0027][0]:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a430d35_81446e1b","line":598,"range":{"start_line":598,"start_character":12,"end_line":598,"end_character":16},"in_reply_to":"1a430d35_5e6b41f1","updated":"2017-02-07 13:19:55.000000000","message":"I got your concern but we are using attribute of host in \"if\" loop, so we need host attribute in \"if\" loop","commit_id":"47e7301f31508c7e49f6589883f172573ddbdfbf"},{"author":{"_account_id":23113,"name":"Hariprasad S Venkatasubramanian","email":"hari.venkat@hpe.com","username":"hari.venkat"},"change_message_id":"a5877ebc8999fca6043055afb5ccc9aae256f28f","unresolved":false,"context_lines":[{"line_number":609,"context_line":"                              \"of Hostname: %(host)s\","},{"line_number":610,"context_line":"                              {\u0027hosts\u0027: hosts[\u0027members\u0027][0][\u0027name\u0027],"},{"line_number":611,"context_line":"                               \u0027host\u0027: hostname})"},{"line_number":612,"context_line":"                    hostname \u003d hosts[\u0027members\u0027][0][\u0027name\u0027]"},{"line_number":613,"context_line":"                    host \u003d common._get_3par_host(hostname)"},{"line_number":614,"context_line":"        except hpeexceptions.HTTPNotFound:"},{"line_number":615,"context_line":"            # get persona from the volume type extra specs"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a430d35_dba82323","line":612,"range":{"start_line":612,"start_character":20,"end_line":612,"end_character":58},"updated":"2017-02-07 05:11:55.000000000","message":"please promote this assignment up the order and re-use it as much:\n\nif hosts and hosts[\u0027members\u0027] and \u0027name\u0027 in hosts[\u0027members\u0027][0]:\n    hostname \u003d hosts[\u0027members\u0027][0][\u0027name\u0027]\n    ...\n    if str(host[\u0027name\u0027]) !\u003d str(hostname):\n        ...","commit_id":"47e7301f31508c7e49f6589883f172573ddbdfbf"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"db603288faae767451c75fb33d4879bfdbb9cedb","unresolved":false,"context_lines":[{"line_number":604,"context_line":"                # if they do not match it means 3par has a pre-existing host"},{"line_number":605,"context_line":"                # with some other name."},{"line_number":606,"context_line":"                hostname \u003d hosts[\u0027members\u0027][0][\u0027name\u0027]"},{"line_number":607,"context_line":"                if str(host[\u0027name\u0027]) !\u003d str(hostname):"},{"line_number":608,"context_line":"                    LOG.debug(\"Prioritize the host retrieved from iqn.\""},{"line_number":609,"context_line":"                              \"Hostname : %(hosts)s  is used instead\""},{"line_number":610,"context_line":"                              \"of Hostname: %(host)s\","}],"source_content_type":"text/x-python","patch_set":3,"id":"1a430d35_1ad6c54e","line":607,"range":{"start_line":607,"start_character":19,"end_line":607,"end_character":22},"updated":"2017-02-08 22:10:43.000000000","message":"Same comments as previous file.","commit_id":"662609c225beb2047e56bbdd0590ce9b05be3a06"},{"author":{"_account_id":21407,"name":"Kushal Wathore","email":"kushal.wathore@hpe.com","username":"kwathore"},"change_message_id":"6d0bfa9c555c0d51449dde4866fa5464d1951d72","unresolved":false,"context_lines":[{"line_number":604,"context_line":"                # if they do not match it means 3par has a pre-existing host"},{"line_number":605,"context_line":"                # with some other name."},{"line_number":606,"context_line":"                hostname \u003d hosts[\u0027members\u0027][0][\u0027name\u0027]"},{"line_number":607,"context_line":"                if str(host[\u0027name\u0027]) !\u003d str(hostname):"},{"line_number":608,"context_line":"                    LOG.debug(\"Prioritize the host retrieved from iqn.\""},{"line_number":609,"context_line":"                              \"Hostname : %(hosts)s  is used instead\""},{"line_number":610,"context_line":"                              \"of Hostname: %(host)s\","}],"source_content_type":"text/x-python","patch_set":3,"id":"1a430d35_ec65b944","line":607,"range":{"start_line":607,"start_character":19,"end_line":607,"end_character":22},"in_reply_to":"1a430d35_1ad6c54e","updated":"2017-02-09 08:39:31.000000000","message":"Done","commit_id":"662609c225beb2047e56bbdd0590ce9b05be3a06"},{"author":{"_account_id":23113,"name":"Hariprasad S Venkatasubramanian","email":"hari.venkat@hpe.com","username":"hari.venkat"},"change_message_id":"03582a260e6a938e00c9f876c4b2bd6e1250dfcd","unresolved":false,"context_lines":[{"line_number":605,"context_line":"                # with some other name."},{"line_number":606,"context_line":"                hostname \u003d hosts[\u0027members\u0027][0][\u0027name\u0027]"},{"line_number":607,"context_line":"                if host[\u0027name\u0027] !\u003d hostname:"},{"line_number":608,"context_line":"                    LOG.debug(\"Prioritize the host retrieved from iqn. \""},{"line_number":609,"context_line":"                              \"Hostname : %(hosts)s  is used instead \""},{"line_number":610,"context_line":"                              \"of Hostname: %(host)s\","},{"line_number":611,"context_line":"                              {\u0027hosts\u0027: hosts[\u0027members\u0027][0][\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa31d9ce_c3cf3327","line":608,"range":{"start_line":608,"start_character":24,"end_line":608,"end_character":29},"updated":"2017-02-14 11:07:18.000000000","message":"Please make this as LOG.info()","commit_id":"c6ab1b71ca6166ca14786cd280cbfdf5fc626843"},{"author":{"_account_id":21407,"name":"Kushal Wathore","email":"kushal.wathore@hpe.com","username":"kwathore"},"change_message_id":"776b7277987a124d913326b3ab5c4ff625d24e73","unresolved":false,"context_lines":[{"line_number":605,"context_line":"                # with some other name."},{"line_number":606,"context_line":"                hostname \u003d hosts[\u0027members\u0027][0][\u0027name\u0027]"},{"line_number":607,"context_line":"                if host[\u0027name\u0027] !\u003d hostname:"},{"line_number":608,"context_line":"                    LOG.debug(\"Prioritize the host retrieved from iqn. \""},{"line_number":609,"context_line":"                              \"Hostname : %(hosts)s  is used instead \""},{"line_number":610,"context_line":"                              \"of Hostname: %(host)s\","},{"line_number":611,"context_line":"                              {\u0027hosts\u0027: hosts[\u0027members\u0027][0][\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa31d9ce_f4606f03","line":608,"range":{"start_line":608,"start_character":24,"end_line":608,"end_character":29},"in_reply_to":"fa31d9ce_c3cf3327","updated":"2017-02-14 12:18:13.000000000","message":"Done","commit_id":"c6ab1b71ca6166ca14786cd280cbfdf5fc626843"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"fdf21218e64cf2b309003e2f9f4682fb41863b4a","unresolved":false,"context_lines":[{"line_number":598,"context_line":"            host \u003d common._get_3par_host(hostname)"},{"line_number":599,"context_line":"            # Check whether host with iqn of initiator present on 3par"},{"line_number":600,"context_line":"            hosts \u003d common.client.queryHost(iqns\u003d[connector[\u0027initiator\u0027]])"},{"line_number":601,"context_line":"            host_exist \u003d common._check_pre_existing_host_on_3par(host, hosts)"},{"line_number":602,"context_line":"            if host_exist:"},{"line_number":603,"context_line":"                hostname \u003d hosts[\u0027members\u0027][0][\u0027name\u0027]"},{"line_number":604,"context_line":"                host \u003d common._get_3par_host(hostname)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa31d9ce_47259608","line":601,"range":{"start_line":601,"start_character":12,"end_line":601,"end_character":22},"updated":"2017-02-16 15:53:31.000000000","message":"host_exists","commit_id":"0e282ee1c9658df17ce02bbcc0a811888f2b2499"},{"author":{"_account_id":21407,"name":"Kushal Wathore","email":"kushal.wathore@hpe.com","username":"kwathore"},"change_message_id":"b47b167bc0894624a571b219a80999f0ab76a02d","unresolved":false,"context_lines":[{"line_number":598,"context_line":"            host \u003d common._get_3par_host(hostname)"},{"line_number":599,"context_line":"            # Check whether host with iqn of initiator present on 3par"},{"line_number":600,"context_line":"            hosts \u003d common.client.queryHost(iqns\u003d[connector[\u0027initiator\u0027]])"},{"line_number":601,"context_line":"            host_exist \u003d common._check_pre_existing_host_on_3par(host, hosts)"},{"line_number":602,"context_line":"            if host_exist:"},{"line_number":603,"context_line":"                hostname \u003d hosts[\u0027members\u0027][0][\u0027name\u0027]"},{"line_number":604,"context_line":"                host \u003d common._get_3par_host(hostname)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa31d9ce_ed082bdc","line":601,"range":{"start_line":601,"start_character":12,"end_line":601,"end_character":22},"in_reply_to":"fa31d9ce_47259608","updated":"2017-02-16 16:33:04.000000000","message":"Done","commit_id":"0e282ee1c9658df17ce02bbcc0a811888f2b2499"},{"author":{"_account_id":21406,"name":"Vijay Ladani","email":"vijay.ladani@hpe.com","username":"vladani"},"change_message_id":"13d2146695036d8d27d47031797cb0778a923fc7","unresolved":false,"context_lines":[{"line_number":596,"context_line":""},{"line_number":597,"context_line":"        try:"},{"line_number":598,"context_line":"            host \u003d common._get_3par_host(hostname)"},{"line_number":599,"context_line":"            # Check whether host with iqn of initiator present on 3par"},{"line_number":600,"context_line":"            hosts \u003d common.client.queryHost(iqns\u003d[connector[\u0027initiator\u0027]])"},{"line_number":601,"context_line":"            host_exist \u003d common._check_pre_existing_host_on_3par(host, hosts)"},{"line_number":602,"context_line":"            if host_exist:"},{"line_number":603,"context_line":"                hostname \u003d hosts[\u0027members\u0027][0][\u0027name\u0027]"},{"line_number":604,"context_line":"                host \u003d common._get_3par_host(hostname)"},{"line_number":605,"context_line":"        except hpeexceptions.HTTPNotFound:"},{"line_number":606,"context_line":"            # get persona from the volume type extra specs"},{"line_number":607,"context_line":"            persona_id \u003d common.get_persona_type(volume)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa31d9ce_bea4b1b9","line":604,"range":{"start_line":599,"start_character":0,"end_line":604,"end_character":54},"updated":"2017-02-16 10:01:52.000000000","message":"same here too","commit_id":"0e282ee1c9658df17ce02bbcc0a811888f2b2499"},{"author":{"_account_id":23113,"name":"Hariprasad S Venkatasubramanian","email":"hari.venkat@hpe.com","username":"hari.venkat"},"change_message_id":"36c9f2a746237cbf52db71c6ce6ff4e04addd353","unresolved":false,"context_lines":[{"line_number":598,"context_line":"            host \u003d common._get_3par_host(hostname)"},{"line_number":599,"context_line":"            # Check whether host with iqn of initiator present on 3par"},{"line_number":600,"context_line":"            hosts \u003d common.client.queryHost(iqns\u003d[connector[\u0027initiator\u0027]])"},{"line_number":601,"context_line":"            host_exists \u003d common._check_pre_existing_host_on_3par(host, hosts)"},{"line_number":602,"context_line":"            if host_exists:"},{"line_number":603,"context_line":"                hostname \u003d hosts[\u0027members\u0027][0][\u0027name\u0027]"},{"line_number":604,"context_line":"                host \u003d common._get_3par_host(hostname)"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa31d9ce_7216c156","line":601,"range":{"start_line":601,"start_character":33,"end_line":601,"end_character":65},"updated":"2017-02-17 07:13:42.000000000","message":"Please consider retrieving the prioritized host record in one shot. You may push the logic to retrieve the host record into this common method and simply use the same in the driver. This would make the code read better. Rename this method to something like \"_get_prioritized_host_on_3par\"","commit_id":"3c583fdaaefc5373cdbf85433c6691b13eaf276a"},{"author":{"_account_id":21407,"name":"Kushal Wathore","email":"kushal.wathore@hpe.com","username":"kwathore"},"change_message_id":"1e7aefe33929bcdf205a6aa8a848eccc9088a5da","unresolved":false,"context_lines":[{"line_number":598,"context_line":"            host \u003d common._get_3par_host(hostname)"},{"line_number":599,"context_line":"            # Check whether host with iqn of initiator present on 3par"},{"line_number":600,"context_line":"            hosts \u003d common.client.queryHost(iqns\u003d[connector[\u0027initiator\u0027]])"},{"line_number":601,"context_line":"            host_exists \u003d common._check_pre_existing_host_on_3par(host, hosts)"},{"line_number":602,"context_line":"            if host_exists:"},{"line_number":603,"context_line":"                hostname \u003d hosts[\u0027members\u0027][0][\u0027name\u0027]"},{"line_number":604,"context_line":"                host \u003d common._get_3par_host(hostname)"}],"source_content_type":"text/x-python","patch_set":7,"id":"da36d5c6_6b7c1973","line":601,"range":{"start_line":601,"start_character":33,"end_line":601,"end_character":65},"in_reply_to":"fa31d9ce_7216c156","updated":"2017-02-20 12:21:24.000000000","message":"Done","commit_id":"3c583fdaaefc5373cdbf85433c6691b13eaf276a"}]}