)]}'
{"cinder/volume/drivers/hpe/hpe_3par_common.py":[{"author":{"_account_id":23100,"name":"Swapnil Nilangekar","email":"swapnil.sun.nilangekar@hpe.com","username":"swapnil-nilangekar"},"change_message_id":"87e59fb2e3f9be8c6878d8b2f58011a5116ec93e","unresolved":false,"context_lines":[{"line_number":2877,"context_line":"            if old_volume_size \u003c 16384:"},{"line_number":2878,"context_line":"                if((new_tpvv | new_tdvv) and new_compressed):"},{"line_number":2879,"context_line":"                    err \u003d (\"\\nError: To enable compression on tpvv or\""},{"line_number":2880,"context_line":"                           \"tdvv old volume size should be atleast 16 GiB\\n\")"},{"line_number":2881,"context_line":"                    LOG.error(err)"},{"line_number":2882,"context_line":"                    raise exception.InvalidInput(reason\u003derr)"},{"line_number":2883,"context_line":"        LOG.debug(\"retype old_volume_info\u003d%s\", old_volume_info)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5201f7_ec7ef917","line":2880,"range":{"start_line":2880,"start_character":37,"end_line":2880,"end_character":43},"updated":"2017-01-05 08:15:56.000000000","message":"remove old","commit_id":"13906776d196cacf6427a20ed2f2971f6be1e817"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"f3cab93945983b9ac6672b9caf9431c7986b6a10","unresolved":false,"context_lines":[{"line_number":248,"context_line":""},{"line_number":249,"context_line":"    \"\"\""},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"    VERSION \u003d \"3.0.26\""},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    stats \u003d {}"},{"line_number":254,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a461143_28c65f48","line":251,"updated":"2017-01-27 06:50:42.000000000","message":"this version should be bumped because this is a new feature.","commit_id":"a2690b30fcbb650e07eeb7b122d48addc4c7373a"},{"author":{"_account_id":23100,"name":"Swapnil Nilangekar","email":"swapnil.sun.nilangekar@hpe.com","username":"swapnil-nilangekar"},"change_message_id":"a0c55f8f9d8e3d985414ce17f104c4e7dcca16a6","unresolved":false,"context_lines":[{"line_number":248,"context_line":""},{"line_number":249,"context_line":"    \"\"\""},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"    VERSION \u003d \"3.0.26\""},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    stats \u003d {}"},{"line_number":254,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a461143_1c48012d","line":251,"in_reply_to":"3a461143_28c65f48","updated":"2017-01-27 09:40:40.000000000","message":"Updated the version in patch set 6","commit_id":"a2690b30fcbb650e07eeb7b122d48addc4c7373a"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"cc286d48ba74f09b3b6b1a6d1ae7448fe1d7c199","unresolved":false,"context_lines":[{"line_number":1610,"context_line":"                         \"WSAPI version \u0027%(compression_version)s\u0027 \""},{"line_number":1611,"context_line":"                         \"version \u0027%(version)s\u0027 is installed.\") %"},{"line_number":1612,"context_line":"                       {\u0027compression_version\u0027: COMPRESS_API_VERSION,"},{"line_number":1613,"context_line":"                        \u0027version\u0027: self.API_VERSION})"},{"line_number":1614,"context_line":"                LOG.error(err)"},{"line_number":1615,"context_line":"                raise exception.InvalidInput(reason\u003derr)"},{"line_number":1616,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a1ced50_ae5ed673","line":1613,"updated":"2017-03-20 18:01:51.000000000","message":"Do you also have to make sure the current licensing supports this feature too?  The feature might be available in the firmware, but not enabled due to licensing.","commit_id":"360633f5acdc391da5f497992bf33d5757bc0925"},{"author":{"_account_id":23100,"name":"Swapnil Nilangekar","email":"swapnil.sun.nilangekar@hpe.com","username":"swapnil-nilangekar"},"change_message_id":"9baf82d9b68c0ff279e03acb2299e545809b39dd","unresolved":false,"context_lines":[{"line_number":1610,"context_line":"                         \"WSAPI version \u0027%(compression_version)s\u0027 \""},{"line_number":1611,"context_line":"                         \"version \u0027%(version)s\u0027 is installed.\") %"},{"line_number":1612,"context_line":"                       {\u0027compression_version\u0027: COMPRESS_API_VERSION,"},{"line_number":1613,"context_line":"                        \u0027version\u0027: self.API_VERSION})"},{"line_number":1614,"context_line":"                LOG.error(err)"},{"line_number":1615,"context_line":"                raise exception.InvalidInput(reason\u003derr)"},{"line_number":1616,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a1ced50_9184dbd4","line":1613,"in_reply_to":"1a1ced50_ae5ed673","updated":"2017-04-04 08:46:08.000000000","message":"Thank you Walter for your comment.\nWhen inform OS 3.3.1 is installed on 3PAR array and presence of a compression license means you can create compressed volume on that array. On array that supports compression, the license will be enabled in 3.3.1.\n\nHence it is needed to check the presence of license in 3PAR.\n\nThis has been addressed in patch set 9","commit_id":"360633f5acdc391da5f497992bf33d5757bc0925"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"72ba17e8e89f7b8dd6aa7908052d01ce9c755637","unresolved":false,"context_lines":[{"line_number":1626,"context_line":"                       {\u0027compression_version\u0027: COMPRESS_API_VERSION,"},{"line_number":1627,"context_line":"                        \u0027version\u0027: self.API_VERSION})"},{"line_number":1628,"context_line":"                LOG.error(err)"},{"line_number":1629,"context_line":"                raise exception.InvalidInput(reason\u003derr)"},{"line_number":1630,"context_line":"            else:"},{"line_number":1631,"context_line":"                if val.lower() \u003d\u003d \u0027true\u0027:"},{"line_number":1632,"context_line":"                    if not compression_support:"}],"source_content_type":"text/x-python","patch_set":9,"id":"dfeb2761_7ae5b808","line":1629,"range":{"start_line":1629,"start_character":22,"end_line":1629,"end_character":56},"updated":"2017-04-04 15:06:06.000000000","message":"Seems like this should be a backend API error instead of invalid input.","commit_id":"88fedf16bb905e0f6fa482bc22548ac6b1abfed2"},{"author":{"_account_id":23100,"name":"Swapnil Nilangekar","email":"swapnil.sun.nilangekar@hpe.com","username":"swapnil-nilangekar"},"change_message_id":"98da8aebb035bff4a9613309bace3c8b1806dfe0","unresolved":false,"context_lines":[{"line_number":1626,"context_line":"                       {\u0027compression_version\u0027: COMPRESS_API_VERSION,"},{"line_number":1627,"context_line":"                        \u0027version\u0027: self.API_VERSION})"},{"line_number":1628,"context_line":"                LOG.error(err)"},{"line_number":1629,"context_line":"                raise exception.InvalidInput(reason\u003derr)"},{"line_number":1630,"context_line":"            else:"},{"line_number":1631,"context_line":"                if val.lower() \u003d\u003d \u0027true\u0027:"},{"line_number":1632,"context_line":"                    if not compression_support:"}],"source_content_type":"text/x-python","patch_set":9,"id":"bff0334d_90ab20d5","line":1629,"range":{"start_line":1629,"start_character":22,"end_line":1629,"end_character":56},"in_reply_to":"dfeb2761_7ae5b808","updated":"2017-04-06 07:16:27.000000000","message":"Here i am trying to maintain the consistant behaviour with feature implementation of get_flash_cache_policy.\n\nAs we are not making any backend call here to check the API version, i have kept it as InvalidInput exception","commit_id":"88fedf16bb905e0f6fa482bc22548ac6b1abfed2"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"72ba17e8e89f7b8dd6aa7908052d01ce9c755637","unresolved":false,"context_lines":[{"line_number":1630,"context_line":"            else:"},{"line_number":1631,"context_line":"                if val.lower() \u003d\u003d \u0027true\u0027:"},{"line_number":1632,"context_line":"                    if not compression_support:"},{"line_number":1633,"context_line":"                        msg \u003d _(\u0027compression is not supported on\u0027"},{"line_number":1634,"context_line":"                                \u0027 underlying hardware\u0027)"},{"line_number":1635,"context_line":"                        LOG.error(msg)"},{"line_number":1636,"context_line":"                        raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":1637,"context_line":"                    return True"}],"source_content_type":"text/x-python","patch_set":9,"id":"dfeb2761_1a910c48","line":1634,"range":{"start_line":1633,"start_character":33,"end_line":1634,"end_character":53},"updated":"2017-04-04 15:06:06.000000000","message":"Should start with a capital \u0027C\u0027 and end with a period.  Also, for consistency please put the space at the end of the first line.  Thanks!","commit_id":"88fedf16bb905e0f6fa482bc22548ac6b1abfed2"},{"author":{"_account_id":23100,"name":"Swapnil Nilangekar","email":"swapnil.sun.nilangekar@hpe.com","username":"swapnil-nilangekar"},"change_message_id":"98da8aebb035bff4a9613309bace3c8b1806dfe0","unresolved":false,"context_lines":[{"line_number":1630,"context_line":"            else:"},{"line_number":1631,"context_line":"                if val.lower() \u003d\u003d \u0027true\u0027:"},{"line_number":1632,"context_line":"                    if not compression_support:"},{"line_number":1633,"context_line":"                        msg \u003d _(\u0027compression is not supported on\u0027"},{"line_number":1634,"context_line":"                                \u0027 underlying hardware\u0027)"},{"line_number":1635,"context_line":"                        LOG.error(msg)"},{"line_number":1636,"context_line":"                        raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":1637,"context_line":"                    return True"}],"source_content_type":"text/x-python","patch_set":9,"id":"bff0334d_d0f768f5","line":1634,"range":{"start_line":1633,"start_character":33,"end_line":1634,"end_character":53},"in_reply_to":"dfeb2761_1a910c48","updated":"2017-04-06 07:16:27.000000000","message":"Done","commit_id":"88fedf16bb905e0f6fa482bc22548ac6b1abfed2"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"72ba17e8e89f7b8dd6aa7908052d01ce9c755637","unresolved":false,"context_lines":[{"line_number":2894,"context_line":"        # if we trust that all the volume type settings are still the"},{"line_number":2895,"context_line":"        # same settings that were used with this volume."},{"line_number":2896,"context_line":"        old_volume_info \u003d self.client.getVolume(volume_name)"},{"line_number":2897,"context_line":""},{"line_number":2898,"context_line":"        old_tpvv \u003d old_volume_info[\u0027provisioningType\u0027] \u003d\u003d self.THIN"},{"line_number":2899,"context_line":"        old_tdvv \u003d old_volume_info[\u0027provisioningType\u0027] \u003d\u003d self.DEDUP"},{"line_number":2900,"context_line":"        old_cpg \u003d old_volume_info[\u0027userCPG\u0027]"}],"source_content_type":"text/x-python","patch_set":9,"id":"dfeb2761_fabe68b2","line":2897,"updated":"2017-04-04 15:06:06.000000000","message":"Why the extra spaces here?","commit_id":"88fedf16bb905e0f6fa482bc22548ac6b1abfed2"},{"author":{"_account_id":23100,"name":"Swapnil Nilangekar","email":"swapnil.sun.nilangekar@hpe.com","username":"swapnil-nilangekar"},"change_message_id":"9be1d49f18e3a6216162efdd1c098fb0bb7b2820","unresolved":false,"context_lines":[{"line_number":2894,"context_line":"        # if we trust that all the volume type settings are still the"},{"line_number":2895,"context_line":"        # same settings that were used with this volume."},{"line_number":2896,"context_line":"        old_volume_info \u003d self.client.getVolume(volume_name)"},{"line_number":2897,"context_line":""},{"line_number":2898,"context_line":"        old_tpvv \u003d old_volume_info[\u0027provisioningType\u0027] \u003d\u003d self.THIN"},{"line_number":2899,"context_line":"        old_tdvv \u003d old_volume_info[\u0027provisioningType\u0027] \u003d\u003d self.DEDUP"},{"line_number":2900,"context_line":"        old_cpg \u003d old_volume_info[\u0027userCPG\u0027]"}],"source_content_type":"text/x-python","patch_set":9,"id":"bff0334d_d0b648da","line":2897,"in_reply_to":"dfeb2761_fabe68b2","updated":"2017-04-06 07:32:41.000000000","message":"Done in patch set 12","commit_id":"88fedf16bb905e0f6fa482bc22548ac6b1abfed2"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"1490865dd6e121d095a16cdcc4abe2ae7594dd87","unresolved":false,"context_lines":[{"line_number":74,"context_line":"MIN_CLIENT_VERSION \u003d \u00274.2.0\u0027"},{"line_number":75,"context_line":"DEDUP_API_VERSION \u003d 30201120"},{"line_number":76,"context_line":"FLASH_CACHE_API_VERSION \u003d 30201200"},{"line_number":77,"context_line":"COMPRESS_API_VERSION \u003d 30301215"},{"line_number":78,"context_line":"SRSTATLD_API_VERSION \u003d 30201200"},{"line_number":79,"context_line":"REMOTE_COPY_API_VERSION \u003d 30202290"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"bff0334d_491815d2","line":77,"updated":"2017-04-07 14:15:13.000000000","message":"COMPRESSION_API_VERSION","commit_id":"5a18ad55ae48e1c1ba785f64f97828e967b2ad0f"},{"author":{"_account_id":23100,"name":"Swapnil Nilangekar","email":"swapnil.sun.nilangekar@hpe.com","username":"swapnil-nilangekar"},"change_message_id":"e521d12f3cd3e7acfda9a6b938f82ff3a68a9c30","unresolved":false,"context_lines":[{"line_number":74,"context_line":"MIN_CLIENT_VERSION \u003d \u00274.2.0\u0027"},{"line_number":75,"context_line":"DEDUP_API_VERSION \u003d 30201120"},{"line_number":76,"context_line":"FLASH_CACHE_API_VERSION \u003d 30201200"},{"line_number":77,"context_line":"COMPRESS_API_VERSION \u003d 30301215"},{"line_number":78,"context_line":"SRSTATLD_API_VERSION \u003d 30201200"},{"line_number":79,"context_line":"REMOTE_COPY_API_VERSION \u003d 30202290"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"bff0334d_fefaa840","line":77,"in_reply_to":"bff0334d_491815d2","updated":"2017-04-11 10:24:10.000000000","message":"Done in patch set 17","commit_id":"5a18ad55ae48e1c1ba785f64f97828e967b2ad0f"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"1490865dd6e121d095a16cdcc4abe2ae7594dd87","unresolved":false,"context_lines":[{"line_number":310,"context_line":"                    \u0027priority\u0027]"},{"line_number":311,"context_line":"    qos_priority_level \u003d {\u0027low\u0027: 1, \u0027normal\u0027: 2, \u0027high\u0027: 3}"},{"line_number":312,"context_line":"    hpe3par_valid_keys \u003d [\u0027cpg\u0027, \u0027snap_cpg\u0027, \u0027provisioning\u0027, \u0027persona\u0027, \u0027vvs\u0027,"},{"line_number":313,"context_line":"                          \u0027flash_cache\u0027, \u0027compressing\u0027]"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"    def __init__(self, config, active_backend_id\u003dNone):"},{"line_number":316,"context_line":"        self.config \u003d config"}],"source_content_type":"text/x-python","patch_set":12,"id":"bff0334d_49937550","line":313,"updated":"2017-04-07 14:15:13.000000000","message":"shouldn\u0027t this be \u0027compression\u0027  ?","commit_id":"5a18ad55ae48e1c1ba785f64f97828e967b2ad0f"},{"author":{"_account_id":23100,"name":"Swapnil Nilangekar","email":"swapnil.sun.nilangekar@hpe.com","username":"swapnil-nilangekar"},"change_message_id":"e521d12f3cd3e7acfda9a6b938f82ff3a68a9c30","unresolved":false,"context_lines":[{"line_number":310,"context_line":"                    \u0027priority\u0027]"},{"line_number":311,"context_line":"    qos_priority_level \u003d {\u0027low\u0027: 1, \u0027normal\u0027: 2, \u0027high\u0027: 3}"},{"line_number":312,"context_line":"    hpe3par_valid_keys \u003d [\u0027cpg\u0027, \u0027snap_cpg\u0027, \u0027provisioning\u0027, \u0027persona\u0027, \u0027vvs\u0027,"},{"line_number":313,"context_line":"                          \u0027flash_cache\u0027, \u0027compressing\u0027]"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"    def __init__(self, config, active_backend_id\u003dNone):"},{"line_number":316,"context_line":"        self.config \u003d config"}],"source_content_type":"text/x-python","patch_set":12,"id":"bff0334d_be9660ef","line":313,"in_reply_to":"bff0334d_49937550","updated":"2017-04-11 10:24:10.000000000","message":"Done","commit_id":"5a18ad55ae48e1c1ba785f64f97828e967b2ad0f"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"1490865dd6e121d095a16cdcc4abe2ae7594dd87","unresolved":false,"context_lines":[{"line_number":1605,"context_line":""},{"line_number":1606,"context_line":"        return None"},{"line_number":1607,"context_line":""},{"line_number":1608,"context_line":"    def get_compressed_policy(self, hpe3par_keys):"},{"line_number":1609,"context_line":"        if hpe3par_keys is not None:"},{"line_number":1610,"context_line":"            # here it should return true/false/None"},{"line_number":1611,"context_line":"            val \u003d self._get_key_value(hpe3par_keys, \u0027compressing\u0027, None)"}],"source_content_type":"text/x-python","patch_set":12,"id":"bff0334d_09b68dda","line":1608,"updated":"2017-04-07 14:15:13.000000000","message":"get_compression_policy()","commit_id":"5a18ad55ae48e1c1ba785f64f97828e967b2ad0f"},{"author":{"_account_id":23100,"name":"Swapnil Nilangekar","email":"swapnil.sun.nilangekar@hpe.com","username":"swapnil-nilangekar"},"change_message_id":"e521d12f3cd3e7acfda9a6b938f82ff3a68a9c30","unresolved":false,"context_lines":[{"line_number":1605,"context_line":""},{"line_number":1606,"context_line":"        return None"},{"line_number":1607,"context_line":""},{"line_number":1608,"context_line":"    def get_compressed_policy(self, hpe3par_keys):"},{"line_number":1609,"context_line":"        if hpe3par_keys is not None:"},{"line_number":1610,"context_line":"            # here it should return true/false/None"},{"line_number":1611,"context_line":"            val \u003d self._get_key_value(hpe3par_keys, \u0027compressing\u0027, None)"}],"source_content_type":"text/x-python","patch_set":12,"id":"bff0334d_1e878cb7","line":1608,"in_reply_to":"bff0334d_09b68dda","updated":"2017-04-11 10:24:10.000000000","message":"Done","commit_id":"5a18ad55ae48e1c1ba785f64f97828e967b2ad0f"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"1490865dd6e121d095a16cdcc4abe2ae7594dd87","unresolved":false,"context_lines":[{"line_number":1608,"context_line":"    def get_compressed_policy(self, hpe3par_keys):"},{"line_number":1609,"context_line":"        if hpe3par_keys is not None:"},{"line_number":1610,"context_line":"            # here it should return true/false/None"},{"line_number":1611,"context_line":"            val \u003d self._get_key_value(hpe3par_keys, \u0027compressing\u0027, None)"},{"line_number":1612,"context_line":"            compression_support \u003d False"},{"line_number":1613,"context_line":"        if val is not None:"},{"line_number":1614,"context_line":"            info \u003d self.client.getStorageSystemInfo()"}],"source_content_type":"text/x-python","patch_set":12,"id":"bff0334d_89c17d31","line":1611,"updated":"2017-04-07 14:15:13.000000000","message":"\u0027compression\u0027\n\nLet\u0027s be consistent in the use of the word throughout the code and options.","commit_id":"5a18ad55ae48e1c1ba785f64f97828e967b2ad0f"},{"author":{"_account_id":23100,"name":"Swapnil Nilangekar","email":"swapnil.sun.nilangekar@hpe.com","username":"swapnil-nilangekar"},"change_message_id":"e521d12f3cd3e7acfda9a6b938f82ff3a68a9c30","unresolved":false,"context_lines":[{"line_number":1608,"context_line":"    def get_compressed_policy(self, hpe3par_keys):"},{"line_number":1609,"context_line":"        if hpe3par_keys is not None:"},{"line_number":1610,"context_line":"            # here it should return true/false/None"},{"line_number":1611,"context_line":"            val \u003d self._get_key_value(hpe3par_keys, \u0027compressing\u0027, None)"},{"line_number":1612,"context_line":"            compression_support \u003d False"},{"line_number":1613,"context_line":"        if val is not None:"},{"line_number":1614,"context_line":"            info \u003d self.client.getStorageSystemInfo()"}],"source_content_type":"text/x-python","patch_set":12,"id":"bff0334d_9ec4bcf6","line":1611,"in_reply_to":"bff0334d_89c17d31","updated":"2017-04-11 10:24:10.000000000","message":"Done","commit_id":"5a18ad55ae48e1c1ba785f64f97828e967b2ad0f"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"1490865dd6e121d095a16cdcc4abe2ae7594dd87","unresolved":false,"context_lines":[{"line_number":1953,"context_line":"                                      provider_location\u003dself.client.id)"},{"line_number":1954,"context_line":""},{"line_number":1955,"context_line":"    def _copy_volume(self, src_name, dest_name, cpg, snap_cpg\u003dNone,"},{"line_number":1956,"context_line":"                     tpvv\u003dTrue, tdvv\u003dFalse, compress\u003dNone):"},{"line_number":1957,"context_line":"        # Virtual volume sets are not supported with the -online option"},{"line_number":1958,"context_line":"        LOG.debug(\u0027Creating clone of a volume %(src)s to %(dest)s.\u0027,"},{"line_number":1959,"context_line":"                  {\u0027src\u0027: src_name, \u0027dest\u0027: dest_name})"}],"source_content_type":"text/x-python","patch_set":12,"id":"bff0334d_2901516c","line":1956,"updated":"2017-04-07 14:15:13.000000000","message":"compression\u003dNone","commit_id":"5a18ad55ae48e1c1ba785f64f97828e967b2ad0f"},{"author":{"_account_id":23100,"name":"Swapnil Nilangekar","email":"swapnil.sun.nilangekar@hpe.com","username":"swapnil-nilangekar"},"change_message_id":"e521d12f3cd3e7acfda9a6b938f82ff3a68a9c30","unresolved":false,"context_lines":[{"line_number":1953,"context_line":"                                      provider_location\u003dself.client.id)"},{"line_number":1954,"context_line":""},{"line_number":1955,"context_line":"    def _copy_volume(self, src_name, dest_name, cpg, snap_cpg\u003dNone,"},{"line_number":1956,"context_line":"                     tpvv\u003dTrue, tdvv\u003dFalse, compress\u003dNone):"},{"line_number":1957,"context_line":"        # Virtual volume sets are not supported with the -online option"},{"line_number":1958,"context_line":"        LOG.debug(\u0027Creating clone of a volume %(src)s to %(dest)s.\u0027,"},{"line_number":1959,"context_line":"                  {\u0027src\u0027: src_name, \u0027dest\u0027: dest_name})"}],"source_content_type":"text/x-python","patch_set":12,"id":"bff0334d_3eb3709a","line":1956,"in_reply_to":"bff0334d_2901516c","updated":"2017-04-11 10:24:10.000000000","message":"Done","commit_id":"5a18ad55ae48e1c1ba785f64f97828e967b2ad0f"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"1490865dd6e121d095a16cdcc4abe2ae7594dd87","unresolved":false,"context_lines":[{"line_number":2079,"context_line":"                type_info \u003d self.get_volume_settings_from_type(volume)"},{"line_number":2080,"context_line":"                cpg \u003d type_info[\u0027cpg\u0027]"},{"line_number":2081,"context_line":""},{"line_number":2082,"context_line":"                compressed \u003d self.get_compressed_policy("},{"line_number":2083,"context_line":"                    type_info[\u0027hpe3par_keys\u0027])"},{"line_number":2084,"context_line":"                # make the 3PAR copy the contents."},{"line_number":2085,"context_line":"                # can\u0027t delete the original until the copy is done."}],"source_content_type":"text/x-python","patch_set":12,"id":"bff0334d_c9f54585","line":2082,"updated":"2017-04-07 14:15:13.000000000","message":"compression \u003d ....\n\nplease be consistent","commit_id":"5a18ad55ae48e1c1ba785f64f97828e967b2ad0f"},{"author":{"_account_id":23100,"name":"Swapnil Nilangekar","email":"swapnil.sun.nilangekar@hpe.com","username":"swapnil-nilangekar"},"change_message_id":"e521d12f3cd3e7acfda9a6b938f82ff3a68a9c30","unresolved":false,"context_lines":[{"line_number":2079,"context_line":"                type_info \u003d self.get_volume_settings_from_type(volume)"},{"line_number":2080,"context_line":"                cpg \u003d type_info[\u0027cpg\u0027]"},{"line_number":2081,"context_line":""},{"line_number":2082,"context_line":"                compressed \u003d self.get_compressed_policy("},{"line_number":2083,"context_line":"                    type_info[\u0027hpe3par_keys\u0027])"},{"line_number":2084,"context_line":"                # make the 3PAR copy the contents."},{"line_number":2085,"context_line":"                # can\u0027t delete the original until the copy is done."}],"source_content_type":"text/x-python","patch_set":12,"id":"bff0334d_be4d409b","line":2082,"in_reply_to":"bff0334d_c9f54585","updated":"2017-04-11 10:24:10.000000000","message":"Done","commit_id":"5a18ad55ae48e1c1ba785f64f97828e967b2ad0f"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"1490865dd6e121d095a16cdcc4abe2ae7594dd87","unresolved":false,"context_lines":[{"line_number":2492,"context_line":"            volume_name \u003d self._get_3par_vol_name(volume[\u0027id\u0027])"},{"line_number":2493,"context_line":"            temp_vol_name \u003d volume_name.replace(\"osv-\", \"omv-\")"},{"line_number":2494,"context_line":""},{"line_number":2495,"context_line":"            compressed \u003d self.get_compressed_policy(type_info[\u0027hpe3par_keys\u0027])"},{"line_number":2496,"context_line":"            # Create a physical copy of the volume"},{"line_number":2497,"context_line":"            task_id \u003d self._copy_volume(volume_name, temp_vol_name,"},{"line_number":2498,"context_line":"                                        cpg, cpg, type_info[\u0027tpvv\u0027],"}],"source_content_type":"text/x-python","patch_set":12,"id":"bff0334d_492ff5f5","line":2495,"updated":"2017-04-07 14:15:13.000000000","message":"compression","commit_id":"5a18ad55ae48e1c1ba785f64f97828e967b2ad0f"},{"author":{"_account_id":23100,"name":"Swapnil Nilangekar","email":"swapnil.sun.nilangekar@hpe.com","username":"swapnil-nilangekar"},"change_message_id":"e521d12f3cd3e7acfda9a6b938f82ff3a68a9c30","unresolved":false,"context_lines":[{"line_number":2492,"context_line":"            volume_name \u003d self._get_3par_vol_name(volume[\u0027id\u0027])"},{"line_number":2493,"context_line":"            temp_vol_name \u003d volume_name.replace(\"osv-\", \"omv-\")"},{"line_number":2494,"context_line":""},{"line_number":2495,"context_line":"            compressed \u003d self.get_compressed_policy(type_info[\u0027hpe3par_keys\u0027])"},{"line_number":2496,"context_line":"            # Create a physical copy of the volume"},{"line_number":2497,"context_line":"            task_id \u003d self._copy_volume(volume_name, temp_vol_name,"},{"line_number":2498,"context_line":"                                        cpg, cpg, type_info[\u0027tpvv\u0027],"}],"source_content_type":"text/x-python","patch_set":12,"id":"bff0334d_7e43386d","line":2495,"in_reply_to":"bff0334d_492ff5f5","updated":"2017-04-11 10:24:10.000000000","message":"Done","commit_id":"5a18ad55ae48e1c1ba785f64f97828e967b2ad0f"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"1490865dd6e121d095a16cdcc4abe2ae7594dd87","unresolved":false,"context_lines":[{"line_number":2684,"context_line":"        either be done or it is in a state that we need to treat as an error."},{"line_number":2685,"context_line":"        \"\"\""},{"line_number":2686,"context_line":""},{"line_number":2687,"context_line":"        compress \u003d False"},{"line_number":2688,"context_line":"        if new_compressed is not None:"},{"line_number":2689,"context_line":"            compress \u003d new_compressed"},{"line_number":2690,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"bff0334d_e93fe922","line":2687,"updated":"2017-04-07 14:15:13.000000000","message":"compression","commit_id":"5a18ad55ae48e1c1ba785f64f97828e967b2ad0f"},{"author":{"_account_id":23100,"name":"Swapnil Nilangekar","email":"swapnil.sun.nilangekar@hpe.com","username":"swapnil-nilangekar"},"change_message_id":"e521d12f3cd3e7acfda9a6b938f82ff3a68a9c30","unresolved":false,"context_lines":[{"line_number":2684,"context_line":"        either be done or it is in a state that we need to treat as an error."},{"line_number":2685,"context_line":"        \"\"\""},{"line_number":2686,"context_line":""},{"line_number":2687,"context_line":"        compress \u003d False"},{"line_number":2688,"context_line":"        if new_compressed is not None:"},{"line_number":2689,"context_line":"            compress \u003d new_compressed"},{"line_number":2690,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"bff0334d_5e487485","line":2687,"in_reply_to":"bff0334d_e93fe922","updated":"2017-04-11 10:24:10.000000000","message":"Done","commit_id":"5a18ad55ae48e1c1ba785f64f97828e967b2ad0f"}],"releasenotes/notes/Enable-HPE-3PAR-Compression-Feature-90e4de4b64a74a46.yaml":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"399e1e4849c682b1216a53a52066f546000f5a56","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    Enabling Compression Feature On 3PAR"},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - |"},{"line_number":6,"context_line":"    * This adds following functionalities"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    * Creating thin/dedup compresssed volume."},{"line_number":9,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":17,"id":"7ffa3b31_abc21c84","line":6,"updated":"2017-04-17 17:31:09.000000000","message":"See the following output release notes, please add \"HPE 3PAR driver\" to the above sentence because \"prelude\" will NOT appear together with \"features\".  Also I think you should remove \"*\" from the above line.\n\nhttp://docs-draft.openstack.org/28/409128/17/check/gate-cinder-releasenotes/271c92d//releasenotes/build/html/unreleased.html","commit_id":"da181434d01dadc4b1adb17ee6ceb979c733d01e"},{"author":{"_account_id":23100,"name":"Swapnil Nilangekar","email":"swapnil.sun.nilangekar@hpe.com","username":"swapnil-nilangekar"},"change_message_id":"e8bc1cd69522fb2aa4eb4ed151102bd134ca89ea","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    Enabling Compression Feature On 3PAR"},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - |"},{"line_number":6,"context_line":"    * This adds following functionalities"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    * Creating thin/dedup compresssed volume."},{"line_number":9,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":17,"id":"7ffa3b31_4c70cb08","line":6,"in_reply_to":"7ffa3b31_abc21c84","updated":"2017-04-21 09:31:12.000000000","message":"Done","commit_id":"da181434d01dadc4b1adb17ee6ceb979c733d01e"}]}