)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"8d6edafd28c2f4629d154119c6c41e6eea80b647","unresolved":false,"context_lines":[{"line_number":19,"context_line":"GET /v3/{project_id}/groups/{group_id}?list_volume\u003dTrue"},{"line_number":20,"context_line":"RESP BODY: {\"group\": {\"status\": \"XXX\","},{"line_number":21,"context_line":"                      \"id\": \"XXX\","},{"line_number":22,"context_line":"\t\t      ...,"},{"line_number":23,"context_line":"\t\t      \"volumes\":[\u0027volume_id1\u0027,"},{"line_number":24,"context_line":"\t\t                 ...,"},{"line_number":25,"context_line":"\t\t                 \u0027volume_idn\u0027]"},{"line_number":26,"context_line":"\t\t     }"},{"line_number":27,"context_line":"\t   }"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Co-Authored-By: wanghao\u003csxmatch1986@gmail.com\u003e"},{"line_number":30,"context_line":"Change-Id: Ica1afd07cd022bab168b6894b9cf43a5b18e34d4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"da4df55a_dd9b9716","line":27,"range":{"start_line":22,"start_character":0,"end_line":27,"end_character":1},"updated":"2016-12-27 15:23:23.000000000","message":"Remove the tabs if you need to do another patch.","commit_id":"f26c0c105c320b54dac14a8ceb75e8d6272b0d6d"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"e976834b5b5c24ec3a9606f95bd671bcf3a16aed","unresolved":false,"context_lines":[{"line_number":19,"context_line":"GET /v3/{project_id}/groups/{group_id}?list_volume\u003dTrue"},{"line_number":20,"context_line":"RESP BODY: {\"group\": {\"status\": \"XXX\","},{"line_number":21,"context_line":"                      \"id\": \"XXX\","},{"line_number":22,"context_line":"\t\t      ...,"},{"line_number":23,"context_line":"\t\t      \"volumes\":[\u0027volume_id1\u0027,"},{"line_number":24,"context_line":"\t\t                 ...,"},{"line_number":25,"context_line":"\t\t                 \u0027volume_idn\u0027]"},{"line_number":26,"context_line":"\t\t     }"},{"line_number":27,"context_line":"\t   }"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Co-Authored-By: wanghao\u003csxmatch1986@gmail.com\u003e"},{"line_number":30,"context_line":"Change-Id: Ica1afd07cd022bab168b6894b9cf43a5b18e34d4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"da4df55a_511ea25f","line":27,"range":{"start_line":22,"start_character":0,"end_line":27,"end_character":1},"in_reply_to":"da4df55a_dd9b9716","updated":"2016-12-28 08:29:12.000000000","message":"Done","commit_id":"f26c0c105c320b54dac14a8ceb75e8d6272b0d6d"}],"cinder/api/v3/views/groups.py":[{"author":{"_account_id":18026,"name":"huanan","email":"huanan@huawei.com","username":"huanan"},"change_message_id":"9798ec018c833deaaf1bee9348943c769c88bbdb","unresolved":false,"context_lines":[{"line_number":64,"context_line":"            group_ref[\u0027group\u0027][\u0027group_snapshot_id\u0027] \u003d group.group_snapshot_id"},{"line_number":65,"context_line":"            group_ref[\u0027group\u0027][\u0027source_group_id\u0027] \u003d group.source_group_id"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        # Add volumes if min version is greater than or equal to 3.14."},{"line_number":68,"context_line":"        if req_version.matches(\"3.16\", None):"},{"line_number":69,"context_line":"            group_ref[\u0027group\u0027][\u0027volumes\u0027] \u003d [volume.id"},{"line_number":70,"context_line":"                                             for volume in group.volumes]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_29f0c7fc","line":67,"range":{"start_line":67,"start_character":65,"end_line":67,"end_character":69},"updated":"2016-12-12 13:12:48.000000000","message":"Here should be 3.16.","commit_id":"cf00ea7e01340898b76ddff453a99cb05d668b60"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"ae5a89999f868ba23d6107169cda37f0edba50eb","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            group_ref[\u0027group\u0027][\u0027source_group_id\u0027] \u003d group.source_group_id"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        # Add volumes if min version is greater than or equal to 3.22."},{"line_number":69,"context_line":"        list_volume \u003d utils.get_bool_param(\u0027list_volume\u0027, request.params)"},{"line_number":70,"context_line":"        if req_version.matches(\"3.22\", None) and list_volume:"},{"line_number":71,"context_line":"            group_ref[\u0027group\u0027][\u0027volumes\u0027] \u003d [volume.id"},{"line_number":72,"context_line":"                                             for volume in group.volumes]"}],"source_content_type":"text/x-python","patch_set":12,"id":"ba5201f7_5da6ee10","line":69,"updated":"2017-01-04 15:12:40.000000000","message":"This should not look for the list_volume parameter unless the version check passes first.\n\nCalling get_bool_param first means that invalid booleans passed in for this parameter will trigger new errors on API versions prior to 3.22.","commit_id":"a6d494ff61da4c5eaae40bd11134b7e32f2fe315"}],"cinder/tests/unit/api/v3/test_groups.py":[{"author":{"_account_id":19774,"name":"Vivek Agrawal","email":"vivek.agrawal@veritas.com","username":"viveksagrawal"},"change_message_id":"0cecb06fd8523468821d8ed5067727132c3dea73","unresolved":false,"context_lines":[{"line_number":170,"context_line":"        self.assertEqual([fake.VOLUME_ID],"},{"line_number":171,"context_line":"                         res_dict[\u0027group\u0027][\u0027volumes\u0027])"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        # If the microversion \u003c 3.22 or \"list_volume\" is missing, \"volumes\""},{"line_number":174,"context_line":"        # should not be contained in the response body."},{"line_number":175,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/v3/%s/groups/%s\u0027 %"},{"line_number":176,"context_line":"                                      (fake.PROJECT_ID, self.group1.id),"}],"source_content_type":"text/x-python","patch_set":12,"id":"ba5201f7_aadec73c","line":173,"updated":"2017-01-04 03:56:49.000000000","message":"In case of uploading another patch, please move the comment to L183. Or am I missing something here?","commit_id":"a6d494ff61da4c5eaae40bd11134b7e32f2fe315"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"eb99fafc8bafb7d2241a2e6c6a13f69f7c46b4fa","unresolved":false,"context_lines":[{"line_number":170,"context_line":"        self.assertEqual([fake.VOLUME_ID],"},{"line_number":171,"context_line":"                         res_dict[\u0027group\u0027][\u0027volumes\u0027])"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        # If the microversion \u003c 3.22 or \"list_volume\" is missing, \"volumes\""},{"line_number":174,"context_line":"        # should not be contained in the response body."},{"line_number":175,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/v3/%s/groups/%s\u0027 %"},{"line_number":176,"context_line":"                                      (fake.PROJECT_ID, self.group1.id),"}],"source_content_type":"text/x-python","patch_set":12,"id":"ba5201f7_f826e5cc","line":173,"in_reply_to":"ba5201f7_aadec73c","updated":"2017-01-04 06:12:33.000000000","message":"L175 test without \"list_volume\",\nL183 test with  microversion \u003c 3.22.","commit_id":"a6d494ff61da4c5eaae40bd11134b7e32f2fe315"},{"author":{"_account_id":19774,"name":"Vivek Agrawal","email":"vivek.agrawal@veritas.com","username":"viveksagrawal"},"change_message_id":"c46e0c3e5bbea93fe87cb6d39555f6665dc424df","unresolved":false,"context_lines":[{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        # If the microversion \u003c 3.22 or \"list_volume\" is missing, \"volumes\""},{"line_number":174,"context_line":"        # should not be contained in the response body."},{"line_number":175,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/v3/%s/groups/%s\u0027 %"},{"line_number":176,"context_line":"                                      (fake.PROJECT_ID, self.group1.id),"},{"line_number":177,"context_line":"                                      version\u003d\u00273.22\u0027)"},{"line_number":178,"context_line":"        res_dict \u003d self.controller.show(req, self.group1.id)"}],"source_content_type":"text/x-python","patch_set":13,"id":"ba5201f7_269752ed","line":175,"updated":"2017-01-04 18:53:17.000000000","message":"The test case and comment combination is confusing to me\nI will put test case on L175 under comment on L162, 163\n\nAnother test case where microversion \u003c3.22(which in this case is 3.21) as a separate comment for test case on L183. Now appending list_volume to 3.21 fake request is of no major use because microversion will be checked first.\n\nbut this is just a comment that will make test case and comments in it more readable","commit_id":"6e29c44e2c753995cbcf07a69cf8b98c06b88de0"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"972ac245a25e313a29350baeee3f8bdb2a0fc2c3","unresolved":false,"context_lines":[{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        # If the microversion \u003c 3.22 or \"list_volume\" is missing, \"volumes\""},{"line_number":174,"context_line":"        # should not be contained in the response body."},{"line_number":175,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/v3/%s/groups/%s\u0027 %"},{"line_number":176,"context_line":"                                      (fake.PROJECT_ID, self.group1.id),"},{"line_number":177,"context_line":"                                      version\u003d\u00273.22\u0027)"},{"line_number":178,"context_line":"        res_dict \u003d self.controller.show(req, self.group1.id)"}],"source_content_type":"text/x-python","patch_set":13,"id":"ba5201f7_761f3d6c","line":175,"in_reply_to":"ba5201f7_269752ed","updated":"2017-01-05 01:31:20.000000000","message":"Thanks for the suggestion","commit_id":"6e29c44e2c753995cbcf07a69cf8b98c06b88de0"}]}