)]}'
{"cinder/volume/flows/manager/create_volume.py":[{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"fc4dede6197460e1ac7e322c8560c3d5e8e0946c","unresolved":false,"context_lines":[{"line_number":754,"context_line":"        original_size \u003d volume.size"},{"line_number":755,"context_line":"        try:"},{"line_number":756,"context_line":"            if not cloned:"},{"line_number":757,"context_line":"                if should_create_cache_entry:"},{"line_number":758,"context_line":"                    # If image cache is enabled, let\u0027s fetch the image, try"},{"line_number":759,"context_line":"                    # to reduce the volume to the virtual image size; we can"},{"line_number":760,"context_line":"                    # then extend the volume once the image has been downloaded"},{"line_number":761,"context_line":"                    # successfully. We wouldn\u0027t need to do this for drivers"},{"line_number":762,"context_line":"                    # that implement a storage based image copy."},{"line_number":763,"context_line":"                    with image_utils.TemporaryImages.fetch("},{"line_number":764,"context_line":"                            image_service, context, image_id) as tmp_image:"},{"line_number":765,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_c5699c8d","line":762,"range":{"start_line":757,"start_character":16,"end_line":762,"end_character":64},"updated":"2016-12-12 21:04:34.000000000","message":"I\u0027m not sure moving this behind the cache really fixes the issue completely... it just adds a perf regression for other backends and the issue still exists if someone turns on the cache flag with the backends that do have this problem.\n\nHow much effort would it be to just move the implementation of copy_image_to_volume with the optimized image clone into the drivers clone_image implementation? They have almost identical signatures, but would allow for this to more smoothly handle those backends.","commit_id":"07d6a31e4372873bc7b1795edcbbd62fee6457fa"},{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"fc4dede6197460e1ac7e322c8560c3d5e8e0946c","unresolved":false,"context_lines":[{"line_number":781,"context_line":"                            volume.size \u003d virtual_size"},{"line_number":782,"context_line":"                            volume.save()"},{"line_number":783,"context_line":""},{"line_number":784,"context_line":"                model_update \u003d self._create_from_image_download("},{"line_number":785,"context_line":"                    context,"},{"line_number":786,"context_line":"                    volume,"},{"line_number":787,"context_line":"                    image_location,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_25a5f003","line":784,"updated":"2016-12-12 21:04:34.000000000","message":"This breaks backends using the cache, they would now download the image twice since this is outside of the fetch scope... Same comments as on https://review.openstack.org/#/c/331598/","commit_id":"07d6a31e4372873bc7b1795edcbbd62fee6457fa"}]}