)]}'
{"cinder/tests/unit/volume/drivers/dell_emc/test_vmax.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"8994d33727e5fad3005a6f2b4e46bebb26321e5e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016 Dell Inc. or its subsidiaries."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_0c20fd48","line":1,"updated":"2016-12-19 17:03:44.000000000","message":"Please don\u0027t change this line.\n\nOnly use this new copyright header for new files, not existing files.","commit_id":"d8f2486b7dc4ec9b26bf536d92825fcd537e290b"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"3da0c22984aa84893ed7ac78c4c9c2afaa78ebd7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016 Dell Inc. or its subsidiaries."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_af9ffbb2","line":1,"in_reply_to":"1a6eadb0_0c20fd48","updated":"2016-12-19 17:13:29.000000000","message":"Sure.  I will revert in all files","commit_id":"d8f2486b7dc4ec9b26bf536d92825fcd537e290b"},{"author":{"_account_id":13047,"name":"Isaac Beckman","email":"beckmani@gmail.com","username":"isaacb"},"change_message_id":"4f024b33710eabe4fc3f3c430f5b3090a47e4338","unresolved":false,"context_lines":[{"line_number":32,"context_line":"from cinder.objects import fields"},{"line_number":33,"context_line":"from cinder.objects import group"},{"line_number":34,"context_line":"from cinder import test"},{"line_number":35,"context_line":"from cinder.tests.unit import utils as unit_utils"},{"line_number":36,"context_line":"from cinder import utils as cinder_utils"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"from cinder.volume import configuration as conf"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba5201f7_18ed9e8e","line":35,"range":{"start_line":35,"start_character":30,"end_line":35,"end_character":35},"updated":"2017-01-10 07:49:39.000000000","message":"This import should be after all cinder.objects imports. (1 line above)","commit_id":"899d694a9cc6e8cf347d5fe2d56ff603db050c86"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"6c5f4138589ced4576859c9bf00b7c8ed2025c98","unresolved":false,"context_lines":[{"line_number":32,"context_line":"from cinder.objects import fields"},{"line_number":33,"context_line":"from cinder.objects import group"},{"line_number":34,"context_line":"from cinder import test"},{"line_number":35,"context_line":"from cinder.tests.unit import utils as unit_utils"},{"line_number":36,"context_line":"from cinder import utils as cinder_utils"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"from cinder.volume import configuration as conf"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba5201f7_cf01803b","line":35,"range":{"start_line":35,"start_character":30,"end_line":35,"end_character":35},"in_reply_to":"ba5201f7_18ed9e8e","updated":"2017-01-10 12:08:24.000000000","message":"Thank you for the feedback.  I will change this","commit_id":"899d694a9cc6e8cf347d5fe2d56ff603db050c86"},{"author":{"_account_id":13047,"name":"Isaac Beckman","email":"beckmani@gmail.com","username":"isaacb"},"change_message_id":"17cdd7cfa16b0fe7a7b8a299a3a37d14462e34a5","unresolved":false,"context_lines":[{"line_number":32,"context_line":"from cinder.objects import fields"},{"line_number":33,"context_line":"from cinder.objects import group"},{"line_number":34,"context_line":"from cinder import test"},{"line_number":35,"context_line":"from cinder.tests.unit import utils as unit_utils"},{"line_number":36,"context_line":"from cinder import utils as cinder_utils"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"from cinder.volume import configuration as conf"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba5201f7_88904f97","line":35,"range":{"start_line":35,"start_character":30,"end_line":35,"end_character":35},"in_reply_to":"ba5201f7_6aba42c2","updated":"2017-01-10 12:36:33.000000000","message":"You are right. please ignore my comments","commit_id":"899d694a9cc6e8cf347d5fe2d56ff603db050c86"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"30ffd2f451f78d7eedc002a8f7a52cddac092a60","unresolved":false,"context_lines":[{"line_number":32,"context_line":"from cinder.objects import fields"},{"line_number":33,"context_line":"from cinder.objects import group"},{"line_number":34,"context_line":"from cinder import test"},{"line_number":35,"context_line":"from cinder.tests.unit import utils as unit_utils"},{"line_number":36,"context_line":"from cinder import utils as cinder_utils"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"from cinder.volume import configuration as conf"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba5201f7_6aba42c2","line":35,"range":{"start_line":35,"start_character":30,"end_line":35,"end_character":35},"in_reply_to":"ba5201f7_cf01803b","updated":"2017-01-10 12:21:48.000000000","message":"Hi Issac, from a pep8 point of view this is alphabetical.  Am I missing something?  If I change it pep8 complains.","commit_id":"899d694a9cc6e8cf347d5fe2d56ff603db050c86"}],"cinder/volume/drivers/dell_emc/vmax/common.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"8994d33727e5fad3005a6f2b4e46bebb26321e5e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016 Dell Inc. or its subsidiaries."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_2c921958","line":1,"updated":"2016-12-19 17:03:44.000000000","message":"Please don\u0027t change this line.\n\nOnly use this new copyright header for new files, not existing files.","commit_id":"d8f2486b7dc4ec9b26bf536d92825fcd537e290b"}],"cinder/volume/drivers/dell_emc/vmax/fast.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"8994d33727e5fad3005a6f2b4e46bebb26321e5e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016 Dell Inc. or its subsidiaries."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_6c73314e","line":1,"updated":"2016-12-19 17:03:44.000000000","message":"Please don\u0027t change this line.\n\nOnly use this new copyright header for new files, not existing files.","commit_id":"d8f2486b7dc4ec9b26bf536d92825fcd537e290b"}],"cinder/volume/drivers/dell_emc/vmax/fc.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"8994d33727e5fad3005a6f2b4e46bebb26321e5e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016 Dell Inc. or its subsidiaries."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_ac93894e","line":1,"updated":"2016-12-19 17:03:44.000000000","message":"Please don\u0027t change this line.\n\nOnly use this new copyright header for new files, not existing files.","commit_id":"d8f2486b7dc4ec9b26bf536d92825fcd537e290b"}],"cinder/volume/drivers/dell_emc/vmax/https.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"8994d33727e5fad3005a6f2b4e46bebb26321e5e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016 Dell Inc. or its subsidiaries."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_8cb5edd1","line":1,"updated":"2016-12-19 17:03:44.000000000","message":"Please don\u0027t change this line.\n\nOnly use this new copyright header for new files, not existing files.","commit_id":"d8f2486b7dc4ec9b26bf536d92825fcd537e290b"}],"cinder/volume/drivers/dell_emc/vmax/iscsi.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"8994d33727e5fad3005a6f2b4e46bebb26321e5e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016 Dell Inc. or its subsidiaries."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_ecb4a1d2","line":1,"updated":"2016-12-19 17:03:44.000000000","message":"Please don\u0027t change this line.\n\nOnly use this new copyright header for new files, not existing files.","commit_id":"d8f2486b7dc4ec9b26bf536d92825fcd537e290b"},{"author":{"_account_id":13047,"name":"Isaac Beckman","email":"beckmani@gmail.com","username":"isaacb"},"change_message_id":"4f024b33710eabe4fc3f3c430f5b3090a47e4338","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from cinder.i18n import _, _LE, _LI"},{"line_number":24,"context_line":"from cinder import interface"},{"line_number":25,"context_line":"from cinder.volume import driver"},{"line_number":26,"context_line":"from cinder.volume.drivers.dell_emc.vmax import common"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba5201f7_5e8d4f7a","line":26,"range":{"start_line":26,"start_character":12,"end_line":26,"end_character":18},"updated":"2017-01-10 07:49:39.000000000","message":"Need to restructure these imports order according to:http://docs.openstack.org/developer/hacking/#imports","commit_id":"899d694a9cc6e8cf347d5fe2d56ff603db050c86"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"6c5f4138589ced4576859c9bf00b7c8ed2025c98","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from cinder.i18n import _, _LE, _LI"},{"line_number":24,"context_line":"from cinder import interface"},{"line_number":25,"context_line":"from cinder.volume import driver"},{"line_number":26,"context_line":"from cinder.volume.drivers.dell_emc.vmax import common"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba5201f7_6f99741f","line":26,"range":{"start_line":26,"start_character":12,"end_line":26,"end_character":18},"in_reply_to":"ba5201f7_5e8d4f7a","updated":"2017-01-10 12:08:24.000000000","message":"Will do. Thank you","commit_id":"899d694a9cc6e8cf347d5fe2d56ff603db050c86"}],"cinder/volume/drivers/dell_emc/vmax/masking.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"8994d33727e5fad3005a6f2b4e46bebb26321e5e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016 Dell Inc. or its subsidiaries."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_0cd1ddfb","line":1,"updated":"2016-12-19 17:03:44.000000000","message":"Please don\u0027t change this line.\n\nOnly use this new copyright header for new files, not existing files.","commit_id":"d8f2486b7dc4ec9b26bf536d92825fcd537e290b"}],"cinder/volume/drivers/dell_emc/vmax/provision.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"8994d33727e5fad3005a6f2b4e46bebb26321e5e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016 Dell Inc. or its subsidiaries."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_6cd8911e","line":1,"updated":"2016-12-19 17:03:44.000000000","message":"Please don\u0027t change this line.\n\nOnly use this new copyright header for new files, not existing files.","commit_id":"d8f2486b7dc4ec9b26bf536d92825fcd537e290b"}],"cinder/volume/drivers/dell_emc/vmax/provision_v3.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"8994d33727e5fad3005a6f2b4e46bebb26321e5e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016 Dell Inc. or its subsidiaries."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_ccfd2570","line":1,"updated":"2016-12-19 17:03:44.000000000","message":"Please don\u0027t change this line.\n\nOnly use this new copyright header for new files, not existing files.","commit_id":"d8f2486b7dc4ec9b26bf536d92825fcd537e290b"}],"cinder/volume/drivers/dell_emc/vmax/utils.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"8994d33727e5fad3005a6f2b4e46bebb26321e5e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016 Dell Inc. or its subsidiaries."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_ec02e16e","line":1,"updated":"2016-12-19 17:03:44.000000000","message":"Please don\u0027t change this line.\n\nOnly use this new copyright header for new files, not existing files.","commit_id":"d8f2486b7dc4ec9b26bf536d92825fcd537e290b"},{"author":{"_account_id":13047,"name":"Isaac Beckman","email":"beckmani@gmail.com","username":"isaacb"},"change_message_id":"9127dbe0c655cedb995975dfeaa73209e4a1764d","unresolved":false,"context_lines":[{"line_number":1535,"context_line":""},{"line_number":1536,"context_line":"        return foundStorageSystemInstanceName"},{"line_number":1537,"context_line":""},{"line_number":1538,"context_line":"    def is_in_range(self, volumeSize, maximumVolumeSize, minimumVolumeSize):"},{"line_number":1539,"context_line":"        \"\"\"Check that volumeSize is in range."},{"line_number":1540,"context_line":""},{"line_number":1541,"context_line":"        :param volumeSize: volume size"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba5201f7_81193d25","line":1538,"range":{"start_line":1538,"start_character":8,"end_line":1538,"end_character":19},"updated":"2017-01-09 14:49:53.000000000","message":"According to:\nhttps://review.openstack.org/#/c/333766/\nThis method should be removed. Why you add it here?","commit_id":"e9dc1b3b401781ae315297c7a3bbf2cc0ac0be89"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"86b55b05deebcf974e58b3c2e95ca23df20c7193","unresolved":false,"context_lines":[{"line_number":1535,"context_line":""},{"line_number":1536,"context_line":"        return foundStorageSystemInstanceName"},{"line_number":1537,"context_line":""},{"line_number":1538,"context_line":"    def is_in_range(self, volumeSize, maximumVolumeSize, minimumVolumeSize):"},{"line_number":1539,"context_line":"        \"\"\"Check that volumeSize is in range."},{"line_number":1540,"context_line":""},{"line_number":1541,"context_line":"        :param volumeSize: volume size"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba5201f7_0111cd5d","line":1538,"range":{"start_line":1538,"start_character":8,"end_line":1538,"end_character":19},"in_reply_to":"ba5201f7_81193d25","updated":"2017-01-09 15:01:49.000000000","message":"Good question.  Not sure why it is here.  I will remove it.","commit_id":"e9dc1b3b401781ae315297c7a3bbf2cc0ac0be89"}],"cinder/volume/manager.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"04e377e78e43d56ec797c12a18a9d5d66d43f7f2","unresolved":false,"context_lines":[{"line_number":165,"context_line":"    \u0027cinder.volume.drivers.dell_emc.xtremio.XtremIOFCDriver\u0027,"},{"line_number":166,"context_line":"    \u0027cinder.volume.drivers.datera.DateraDriver\u0027:"},{"line_number":167,"context_line":"    \u0027cinder.volume.drivers.datera.datera_iscsi.DateraDriver\u0027,"},{"line_number":168,"context_line":"    \u0027cinder.volume.drivers.emc.EMCVMAXISCSIDriver\u0027:"},{"line_number":169,"context_line":"    \u0027cinder.volume.drivers.dell_emc.vmax.VMAXISCSIDriver\u0027,"},{"line_number":170,"context_line":"    \u0027cinder.volume.drivers.emc.EMCVMAXFCDriver\u0027:"},{"line_number":171,"context_line":"    \u0027cinder.volume.drivers.dell_emc.vmax.VMAXFCDriver\u0027,"}],"source_content_type":"text/x-python","patch_set":15,"id":"5a3905b3_e45e8911","line":168,"updated":"2017-01-25 03:12:13.000000000","message":"cinder.volume.drivers.emc.emc_vmax_iscsi.EMCVMAXISCSIDriver","commit_id":"0f850f32081b9512246ab623da9d68b1ea510c7f"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"ad45483982c1b95b511c529d4efbf831473f6bf4","unresolved":false,"context_lines":[{"line_number":165,"context_line":"    \u0027cinder.volume.drivers.dell_emc.xtremio.XtremIOFCDriver\u0027,"},{"line_number":166,"context_line":"    \u0027cinder.volume.drivers.datera.DateraDriver\u0027:"},{"line_number":167,"context_line":"    \u0027cinder.volume.drivers.datera.datera_iscsi.DateraDriver\u0027,"},{"line_number":168,"context_line":"    \u0027cinder.volume.drivers.emc.EMCVMAXISCSIDriver\u0027:"},{"line_number":169,"context_line":"    \u0027cinder.volume.drivers.dell_emc.vmax.VMAXISCSIDriver\u0027,"},{"line_number":170,"context_line":"    \u0027cinder.volume.drivers.emc.EMCVMAXFCDriver\u0027:"},{"line_number":171,"context_line":"    \u0027cinder.volume.drivers.dell_emc.vmax.VMAXFCDriver\u0027,"}],"source_content_type":"text/x-python","patch_set":15,"id":"5a3905b3_7a086929","line":168,"in_reply_to":"5a3905b3_e45e8911","updated":"2017-01-25 09:21:33.000000000","message":"Will do.","commit_id":"0f850f32081b9512246ab623da9d68b1ea510c7f"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"04e377e78e43d56ec797c12a18a9d5d66d43f7f2","unresolved":false,"context_lines":[{"line_number":166,"context_line":"    \u0027cinder.volume.drivers.datera.DateraDriver\u0027:"},{"line_number":167,"context_line":"    \u0027cinder.volume.drivers.datera.datera_iscsi.DateraDriver\u0027,"},{"line_number":168,"context_line":"    \u0027cinder.volume.drivers.emc.EMCVMAXISCSIDriver\u0027:"},{"line_number":169,"context_line":"    \u0027cinder.volume.drivers.dell_emc.vmax.VMAXISCSIDriver\u0027,"},{"line_number":170,"context_line":"    \u0027cinder.volume.drivers.emc.EMCVMAXFCDriver\u0027:"},{"line_number":171,"context_line":"    \u0027cinder.volume.drivers.dell_emc.vmax.VMAXFCDriver\u0027,"},{"line_number":172,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":15,"id":"5a3905b3_a4d9e185","line":169,"updated":"2017-01-25 03:12:13.000000000","message":"cinder.volume.drivers.dell_emc.vmax.iscsi.VMAXISCSIDriver","commit_id":"0f850f32081b9512246ab623da9d68b1ea510c7f"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"04e377e78e43d56ec797c12a18a9d5d66d43f7f2","unresolved":false,"context_lines":[{"line_number":167,"context_line":"    \u0027cinder.volume.drivers.datera.datera_iscsi.DateraDriver\u0027,"},{"line_number":168,"context_line":"    \u0027cinder.volume.drivers.emc.EMCVMAXISCSIDriver\u0027:"},{"line_number":169,"context_line":"    \u0027cinder.volume.drivers.dell_emc.vmax.VMAXISCSIDriver\u0027,"},{"line_number":170,"context_line":"    \u0027cinder.volume.drivers.emc.EMCVMAXFCDriver\u0027:"},{"line_number":171,"context_line":"    \u0027cinder.volume.drivers.dell_emc.vmax.VMAXFCDriver\u0027,"},{"line_number":172,"context_line":"}"},{"line_number":173,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"5a3905b3_c4b8ad2d","line":170,"updated":"2017-01-25 03:12:13.000000000","message":"cinder.volume.drivers.emc.emc_vmax_fc.EMCVMAXFCDriver","commit_id":"0f850f32081b9512246ab623da9d68b1ea510c7f"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"04e377e78e43d56ec797c12a18a9d5d66d43f7f2","unresolved":false,"context_lines":[{"line_number":168,"context_line":"    \u0027cinder.volume.drivers.emc.EMCVMAXISCSIDriver\u0027:"},{"line_number":169,"context_line":"    \u0027cinder.volume.drivers.dell_emc.vmax.VMAXISCSIDriver\u0027,"},{"line_number":170,"context_line":"    \u0027cinder.volume.drivers.emc.EMCVMAXFCDriver\u0027:"},{"line_number":171,"context_line":"    \u0027cinder.volume.drivers.dell_emc.vmax.VMAXFCDriver\u0027,"},{"line_number":172,"context_line":"}"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"5a3905b3_a492c19d","line":171,"updated":"2017-01-25 03:12:13.000000000","message":"cinder.volume.drivers.dell_emc.vmax.fc.VMAXFCDriver","commit_id":"0f850f32081b9512246ab623da9d68b1ea510c7f"}],"releasenotes/notes/vmax-rename-dell-emc-f9ebfb9eb567f427.yaml":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"8994d33727e5fad3005a6f2b4e46bebb26321e5e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - VMAX driver - rename and restructure driver from EMC to Dell EMC."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1a6eadb0_ecf741f3","line":3,"updated":"2016-12-19 17:03:44.000000000","message":"Please follow the example here:\n\nhttps://review.openstack.org/#/c/400481/5/releasenotes/notes/move-xtremio-driver-to-dell-emc-dir-f7e07a502cafd78f.yaml","commit_id":"d8f2486b7dc4ec9b26bf536d92825fcd537e290b"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"3da0c22984aa84893ed7ac78c4c9c2afaa78ebd7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - VMAX driver - rename and restructure driver from EMC to Dell EMC."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1a6eadb0_0f3aafcd","line":3,"in_reply_to":"1a6eadb0_ecf741f3","updated":"2016-12-19 17:13:29.000000000","message":"Ok.  Thanks","commit_id":"d8f2486b7dc4ec9b26bf536d92825fcd537e290b"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"04e377e78e43d56ec797c12a18a9d5d66d43f7f2","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - The VMAX driver is moved to the dell_emc directory."},{"line_number":4,"context_line":"    volume_driver entry in cinder.conf needs to be changed to"},{"line_number":5,"context_line":"    cinder.volume.drivers.dell_emc.vmax.VMAXISCSIDriver or"},{"line_number":6,"context_line":"    cinder.volume.drivers.dell_emc.vmax.VMAXFCDriver."}],"source_content_type":"text/x-yaml","patch_set":15,"id":"5a3905b3_84c3058a","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":55},"updated":"2017-01-25 03:12:13.000000000","message":"cinder.volume.drivers.dell_emc.vmax.iscsi.VMAXISCSIDriver","commit_id":"0f850f32081b9512246ab623da9d68b1ea510c7f"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"ad45483982c1b95b511c529d4efbf831473f6bf4","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - The VMAX driver is moved to the dell_emc directory."},{"line_number":4,"context_line":"    volume_driver entry in cinder.conf needs to be changed to"},{"line_number":5,"context_line":"    cinder.volume.drivers.dell_emc.vmax.VMAXISCSIDriver or"},{"line_number":6,"context_line":"    cinder.volume.drivers.dell_emc.vmax.VMAXFCDriver."}],"source_content_type":"text/x-yaml","patch_set":15,"id":"5a3905b3_fa3379f4","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":55},"in_reply_to":"5a3905b3_84c3058a","updated":"2017-01-25 09:21:33.000000000","message":"Sure","commit_id":"0f850f32081b9512246ab623da9d68b1ea510c7f"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"04e377e78e43d56ec797c12a18a9d5d66d43f7f2","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - The VMAX driver is moved to the dell_emc directory."},{"line_number":4,"context_line":"    volume_driver entry in cinder.conf needs to be changed to"},{"line_number":5,"context_line":"    cinder.volume.drivers.dell_emc.vmax.VMAXISCSIDriver or"},{"line_number":6,"context_line":"    cinder.volume.drivers.dell_emc.vmax.VMAXFCDriver."}],"source_content_type":"text/x-yaml","patch_set":15,"id":"5a3905b3_043635b4","line":6,"range":{"start_line":6,"start_character":4,"end_line":6,"end_character":52},"updated":"2017-01-25 03:12:13.000000000","message":"cinder.volume.drivers.dell_emc.vmax.fc.VMAXFCDriver","commit_id":"0f850f32081b9512246ab623da9d68b1ea510c7f"}]}