)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"a14c79e708482b74551f30d3a88f1ae7eba28559","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Replace assertTrue with assertIs."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"[H203] \u0027assertTrue\u0027 should also be avoided when more specific methods are available (assertIs instead of assertTrue), because they provide a better error message in case of failure."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I10aafa86542685368a8c339d657cb992905fbce3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a6eadb0_0e4c8c75","line":9,"updated":"2016-12-19 08:32:09.000000000","message":"please format the commit message. Don\u0027t let the line too long.","commit_id":"07ac52d541253e954e42d6ea152dd31725e1f588"}],"cinder/tests/unit/volume/drivers/test_dothill.py":[{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"27c7734006d3eee73a7203cd64f6b2fb8439bca7","unresolved":false,"context_lines":[{"line_number":188,"context_line":"                                     RequestException(\"error\")]"},{"line_number":189,"context_line":"        mock_requests_get.return_value \u003d m"},{"line_number":190,"context_line":"        ret \u003d self.client._request(\u0027/path\u0027)"},{"line_number":191,"context_line":"        self.assertIs(type(ret), etree._Element)"},{"line_number":192,"context_line":"        self.assertRaises(exception.DotHillConnectionError,"},{"line_number":193,"context_line":"                          self.client._request,"},{"line_number":194,"context_line":"                          \u0027/path\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_510e25e6","line":191,"range":{"start_line":191,"start_character":7,"end_line":191,"end_character":48},"updated":"2016-12-19 08:55:12.000000000","message":"I think assertEqual is easier to understand, Can we use it here?","commit_id":"dc4766a92229f7d5bd8417604efb0349f8bf9194"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"4c2820042d339212bd65d1ae909eeec6fbaadf06","unresolved":false,"context_lines":[{"line_number":188,"context_line":"                                     RequestException(\"error\")]"},{"line_number":189,"context_line":"        mock_requests_get.return_value \u003d m"},{"line_number":190,"context_line":"        ret \u003d self.client._request(\u0027/path\u0027)"},{"line_number":191,"context_line":"        self.assertIs(type(ret), etree._Element)"},{"line_number":192,"context_line":"        self.assertRaises(exception.DotHillConnectionError,"},{"line_number":193,"context_line":"                          self.client._request,"},{"line_number":194,"context_line":"                          \u0027/path\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_e01b821a","line":191,"range":{"start_line":191,"start_character":7,"end_line":191,"end_character":48},"in_reply_to":"1a6eadb0_510e25e6","updated":"2016-12-20 20:28:33.000000000","message":"+1 to assertEqual()","commit_id":"dc4766a92229f7d5bd8417604efb0349f8bf9194"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"cb299c8c7feb5a683614a119e2f9807ad5391976","unresolved":false,"context_lines":[{"line_number":188,"context_line":"                                     RequestException(\"error\")]"},{"line_number":189,"context_line":"        mock_requests_get.return_value \u003d m"},{"line_number":190,"context_line":"        ret \u003d self.client._request(\u0027/path\u0027)"},{"line_number":191,"context_line":"        self.assertIs(type(ret), etree._Element)"},{"line_number":192,"context_line":"        self.assertRaises(exception.DotHillConnectionError,"},{"line_number":193,"context_line":"                          self.client._request,"},{"line_number":194,"context_line":"                          \u0027/path\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a3c09a3_f42ad02b","line":191,"range":{"start_line":191,"start_character":7,"end_line":191,"end_character":48},"in_reply_to":"1a6eadb0_e01b821a","updated":"2017-01-12 21:38:42.000000000","message":"I agree. assertIs(A, B) evaluates the A and B are the same object. We are actually checking that they are the same type.","commit_id":"dc4766a92229f7d5bd8417604efb0349f8bf9194"},{"author":{"_account_id":23185,"name":"Samantha Blanco","email":"samantha.blanco@att.com","username":"sblanco"},"change_message_id":"607bb5a0df3ed4a8cff072c01308ef4f3d68d6db","unresolved":false,"context_lines":[{"line_number":188,"context_line":"                                     RequestException(\"error\")]"},{"line_number":189,"context_line":"        mock_requests_get.return_value \u003d m"},{"line_number":190,"context_line":"        ret \u003d self.client._request(\u0027/path\u0027)"},{"line_number":191,"context_line":"        self.assertEqual(type(ret), etree._Element)"},{"line_number":192,"context_line":"        self.assertRaises(exception.DotHillConnectionError,"},{"line_number":193,"context_line":"                          self.client._request,"},{"line_number":194,"context_line":"                          \u0027/path\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a3c09a3_5456122a","line":191,"updated":"2017-01-13 19:42:40.000000000","message":"Would assertIsInstance work here instead?","commit_id":"7727544dc4cf7a8d223b3b57b21d8271f232dfc9"}]}