)]}'
{"cinder/volume/drivers/hpe/hpe_lefthand_iscsi.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"b01d122b2dca64802db64466c449f598e8a7bd09","unresolved":false,"context_lines":[{"line_number":1708,"context_line":"                        break"},{"line_number":1709,"context_line":"        except Exception as ex:"},{"line_number":1710,"context_line":"            LOG.error(_LE(\"There was a problem when trying to determine if \""},{"line_number":1711,"context_line":"                          \"the volume can be failed-back: %s\") %"},{"line_number":1712,"context_line":"                      six.text_type(ex))"},{"line_number":1713,"context_line":"            is_ready \u003d False"},{"line_number":1714,"context_line":"        finally:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_ea19e623","line":1711,"range":{"start_line":1711,"start_character":62,"end_line":1711,"end_character":64},"updated":"2016-12-19 16:01:09.000000000","message":"Can you also switch this to a , while you\u0027re at it? Or change to LOG.exception()","commit_id":"ad588bbb8273dee1977643611b8311df5b0dcee2"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"e0a4e3271ad2c9543c4dc33d63953dfac9692b44","unresolved":false,"context_lines":[{"line_number":1707,"context_line":"                        is_ready \u003d False"},{"line_number":1708,"context_line":"                        break"},{"line_number":1709,"context_line":"        except Exception as ex:"},{"line_number":1710,"context_line":"            LOG.exception(_LE(\"There was a problem when trying to determine if \""},{"line_number":1711,"context_line":"                              \"the volume can be failed-back: %s\"),"},{"line_number":1712,"context_line":"                          six.text_type(ex))"},{"line_number":1713,"context_line":"            is_ready \u003d False"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_d4b016e0","line":1710,"range":{"start_line":1710,"start_character":16,"end_line":1710,"end_character":25},"updated":"2016-12-20 15:32:38.000000000","message":"Sorry, I should have noted, if using LOG.exception the logger will automatically log the exception details. So if using LOG.exception, don\u0027t include the exception in the log message.\n\nSo either:\n\nLOG.exception(_LE(\u0027Some text\u0027))\n\nor:\n\nLOG.error(_LE(\u0027Some text: %s\u0027), ex)\n\nAlso note, six.text_type should not be used when passing the exception object in to the logger as a formatting arg.","commit_id":"4078b081e5516f8d9535c66ec32123087ac65d1e"}]}