)]}'
{"cinder/flow_utils.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"bc280599750e2f51fbf779edf580350ae1d650c1","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            log\u003dlogger)"},{"line_number":88,"context_line":"        # TODO(vbala) Pass SpecialFormatter instance as kwarg once taskflow"},{"line_number":89,"context_line":"        # min version is raised to 2.7.0."},{"line_number":90,"context_line":"        self._fail_formatter \u003d SpecialFormatter(engine)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da4df55a_cde4463d","line":90,"updated":"2016-12-22 11:37:48.000000000","message":"-1: I believe using _fail_formatter attribute is kind of a hack, and while I\u0027m OK to use it in versions prior to 2.7.0 due to the lack of other options, I\u0027m against using it for versions that accept fail_formatter parameter on initialization.\n\nSo I think this should be handled to pass the parameter for versions that support it and to use _fail_formatter in other cases until we raise the min version.\n\nTo determine which version we have we can use taskflow.version.version_string()","commit_id":"4a50c0779958df27410904ed28382e357a56450c"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"563ed05879eb7da773c1b224739f856bca7665bb","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            log\u003dlogger)"},{"line_number":88,"context_line":"        # TODO(vbala) Pass SpecialFormatter instance as kwarg once taskflow"},{"line_number":89,"context_line":"        # min version is raised to 2.7.0."},{"line_number":90,"context_line":"        self._fail_formatter \u003d SpecialFormatter(engine)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da4df55a_ed5f4a73","line":90,"in_reply_to":"da4df55a_cde4463d","updated":"2016-12-22 11:47:29.000000000","message":"We don\u0027t really know when TaskFlow will get bumped in global requirements. Right now it\u0027s only 1.26 [1]. We\u0027ll need to change the code here once it\u0027ll be bumped to 2.7 anyway.\n\n[1] https://github.com/openstack/requirements/blob/master/global-requirements.txt#L269","commit_id":"4a50c0779958df27410904ed28382e357a56450c"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"00b08d4a9e0a27a2c078dd286e7c3c5ef6d4ee3f","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            log\u003dlogger)"},{"line_number":88,"context_line":"        # TODO(vbala) Pass SpecialFormatter instance as kwarg once taskflow"},{"line_number":89,"context_line":"        # min version is raised to 2.7.0."},{"line_number":90,"context_line":"        self._fail_formatter \u003d SpecialFormatter(engine)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da4df55a_10bca604","line":90,"in_reply_to":"da4df55a_ed5f4a73","updated":"2016-12-22 12:20:56.000000000","message":"We are already using 2.7, that\u0027s why the gate is happy with this argument that isn\u0027t available until 2.7.  You can look at the upper constraints.  That\u0027s why I insist on the code using the new mechanism, because in 2.7.x _fail_formatter could be removed, so we better support the new mechanism now that we are fixing it.","commit_id":"4a50c0779958df27410904ed28382e357a56450c"}]}