)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"e676f1fcc9e668b8336ab4960775d4509006a798","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Tina \u003ctina.tang@emc.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-12-22 06:45:03 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add generic group support in VNX driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds the generic group support in VNX driver."},{"line_number":10,"context_line":"Consistency groups will be used as generic groups."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da4df55a_cbceadb3","line":7,"updated":"2016-12-23 19:30:38.000000000","message":"VNX driver already supports generic volume group in Newton by default.  Change this to: Add CG capability to Generic Groups in VNX driver","commit_id":"083be41e2c3a5bd0838c7c8cde333cc0627fb6c8"},{"author":{"_account_id":9988,"name":"Tina Tang","email":"tina.tang@emc.com","username":"Tina"},"change_message_id":"544d4c41d7bae391ec81ccaf64e7bdede117ccdc","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Tina \u003ctina.tang@emc.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-12-22 06:45:03 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add generic group support in VNX driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds the generic group support in VNX driver."},{"line_number":10,"context_line":"Consistency groups will be used as generic groups."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba5201f7_a4cf3ab2","line":7,"in_reply_to":"da4df55a_cbceadb3","updated":"2016-12-29 08:54:08.000000000","message":"Done","commit_id":"083be41e2c3a5bd0838c7c8cde333cc0627fb6c8"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"e676f1fcc9e668b8336ab4960775d4509006a798","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add generic group support in VNX driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds the generic group support in VNX driver."},{"line_number":10,"context_line":"Consistency groups will be used as generic groups."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"DocImpact:"},{"line_number":13,"context_line":"Implements: blueprint vnx-generic-group"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da4df55a_eb4c5144","line":10,"updated":"2016-12-23 19:30:38.000000000","message":"This patch adds the consistency group capability to the generic volume groups.","commit_id":"083be41e2c3a5bd0838c7c8cde333cc0627fb6c8"}],"cinder/tests/unit/volume/drivers/dell_emc/vnx/test_driver.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"d69650daec646ed5e323d82c59d7f8901ba3e8fc","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    def test_is_consistent_group_snapshot_enabled(self):"},{"line_number":76,"context_line":"        _driver \u003d self._get_driver(\u0027iscsi\u0027)"},{"line_number":77,"context_line":"        _driver._stats \u003d {\u0027consistent_group_snapshot_enabled\u0027: True}"},{"line_number":78,"context_line":"        self.assertIs(True, _driver.is_consistent_group_snapshot_enabled())"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba5201f7_6bda73eb","line":78,"updated":"2017-01-09 16:32:35.000000000","message":"Use assertTrue","commit_id":"25e054b55661e44aa4d90d611059a2571928eeb5"},{"author":{"_account_id":9988,"name":"Tina Tang","email":"tina.tang@emc.com","username":"Tina"},"change_message_id":"0ddba4e6ad8e27f666f854d3de6a4ec633f04c43","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    def test_is_consistent_group_snapshot_enabled(self):"},{"line_number":76,"context_line":"        _driver \u003d self._get_driver(\u0027iscsi\u0027)"},{"line_number":77,"context_line":"        _driver._stats \u003d {\u0027consistent_group_snapshot_enabled\u0027: True}"},{"line_number":78,"context_line":"        self.assertIs(True, _driver.is_consistent_group_snapshot_enabled())"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba5201f7_93941745","line":78,"in_reply_to":"ba5201f7_6bda73eb","updated":"2017-01-10 02:19:55.000000000","message":"Done","commit_id":"25e054b55661e44aa4d90d611059a2571928eeb5"}],"cinder/volume/drivers/dell_emc/vnx/adapter.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"8495d6947278a40ec929b0a87f4c0acf328f9493","unresolved":false,"context_lines":[{"line_number":648,"context_line":"        stats[\u0027consistencygroup_support\u0027] \u003d self.client.is_snap_enabled()"},{"line_number":649,"context_line":"        stats[\u0027replication_enabled\u0027] \u003d True if self.mirror_view else False"},{"line_number":650,"context_line":"        stats[\u0027consistent_group_snapshot_enabled\u0027] \u003d ("},{"line_number":651,"context_line":"            self.client.is_snap_enabled())"},{"line_number":652,"context_line":"        return stats"},{"line_number":653,"context_line":""},{"line_number":654,"context_line":"    def get_pool_stats(self, enabler_stats\u003dNone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5201f7_8904bf7e","line":651,"range":{"start_line":651,"start_character":24,"end_line":651,"end_character":41},"updated":"2017-01-03 20:39:15.000000000","message":"What if this returns False?  Generic volume group APIs should work even if consistent_group_snapshot_enabled \u003d False.  If the driver can\u0027t make it consistent when this flag is False, it should create a group of volumes like the default behavior (without this patch).\n\nIn the current design, the driver will try to make calls to VNX to create consistent groups even if consistent_group_snapshot_enabled \u003d False.","commit_id":"5e4f37fff1a97def0599c7eab8ad05512b787b9d"},{"author":{"_account_id":9988,"name":"Tina Tang","email":"tina.tang@emc.com","username":"Tina"},"change_message_id":"c323c7913e264f37200962d24dbceb4333c478e3","unresolved":false,"context_lines":[{"line_number":648,"context_line":"        stats[\u0027consistencygroup_support\u0027] \u003d self.client.is_snap_enabled()"},{"line_number":649,"context_line":"        stats[\u0027replication_enabled\u0027] \u003d True if self.mirror_view else False"},{"line_number":650,"context_line":"        stats[\u0027consistent_group_snapshot_enabled\u0027] \u003d ("},{"line_number":651,"context_line":"            self.client.is_snap_enabled())"},{"line_number":652,"context_line":"        return stats"},{"line_number":653,"context_line":""},{"line_number":654,"context_line":"    def get_pool_stats(self, enabler_stats\u003dNone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5201f7_526b1785","line":651,"range":{"start_line":651,"start_character":24,"end_line":651,"end_character":41},"in_reply_to":"ba5201f7_8904bf7e","updated":"2017-01-05 10:05:17.000000000","message":"Got it. I have just changed the driver to raise NotImplementedError when the value is False","commit_id":"5e4f37fff1a97def0599c7eab8ad05512b787b9d"}],"cinder/volume/drivers/dell_emc/vnx/driver.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"e676f1fcc9e668b8336ab4960775d4509006a798","unresolved":false,"context_lines":[{"line_number":252,"context_line":"        \"\"\"Return size of volume to be managed by manage_existing.\"\"\""},{"line_number":253,"context_line":"        return self.adapter.manage_existing_get_size(volume, existing_ref)"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    @utils.deprecated()"},{"line_number":256,"context_line":"    def create_consistencygroup(self, context, group):"},{"line_number":257,"context_line":"        \"\"\"Creates a consistencygroup.\"\"\""},{"line_number":258,"context_line":"        return self.adapter.create_consistencygroup(context, group)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da4df55a_4bb63d3e","line":255,"updated":"2016-12-23 19:30:38.000000000","message":"We are not deprecating these driver interface in Ocata yet.  These should stay until we can remove the CG tables from database.  Before that, the migrated CGs can only be operated by CG APIs.  See the following justed merged patch;\n\nhttps://review.openstack.org/#/c/401839/","commit_id":"083be41e2c3a5bd0838c7c8cde333cc0627fb6c8"},{"author":{"_account_id":9988,"name":"Tina Tang","email":"tina.tang@emc.com","username":"Tina"},"change_message_id":"544d4c41d7bae391ec81ccaf64e7bdede117ccdc","unresolved":false,"context_lines":[{"line_number":252,"context_line":"        \"\"\"Return size of volume to be managed by manage_existing.\"\"\""},{"line_number":253,"context_line":"        return self.adapter.manage_existing_get_size(volume, existing_ref)"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    @utils.deprecated()"},{"line_number":256,"context_line":"    def create_consistencygroup(self, context, group):"},{"line_number":257,"context_line":"        \"\"\"Creates a consistencygroup.\"\"\""},{"line_number":258,"context_line":"        return self.adapter.create_consistencygroup(context, group)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5201f7_e4c942ae","line":255,"in_reply_to":"da4df55a_4bb63d3e","updated":"2016-12-29 08:54:08.000000000","message":"Thanks for this information. I will remove the decorator","commit_id":"083be41e2c3a5bd0838c7c8cde333cc0627fb6c8"}],"releasenotes/notes/generic-groups-in-vnx-cbbe1346e889b5c2.yaml":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"8495d6947278a40ec929b0a87f4c0acf328f9493","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add CG capability to generic groups in VNX driver."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ba5201f7_494ad7c6","line":3,"updated":"2017-01-03 20:39:15.000000000","message":"generic volume groups","commit_id":"5e4f37fff1a97def0599c7eab8ad05512b787b9d"},{"author":{"_account_id":9988,"name":"Tina Tang","email":"tina.tang@emc.com","username":"Tina"},"change_message_id":"c323c7913e264f37200962d24dbceb4333c478e3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add CG capability to generic groups in VNX driver."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ba5201f7_12c7cf96","line":3,"in_reply_to":"ba5201f7_494ad7c6","updated":"2017-01-05 10:05:17.000000000","message":"Done","commit_id":"5e4f37fff1a97def0599c7eab8ad05512b787b9d"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"3214407dd791612ecb7d4363fc17587afa76d5fd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add consistent group capability to generic volume groups in VNX driver."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9a57fde8_9fa41f58","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":7},"updated":"2017-01-12 19:57:55.000000000","message":"Should be \"Added\", but we can clean that up when we do a general release note cleanup prior to release.","commit_id":"6359dcecd54b54b18edbffbd55e91809383cea6a"}]}