)]}'
{"cinder/opts.py":[{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"ff72622bd0fc27e2b0339038ab75c4a53c337fb5","unresolved":false,"context_lines":[{"line_number":73,"context_line":"from cinder.volume.drivers.datera import datera_iscsi as \\"},{"line_number":74,"context_line":"    cinder_volume_drivers_datera_dateraiscsi"},{"line_number":75,"context_line":"from cinder.volume.drivers.dell import dell_storagecenter_common as \\"},{"line_number":76,"context_line":"    cinder_volume_drivers_dell_dellstoragecentercommon"},{"line_number":77,"context_line":"from cinder.volume.drivers.dell_emc import ps as \\"},{"line_number":78,"context_line":"    cinder_volume_drivers_dell_emc_ps"},{"line_number":79,"context_line":"from cinder.volume.drivers.dell_emc.scaleio import driver as \\"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_877840f4","line":76,"range":{"start_line":76,"start_character":4,"end_line":76,"end_character":53},"updated":"2017-01-26 16:06:28.000000000","message":"Do we need to change that also to\ncinder_volume_drivers_dell_emc_dellstoragecentercommon","commit_id":"d0e0d8fc0a8a3e9edeff239086c62cd4c1903740"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"61e857b3c02042a99bfc31a569c8cb3c5282d1bd","unresolved":false,"context_lines":[{"line_number":73,"context_line":"from cinder.volume.drivers.datera import datera_iscsi as \\"},{"line_number":74,"context_line":"    cinder_volume_drivers_datera_dateraiscsi"},{"line_number":75,"context_line":"from cinder.volume.drivers.dell import dell_storagecenter_common as \\"},{"line_number":76,"context_line":"    cinder_volume_drivers_dell_dellstoragecentercommon"},{"line_number":77,"context_line":"from cinder.volume.drivers.dell_emc import ps as \\"},{"line_number":78,"context_line":"    cinder_volume_drivers_dell_emc_ps"},{"line_number":79,"context_line":"from cinder.volume.drivers.dell_emc.scaleio import driver as \\"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_0ad297d2","line":76,"range":{"start_line":76,"start_character":4,"end_line":76,"end_character":53},"in_reply_to":"3a461143_877840f4","updated":"2017-01-26 16:20:28.000000000","message":"No. This file is automatically generated, and all references will be updated once the corresponding changes are made for each one.","commit_id":"d0e0d8fc0a8a3e9edeff239086c62cd4c1903740"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"ff72622bd0fc27e2b0339038ab75c4a53c337fb5","unresolved":false,"context_lines":[{"line_number":75,"context_line":"from cinder.volume.drivers.dell import dell_storagecenter_common as \\"},{"line_number":76,"context_line":"    cinder_volume_drivers_dell_dellstoragecentercommon"},{"line_number":77,"context_line":"from cinder.volume.drivers.dell_emc import ps as \\"},{"line_number":78,"context_line":"    cinder_volume_drivers_dell_emc_ps"},{"line_number":79,"context_line":"from cinder.volume.drivers.dell_emc.scaleio import driver as \\"},{"line_number":80,"context_line":"    cinder_volume_drivers_dell_emc_scaleio_driver"},{"line_number":81,"context_line":"from cinder.volume.drivers.dell_emc.unity import driver as \\"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_a7ee1cb2","line":78,"range":{"start_line":78,"start_character":4,"end_line":78,"end_character":37},"updated":"2017-01-26 16:06:28.000000000","message":"that does not feel right.\nPS on its own does not exists so it is dell_ps.\nsimilar to dellstoragecenter.\nSo we should either be cinder_volume_drivers_dell_emc_dellps or dell_ps\nor cinder_volume_drivers_dell_ps.","commit_id":"d0e0d8fc0a8a3e9edeff239086c62cd4c1903740"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"dd2b5690f9199f60ff8fa39fc20c74b3bbcba979","unresolved":false,"context_lines":[{"line_number":75,"context_line":"from cinder.volume.drivers.dell import dell_storagecenter_common as \\"},{"line_number":76,"context_line":"    cinder_volume_drivers_dell_dellstoragecentercommon"},{"line_number":77,"context_line":"from cinder.volume.drivers.dell_emc import ps as \\"},{"line_number":78,"context_line":"    cinder_volume_drivers_dell_emc_ps"},{"line_number":79,"context_line":"from cinder.volume.drivers.dell_emc.scaleio import driver as \\"},{"line_number":80,"context_line":"    cinder_volume_drivers_dell_emc_scaleio_driver"},{"line_number":81,"context_line":"from cinder.volume.drivers.dell_emc.unity import driver as \\"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_6ac6bb4a","line":78,"range":{"start_line":78,"start_character":4,"end_line":78,"end_character":37},"in_reply_to":"3a461143_a7ee1cb2","updated":"2017-01-26 16:20:16.000000000","message":"Shouldn\u0027t it be Equallogic PS Series\nhttp://www.dell.com/us/business/p/equallogic-ps-series","commit_id":"d0e0d8fc0a8a3e9edeff239086c62cd4c1903740"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"ff72622bd0fc27e2b0339038ab75c4a53c337fb5","unresolved":false,"context_lines":[{"line_number":91,"context_line":"from cinder.volume.drivers import drbdmanagedrv as \\"},{"line_number":92,"context_line":"    cinder_volume_drivers_drbdmanagedrv"},{"line_number":93,"context_line":"from cinder.volume.drivers.emc import emc_vmax_common as \\"},{"line_number":94,"context_line":"    cinder_volume_drivers_emc_emcvmaxcommon"},{"line_number":95,"context_line":"from cinder.volume.drivers.falconstor import fss_common as \\"},{"line_number":96,"context_line":"    cinder_volume_drivers_falconstor_fsscommon"},{"line_number":97,"context_line":"from cinder.volume.drivers.fujitsu import eternus_dx_common as \\"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_6750b45f","line":94,"range":{"start_line":94,"start_character":4,"end_line":94,"end_character":43},"updated":"2017-01-26 16:06:28.000000000","message":"ditto. Need to be consistent across all Dell EMC drivers","commit_id":"d0e0d8fc0a8a3e9edeff239086c62cd4c1903740"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"ff72622bd0fc27e2b0339038ab75c4a53c337fb5","unresolved":false,"context_lines":[{"line_number":276,"context_line":"                cinder_volume_drivers_datera_dateraiscsi.d_opts,"},{"line_number":277,"context_line":"                cinder_volume_drivers_dell_dellstoragecentercommon."},{"line_number":278,"context_line":"                common_opts,"},{"line_number":279,"context_line":"                cinder_volume_drivers_dell_emc_ps.eqlx_opts,"},{"line_number":280,"context_line":"                cinder_volume_drivers_dell_emc_scaleio_driver.scaleio_opts,"},{"line_number":281,"context_line":"                cinder_volume_drivers_dell_emc_unity_driver.UNITY_OPTS,"},{"line_number":282,"context_line":"                cinder_volume_drivers_dell_emc_vnx_common.VNX_OPTS,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_07a0d042","line":279,"range":{"start_line":279,"start_character":16,"end_line":279,"end_character":59},"updated":"2017-01-26 16:06:28.000000000","message":"cinder_volume_drivers_dell_emc_dellps.eqlx_opts?\n\nhow does that impact deployment and upgrade tooling?","commit_id":"d0e0d8fc0a8a3e9edeff239086c62cd4c1903740"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"cf606c2354d40ba4b4606f1f4f3b54c1c0cfdb55","unresolved":false,"context_lines":[{"line_number":276,"context_line":"                cinder_volume_drivers_datera_dateraiscsi.d_opts,"},{"line_number":277,"context_line":"                cinder_volume_drivers_dell_dellstoragecentercommon."},{"line_number":278,"context_line":"                common_opts,"},{"line_number":279,"context_line":"                cinder_volume_drivers_dell_emc_ps.eqlx_opts,"},{"line_number":280,"context_line":"                cinder_volume_drivers_dell_emc_scaleio_driver.scaleio_opts,"},{"line_number":281,"context_line":"                cinder_volume_drivers_dell_emc_unity_driver.UNITY_OPTS,"},{"line_number":282,"context_line":"                cinder_volume_drivers_dell_emc_vnx_common.VNX_OPTS,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a461143_f9e0b9fc","line":279,"range":{"start_line":279,"start_character":50,"end_line":279,"end_character":59},"updated":"2017-01-26 21:08:53.000000000","message":"nit pic.\nshould this be dell_emc_ps.ps_opts ?","commit_id":"8f12e71432ee8b37ead1d487166d50a2cacfe049"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"28af69ce6d2a3a2053c48a53bf472a898ad9fac6","unresolved":false,"context_lines":[{"line_number":276,"context_line":"                cinder_volume_drivers_datera_dateraiscsi.d_opts,"},{"line_number":277,"context_line":"                cinder_volume_drivers_dell_dellstoragecentercommon."},{"line_number":278,"context_line":"                common_opts,"},{"line_number":279,"context_line":"                cinder_volume_drivers_dell_emc_ps.eqlx_opts,"},{"line_number":280,"context_line":"                cinder_volume_drivers_dell_emc_scaleio_driver.scaleio_opts,"},{"line_number":281,"context_line":"                cinder_volume_drivers_dell_emc_unity_driver.UNITY_OPTS,"},{"line_number":282,"context_line":"                cinder_volume_drivers_dell_emc_vnx_common.VNX_OPTS,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a461143_bca45fb9","line":279,"range":{"start_line":279,"start_character":50,"end_line":279,"end_character":59},"in_reply_to":"3a461143_f9e0b9fc","updated":"2017-01-26 21:28:02.000000000","message":"This is an automatically generated file and these are just used for extracting the config options used in cinder.conf.","commit_id":"8f12e71432ee8b37ead1d487166d50a2cacfe049"}],"cinder/tests/unit/volume/drivers/dell_emc/test_ps.py":[{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"ff72622bd0fc27e2b0339038ab75c4a53c337fb5","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from cinder import test"},{"line_number":29,"context_line":"from cinder import utils"},{"line_number":30,"context_line":"from cinder.volume import configuration as conf"},{"line_number":31,"context_line":"from cinder.volume.drivers.dell_emc import ps"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"class PSSeriesISCSIDriverTestCase(test.TestCase):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_87abe01c","line":31,"range":{"start_line":31,"start_character":43,"end_line":31,"end_character":45},"updated":"2017-01-26 16:06:28.000000000","message":"really prefer ps-\u003e dell_ps.","commit_id":"d0e0d8fc0a8a3e9edeff239086c62cd4c1903740"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"dd2b5690f9199f60ff8fa39fc20c74b3bbcba979","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from cinder import test"},{"line_number":29,"context_line":"from cinder import utils"},{"line_number":30,"context_line":"from cinder.volume import configuration as conf"},{"line_number":31,"context_line":"from cinder.volume.drivers.dell_emc import ps"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"class PSSeriesISCSIDriverTestCase(test.TestCase):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_ca2b2fea","line":31,"range":{"start_line":31,"start_character":43,"end_line":31,"end_character":45},"in_reply_to":"3a461143_87abe01c","updated":"2017-01-26 16:20:16.000000000","message":"equallogic_ps or eqlx_ps\nhttp://www.dell.com/us/business/p/equallogic-ps-series","commit_id":"d0e0d8fc0a8a3e9edeff239086c62cd4c1903740"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"dd2b5690f9199f60ff8fa39fc20c74b3bbcba979","unresolved":false,"context_lines":[{"line_number":61,"context_line":"                                    \u0027VolumeReserve: 80GB\u0027]"},{"line_number":62,"context_line":"        self.cmd \u003d \u0027this is dummy command\u0027"},{"line_number":63,"context_line":"        self._context \u003d context.get_admin_context()"},{"line_number":64,"context_line":"        self.driver \u003d ps.PSSeriesISCSIDriver("},{"line_number":65,"context_line":"            configuration\u003dself.configuration)"},{"line_number":66,"context_line":"        self.volume_name \u003d \"fakevolume\""},{"line_number":67,"context_line":"        self.volid \u003d \"fakeid\""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_8a4f67bc","line":64,"updated":"2017-01-26 16:20:16.000000000","message":"Prefer EquallogicPSSeries or DellPSSeries or DEllEQLPSSeries","commit_id":"d0e0d8fc0a8a3e9edeff239086c62cd4c1903740"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"406a44f672f46515f7a047c6939c01ee073a5c65","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#    Copyright (c) 2013-2017 Dell Inc, or its subsidiaries."},{"line_number":2,"context_line":"#    Copyright 2013 OpenStack Foundation"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_cd37c9ae","line":1,"updated":"2017-01-26 16:32:31.000000000","message":"I was told by Legal that we should not change the copyright header of an existing file.  This new copyright header is only needed for a new file.\n\nWe have this range in some of our code too, but actually there\u0027s no need to add a range.  Only the year when you first published the code is needed.\n\nhttps://wiki.openstack.org/wiki/Documentation/Copyright","commit_id":"0594529a8f896531bf79f41aa96020cf51309072"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"222fd1b7a776b575dacd114b9317f2a27c8b5f9e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#    Copyright (c) 2013-2017 Dell Inc, or its subsidiaries."},{"line_number":2,"context_line":"#    Copyright 2013 OpenStack Foundation"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_8e693428","line":1,"in_reply_to":"3a461143_38808946","updated":"2017-01-26 18:45:19.000000000","message":"I am fine with this copyright.","commit_id":"0594529a8f896531bf79f41aa96020cf51309072"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"3817b5e9a5d51e5131999b77c8fa98be95354ceb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#    Copyright (c) 2013-2017 Dell Inc, or its subsidiaries."},{"line_number":2,"context_line":"#    Copyright 2013 OpenStack Foundation"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_38808946","line":1,"in_reply_to":"3a461143_4ddcb9e4","updated":"2017-01-26 16:45:22.000000000","message":"Arkady,\n\nDo you suggest to keep the copyright change on line 1 or change it to something else?  Thanks.","commit_id":"0594529a8f896531bf79f41aa96020cf51309072"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"e8c2471c8049f7f663c7595963bd654262b46753","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#    Copyright (c) 2013-2017 Dell Inc, or its subsidiaries."},{"line_number":2,"context_line":"#    Copyright 2013 OpenStack Foundation"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_4ddcb9e4","line":1,"in_reply_to":"3a461143_adc0bd2b","updated":"2017-01-26 16:38:58.000000000","message":"And standard open source model is update year as you make a change in a new year.\nPrefer to stick to well understood community rules.\nAnd we can make related change to copyright ones we touch it.","commit_id":"0594529a8f896531bf79f41aa96020cf51309072"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"0b89a0e3a2ce707fbc4df87f213b6683cccd4a3a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#    Copyright (c) 2013-2017 Dell Inc, or its subsidiaries."},{"line_number":2,"context_line":"#    Copyright 2013 OpenStack Foundation"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_adc0bd2b","line":1,"in_reply_to":"3a461143_cd37c9ae","updated":"2017-01-26 16:34:16.000000000","message":"Hah, and of course I was told the opposite by legal. :)","commit_id":"0594529a8f896531bf79f41aa96020cf51309072"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"cf606c2354d40ba4b4606f1f4f3b54c1c0cfdb55","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from cinder import test"},{"line_number":29,"context_line":"from cinder import utils"},{"line_number":30,"context_line":"from cinder.volume import configuration as conf"},{"line_number":31,"context_line":"from cinder.volume.drivers.dell_emc import ps"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"class PSSeriesISCSIDriverTestCase(test.TestCase):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a461143_99ba55e0","line":31,"range":{"start_line":31,"start_character":43,"end_line":31,"end_character":45},"updated":"2017-01-26 21:08:53.000000000","message":"cringe - but accept.","commit_id":"8f12e71432ee8b37ead1d487166d50a2cacfe049"}],"cinder/volume/drivers/dell_emc/ps.py":[{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"ff72622bd0fc27e2b0339038ab75c4a53c337fb5","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"\"\"\"Volume driver for Dell PS Series Storage.\"\"\""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import functools"},{"line_number":19,"context_line":"import math"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_c731680d","line":16,"range":{"start_line":16,"start_character":21,"end_line":16,"end_character":34},"updated":"2017-01-26 16:06:28.000000000","message":"should it be Dell EMC Dell PS Series?","commit_id":"d0e0d8fc0a8a3e9edeff239086c62cd4c1903740"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"dd2b5690f9199f60ff8fa39fc20c74b3bbcba979","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"\"\"\"Volume driver for Dell PS Series Storage.\"\"\""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import functools"},{"line_number":19,"context_line":"import math"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_6ad79bbf","line":16,"range":{"start_line":16,"start_character":21,"end_line":16,"end_character":34},"in_reply_to":"3a461143_c731680d","updated":"2017-01-26 16:20:16.000000000","message":"Dell EMC EqualLogic PS Series","commit_id":"d0e0d8fc0a8a3e9edeff239086c62cd4c1903740"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"61e857b3c02042a99bfc31a569c8cb3c5282d1bd","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"\"\"\"Volume driver for Dell PS Series Storage.\"\"\""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import functools"},{"line_number":19,"context_line":"import math"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_6a85dbab","line":16,"range":{"start_line":16,"start_character":21,"end_line":16,"end_character":34},"in_reply_to":"3a461143_c731680d","updated":"2017-01-26 16:20:28.000000000","message":"Good point. I will just remove the references to Dell in the comments.","commit_id":"d0e0d8fc0a8a3e9edeff239086c62cd4c1903740"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"ff72622bd0fc27e2b0339038ab75c4a53c337fb5","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"@interface.volumedriver"},{"line_number":82,"context_line":"class PSSeriesISCSIDriver(san.SanISCSIDriver):"},{"line_number":83,"context_line":"    \"\"\"Implements commands for Dell EMC PS Series ISCSI management."},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    To enable the driver add the following line to the cinder configuration:"},{"line_number":86,"context_line":"        volume_driver\u003dcinder.volume.drivers.dell_emc.ps.PSSeriesISCSIDriver"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_6708b42e","line":83,"range":{"start_line":83,"start_character":31,"end_line":83,"end_character":49},"updated":"2017-01-26 16:06:28.000000000","message":"inconsistent with above Dell PS series terminology.","commit_id":"d0e0d8fc0a8a3e9edeff239086c62cd4c1903740"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"dd2b5690f9199f60ff8fa39fc20c74b3bbcba979","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"@interface.volumedriver"},{"line_number":82,"context_line":"class PSSeriesISCSIDriver(san.SanISCSIDriver):"},{"line_number":83,"context_line":"    \"\"\"Implements commands for Dell EMC PS Series ISCSI management."},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    To enable the driver add the following line to the cinder configuration:"},{"line_number":86,"context_line":"        volume_driver\u003dcinder.volume.drivers.dell_emc.ps.PSSeriesISCSIDriver"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_2aa3d350","line":83,"range":{"start_line":83,"start_character":31,"end_line":83,"end_character":49},"in_reply_to":"3a461143_6708b42e","updated":"2017-01-26 16:20:16.000000000","message":"Dell EMC EqualLogic PS Series","commit_id":"d0e0d8fc0a8a3e9edeff239086c62cd4c1903740"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"dd2b5690f9199f60ff8fa39fc20c74b3bbcba979","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        1.3.0 - Added support for manage/unmanage volume"},{"line_number":134,"context_line":"        1.4.0 - Removed deprecated options eqlx_cli_timeout, eqlx_use_chap,"},{"line_number":135,"context_line":"                eqlx_chap_login, and eqlx_chap_password."},{"line_number":136,"context_line":"        1.4.1 - Rebranded driver to Dell EMC."},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    \"\"\""},{"line_number":139,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_6aacfb35","line":136,"updated":"2017-01-26 16:20:16.000000000","message":"to DellEMC one word?\nto DellEMC EqualLogic PS Series?","commit_id":"d0e0d8fc0a8a3e9edeff239086c62cd4c1903740"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"20713af2f1e4c7c053df333484c657ea673d1d89","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        1.3.0 - Added support for manage/unmanage volume"},{"line_number":134,"context_line":"        1.4.0 - Removed deprecated options eqlx_cli_timeout, eqlx_use_chap,"},{"line_number":135,"context_line":"                eqlx_chap_login, and eqlx_chap_password."},{"line_number":136,"context_line":"        1.4.1 - Rebranded driver to Dell EMC."},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    \"\"\""},{"line_number":139,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_6a087b2e","line":136,"in_reply_to":"3a461143_6aacfb35","updated":"2017-01-26 16:21:40.000000000","message":"No, the name is Dell EMC, not DellEMC.","commit_id":"d0e0d8fc0a8a3e9edeff239086c62cd4c1903740"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"dd2b5690f9199f60ff8fa39fc20c74b3bbcba979","unresolved":false,"context_lines":[{"line_number":158,"context_line":"                # says \"If a string of length zero is returned, the channel"},{"line_number":159,"context_line":"                # stream has closed\". So we can confirm that the PS server"},{"line_number":160,"context_line":"                # has closed the connection."},{"line_number":161,"context_line":"                msg \u003d _(\"The PS array has closed the connection.\")"},{"line_number":162,"context_line":"                LOG.error(msg)"},{"line_number":163,"context_line":"                raise exception.VolumeBackendAPIException(data\u003dmsg)"},{"line_number":164,"context_line":"            out +\u003d ret"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_ea662b28","line":161,"updated":"2017-01-26 16:20:16.000000000","message":"Ditto EqualLogic PS","commit_id":"d0e0d8fc0a8a3e9edeff239086c62cd4c1903740"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"dd2b5690f9199f60ff8fa39fc20c74b3bbcba979","unresolved":false,"context_lines":[{"line_number":196,"context_line":"            completed \u003d True"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"            if any(ln.startswith((\u0027% Error\u0027, \u0027Error:\u0027)) for ln in out):"},{"line_number":199,"context_line":"                desc \u003d _(\"Error executing PS command\")"},{"line_number":200,"context_line":"                cmdout \u003d \u0027\\n\u0027.join(out)"},{"line_number":201,"context_line":"                LOG.error(_LE(\"%s\"), cmdout)"},{"line_number":202,"context_line":"                raise processutils.ProcessExecutionError("}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_0a6e1701","line":199,"updated":"2017-01-26 16:20:16.000000000","message":"ditto","commit_id":"d0e0d8fc0a8a3e9edeff239086c62cd4c1903740"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"dd2b5690f9199f60ff8fa39fc20c74b3bbcba979","unresolved":false,"context_lines":[{"line_number":290,"context_line":"        if self.configuration:"},{"line_number":291,"context_line":"            backend_name \u003d self.configuration.safe_get(\u0027volume_backend_name\u0027)"},{"line_number":292,"context_line":"        data[\"volume_backend_name\"] \u003d backend_name or \u0027eqlx\u0027"},{"line_number":293,"context_line":"        data[\"vendor_name\"] \u003d \u0027Dell EMC\u0027"},{"line_number":294,"context_line":"        data[\"driver_version\"] \u003d self.VERSION"},{"line_number":295,"context_line":"        data[\"storage_protocol\"] \u003d \u0027iSCSI\u0027"},{"line_number":296,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_4a781fc5","line":293,"updated":"2017-01-26 16:20:16.000000000","message":"One word DellEMC?","commit_id":"d0e0d8fc0a8a3e9edeff239086c62cd4c1903740"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"406a44f672f46515f7a047c6939c01ee073a5c65","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#    Copyright (c) 2013-2017 Dell Inc, or its subsidiaries."},{"line_number":2,"context_line":"#    Copyright 2013 OpenStack Foundation"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_2d2a0d2d","line":1,"updated":"2017-01-26 16:32:31.000000000","message":"Same comment as earlier.  No need to change the copyright header.","commit_id":"0594529a8f896531bf79f41aa96020cf51309072"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"cf606c2354d40ba4b4606f1f4f3b54c1c0cfdb55","unresolved":false,"context_lines":[{"line_number":158,"context_line":"                # says \"If a string of length zero is returned, the channel"},{"line_number":159,"context_line":"                # stream has closed\". So we can confirm that the PS server"},{"line_number":160,"context_line":"                # has closed the connection."},{"line_number":161,"context_line":"                msg \u003d _(\"The PS array has closed the connection.\")"},{"line_number":162,"context_line":"                LOG.error(msg)"},{"line_number":163,"context_line":"                raise exception.VolumeBackendAPIException(data\u003dmsg)"},{"line_number":164,"context_line":"            out +\u003d ret"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a461143_7972094b","line":161,"range":{"start_line":161,"start_character":29,"end_line":161,"end_character":37},"updated":"2017-01-26 21:08:53.000000000","message":"should we change it to Dell EMC PS array?","commit_id":"8f12e71432ee8b37ead1d487166d50a2cacfe049"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"cf606c2354d40ba4b4606f1f4f3b54c1c0cfdb55","unresolved":false,"context_lines":[{"line_number":196,"context_line":"            completed \u003d True"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"            if any(ln.startswith((\u0027% Error\u0027, \u0027Error:\u0027)) for ln in out):"},{"line_number":199,"context_line":"                desc \u003d _(\"Error executing PS command\")"},{"line_number":200,"context_line":"                cmdout \u003d \u0027\\n\u0027.join(out)"},{"line_number":201,"context_line":"                LOG.error(_LE(\"%s\"), cmdout)"},{"line_number":202,"context_line":"                raise processutils.ProcessExecutionError("}],"source_content_type":"text/x-python","patch_set":4,"id":"3a461143_39cde15d","line":199,"range":{"start_line":199,"start_character":42,"end_line":199,"end_character":45},"updated":"2017-01-26 21:08:53.000000000","message":"The name of the class is PSseries.\nShould this be PS series command?","commit_id":"8f12e71432ee8b37ead1d487166d50a2cacfe049"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"cf606c2354d40ba4b4606f1f4f3b54c1c0cfdb55","unresolved":false,"context_lines":[{"line_number":231,"context_line":"                while attempts \u003e 0:"},{"line_number":232,"context_line":"                    attempts -\u003d 1"},{"line_number":233,"context_line":"                    try:"},{"line_number":234,"context_line":"                        LOG.info(_LI(\u0027PS-driver: executing \"%s\".\u0027), command)"},{"line_number":235,"context_line":"                        return self._ssh_execute("},{"line_number":236,"context_line":"                            ssh, command,"},{"line_number":237,"context_line":"                            timeout\u003dself.configuration.ssh_conn_timeout)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a461143_9904157f","line":234,"range":{"start_line":234,"start_character":38,"end_line":234,"end_character":40},"updated":"2017-01-26 21:08:53.000000000","message":"ditto.","commit_id":"8f12e71432ee8b37ead1d487166d50a2cacfe049"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"cf606c2354d40ba4b4606f1f4f3b54c1c0cfdb55","unresolved":false,"context_lines":[{"line_number":397,"context_line":"                    out_tup \u003d line.rstrip().partition(\u0027 \u0027)"},{"line_number":398,"context_line":"                    self._group_ip \u003d out_tup[-1]"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"            LOG.info(_LI(\u0027PS-driver: Setup is complete, group IP is \"%s\".\u0027),"},{"line_number":401,"context_line":"                     self._group_ip)"},{"line_number":402,"context_line":"        except Exception:"},{"line_number":403,"context_line":"            with excutils.save_and_reraise_exception():"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a461143_19f90581","line":400,"range":{"start_line":400,"start_character":26,"end_line":400,"end_character":28},"updated":"2017-01-26 21:08:53.000000000","message":"ditto","commit_id":"8f12e71432ee8b37ead1d487166d50a2cacfe049"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"d9a4cf77426bb4106bae1727749505921757c3b6","unresolved":false,"context_lines":[{"line_number":402,"context_line":"                     self._group_ip)"},{"line_number":403,"context_line":"        except Exception:"},{"line_number":404,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":405,"context_line":"                LOG.error(_LE(\u0027Failed to setup the Dell EMC PS driver.\u0027))"},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"    def create_volume(self, volume):"},{"line_number":408,"context_line":"        \"\"\"Create a volume.\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a461143_a5636240","line":405,"range":{"start_line":405,"start_character":62,"end_line":405,"end_character":63},"updated":"2017-01-26 22:38:20.000000000","message":"PS series driver","commit_id":"f265db05d02816113e3706fae9f9b23bba2b068c"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"2988c1b7df88a9838f2a0b6ef40d9a30c31120f4","unresolved":false,"context_lines":[{"line_number":402,"context_line":"                     self._group_ip)"},{"line_number":403,"context_line":"        except Exception:"},{"line_number":404,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":405,"context_line":"                LOG.error(_LE(\u0027Failed to setup the Dell EMC PS driver.\u0027))"},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"    def create_volume(self, volume):"},{"line_number":408,"context_line":"        \"\"\"Create a volume.\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a461143_e5a2ca4a","line":405,"range":{"start_line":405,"start_character":62,"end_line":405,"end_character":63},"in_reply_to":"3a461143_a5636240","updated":"2017-01-26 22:39:23.000000000","message":"The array is a PS array. It is part of the PS Series of arrays.","commit_id":"f265db05d02816113e3706fae9f9b23bba2b068c"}],"cinder/volume/manager.py":[{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"dd2b5690f9199f60ff8fa39fc20c74b3bbcba979","unresolved":false,"context_lines":[{"line_number":165,"context_line":"    \u0027cinder.volume.drivers.dell_emc.xtremio.XtremIOFCDriver\u0027,"},{"line_number":166,"context_line":"    \u0027cinder.volume.drivers.datera.DateraDriver\u0027:"},{"line_number":167,"context_line":"    \u0027cinder.volume.drivers.datera.datera_iscsi.DateraDriver\u0027,"},{"line_number":168,"context_line":"    \u0027cinder.volume.drivers.eqlx.DellEQLSanISCSIDriver\u0027:"},{"line_number":169,"context_line":"    \u0027cinder.volume.drivers.dell_emc.ps.PSSeriesISCSIDriver\u0027,"},{"line_number":170,"context_line":"}"},{"line_number":171,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_8a820793","line":168,"updated":"2017-01-26 16:20:16.000000000","message":"ditto","commit_id":"d0e0d8fc0a8a3e9edeff239086c62cd4c1903740"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"6476ecf2de14a960009b9b9e9e6ffa32d6f59bb6","unresolved":false,"context_lines":[{"line_number":165,"context_line":"    \u0027cinder.volume.drivers.dell_emc.xtremio.XtremIOFCDriver\u0027,"},{"line_number":166,"context_line":"    \u0027cinder.volume.drivers.datera.DateraDriver\u0027:"},{"line_number":167,"context_line":"    \u0027cinder.volume.drivers.datera.datera_iscsi.DateraDriver\u0027,"},{"line_number":168,"context_line":"\u003c\u003c\u003c\u003c\u003c\u003c\u003c 6932b2b5174214eda51f448c6a169d9ca219a757"},{"line_number":169,"context_line":"    \u0027cinder.volume.drivers.emc.emc_vmax_iscsi.EMCVMAXISCSIDriver\u0027:"},{"line_number":170,"context_line":"    \u0027cinder.volume.drivers.dell_emc.vmax.iscsi.VMAXISCSIDriver\u0027,"},{"line_number":171,"context_line":"    \u0027cinder.volume.drivers.emc.emc_vmax_fc.EMCVMAXFCDriver\u0027:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a461143_baac3836","line":168,"range":{"start_line":168,"start_character":0,"end_line":168,"end_character":48},"updated":"2017-01-27 18:53:38.000000000","message":"looks like cherry picking crud.","commit_id":"d3576b0ff3600e75c244d5db0023fb4a43d20dca"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"31f4f27824030bea84542d906ef5953f7b005239","unresolved":false,"context_lines":[{"line_number":165,"context_line":"    \u0027cinder.volume.drivers.dell_emc.xtremio.XtremIOFCDriver\u0027,"},{"line_number":166,"context_line":"    \u0027cinder.volume.drivers.datera.DateraDriver\u0027:"},{"line_number":167,"context_line":"    \u0027cinder.volume.drivers.datera.datera_iscsi.DateraDriver\u0027,"},{"line_number":168,"context_line":"\u003c\u003c\u003c\u003c\u003c\u003c\u003c 6932b2b5174214eda51f448c6a169d9ca219a757"},{"line_number":169,"context_line":"    \u0027cinder.volume.drivers.emc.emc_vmax_iscsi.EMCVMAXISCSIDriver\u0027:"},{"line_number":170,"context_line":"    \u0027cinder.volume.drivers.dell_emc.vmax.iscsi.VMAXISCSIDriver\u0027,"},{"line_number":171,"context_line":"    \u0027cinder.volume.drivers.emc.emc_vmax_fc.EMCVMAXFCDriver\u0027:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a461143_35c059e0","line":168,"range":{"start_line":168,"start_character":0,"end_line":168,"end_character":48},"in_reply_to":"3a461143_baac3836","updated":"2017-01-27 19:15:57.000000000","message":"Whoops, missed that. Surprised rebase didn\u0027t complain about that. Good catch!","commit_id":"d3576b0ff3600e75c244d5db0023fb4a43d20dca"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"6476ecf2de14a960009b9b9e9e6ffa32d6f59bb6","unresolved":false,"context_lines":[{"line_number":173,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":174,"context_line":"    \u0027cinder.volume.drivers.eqlx.DellEQLSanISCSIDriver\u0027:"},{"line_number":175,"context_line":"    \u0027cinder.volume.drivers.dell_emc.ps.PSSeriesISCSIDriver\u0027,"},{"line_number":176,"context_line":"\u003e\u003e\u003e\u003e\u003e\u003e\u003e Rebrand and move EQLX driver to dell_emc folder"},{"line_number":177,"context_line":"}"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3a461143_7a71f0df","line":176,"range":{"start_line":176,"start_character":0,"end_line":176,"end_character":55},"updated":"2017-01-27 18:53:38.000000000","message":"ditto","commit_id":"d3576b0ff3600e75c244d5db0023fb4a43d20dca"}],"releasenotes/notes/move-eqlx-driver-to-dell-emc-fe5d2b484c47b7a6.yaml":[{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"ff72622bd0fc27e2b0339038ab75c4a53c337fb5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - The EqualLogic driver is moved to the dell_emc directory and has been"},{"line_number":4,"context_line":"    rebranded to its current PS Series name. The volume_driver entry in"},{"line_number":5,"context_line":"    cinder.conf needs to be changed to"},{"line_number":6,"context_line":"    cinder.volume.drivers.dell_emc.ps.PSSeriesISCSIDriver."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3a461143_0a21b79f","line":4,"range":{"start_line":4,"start_character":29,"end_line":4,"end_character":38},"updated":"2017-01-26 16:06:28.000000000","message":"Dell PS Series.\nPS series in isolation does not exist.","commit_id":"d0e0d8fc0a8a3e9edeff239086c62cd4c1903740"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"61e857b3c02042a99bfc31a569c8cb3c5282d1bd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - The EqualLogic driver is moved to the dell_emc directory and has been"},{"line_number":4,"context_line":"    rebranded to its current PS Series name. The volume_driver entry in"},{"line_number":5,"context_line":"    cinder.conf needs to be changed to"},{"line_number":6,"context_line":"    cinder.volume.drivers.dell_emc.ps.PSSeriesISCSIDriver."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3a461143_4ab1ff8e","line":4,"range":{"start_line":4,"start_character":29,"end_line":4,"end_character":38},"in_reply_to":"3a461143_0a21b79f","updated":"2017-01-26 16:20:28.000000000","message":"Actually, that is the product name. Just like EqualLogic was still used, the product is call the PS Series.","commit_id":"d0e0d8fc0a8a3e9edeff239086c62cd4c1903740"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"dd2b5690f9199f60ff8fa39fc20c74b3bbcba979","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - The EqualLogic driver is moved to the dell_emc directory and has been"},{"line_number":4,"context_line":"    rebranded to its current PS Series name. The volume_driver entry in"},{"line_number":5,"context_line":"    cinder.conf needs to be changed to"},{"line_number":6,"context_line":"    cinder.volume.drivers.dell_emc.ps.PSSeriesISCSIDriver."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3a461143_aa7d03b3","line":4,"range":{"start_line":4,"start_character":29,"end_line":4,"end_character":38},"in_reply_to":"3a461143_0a21b79f","updated":"2017-01-26 16:20:16.000000000","message":"Dell EMC EqualLogic PS Series","commit_id":"d0e0d8fc0a8a3e9edeff239086c62cd4c1903740"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"ff2c6bda05ab78c701d51961c2124308fe7f9644","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - The EqualLogic driver is moved to the dell_emc directory and has been"},{"line_number":4,"context_line":"    rebranded to its current Dell EMC PS Series name. The volume_driver"},{"line_number":5,"context_line":"    entry in cinder.conf needs to be changed to"},{"line_number":6,"context_line":"    cinder.volume.drivers.dell_emc.ps.PSSeriesISCSIDriver."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3a461143_35e139d1","line":6,"updated":"2017-01-27 19:11:28.000000000","message":"Should also mention the impact on the config options.  Right?","commit_id":"d3576b0ff3600e75c244d5db0023fb4a43d20dca"}]}