)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},"change_message_id":"d85a4935b0d75cfd4af72228452cd0a5410232a3","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add orm type check for paginate_query"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Cinder rasises 500 error if the sort key is the resources"},{"line_number":10,"context_line":"objest\u0027 property."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch add the type check to prevent querying with non-ORM"},{"line_number":13,"context_line":"propery."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba5201f7_355f8b0f","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":7},"updated":"2017-01-04 10:52:21.000000000","message":"object\u0027s?","commit_id":"a3408dbfb25487c4b15f26457e5bfaa0663cb7bf"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"b25aaa7981ec0880cef4929df2004b9c85fb4030","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add orm type check for paginate_query"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Cinder rasises 500 error if the sort key is the resources"},{"line_number":10,"context_line":"objest\u0027 property."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch add the type check to prevent querying with non-ORM"},{"line_number":13,"context_line":"propery."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba5201f7_766addef","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":7},"in_reply_to":"ba5201f7_355f8b0f","updated":"2017-01-05 01:21:05.000000000","message":"Done","commit_id":"a3408dbfb25487c4b15f26457e5bfaa0663cb7bf"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"64dc122310c728cd1b1cfbdfc3dc559889b603ae","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add orm type check for paginate_query"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Cinder rasises 500 error if the sort key is the resources\u0027"},{"line_number":10,"context_line":"object property."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch add the type check to prevent querying with non-ORM"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ba5201f7_4311445c","line":9,"range":{"start_line":9,"start_character":7,"end_line":9,"end_character":14},"updated":"2017-01-07 05:33:18.000000000","message":"raises","commit_id":"3ab03318ac7cf98374fa74d6fe2befed1833b904"}],"cinder/tests/unit/objects/test_volume.py":[{"author":{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},"change_message_id":"d85a4935b0d75cfd4af72228452cd0a5410232a3","unresolved":false,"context_lines":[{"line_number":563,"context_line":"    def test_get_by_project_with_sort_key(self):"},{"line_number":564,"context_line":"        fake_volume.fake_db_volume()"},{"line_number":565,"context_line":""},{"line_number":566,"context_line":"        sort_keys \u003d [\"name_id\"]"},{"line_number":567,"context_line":"        self.assertRaises(exception.InvalidInput,"},{"line_number":568,"context_line":"                          objects.VolumeList.get_all_by_project,"},{"line_number":569,"context_line":"                          self.context,"},{"line_number":570,"context_line":"                          self.context.project_id,"},{"line_number":571,"context_line":"                          sort_keys\u003dsort_keys)"},{"line_number":572,"context_line":""},{"line_number":573,"context_line":"        sort_keys \u003d [\"__contains__\"]"},{"line_number":574,"context_line":"        self.assertRaises(exception.InvalidInput,"},{"line_number":575,"context_line":"                          objects.VolumeList.get_all_by_project,"},{"line_number":576,"context_line":"                          self.context,"},{"line_number":577,"context_line":"                          self.context.project_id,"},{"line_number":578,"context_line":"                          sort_keys\u003dsort_keys)"},{"line_number":579,"context_line":""},{"line_number":580,"context_line":"    @mock.patch(\u0027cinder.db.volume_include_in_cluster\u0027)"},{"line_number":581,"context_line":"    def test_include_in_cluster(self, include_mock):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5201f7_b55b7b2d","line":578,"range":{"start_line":566,"start_character":0,"end_line":578,"end_character":46},"updated":"2017-01-04 10:52:21.000000000","message":"-1\nI think it is better to use ddt library here not to duplicate the same code","commit_id":"a3408dbfb25487c4b15f26457e5bfaa0663cb7bf"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"860c85663633f34552790dc86a605f694fcd62a3","unresolved":false,"context_lines":[{"line_number":563,"context_line":"    def test_get_by_project_with_sort_key(self):"},{"line_number":564,"context_line":"        fake_volume.fake_db_volume()"},{"line_number":565,"context_line":""},{"line_number":566,"context_line":"        sort_keys \u003d [\"name_id\"]"},{"line_number":567,"context_line":"        self.assertRaises(exception.InvalidInput,"},{"line_number":568,"context_line":"                          objects.VolumeList.get_all_by_project,"},{"line_number":569,"context_line":"                          self.context,"},{"line_number":570,"context_line":"                          self.context.project_id,"},{"line_number":571,"context_line":"                          sort_keys\u003dsort_keys)"},{"line_number":572,"context_line":""},{"line_number":573,"context_line":"        sort_keys \u003d [\"__contains__\"]"},{"line_number":574,"context_line":"        self.assertRaises(exception.InvalidInput,"},{"line_number":575,"context_line":"                          objects.VolumeList.get_all_by_project,"},{"line_number":576,"context_line":"                          self.context,"},{"line_number":577,"context_line":"                          self.context.project_id,"},{"line_number":578,"context_line":"                          sort_keys\u003dsort_keys)"},{"line_number":579,"context_line":""},{"line_number":580,"context_line":"    @mock.patch(\u0027cinder.db.volume_include_in_cluster\u0027)"},{"line_number":581,"context_line":"    def test_include_in_cluster(self, include_mock):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5201f7_ef4c3dca","line":578,"range":{"start_line":566,"start_character":0,"end_line":578,"end_character":46},"in_reply_to":"ba5201f7_b55b7b2d","updated":"2017-01-04 20:20:42.000000000","message":"Agreed about ddt.  This is two separate tests.","commit_id":"a3408dbfb25487c4b15f26457e5bfaa0663cb7bf"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"b25aaa7981ec0880cef4929df2004b9c85fb4030","unresolved":false,"context_lines":[{"line_number":563,"context_line":"    def test_get_by_project_with_sort_key(self):"},{"line_number":564,"context_line":"        fake_volume.fake_db_volume()"},{"line_number":565,"context_line":""},{"line_number":566,"context_line":"        sort_keys \u003d [\"name_id\"]"},{"line_number":567,"context_line":"        self.assertRaises(exception.InvalidInput,"},{"line_number":568,"context_line":"                          objects.VolumeList.get_all_by_project,"},{"line_number":569,"context_line":"                          self.context,"},{"line_number":570,"context_line":"                          self.context.project_id,"},{"line_number":571,"context_line":"                          sort_keys\u003dsort_keys)"},{"line_number":572,"context_line":""},{"line_number":573,"context_line":"        sort_keys \u003d [\"__contains__\"]"},{"line_number":574,"context_line":"        self.assertRaises(exception.InvalidInput,"},{"line_number":575,"context_line":"                          objects.VolumeList.get_all_by_project,"},{"line_number":576,"context_line":"                          self.context,"},{"line_number":577,"context_line":"                          self.context.project_id,"},{"line_number":578,"context_line":"                          sort_keys\u003dsort_keys)"},{"line_number":579,"context_line":""},{"line_number":580,"context_line":"    @mock.patch(\u0027cinder.db.volume_include_in_cluster\u0027)"},{"line_number":581,"context_line":"    def test_include_in_cluster(self, include_mock):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5201f7_36a69553","line":578,"range":{"start_line":566,"start_character":0,"end_line":578,"end_character":46},"in_reply_to":"ba5201f7_ef4c3dca","updated":"2017-01-05 01:21:05.000000000","message":"Done","commit_id":"a3408dbfb25487c4b15f26457e5bfaa0663cb7bf"}]}