)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"a71879fd54591d4a65ab7e1bf9ea19044db8e0e8","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     xianming mao \u003cxianming.mao@easystack.cn\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-01-11 19:16:43 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add ERROR info"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As TODO says, we add usage and limit message in ERROR msg."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5a3905b3_aef64f8c","line":7,"updated":"2017-01-24 10:43:12.000000000","message":"-1: Sorry, this commit is no good, what info is being added, where?","commit_id":"ddf6d2acde9b1967093be959916d50d96d908440"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"051fdccd6ec4e996e87723317c6a3323ef3a764d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add usage and limit message in ERROR info"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As TODO says, we add usage and limit message in ERROR msg"},{"line_number":10,"context_line":"when we validate existing resource."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I7f6b9ea6fa30e412f0f027c93f078621dd387884"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5a3905b3_2b4691bf","line":10,"updated":"2017-01-25 10:32:27.000000000","message":"-1: Sorry this is still not good enough, when I look at this commit message it\u0027s still not clear what this patch is changing without actually looking at the code since there is not a single mention of this being related to quotas, sure I could infer it, but that defeats the point of the commit message.\n\nHere is a suggestion:\n\nAdd usage and limit info on quota limit errors\n\nCurrent error message on quota limits error only shows what key has had the error but does not provide additional information.\n\nThis patch adds current usage as well as the enforced limit that prevented the quota reservation and takes care of the pending TODO.","commit_id":"aa97b295ba553397b26a7a2d2ee4403e04f40734"}],"cinder/api/contrib/quotas.py":[{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"77b001a13fbabe465188963b30b2ce57ff291225","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            used +\u003d v.get(\u0027allocated\u0027, 0)"},{"line_number":55,"context_line":"        if value \u003c used:"},{"line_number":56,"context_line":"            msg \u003d (_(\"Quota %(key)s limit must be equal or greater than\""},{"line_number":57,"context_line":"                     \"existing resources. But now, current usage is %(usage)s\""},{"line_number":58,"context_line":"                     \"and the requested limit is %(limit)s\")"},{"line_number":59,"context_line":"                   % {\u0027key\u0027: key,"},{"line_number":60,"context_line":"                      \u0027usage\u0027: used,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5201f7_57035e42","line":57,"updated":"2017-01-03 13:44:19.000000000","message":"Remove \"But now,\". It\u0027s a bit superfluous in an error message.","commit_id":"cbc6dd350cbab7b69ea8832483ded74fe77bfab0"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"5984addb21a18474788fa752ab35af2da8714814","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        if value \u003c used:"},{"line_number":56,"context_line":"            msg \u003d (_(\"Quota %(key)s limit must be equal or greater than\""},{"line_number":57,"context_line":"                     \"existing resources. But now, current usage is %(usage)s\""},{"line_number":58,"context_line":"                     \"and the requested limit is %(limit)s\")"},{"line_number":59,"context_line":"                   % {\u0027key\u0027: key,"},{"line_number":60,"context_line":"                      \u0027usage\u0027: used,"},{"line_number":61,"context_line":"                      \u0027limit\u0027: value})"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5201f7_c5731514","line":58,"updated":"2017-01-03 15:37:06.000000000","message":"This message should also end with a period.","commit_id":"cbc6dd350cbab7b69ea8832483ded74fe77bfab0"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"cd2c546bd273101bc8bac53413c77cd64fec698e","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        if value \u003c used:"},{"line_number":56,"context_line":"            msg \u003d (_(\"Quota %(key)s limit must be equal or greater than \""},{"line_number":57,"context_line":"                     \"existing resources. Current usage is %(usage)s \""},{"line_number":58,"context_line":"                     \"and the requested limit is %(limit)s. \")"},{"line_number":59,"context_line":"                   % {\u0027key\u0027: key,"},{"line_number":60,"context_line":"                      \u0027usage\u0027: used,"},{"line_number":61,"context_line":"                      \u0027limit\u0027: value})"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5201f7_bb33e512","line":58,"range":{"start_line":58,"start_character":59,"end_line":58,"end_character":60},"updated":"2017-01-09 01:22:57.000000000","message":"There is a blank space, should remove it.","commit_id":"1d2ca6307f246bac0d5b8324640d9ea6239d1fb3"}]}
