)]}'
{"cinder/tests/unit/zonemanager/test_brcd_http_fc_zone_client.py":[{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"1120c705bd941c23fe1d4318d232c4c21579fe85","unresolved":false,"context_lines":[{"line_number":607,"context_line":"        new_ifas \u003d {\u0027fa1\u0027: u\u002720:15:f4:ce:96:ae:68:6c;20:11:f4:ce:46:ae:68:6c\u0027}"},{"line_number":608,"context_line":"        zone_str \u003d self.form_zone_string("},{"line_number":609,"context_line":"            cfgs, active_cfg, zones, new_alias, new_qlps, new_ifas, True)"},{"line_number":610,"context_line":"        self.assertTrue(isinstance(zone_str, basestring))"},{"line_number":611,"context_line":"        self.assertEqual(mocked_zone_string, self.form_zone_string("},{"line_number":612,"context_line":"            cfgs, active_cfg, zones, new_alias, new_qlps, new_ifas, True))"},{"line_number":613,"context_line":"        self.assertEqual(mocked_zone_string_no_activate, self.form_zone_string("}],"source_content_type":"text/x-python","patch_set":4,"id":"7a3c09a3_763e4429","line":610,"range":{"start_line":610,"start_character":45,"end_line":610,"end_character":55},"updated":"2017-01-17 12:43:30.000000000","message":"Jenkins is not happy with the basestring. Maybe you can use just str or string_types from six lib.\nAlso, it\u0027d be better to use assertIsInstance instead of assertTrue","commit_id":"2e605dfb8c09890a1a5bf45e12f96831ae3e3d77"},{"author":{"_account_id":23674,"name":"Rohan Arora","email":"ra271w@att.com","username":"rarora"},"change_message_id":"25a21728d807bd081c5e4e55444ac587de70aa5a","unresolved":false,"context_lines":[{"line_number":605,"context_line":"            \u0027alia1\u0027: u\u002710:00:00:05:1e:7c:64:96;10:21:10:05:33:0e:96:12\u0027}"},{"line_number":606,"context_line":"        new_qlps \u003d {\u0027qlp\u0027: u\u002710:11:f4:ce:46:ae:68:6c;20:11:f4:ce:46:ae:68:6c\u0027}"},{"line_number":607,"context_line":"        new_ifas \u003d {\u0027fa1\u0027: u\u002720:15:f4:ce:96:ae:68:6c;20:11:f4:ce:46:ae:68:6c\u0027}"},{"line_number":608,"context_line":"        zone_str \u003d self.form_zone_string("},{"line_number":609,"context_line":"            cfgs, active_cfg, zones, new_alias, new_qlps, new_ifas, True)"},{"line_number":610,"context_line":"        self.assertTrue(isinstance(zone_str, basestring))"},{"line_number":611,"context_line":"        self.assertEqual(mocked_zone_string, self.form_zone_string("},{"line_number":612,"context_line":"            cfgs, active_cfg, zones, new_alias, new_qlps, new_ifas, True))"},{"line_number":613,"context_line":"        self.assertEqual(mocked_zone_string_no_activate, self.form_zone_string("}],"source_content_type":"text/x-python","patch_set":4,"id":"7a3c09a3_124a8cac","line":610,"range":{"start_line":608,"start_character":8,"end_line":610,"end_character":57},"updated":"2017-01-16 20:35:44.000000000","message":"nit: does not follow format of other tests where zone_str is not saved into a variable but is passed directly from the form_zone_string() return","commit_id":"2e605dfb8c09890a1a5bf45e12f96831ae3e3d77"},{"author":{"_account_id":15383,"name":"Yucong Feng","email":"yfeng@us.ibm.com","username":"yfeng"},"change_message_id":"ecbe50f6619272b4edc834860f02c6fcda75c655","unresolved":false,"context_lines":[{"line_number":605,"context_line":"            \u0027alia1\u0027: u\u002710:00:00:05:1e:7c:64:96;10:21:10:05:33:0e:96:12\u0027}"},{"line_number":606,"context_line":"        new_qlps \u003d {\u0027qlp\u0027: u\u002710:11:f4:ce:46:ae:68:6c;20:11:f4:ce:46:ae:68:6c\u0027}"},{"line_number":607,"context_line":"        new_ifas \u003d {\u0027fa1\u0027: u\u002720:15:f4:ce:96:ae:68:6c;20:11:f4:ce:46:ae:68:6c\u0027}"},{"line_number":608,"context_line":"        zone_str \u003d self.form_zone_string("},{"line_number":609,"context_line":"            cfgs, active_cfg, zones, new_alias, new_qlps, new_ifas, True)"},{"line_number":610,"context_line":"        self.assertTrue(isinstance(zone_str, basestring))"},{"line_number":611,"context_line":"        self.assertEqual(mocked_zone_string, self.form_zone_string("},{"line_number":612,"context_line":"            cfgs, active_cfg, zones, new_alias, new_qlps, new_ifas, True))"},{"line_number":613,"context_line":"        self.assertEqual(mocked_zone_string_no_activate, self.form_zone_string("}],"source_content_type":"text/x-python","patch_set":4,"id":"7a3c09a3_7a195e22","line":610,"range":{"start_line":608,"start_character":8,"end_line":610,"end_character":57},"in_reply_to":"7a3c09a3_124a8cac","updated":"2017-01-18 22:15:48.000000000","message":"Done","commit_id":"2e605dfb8c09890a1a5bf45e12f96831ae3e3d77"},{"author":{"_account_id":15383,"name":"Yucong Feng","email":"yfeng@us.ibm.com","username":"yfeng"},"change_message_id":"ecbe50f6619272b4edc834860f02c6fcda75c655","unresolved":false,"context_lines":[{"line_number":607,"context_line":"        new_ifas \u003d {\u0027fa1\u0027: u\u002720:15:f4:ce:96:ae:68:6c;20:11:f4:ce:46:ae:68:6c\u0027}"},{"line_number":608,"context_line":"        zone_str \u003d self.form_zone_string("},{"line_number":609,"context_line":"            cfgs, active_cfg, zones, new_alias, new_qlps, new_ifas, True)"},{"line_number":610,"context_line":"        self.assertTrue(isinstance(zone_str, basestring))"},{"line_number":611,"context_line":"        self.assertEqual(mocked_zone_string, self.form_zone_string("},{"line_number":612,"context_line":"            cfgs, active_cfg, zones, new_alias, new_qlps, new_ifas, True))"},{"line_number":613,"context_line":"        self.assertEqual(mocked_zone_string_no_activate, self.form_zone_string("}],"source_content_type":"text/x-python","patch_set":4,"id":"7a3c09a3_3a943643","line":610,"range":{"start_line":610,"start_character":45,"end_line":610,"end_character":55},"in_reply_to":"7a3c09a3_763e4429","updated":"2017-01-18 22:15:48.000000000","message":"Thanks for the tip, assertIsIstance is only used for instance objects to check against their class. Will use assertEqual here as the purpose is the same.","commit_id":"2e605dfb8c09890a1a5bf45e12f96831ae3e3d77"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"c5ead89be79072825dbf4404d1e5a12a8c9768d0","unresolved":false,"context_lines":[{"line_number":606,"context_line":"        new_qlps \u003d {\u0027qlp\u0027: u\u002710:11:f4:ce:46:ae:68:6c;20:11:f4:ce:46:ae:68:6c\u0027}"},{"line_number":607,"context_line":"        new_ifas \u003d {\u0027fa1\u0027: u\u002720:15:f4:ce:96:ae:68:6c;20:11:f4:ce:46:ae:68:6c\u0027}"},{"line_number":608,"context_line":"        self.assertEqual(self.form_zone_string("},{"line_number":609,"context_line":"            cfgs, active_cfg, zones, new_alias, new_qlps, new_ifas, True), str))"},{"line_number":610,"context_line":"        self.assertEqual(mocked_zone_string, self.form_zone_string("},{"line_number":611,"context_line":"            cfgs, active_cfg, zones, new_alias, new_qlps, new_ifas, True))"},{"line_number":612,"context_line":"        self.assertEqual(mocked_zone_string_no_activate, self.form_zone_string("}],"source_content_type":"text/x-python","patch_set":5,"id":"5a3905b3_a4ac81ee","line":609,"range":{"start_line":609,"start_character":79,"end_line":609,"end_character":80},"updated":"2017-01-19 12:03:48.000000000","message":"needs to be removed","commit_id":"ae0d121b4b3dd9fd6332052c044f90aed4041b64"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"e41900de7fa8329e29e1a67e9a73e144717b9252","unresolved":false,"context_lines":[{"line_number":606,"context_line":"        new_qlps \u003d {\u0027qlp\u0027: u\u002710:11:f4:ce:46:ae:68:6c;20:11:f4:ce:46:ae:68:6c\u0027}"},{"line_number":607,"context_line":"        new_ifas \u003d {\u0027fa1\u0027: u\u002720:15:f4:ce:96:ae:68:6c;20:11:f4:ce:46:ae:68:6c\u0027}"},{"line_number":608,"context_line":"        self.assertEqual(self.form_zone_string("},{"line_number":609,"context_line":"            cfgs, active_cfg, zones, new_alias, new_qlps, new_ifas, True), str))"},{"line_number":610,"context_line":"        self.assertEqual(mocked_zone_string, self.form_zone_string("},{"line_number":611,"context_line":"            cfgs, active_cfg, zones, new_alias, new_qlps, new_ifas, True))"},{"line_number":612,"context_line":"        self.assertEqual(mocked_zone_string_no_activate, self.form_zone_string("}],"source_content_type":"text/x-python","patch_set":5,"id":"5a3905b3_5f5a8851","line":609,"range":{"start_line":609,"start_character":79,"end_line":609,"end_character":80},"in_reply_to":"5a3905b3_37498160","updated":"2017-01-20 11:35:50.000000000","message":"Actually, I was referencing just the parenthesis","commit_id":"ae0d121b4b3dd9fd6332052c044f90aed4041b64"},{"author":{"_account_id":15383,"name":"Yucong Feng","email":"yfeng@us.ibm.com","username":"yfeng"},"change_message_id":"201c4d7546d182f69e92adb625530210d9f66861","unresolved":false,"context_lines":[{"line_number":606,"context_line":"        new_qlps \u003d {\u0027qlp\u0027: u\u002710:11:f4:ce:46:ae:68:6c;20:11:f4:ce:46:ae:68:6c\u0027}"},{"line_number":607,"context_line":"        new_ifas \u003d {\u0027fa1\u0027: u\u002720:15:f4:ce:96:ae:68:6c;20:11:f4:ce:46:ae:68:6c\u0027}"},{"line_number":608,"context_line":"        self.assertEqual(self.form_zone_string("},{"line_number":609,"context_line":"            cfgs, active_cfg, zones, new_alias, new_qlps, new_ifas, True), str))"},{"line_number":610,"context_line":"        self.assertEqual(mocked_zone_string, self.form_zone_string("},{"line_number":611,"context_line":"            cfgs, active_cfg, zones, new_alias, new_qlps, new_ifas, True))"},{"line_number":612,"context_line":"        self.assertEqual(mocked_zone_string_no_activate, self.form_zone_string("}],"source_content_type":"text/x-python","patch_set":5,"id":"5a3905b3_37498160","line":609,"range":{"start_line":609,"start_character":79,"end_line":609,"end_character":80},"in_reply_to":"5a3905b3_a4ac81ee","updated":"2017-01-19 23:08:42.000000000","message":"The unicode declarations is necessary for the test.","commit_id":"ae0d121b4b3dd9fd6332052c044f90aed4041b64"}],"cinder/zonemanager/drivers/brocade/brcd_http_fc_zone_client.py":[{"author":{"_account_id":14532,"name":"Gerald McBrearty","email":"gfm@us.ibm.com","username":"gfm"},"change_message_id":"07bc461e90468c68f4aab9b1a4e7bc19bee9d662","unresolved":false,"context_lines":[{"line_number":642,"context_line":"                               active_cfg + \" null \")"},{"line_number":643,"context_line":"            # Build the final zone string"},{"line_number":644,"context_line":"            zoneString +\u003d zone_constant.ZONE_END_DELIM + saveonly"},{"line_number":645,"context_line":"            # Reconstruct the zoneString to type base string for OpenSSL"},{"line_number":646,"context_line":"            zoneString \u003d str(zoneString)"},{"line_number":647,"context_line":"        except Exception as e:"},{"line_number":648,"context_line":"            msg \u003d (_(\"Exception while forming the zone string: %s.\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5201f7_37daec4c","line":645,"updated":"2017-01-05 20:02:37.000000000","message":"I think it would be better to move the str to the return below.\n\nreturn str(zoneString)\n\nIs there a UT that can be updated to test this?","commit_id":"a5a72ea338c56a0140e7cb73d660214d706d4b40"},{"author":{"_account_id":23674,"name":"Rohan Arora","email":"ra271w@att.com","username":"rarora"},"change_message_id":"81ace58811663abe37d3a3df356fc98784210eaa","unresolved":false,"context_lines":[{"line_number":642,"context_line":"                               active_cfg + \" null \")"},{"line_number":643,"context_line":"            # Build the final zone string"},{"line_number":644,"context_line":"            zoneString +\u003d zone_constant.ZONE_END_DELIM + saveonly"},{"line_number":645,"context_line":"            # Reconstruct the zoneString to type base string for OpenSSL"},{"line_number":646,"context_line":"            zoneString \u003d str(zoneString)"},{"line_number":647,"context_line":"        except Exception as e:"},{"line_number":648,"context_line":"            msg \u003d (_(\"Exception while forming the zone string: %s.\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5201f7_4a3a429a","line":645,"in_reply_to":"ba5201f7_37daec4c","updated":"2017-01-06 19:30:20.000000000","message":"I agree with Gerald. Because the str value is not used, rather than saving it you can just return it as a base string, or you could modify line 644 to be:\nzoneString \u003d str(zoneString + zone_constant.ZONE_END_DELIM + saveonly).","commit_id":"a5a72ea338c56a0140e7cb73d660214d706d4b40"},{"author":{"_account_id":8757,"name":"Angela Smith","email":"angela.smith@broadcom.com","username":"asmith_brcd"},"change_message_id":"eda71383e84233f5151f2ff02ea211bc50783048","unresolved":false,"context_lines":[{"line_number":642,"context_line":"                               active_cfg + \" null \")"},{"line_number":643,"context_line":"            # Build the final zone string"},{"line_number":644,"context_line":"            zoneString +\u003d zone_constant.ZONE_END_DELIM + saveonly"},{"line_number":645,"context_line":"            # Reconstruct the zoneString to type base string for OpenSSL"},{"line_number":646,"context_line":"        except Exception as e:"},{"line_number":647,"context_line":"            msg \u003d (_(\"Exception while forming the zone string: %s.\")"},{"line_number":648,"context_line":"                   % six.text_type(e))"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a3c09a3_bfff35a9","line":645,"range":{"start_line":645,"start_character":0,"end_line":645,"end_character":5},"updated":"2017-01-18 22:53:13.000000000","message":"Move the comment to where the reconstruct is happening","commit_id":"ae0d121b4b3dd9fd6332052c044f90aed4041b64"},{"author":{"_account_id":15383,"name":"Yucong Feng","email":"yfeng@us.ibm.com","username":"yfeng"},"change_message_id":"201c4d7546d182f69e92adb625530210d9f66861","unresolved":false,"context_lines":[{"line_number":642,"context_line":"                               active_cfg + \" null \")"},{"line_number":643,"context_line":"            # Build the final zone string"},{"line_number":644,"context_line":"            zoneString +\u003d zone_constant.ZONE_END_DELIM + saveonly"},{"line_number":645,"context_line":"            # Reconstruct the zoneString to type base string for OpenSSL"},{"line_number":646,"context_line":"        except Exception as e:"},{"line_number":647,"context_line":"            msg \u003d (_(\"Exception while forming the zone string: %s.\")"},{"line_number":648,"context_line":"                   % six.text_type(e))"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a3905b3_5c18f284","line":645,"range":{"start_line":645,"start_character":0,"end_line":645,"end_character":5},"in_reply_to":"7a3c09a3_bfff35a9","updated":"2017-01-19 23:08:42.000000000","message":"Done","commit_id":"ae0d121b4b3dd9fd6332052c044f90aed4041b64"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"67c8baf34885f2b30b932cc57b44631b417e6e6f","unresolved":false,"context_lines":[{"line_number":648,"context_line":"                   % six.text_type(e))"},{"line_number":649,"context_line":"            LOG.error(msg)"},{"line_number":650,"context_line":"            raise exception.BrocadeZoningHttpException(reason\u003dmsg)"},{"line_number":651,"context_line":"        return str(zoneString)"},{"line_number":652,"context_line":""},{"line_number":653,"context_line":"    def add_zones_cfgs(self, cfgs, zones, add_zones_info,"},{"line_number":654,"context_line":"                       active_cfg, cfg_name):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a3c09a3_5a910252","line":651,"updated":"2017-01-18 22:16:22.000000000","message":"str() will produce Unicode here in Python 3.\n\nWill this still cause the same problem?","commit_id":"ae0d121b4b3dd9fd6332052c044f90aed4041b64"},{"author":{"_account_id":15383,"name":"Yucong Feng","email":"yfeng@us.ibm.com","username":"yfeng"},"change_message_id":"201c4d7546d182f69e92adb625530210d9f66861","unresolved":false,"context_lines":[{"line_number":648,"context_line":"                   % six.text_type(e))"},{"line_number":649,"context_line":"            LOG.error(msg)"},{"line_number":650,"context_line":"            raise exception.BrocadeZoningHttpException(reason\u003dmsg)"},{"line_number":651,"context_line":"        return str(zoneString)"},{"line_number":652,"context_line":""},{"line_number":653,"context_line":"    def add_zones_cfgs(self, cfgs, zones, add_zones_info,"},{"line_number":654,"context_line":"                       active_cfg, cfg_name):"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a3905b3_9720759d","line":651,"in_reply_to":"7a3c09a3_5a910252","updated":"2017-01-19 23:08:42.000000000","message":"Good point, will instead use str().encode(\u0027utf-8\u0027) so that even in python 3 the string will be converted to type \u0027bytes\u0027 for handling purposes","commit_id":"ae0d121b4b3dd9fd6332052c044f90aed4041b64"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"7c7dbafa27a8f90bfcecd160722a15901790aaea","unresolved":false,"context_lines":[{"line_number":648,"context_line":"            LOG.error(msg)"},{"line_number":649,"context_line":"            raise exception.BrocadeZoningHttpException(reason\u003dmsg)"},{"line_number":650,"context_line":"        # Reconstruct the zoneString to type base string for OpenSSL"},{"line_number":651,"context_line":"        return str(zoneString).encode(\u0027utf-8\u0027)"},{"line_number":652,"context_line":""},{"line_number":653,"context_line":"    def add_zones_cfgs(self, cfgs, zones, add_zones_info,"},{"line_number":654,"context_line":"                       active_cfg, cfg_name):"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a461143_9f9e2061","line":651,"updated":"2017-01-31 21:11:32.000000000","message":"Can you use safe_encode instead?\n\nhttp://docs.openstack.org/developer/oslo.utils/api/encodeutils.html","commit_id":"ccdab91142ddda1fe8b4a873247fa789ccfdb05c"},{"author":{"_account_id":15383,"name":"Yucong Feng","email":"yfeng@us.ibm.com","username":"yfeng"},"change_message_id":"cab03f2de1728864bc12c7d87342a23c1b65df5d","unresolved":false,"context_lines":[{"line_number":648,"context_line":"            LOG.error(msg)"},{"line_number":649,"context_line":"            raise exception.BrocadeZoningHttpException(reason\u003dmsg)"},{"line_number":650,"context_line":"        # Reconstruct the zoneString to type base string for OpenSSL"},{"line_number":651,"context_line":"        return str(zoneString).encode(\u0027utf-8\u0027)"},{"line_number":652,"context_line":""},{"line_number":653,"context_line":"    def add_zones_cfgs(self, cfgs, zones, add_zones_info,"},{"line_number":654,"context_line":"                       active_cfg, cfg_name):"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a461143_13259c5b","line":651,"in_reply_to":"3a461143_9f9e2061","updated":"2017-02-02 21:18:33.000000000","message":"Done","commit_id":"ccdab91142ddda1fe8b4a873247fa789ccfdb05c"}]}