)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"e921056b6fa22dec72b10a5d73ec59066ab66239","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2017-01-04 16:18:17 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Cast type of stats[\u0027replication_enabled\u0027] from boolean to string"},{"line_number":8,"context_line":"Now, when creating a volume that needs repication, the scheduler will not report error."},{"line_number":9,"context_line":"Fixes Bug1653904"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Icea820053c73af03d62b65da7c8fa4bb317c5279"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba5201f7_61307d9f","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":87},"updated":"2017-01-04 09:15:56.000000000","message":"please leave a blank line below the title.","commit_id":"f8e9a6296d5ae58c2872aebd38d068a1396d597e"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"e921056b6fa22dec72b10a5d73ec59066ab66239","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Cast type of stats[\u0027replication_enabled\u0027] from boolean to string"},{"line_number":8,"context_line":"Now, when creating a volume that needs repication, the scheduler will not report error."},{"line_number":9,"context_line":"Fixes Bug1653904"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Icea820053c73af03d62b65da7c8fa4bb317c5279"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba5201f7_81272163","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":16},"updated":"2017-01-04 09:15:56.000000000","message":"Closes-bug: #1653904","commit_id":"f8e9a6296d5ae58c2872aebd38d068a1396d597e"}],"cinder/volume/drivers/rbd.py":[{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"e921056b6fa22dec72b10a5d73ec59066ab66239","unresolved":false,"context_lines":[{"line_number":393,"context_line":"        backend_name \u003d self.configuration.safe_get(\u0027volume_backend_name\u0027)"},{"line_number":394,"context_line":"        stats[\u0027volume_backend_name\u0027] \u003d backend_name or \u0027RBD\u0027"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"        stats[\u0027replication_enabled\u0027] \u003d str(self._is_replication_enabled)"},{"line_number":397,"context_line":"        if self._is_replication_enabled:"},{"line_number":398,"context_line":"            stats[\u0027replication_targets\u0027] \u003d self._target_names"},{"line_number":399,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5201f7_e1f46d88","line":396,"updated":"2017-01-04 09:15:56.000000000","message":"Please see https://github.com/openstack/cinder/blob/master/cinder/volume/manager.py#L509\n\nThe boolean value is used there at least. So change the boolean to string will break the logic there. And you can see this value is boolean in many drivers. Such as solidfire, pure and so on. Are you sure this should be string here? I suggest you can explain and update more in the commit message and launchpad bug description.","commit_id":"f8e9a6296d5ae58c2872aebd38d068a1396d597e"}]}