)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"f158b12430ae246c23d6e5cea7c8d5a1aed17d47","unresolved":false,"context_lines":[{"line_number":10,"context_line":"This patch add the support to keep the same with volume"},{"line_number":11,"context_line":"does."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: If4779ee1905d2ceea44f1faeaf772b209b0d074c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ff0f0b1f_e3ce7561","line":13,"updated":"2017-05-24 09:12:00.000000000","message":"-1: Missing APIImpact flag","commit_id":"fe565116bd4301a912ca09ef792a63502c1d1e37"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"5333222da2698c8b418471f8200bf8811e55d65b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support sort backup with name"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Cinder now doesn\u0027t support sort backup with \"name\"."},{"line_number":10,"context_line":"This patch add the support to keep the same with volume"},{"line_number":11,"context_line":"and snapshot."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"df140735_917cde1f","line":9,"range":{"start_line":9,"start_character":39,"end_line":9,"end_character":43},"updated":"2017-06-02 09:18:04.000000000","message":"nit: by","commit_id":"74a0a8c5303fc4927511dc29fb7d9025d569343c"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"5333222da2698c8b418471f8200bf8811e55d65b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support sort backup with name"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Cinder now doesn\u0027t support sort backup with \"name\"."},{"line_number":10,"context_line":"This patch add the support to keep the same with volume"},{"line_number":11,"context_line":"and snapshot."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"df140735_b17fe213","line":9,"range":{"start_line":9,"start_character":27,"end_line":9,"end_character":31},"updated":"2017-06-02 09:18:04.000000000","message":"nit: sorting","commit_id":"74a0a8c5303fc4927511dc29fb7d9025d569343c"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"69387f187bd68150d652cf535d7451b6b660d5cc","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support sort backup with name"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Cinder now doesn\u0027t support sort backup with \"name\"."},{"line_number":10,"context_line":"This patch add the support to keep the same with volume"},{"line_number":11,"context_line":"and snapshot."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"df140735_8576aa3d","line":9,"range":{"start_line":9,"start_character":27,"end_line":9,"end_character":31},"in_reply_to":"df140735_b17fe213","updated":"2017-06-05 03:08:10.000000000","message":"Done","commit_id":"74a0a8c5303fc4927511dc29fb7d9025d569343c"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"5333222da2698c8b418471f8200bf8811e55d65b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Support sort backup with name"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Cinder now doesn\u0027t support sort backup with \"name\"."},{"line_number":10,"context_line":"This patch add the support to keep the same with volume"},{"line_number":11,"context_line":"and snapshot."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"APIimpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"df140735_31919248","line":10,"range":{"start_line":10,"start_character":11,"end_line":10,"end_character":14},"updated":"2017-06-02 09:18:04.000000000","message":"nit: adds","commit_id":"74a0a8c5303fc4927511dc29fb7d9025d569343c"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"5333222da2698c8b418471f8200bf8811e55d65b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Support sort backup with name"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Cinder now doesn\u0027t support sort backup with \"name\"."},{"line_number":10,"context_line":"This patch add the support to keep the same with volume"},{"line_number":11,"context_line":"and snapshot."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"APIimpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"df140735_f1967a3e","line":10,"range":{"start_line":10,"start_character":35,"end_line":10,"end_character":43},"updated":"2017-06-02 09:18:04.000000000","message":"nit: it consistent","commit_id":"74a0a8c5303fc4927511dc29fb7d9025d569343c"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"69387f187bd68150d652cf535d7451b6b660d5cc","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Support sort backup with name"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Cinder now doesn\u0027t support sort backup with \"name\"."},{"line_number":10,"context_line":"This patch add the support to keep the same with volume"},{"line_number":11,"context_line":"and snapshot."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"APIimpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"df140735_65715644","line":10,"range":{"start_line":10,"start_character":35,"end_line":10,"end_character":43},"in_reply_to":"df140735_f1967a3e","updated":"2017-06-05 03:08:10.000000000","message":"Done","commit_id":"74a0a8c5303fc4927511dc29fb7d9025d569343c"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"bfec446e7f4211c6e3ac6e6e698aff2343c387a7","unresolved":false,"context_lines":[{"line_number":11,"context_line":"This patch adds the support to keep it consistent with volume"},{"line_number":12,"context_line":"and snapshot."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"APIimpact"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: If4779ee1905d2ceea44f1faeaf772b209b0d074c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"df140735_fa586031","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":9},"updated":"2017-06-05 06:25:57.000000000","message":"APIImpact","commit_id":"8427e7cc540e169da91a489b0966576fb034f73f"}],"cinder/api/contrib/backups.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"f158b12430ae246c23d6e5cea7c8d5a1aed17d47","unresolved":false,"context_lines":[{"line_number":94,"context_line":"                                            filters,"},{"line_number":95,"context_line":"                                            self._get_backup_filter_options())"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        if \u0027name\u0027 in sort_keys:"},{"line_number":98,"context_line":"            sort_keys[sort_keys.index(\u0027name\u0027)] \u003d \u0027display_name\u0027"},{"line_number":99,"context_line":"        if \u0027name\u0027 in filters:"},{"line_number":100,"context_line":"            filters[\u0027display_name\u0027] \u003d filters.pop(\u0027name\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff0f0b1f_83bfb9a8","line":97,"updated":"2017-05-24 09:12:00.000000000","message":"-1: This requires a new API microversion","commit_id":"fe565116bd4301a912ca09ef792a63502c1d1e37"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"6037eebb7db948bb4ce64a0a1b5cc61eae2fd76f","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                                            self._get_backup_filter_options())"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def _convert_sort_name(self, req_version, sort_keys):"},{"line_number":91,"context_line":"        \"\"\"Convert sort key \"name\" to \"display_name\". \"\"\""},{"line_number":92,"context_line":"        pass"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def _get_backups(self, req, is_detail):"}],"source_content_type":"text/x-python","patch_set":8,"id":"df140735_c2dfb3d4","line":91,"updated":"2017-06-06 21:28:09.000000000","message":"This doesn\u0027t do what this comment says -- and the code in v3/backups.py does, but it doesn\u0027t have the comment.","commit_id":"2c7758d4513fa257b0d684de878f921184b47ae1"}],"cinder/api/openstack/api_version_request.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"5333222da2698c8b418471f8200bf8811e55d65b","unresolved":false,"context_lines":[{"line_number":89,"context_line":"             ``message``, ``attachment``, ``group`` and ``group-snapshot``"},{"line_number":90,"context_line":"             list APIs."},{"line_number":91,"context_line":"    * 3.35 - Add ``volume-type`` filter to Get-Pools API."},{"line_number":92,"context_line":"    * 3.36 - Support sort backup with \"name\"."},{"line_number":93,"context_line":"\"\"\""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"# The minimum and maximum versions of the API supported"}],"source_content_type":"text/x-python","patch_set":5,"id":"df140735_51a766a8","line":92,"range":{"start_line":92,"start_character":33,"end_line":92,"end_character":37},"updated":"2017-06-02 09:18:04.000000000","message":"nit: by","commit_id":"74a0a8c5303fc4927511dc29fb7d9025d569343c"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"69387f187bd68150d652cf535d7451b6b660d5cc","unresolved":false,"context_lines":[{"line_number":89,"context_line":"             ``message``, ``attachment``, ``group`` and ``group-snapshot``"},{"line_number":90,"context_line":"             list APIs."},{"line_number":91,"context_line":"    * 3.35 - Add ``volume-type`` filter to Get-Pools API."},{"line_number":92,"context_line":"    * 3.36 - Support sort backup with \"name\"."},{"line_number":93,"context_line":"\"\"\""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"# The minimum and maximum versions of the API supported"}],"source_content_type":"text/x-python","patch_set":5,"id":"df140735_25959e33","line":92,"range":{"start_line":92,"start_character":33,"end_line":92,"end_character":37},"in_reply_to":"df140735_51a766a8","updated":"2017-06-05 03:08:10.000000000","message":"Done","commit_id":"74a0a8c5303fc4927511dc29fb7d9025d569343c"}],"cinder/api/openstack/rest_api_version_history.rst":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"5333222da2698c8b418471f8200bf8811e55d65b","unresolved":false,"context_lines":[{"line_number":320,"context_line":""},{"line_number":321,"context_line":"3.36"},{"line_number":322,"context_line":"----"},{"line_number":323,"context_line":"  Support sort backup with \"name\"."}],"source_content_type":"text/x-rst","patch_set":5,"id":"df140735_f1af9a7a","line":323,"range":{"start_line":323,"start_character":22,"end_line":323,"end_character":26},"updated":"2017-06-02 09:18:04.000000000","message":"nit: by","commit_id":"74a0a8c5303fc4927511dc29fb7d9025d569343c"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"69387f187bd68150d652cf535d7451b6b660d5cc","unresolved":false,"context_lines":[{"line_number":320,"context_line":""},{"line_number":321,"context_line":"3.36"},{"line_number":322,"context_line":"----"},{"line_number":323,"context_line":"  Support sort backup with \"name\"."}],"source_content_type":"text/x-rst","patch_set":5,"id":"df140735_c5a5c2a3","line":323,"range":{"start_line":323,"start_character":22,"end_line":323,"end_character":26},"in_reply_to":"df140735_f1af9a7a","updated":"2017-06-05 03:08:10.000000000","message":"Done","commit_id":"74a0a8c5303fc4927511dc29fb7d9025d569343c"}],"cinder/api/v3/backups.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"5333222da2698c8b418471f8200bf8811e55d65b","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                pass"},{"line_number":98,"context_line":"        return resp_backup"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def _get_backups(self, req, is_detail):"},{"line_number":101,"context_line":"        \"\"\"Returns a list of backups, transformed through view builder.\"\"\""},{"line_number":102,"context_line":"        context \u003d req.environ[\u0027cinder.context\u0027]"},{"line_number":103,"context_line":"        filters \u003d req.params.copy()"}],"source_content_type":"text/x-python","patch_set":5,"id":"df140735_ccad199c","line":100,"updated":"2017-06-02 09:18:04.000000000","message":"-1: I\u0027d rather we didn\u0027t just copy the whole v2 version here, it seems like unnecessary code duplication.  We can add a get_sort_params method in v2 that takes the filters and teh req_version and just calls the method in common, and overwrite this method in v3 to call the super method and then do what you are doing in L111-112 before returning the results.","commit_id":"74a0a8c5303fc4927511dc29fb7d9025d569343c"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"69387f187bd68150d652cf535d7451b6b660d5cc","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                pass"},{"line_number":98,"context_line":"        return resp_backup"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def _get_backups(self, req, is_detail):"},{"line_number":101,"context_line":"        \"\"\"Returns a list of backups, transformed through view builder.\"\"\""},{"line_number":102,"context_line":"        context \u003d req.environ[\u0027cinder.context\u0027]"},{"line_number":103,"context_line":"        filters \u003d req.params.copy()"}],"source_content_type":"text/x-python","patch_set":5,"id":"df140735_65bf16aa","line":100,"in_reply_to":"df140735_ccad199c","updated":"2017-06-05 03:08:10.000000000","message":"Done","commit_id":"74a0a8c5303fc4927511dc29fb7d9025d569343c"}],"releasenotes/notes/support_sort_backup_with_name-0b080bcb60c0eaa0.yaml":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"5333222da2698c8b418471f8200bf8811e55d65b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add support for sorting backups with \"name\"."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"df140735_cc37594d","line":3,"range":{"start_line":3,"start_character":36,"end_line":3,"end_character":40},"updated":"2017-06-02 09:18:04.000000000","message":"nit: by","commit_id":"74a0a8c5303fc4927511dc29fb7d9025d569343c"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"69387f187bd68150d652cf535d7451b6b660d5cc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add support for sorting backups with \"name\"."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"df140735_c5cee261","line":3,"range":{"start_line":3,"start_character":36,"end_line":3,"end_character":40},"in_reply_to":"df140735_cc37594d","updated":"2017-06-05 03:08:10.000000000","message":"Done","commit_id":"74a0a8c5303fc4927511dc29fb7d9025d569343c"}]}