)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"2d38e8541c918430043e604b9366b2973e1f3eb2","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Zhao Liqiang \u003czhaoliqiang@cmss.chinamobile.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-01-10 17:41:19 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"RBD: the feature of \u0027journaling\u0027 of a volume lose when coping an image to it."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When copying a image to a volume with feature \u0027journaling\u0027, cinder will"},{"line_number":10,"context_line":"create a new volume, then copy the image to the new volume, and delete"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a3c09a3_75a5de02","line":7,"updated":"2017-01-13 13:12:57.000000000","message":"-1: don\u0027t exceed 52 chars for the first line: \"Fix RBD replication on volumes from image source\"","commit_id":"a0cda8a6ab4c1ca08a72766113936fb9110529dd"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"2d38e8541c918430043e604b9366b2973e1f3eb2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"RBD: the feature of \u0027journaling\u0027 of a volume lose when coping an image to it."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When copying a image to a volume with feature \u0027journaling\u0027, cinder will"},{"line_number":10,"context_line":"create a new volume, then copy the image to the new volume, and delete"},{"line_number":11,"context_line":"the old volume. But I find that the new volume has no \u0027journaling\u0027."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a3c09a3_158e5a78","line":9,"range":{"start_line":9,"start_character":26,"end_line":9,"end_character":59},"updated":"2017-01-13 13:12:57.000000000","message":"nit: replicated volume","commit_id":"a0cda8a6ab4c1ca08a72766113936fb9110529dd"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"2d38e8541c918430043e604b9366b2973e1f3eb2","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When copying a image to a volume with feature \u0027journaling\u0027, cinder will"},{"line_number":10,"context_line":"create a new volume, then copy the image to the new volume, and delete"},{"line_number":11,"context_line":"the old volume. But I find that the new volume has no \u0027journaling\u0027."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"I do some modify of method \u0027copy_image_to_volume\u0027, adding \u0027self._enable_"},{"line_number":14,"context_line":"replication_if_needed(volume)\u0027 at last."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a3c09a3_955deaeb","line":11,"range":{"start_line":11,"start_character":66,"end_line":11,"end_character":67},"updated":"2017-01-13 13:12:57.000000000","message":"nit: , so replication is disabled for the volume.","commit_id":"a0cda8a6ab4c1ca08a72766113936fb9110529dd"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"2d38e8541c918430043e604b9366b2973e1f3eb2","unresolved":false,"context_lines":[{"line_number":10,"context_line":"create a new volume, then copy the image to the new volume, and delete"},{"line_number":11,"context_line":"the old volume. But I find that the new volume has no \u0027journaling\u0027."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"I do some modify of method \u0027copy_image_to_volume\u0027, adding \u0027self._enable_"},{"line_number":14,"context_line":"replication_if_needed(volume)\u0027 at last."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I4df249ae752b46e4eb5afab142947db04793b585"},{"line_number":17,"context_line":"Closes-Bug: #1654471"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a3c09a3_350516c2","line":14,"range":{"start_line":13,"start_character":0,"end_line":14,"end_character":39},"updated":"2017-01-13 13:12:57.000000000","message":"nit: No need to explain here what the patch does.","commit_id":"a0cda8a6ab4c1ca08a72766113936fb9110529dd"}],"cinder/volume/drivers/rbd.py":[{"author":{"_account_id":19901,"name":"Xu Ao","email":"xuao@awcloud.com","username":"xuao"},"change_message_id":"3a54330f27b1802cbcbd6747fd089cc7daf482e5","unresolved":false,"context_lines":[{"line_number":573,"context_line":"    def _enable_replication_if_needed(self, volume):"},{"line_number":574,"context_line":"        if self._is_replicated_type(volume.volume_type):"},{"line_number":575,"context_line":"            return self._enable_replication(volume)"},{"line_number":576,"context_line":"        if self._is_replication_enabled:"},{"line_number":577,"context_line":"            return {\u0027replication_status\u0027: fields.ReplicationStatus.DISABLED}"},{"line_number":578,"context_line":"        return None"},{"line_number":579,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a57fde8_b203fe0c","line":576,"range":{"start_line":576,"start_character":8,"end_line":576,"end_character":40},"updated":"2017-01-12 07:56:36.000000000","message":"Mark","commit_id":"a0cda8a6ab4c1ca08a72766113936fb9110529dd"},{"author":{"_account_id":19901,"name":"Xu Ao","email":"xuao@awcloud.com","username":"xuao"},"change_message_id":"3a54330f27b1802cbcbd6747fd089cc7daf482e5","unresolved":false,"context_lines":[{"line_number":1169,"context_line":"        self._resize(volume)"},{"line_number":1170,"context_line":""},{"line_number":1171,"context_line":"        try:"},{"line_number":1172,"context_line":"            self._enable_replication_if_needed(volume)"},{"line_number":1173,"context_line":"        except Exception:"},{"line_number":1174,"context_line":"            self.delete_volume(volume)"},{"line_number":1175,"context_line":"            err_msg \u003d (_(\u0027Failed to enable image replication\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a57fde8_af1639a5","line":1172,"range":{"start_line":1172,"start_character":12,"end_line":1172,"end_character":54},"updated":"2017-01-12 07:56:36.000000000","message":"Whether a volume updating  is required after this? Order to cover the situation that set a \u0027Mark\u0027 in the comment.\nNot sure about that.","commit_id":"a0cda8a6ab4c1ca08a72766113936fb9110529dd"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"2d38e8541c918430043e604b9366b2973e1f3eb2","unresolved":false,"context_lines":[{"line_number":1169,"context_line":"        self._resize(volume)"},{"line_number":1170,"context_line":""},{"line_number":1171,"context_line":"        try:"},{"line_number":1172,"context_line":"            self._enable_replication_if_needed(volume)"},{"line_number":1173,"context_line":"        except Exception:"},{"line_number":1174,"context_line":"            self.delete_volume(volume)"},{"line_number":1175,"context_line":"            err_msg \u003d (_(\u0027Failed to enable image replication\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_9217c050","line":1172,"range":{"start_line":1172,"start_character":12,"end_line":1172,"end_character":54},"in_reply_to":"9a57fde8_3579b830","updated":"2017-01-13 13:12:57.000000000","message":"nit: Please add a comment on why we need to do this here, as it is counter intuitive, as we should only require to do this when we are initially creating the volume:\n\n # We may need to re-enable replication because we have deleted the original image and created a new one using the command line import.","commit_id":"a0cda8a6ab4c1ca08a72766113936fb9110529dd"},{"author":{"_account_id":24741,"name":"Zhao Liqiang","email":"zhaoliqiang@cmss.chinamobile.com","username":"zhaoliqiang"},"change_message_id":"73b748be43620e528db6d5f3287e2084048df17f","unresolved":false,"context_lines":[{"line_number":1169,"context_line":"        self._resize(volume)"},{"line_number":1170,"context_line":""},{"line_number":1171,"context_line":"        try:"},{"line_number":1172,"context_line":"            self._enable_replication_if_needed(volume)"},{"line_number":1173,"context_line":"        except Exception:"},{"line_number":1174,"context_line":"            self.delete_volume(volume)"},{"line_number":1175,"context_line":"            err_msg \u003d (_(\u0027Failed to enable image replication\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a57fde8_3579b830","line":1172,"range":{"start_line":1172,"start_character":12,"end_line":1172,"end_character":54},"in_reply_to":"9a57fde8_af1639a5","updated":"2017-01-13 06:11:46.000000000","message":"No, these information have already written to database when creating a volume.","commit_id":"a0cda8a6ab4c1ca08a72766113936fb9110529dd"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"2d38e8541c918430043e604b9366b2973e1f3eb2","unresolved":false,"context_lines":[{"line_number":1171,"context_line":"        try:"},{"line_number":1172,"context_line":"            self._enable_replication_if_needed(volume)"},{"line_number":1173,"context_line":"        except Exception:"},{"line_number":1174,"context_line":"            self.delete_volume(volume)"},{"line_number":1175,"context_line":"            err_msg \u003d (_(\u0027Failed to enable image replication\u0027))"},{"line_number":1176,"context_line":"            raise exception.ReplicationError(reason\u003derr_msg,"},{"line_number":1177,"context_line":"                                             volume_id\u003dvolume.id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_f2aac418","line":1174,"updated":"2017-01-13 13:12:57.000000000","message":"-1: Don\u0027t try to delete the volume, an error here would obscure the real issue, and it\u0027s ok to leave the image, as the volume will go to error status and the image in the backend will be properly removed once a volume delete is requested.","commit_id":"a0cda8a6ab4c1ca08a72766113936fb9110529dd"}]}