)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"74be42c386edd7520577501e74ac024747d8f914","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Zhao Liqiang \u003czhaoliqiang@cmss.chinamobile.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-01-11 09:42:20 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"RBD: the value of \u0027had_journaling\u0027 has not changed after \u0027update_features\u0027."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If rbd replication is enabled, creating a volume will be divided into two stages:"},{"line_number":10,"context_line":"1) create a volume by calling librbd API."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba5201f7_eab0cf8d","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":75},"updated":"2017-01-11 03:06:31.000000000","message":"I suggest the title should be what the patch does, not what the error behavior.","commit_id":"892054abd1c57282d3cf724350e5c37511f010e6"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"74be42c386edd7520577501e74ac024747d8f914","unresolved":false,"context_lines":[{"line_number":10,"context_line":"1) create a volume by calling librbd API."},{"line_number":11,"context_line":"2) enable rbd mirror for the volume."},{"line_number":12,"context_line":"In the second stage, if a volume created has no feature of \u0027journaling\u0027, the value of"},{"line_number":13,"context_line":"\u0027had_journaling\u0027 will be None(rbd.py: line 559). However, after executing"},{"line_number":14,"context_line":"\u0027image.update_features\u0027(rbd.py: line 561), \u0027journaling\u0027 feature has already added"},{"line_number":15,"context_line":" to the volume, so, the value of \u0027had_journaling\u0027 should not be None anymore, but"},{"line_number":16,"context_line":"no code changes it. I think that a bug and fix it."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba5201f7_ea028f3d","line":13,"range":{"start_line":13,"start_character":29,"end_line":13,"end_character":47},"updated":"2017-01-11 03:06:31.000000000","message":"please remove this, as the code is changed everyday, \"line 559\" is a not a effective indication all time.","commit_id":"892054abd1c57282d3cf724350e5c37511f010e6"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"74be42c386edd7520577501e74ac024747d8f914","unresolved":false,"context_lines":[{"line_number":11,"context_line":"2) enable rbd mirror for the volume."},{"line_number":12,"context_line":"In the second stage, if a volume created has no feature of \u0027journaling\u0027, the value of"},{"line_number":13,"context_line":"\u0027had_journaling\u0027 will be None(rbd.py: line 559). However, after executing"},{"line_number":14,"context_line":"\u0027image.update_features\u0027(rbd.py: line 561), \u0027journaling\u0027 feature has already added"},{"line_number":15,"context_line":" to the volume, so, the value of \u0027had_journaling\u0027 should not be None anymore, but"},{"line_number":16,"context_line":"no code changes it. I think that a bug and fix it."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba5201f7_0afef337","line":14,"range":{"start_line":14,"start_character":23,"end_line":14,"end_character":41},"updated":"2017-01-11 03:06:31.000000000","message":"ditto","commit_id":"892054abd1c57282d3cf724350e5c37511f010e6"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"74be42c386edd7520577501e74ac024747d8f914","unresolved":false,"context_lines":[{"line_number":13,"context_line":"\u0027had_journaling\u0027 will be None(rbd.py: line 559). However, after executing"},{"line_number":14,"context_line":"\u0027image.update_features\u0027(rbd.py: line 561), \u0027journaling\u0027 feature has already added"},{"line_number":15,"context_line":" to the volume, so, the value of \u0027had_journaling\u0027 should not be None anymore, but"},{"line_number":16,"context_line":"no code changes it. I think that a bug and fix it."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Ie281b842e6d7fadb541fd882ff38b34ca68663d2"},{"line_number":19,"context_line":"Closes-Bug: #1654126"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba5201f7_4af8fb49","line":16,"range":{"start_line":16,"start_character":20,"end_line":16,"end_character":50},"updated":"2017-01-11 03:06:31.000000000","message":"Remove this. Or change to something like what this patch does","commit_id":"892054abd1c57282d3cf724350e5c37511f010e6"}]}
